foreman_maintain 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b4d4f7fe5a4a2f6a3a992a94e7fe674a00866dac9fa0f2f59fe30b5296c0a3a4
-  data.tar.gz: 56b9be2ae99686aefa13e2de26b9c72bcd4a3eb82697ef2ec7b099252a2ce352
+  metadata.gz: 2f9e8ef6df753833b37ddddb8923706bfe5f53671e3cf21dd3706227f759d292
+  data.tar.gz: 43d73546fe50ec575de65b7c27b4b05df136ee1ed8076921a3b6548b310dca39
 SHA512:
-  metadata.gz: 9dc4c82dcc0fef0ee09cc838af7afd1065c5171ea5b3400a33c58e6aece35e0964b359e8a57a9f058cb4ee82741edafc5d6da14e9d8e566a13455c44a524f9a6
-  data.tar.gz: 4dae3e89d6bdc190fa10dde17fce93147f6c6f31ba636bb87d919cf78dbfc253dd10096e45e78f606230709bac50963a7e6c4b006203dc6386331f8209c1b425
+  metadata.gz: 2f4d2397cd58b6223f823c599c33695f1d814e24d782f0ee60ef97db953b741e7ad1502ec01f5cf8e24beb472360c16b0434e98461e444a42d3121f49e997a50
+  data.tar.gz: b09a486b783897e76cc6c70de5ce569bc5889c26a798beb01ab861a9d8baae8884e5160517875a91ad0c71e13fb773e66c97dd05c4c00be2a70fe1753aebe62f

data/README.md

@@ -50,10 +50,6 @@ Subcommands:
       stop                          Stop maintenance-mode
       status                        Get maintenance-mode status
       is-enabled                    Get maintenance-mode status code
-
-    content                       Content related commands
-      prepare                       Prepare content for Pulp 3
-      switchover                    Switch support for certain content from Pulp 2 to Pulp 3
 ```
 
 ### Upgrades

data/bin/foreman-maintain

@@ -3,7 +3,7 @@
 # Ensure we use UTF-8 by defualt, even when run with LC_ALL=C
 Encoding.default_internal = Encoding.default_external = Encoding::UTF_8
 
-$LOAD_PATH.unshift(File.expand_path('../../lib', __FILE__))
+$LOAD_PATH.unshift(File.expand_path('../lib', __dir__))
 
 require 'foreman_maintain'
 

data/bin/foreman-maintain-complete

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 require 'English'
-project_root = File.expand_path('../..', __FILE__)
+project_root = File.expand_path('..', __dir__)
 $LOAD_PATH.unshift(File.join(project_root, 'lib'))
 CONFIG_FILE = '/etc/foreman-maintain/foreman_maintain.yml'.freeze
 system('which foreman_maintain > /dev/null 2>&1')
@@ -10,14 +10,14 @@ FOREMAN_MAINTAIN = found ? 'foreman-maintain' : File.join(project_root, 'bin/for
 require 'yaml'
 require 'foreman_maintain/utils/bash'
 
-# rubocop:disable Lint/RescueWithoutErrorClass, Lint/HandleExceptions
+# rubocop:disable Lint/SuppressedException
 def cache_file(config_file)
   config = YAML.load(File.open(config_file))
   config.fetch(:completion_cache_file,
-               "#{ENV['HOME'] || '/root'}/.cache/foreman_maintain_completion.yml")
-rescue
+    "#{ENV['HOME'] || '/root'}/.cache/foreman_maintain_completion.yml")
+rescue StandardError
 end
-# rubocop:enable Lint/RescueWithoutErrorClass, Lint/HandleExceptions
+# rubocop:enable Lint/SuppressedException
 
 config_file = if File.exist?(CONFIG_FILE)
                 CONFIG_FILE

data/definitions/checks/candlepin/db_up.rb

@@ -15,7 +15,7 @@ module Checks
           end
           assert(status, 'Candlepin DB is not responding. ' \
             'It needs to be up and running to perform the following steps',
-                 :next_steps => start_pgsql)
+            :next_steps => start_pgsql)
         else
           feature(:candlepin_database).raise_psql_missing_error
         end

data/definitions/checks/candlepin/validate_db.rb

@@ -5,20 +5,13 @@ module Checks::Candlepin
       tags :pre_upgrade
 
       confine do
-        feature(:candlepin_database) && feature(:candlepin_database).validate_available_in_cpdb?
+        feature(:candlepin_database)&.validate_available_in_cpdb?
       end
     end
 
     def run
       result, result_msg = feature(:candlepin_database).execute_cpdb_validate_cmd
-      next_steps = []
-      if feature(:satellite) && feature(:satellite).current_minor_version == '6.2'
-        next_steps.concat(
-          [Procedures::Candlepin::DeleteOrphanedRecordsFromEnvContent.new,
-           Procedures::KnowledgeBaseArticle.new(:doc => 'fix_cpdb_validate_failure')]
-        )
-      end
-      assert(result == 0, result_msg, :next_steps => next_steps)
+      assert(result == 0, result_msg)
     end
   end
 end

data/definitions/checks/check_for_newer_packages.rb

@@ -4,11 +4,11 @@ class Checks::CheckForNewerPackages < ForemanMaintain::Check
     description 'Check for newer packages and optionally ask for confirmation if not found.'
 
     param :packages,
-          'package names to validate',
-          :required => true
+      'package names to validate',
+      :required => true
     param :manual_confirmation_version,
-          'Version of satellite (6.9) to ask the user if they are on the latest minor release of.',
-          :required => false
+      'Version of satellite to ask the user if they are on the latest minor release of.',
+      :required => false
     manual_detection
   end
 
@@ -24,7 +24,7 @@ class Checks::CheckForNewerPackages < ForemanMaintain::Check
 
   def check_for_package_update
     exit_status, output = ForemanMaintain.package_manager.check_update(packages: @packages,
-                                                                       with_status: true)
+      with_status: true)
     packages_with_updates = []
     if exit_status == 100
       packages_with_updates = compare_pkg_versions(output).select do |_, result|

data/definitions/checks/check_hotfix_installed.rb

@@ -22,8 +22,8 @@ class Checks::CheckHotfixInstalled < ForemanMaintain::Check
         installed_pkg_list = installed_packages
         files_modifications = installed_pkg_list.flat_map { |pkg| modified_files(pkg) }
         assert(hotfix_rpmlist.empty? && files_modifications.empty?,
-               warning_message(hotfix_rpmlist, files_modifications),
-               :warn => true)
+          warning_message(hotfix_rpmlist, files_modifications),
+          :warn => true)
       end
     end
   end
@@ -49,17 +49,13 @@ class Checks::CheckHotfixInstalled < ForemanMaintain::Check
       io.each do |line|
         repo, pkg = line.chomp.split
         next if repo.nil? || pkg.nil?
-        packages << pkg if /satellite|rhscl/ =~ repo.downcase
+        packages << pkg if /satellite/.match?(repo.downcase)
       end
     end
     packages
   end
 
   def query_format
-    if el7?
-      return '%{ui_from_repo} %{name}-%{evr}.%{arch}'
-    end
-
     '%{from_repo} %{name}-%{evr}.%{arch}'
   end
 

data/definitions/checks/disk/available_space_postgresql12.rb

@@ -16,9 +16,10 @@ module Checks
       end
 
       def pgsql_dir(version)
-        if version == 9
+        case version
+        when 9
           '/var/lib/pgsql/'
-        elsif version == 12
+        when 12
           '/var/opt/rh/rh-postgresql12/'
         end
       end

data/definitions/checks/disk/performance.rb

@@ -31,7 +31,7 @@ module Checks
           puts stats.stdout
 
           current_downstream_feature = feature(:instance).downstream
-          if current_downstream_feature && current_downstream_feature.at_least_version?('6.3')
+          if current_downstream_feature&.at_least_version?('6.3')
             assert(success, io_obj.slow_disk_error_msg + warning_message, :warn => true)
           else
             assert(success, io_obj.slow_disk_error_msg)
@@ -40,7 +40,7 @@ module Checks
       end
 
       def data_dirs
-        @data_dirs ||= %i[pulpcore_database mongo foreman_database].inject({}) do |dirs, f|
+        @data_dirs ||= %i[pulpcore_database foreman_database].inject({}) do |dirs, f|
           if feature(f) && File.directory?(feature(f).data_dir)
             dirs[feature(f).label_dashed] = feature(f).data_dir
           end
@@ -50,7 +50,7 @@ module Checks
 
       def pulp_dir
         @pulp_dir ||= begin
-          pulp_feature = feature(:pulp2) || feature(:pulpcore_database)
+          pulp_feature = feature(:pulpcore)
           { pulp_feature.label_dashed => pulp_feature.pulp_data_dir }
         end
       end

data/definitions/checks/foreman/check_corrupted_roles.rb

@@ -14,8 +14,8 @@ module Checks
       def run
         items = find_filter_permissions
         assert(items.empty?,
-               error_message(items),
-               :next_steps => Procedures::Foreman::FixCorruptedRoles.new)
+          error_message(items),
+          :next_steps => Procedures::Foreman::FixCorruptedRoles.new)
       end
 
       def error_message(items)
@@ -29,7 +29,6 @@ module Checks
         feature(:foreman_database).query(self.class.inconsistent_filter_perms)
       end
 
-      # rubocop:disable Metrics/MethodLength
       def self.inconsistent_filter_perms
         subquery = <<-SQL
           SELECT filters.id AS filter_id,
@@ -65,7 +64,6 @@ module Checks
                 OR (first.resource_type != second.resource_type))
         SQL
       end
-      # rubocop:enable Metrics/MethodLength
     end
   end
 end

data/definitions/checks/foreman/check_duplicate_permission.rb

@@ -14,7 +14,7 @@ module Checks
           duplicate_permissions.empty?,
           'Duplicate permissions in your database',
           :next_steps => [
-            Procedures::Foreman::RemoveDuplicatePermissions.new
+            Procedures::Foreman::RemoveDuplicatePermissions.new,
           ]
         )
       end

data/definitions/checks/foreman/check_duplicate_roles.rb

@@ -21,7 +21,7 @@ module Checks
             Procedures::Foreman::RemoveDuplicateObsoleteRoles.new,
             Procedures::KnowledgeBaseArticle.new(
               :doc => 'fix_db_migrate_failure_on_duplicate_roles'
-            )
+            ),
           ]
         )
       end

data/definitions/checks/foreman/check_tuning_requirements.rb

@@ -65,7 +65,7 @@ module Checks
           'medium' => { cpu_cores: 8, memory: 32 },
           'large' => { cpu_cores: 16, memory: 64 },
           'extra-large' => { cpu_cores: 32, memory: 128 },
-          'extra-extra-large' => { cpu_cores: 48, memory: 256 }
+          'extra-extra-large' => { cpu_cores: 48, memory: 256 },
         }
       end
 

data/definitions/checks/foreman/db_up.rb

@@ -15,7 +15,7 @@ module Checks
           end
           assert(status, 'Foreman DB is not responding. ' \
             'It needs to be up and running to perform the following steps',
-                 :next_steps => start_pgsql)
+            :next_steps => start_pgsql)
         else
           feature(:foreman_database).raise_psql_missing_error
         end

data/definitions/checks/foreman/facts_names.rb

@@ -21,10 +21,10 @@ module Checks
           host_id = result['host_id']
           count = result['count'].to_i
           assert(count < max,
-                 "Host (ID #{host_id}) has #{count} fact values which is more than #{max}.\n" \
-                 'This can cause slow fact processing.',
-                 :warn => true,
-                 :next_steps => [Procedures::KnowledgeBaseArticle.new(:doc => 'many_fact_values')])
+            "Host (ID #{host_id}) has #{count} fact values which is more than #{max}.\n" \
+            'This can cause slow fact processing.',
+            :warn => true,
+            :next_steps => [Procedures::KnowledgeBaseArticle.new(:doc => 'many_fact_values')])
         end
       end
     end

data/definitions/checks/foreman_openscap/invalid_report_associations.rb

@@ -11,10 +11,10 @@ module Checks
       def run
         ids_to_remove = to_remove
         assert(ids_to_remove.empty?,
-               "There are #{ids_to_remove.count} reports with issues that will be removed",
-               :next_steps => Procedures::ForemanOpenscap::InvalidReportAssociations.new(
-                 :ids_to_remove => ids_to_remove
-               ))
+          "There are #{ids_to_remove.count} reports with issues that will be removed",
+          :next_steps => Procedures::ForemanOpenscap::InvalidReportAssociations.new(
+            :ids_to_remove => ids_to_remove
+          ))
       end
 
       def to_remove

data/definitions/checks/foreman_proxy/check_tftp_storage.rb

@@ -14,8 +14,8 @@ module Checks::ForemanProxy
       if non_zero_token_duration? && Dir.exist?(tftp_boot_directory)
         files = old_files_from_tftp_boot
         assert(files.empty?,
-               'There are old initrd and vmlinuz files present in tftp',
-               :next_steps => Procedures::Files::Remove.new(:files => files))
+          'There are old initrd and vmlinuz files present in tftp',
+          :next_steps => Procedures::Files::Remove.new(:files => files))
       else
         skip "TFTP #{tftp_boot_directory} directory doesn't exist."
       end
@@ -23,8 +23,8 @@ module Checks::ForemanProxy
 
     def old_files_from_tftp_boot
       Dir.glob("#{tftp_boot_directory}*-{vmlinuz,initrd.img}").map do |file|
-        unless File.directory?(file)
-          file if File.mtime(file) + (token_duration * 60) < Time.now
+        if !File.directory?(file) && (File.mtime(file) + (token_duration * 60) < Time.now)
+          file
         end
       end.compact
     end

data/definitions/checks/foreman_proxy/verify_dhcp_config_syntax.rb

@@ -4,8 +4,7 @@ module Checks::ForemanProxy
       description 'Check for verifying syntax for ISP DHCP configurations'
       tags :default
       confine do
-        feature(:foreman_proxy) &&
-          feature(:foreman_proxy).features.include?('dhcp') &&
+        feature(:foreman_proxy)&.features&.include?('dhcp') &&
           feature(:foreman_proxy).dhcp_isc_provider?
       end
     end

data/definitions/checks/foreman_tasks/invalid/check_old.rb

@@ -14,8 +14,8 @@ module Checks::ForemanTasks
         # Check and delete 'all tasks beyond 30 days(paused and stopped)'
         count_old_tasks = feature(:foreman_tasks).count(:old)
         assert(count_old_tasks <= 0,
-               "Found #{count_old_tasks} paused or stopped task(s) older than 30 days",
-               :next_steps => Procedures::ForemanTasks::Delete.new(:state => :old))
+          "Found #{count_old_tasks} paused or stopped task(s) older than 30 days",
+          :next_steps => Procedures::ForemanTasks::Delete.new(:state => :old))
       end
     end
   end

data/definitions/checks/foreman_tasks/invalid/check_pending_state.rb

@@ -13,8 +13,8 @@ module Checks::ForemanTasks
         # Check and delete 'all tasks in pending state'
         count_tasks_in_pending_state = feature(:foreman_tasks).count(:pending)
         assert(count_tasks_in_pending_state <= 0,
-               "Found #{count_tasks_in_pending_state} pending task(s) which are safe to delete",
-               :next_steps => Procedures::ForemanTasks::Delete.new(:state => :pending))
+          "Found #{count_tasks_in_pending_state} pending task(s) which are safe to delete",
+          :next_steps => Procedures::ForemanTasks::Delete.new(:state => :pending))
       end
     end
   end

data/definitions/checks/foreman_tasks/invalid/check_planning_state.rb

@@ -13,8 +13,8 @@ module Checks::ForemanTasks
         # Check and delete 'all tasks in planning state'
         tasks_in_planning_count = feature(:foreman_tasks).count(:planning)
         assert(tasks_in_planning_count <= 0,
-               "Found #{tasks_in_planning_count} task(s) in planning state",
-               :next_steps => Procedures::ForemanTasks::Delete.new(:state => :planning))
+          "Found #{tasks_in_planning_count} task(s) in planning state",
+          :next_steps => Procedures::ForemanTasks::Delete.new(:state => :planning))
       end
     end
   end

data/definitions/checks/foreman_tasks/not_paused.rb

@@ -11,8 +11,8 @@ module Checks::ForemanTasks
     def run
       paused_tasks_count = feature(:foreman_tasks).paused_tasks_count()
       assert(paused_tasks_count == 0,
-             "There are currently #{paused_tasks_count} paused tasks in the system",
-             :next_steps => next_procedures)
+        "There are currently #{paused_tasks_count} paused tasks in the system",
+        :next_steps => next_procedures)
     end
 
     def next_procedures

data/definitions/checks/foreman_tasks/not_running.rb

@@ -11,12 +11,12 @@ module Checks::ForemanTasks
     def run
       task_count = feature(:foreman_tasks).running_tasks_count
       assert(task_count == 0,
-             failure_message(task_count),
-             :next_steps =>
-               [Procedures::ForemanTasks::FetchTasksStatus.new(:state => 'running'),
-                Procedures::ForemanTasks::UiInvestigate.new(
-                  'search_query' => search_query_for_running_tasks
-                )])
+        failure_message(task_count),
+        :next_steps =>
+          [Procedures::ForemanTasks::FetchTasksStatus.new(:state => 'running'),
+           Procedures::ForemanTasks::UiInvestigate.new(
+             'search_query' => search_query_for_running_tasks
+           )])
     end
 
     private

data/definitions/checks/original_assets.rb

@@ -16,8 +16,8 @@ class Checks::OriginalAssets < ForemanMaintain::Check
     end
     remove_files = Procedures::Files::Remove.new(:files => custom_assets, :assumeyes => true)
     assert(custom_assets.empty?,
-           "Some assets not owned by #{product_name} were detected on the system.\n" \
-             'Possible conflicting versions can affect operation of the Web UI.',
-           :next_steps => remove_files)
+      "Some assets not owned by #{product_name} were detected on the system.\n" \
+        'Possible conflicting versions can affect operation of the Web UI.',
+      :next_steps => remove_files)
   end
 end

data/definitions/checks/package_manager/yum/validate_yum_config.rb

@@ -41,7 +41,7 @@ module Checks::PackageManager
 
       def yum_config_options
         @yum_config_options ||= {
-          'exclude' => '^exclude\s*=\s*\S+.*$'
+          'exclude' => '^exclude\s*=\s*\S+.*$',
         }
       end
     end

data/definitions/checks/pulpcore/db_up.rb

@@ -14,7 +14,7 @@ module Checks
         end
         assert(status, 'Pulpcore DB is not responding. ' \
           'It needs to be up and running to perform the following steps',
-               :next_steps => next_steps)
+          :next_steps => next_steps)
       end
 
       def next_steps

data/definitions/checks/repositories/check_upstream_repository.rb

@@ -18,8 +18,8 @@ class Checks::CheckUpstreamRepository < ForemanMaintain::Check
     with_spinner('Checking for presence of upstream repositories') do
       enabled_repo_ids = repoids_and_urls.keys
       assert(enabled_repo_ids.empty?,
-             "System has upstream #{enabled_repo_ids.join(',')} repositories enabled",
-             :next_steps => Procedures::Repositories::Disable.new(:repos => enabled_repo_ids))
+        "System has upstream #{enabled_repo_ids.join(',')} repositories enabled",
+        :next_steps => Procedures::Repositories::Disable.new(:repos => enabled_repo_ids))
     end
   end
 end

data/definitions/checks/repositories/validate.rb

@@ -11,8 +11,8 @@ module Checks::Repositories
       end
 
       param :version,
-            'Version for which repositories needs to be validated',
-            :required => true
+        'Version for which repositories needs to be validated',
+        :required => true
 
       manual_detection
     end

data/definitions/checks/restore/validate_backup.rb

@@ -6,8 +6,8 @@ module Checks::Restore
       description 'Validate backup has appropriate files'
 
       param :backup_dir,
-            'Path to backup directory',
-            :required => true
+        'Path to backup directory',
+        :required => true
       manual_detection
     end
 

data/definitions/checks/restore/validate_hostname.rb

@@ -6,8 +6,8 @@ module Checks::Restore
       description 'Validate hostname is the same as backup'
 
       param :backup_dir,
-            'Path to backup directory',
-            :required => true
+        'Path to backup directory',
+        :required => true
       manual_detection
     end
 

data/definitions/checks/restore/validate_interfaces.rb

@@ -6,8 +6,8 @@ module Checks::Restore
       description 'Validate network interfaces match the backup'
 
       param :backup_dir,
-            'Path to backup directory',
-            :required => true
+        'Path to backup directory',
+        :required => true
       manual_detection
     end
 

data/definitions/checks/restore/validate_postgresql_dump_permissions.rb

@@ -0,0 +1,31 @@
+module Checks::Restore
+  class ValidatePostgresqlDumpPermissions < ForemanMaintain::Check
+    metadata do
+      description 'Validate permissions for PostgreSQL dumps'
+
+      param :backup_dir,
+        'Path to backup directory',
+        :required => true
+      manual_detection
+    end
+
+    def run
+      backup = ForemanMaintain::Utils::Backup.new(@backup_dir)
+      if feature(:instance).postgresql_local? && backup.online_backup?
+        errors = []
+        [:candlepin_dump, :foreman_dump, :pulpcore_dump].each do |dump|
+          next unless backup.file_map[dump][:present]
+
+          unless system("runuser - postgres -c 'test -r #{backup.file_map[dump][:path]}'")
+            errors << backup.file_map[dump][:path]
+          end
+        end
+
+        msg = "The 'postgres' user needs read access to the following files:\n"
+        msg << errors.join("\n")
+        assert(errors.empty?, msg)
+
+      end
+    end
+  end
+end

data/definitions/checks/services_up.rb

@@ -14,7 +14,7 @@ class Checks::ServicesUp < ForemanMaintain::Check
       :wait_for_server_response => true
     )
     assert(failed_services.empty?,
-           'Following services are not running: ' + failed_services.map(&:to_s).join(', '),
-           :next_steps => restart_procedure)
+      'Following services are not running: ' + failed_services.map(&:to_s).join(', '),
+      :next_steps => restart_procedure)
   end
 end

data/definitions/features/apache.rb

@@ -9,7 +9,7 @@ class Features::Apache < ForemanMaintain::Feature
 
   def services
     [
-      system_service(self.class.package_name, 30)
+      system_service(self.class.package_name, 30),
     ]
   end
 

data/definitions/features/candlepin.rb

@@ -13,7 +13,7 @@ class Features::Candlepin < ForemanMaintain::Feature
 
   def services
     [
-      system_service('tomcat', 20)
+      system_service('tomcat', 20),
     ]
   end
 end

data/definitions/features/candlepin_database.rb

@@ -14,7 +14,7 @@ class Features::CandlepinDatabase < ForemanMaintain::Feature
   def services
     [
       system_service('postgresql', 10, :component => 'candlepin',
-                                       :db_feature => feature(:candlepin_database))
+                                       :db_feature => feature(:candlepin_database)),
     ]
   end
 
@@ -53,7 +53,6 @@ class Features::CandlepinDatabase < ForemanMaintain::Feature
 
   private
 
-  # rubocop:disable Metrics/MethodLength
   def load_configuration
     raw_config = File.read(CANDLEPIN_DB_CONFIG)
     full_config = Hash[raw_config.scan(/(^[^#\n][^=]*)=(.*)/)]
@@ -69,10 +68,9 @@ class Features::CandlepinDatabase < ForemanMaintain::Feature
       'ssl' => (fetch_extra_param(url, 'ssl') == 'true'),
       'sslfactory' => fetch_extra_param(url, 'sslfactory'),
       'driver_class' => full_config['jpa.config.hibernate.connection.driver_class'],
-      'url' => url
+      'url' => url,
     }
   end
-  # rubocop:enable Metrics/MethodLength
 
   def extend_with_db_options
     db_options = { '-d' => configuration['database'] }

data/definitions/features/cron.rb

@@ -2,9 +2,7 @@ class Features::Cron < ForemanMaintain::Feature
   metadata do
     label :cron
     confine do
-      ForemanMaintain.config.manage_crond && !(
-        feature(:instance).downstream && feature(:instance).downstream.less_than_version?('6.3')
-      )
+      ForemanMaintain.config.manage_crond && feature(:instance).downstream
     end
   end
 
@@ -13,12 +11,12 @@ class Features::Cron < ForemanMaintain::Feature
     if cron_service.running?
       [
         'cron jobs: running',
-        mode_on ? [Procedures::Service::Stop.new(:only => [cron_service])] : []
+        mode_on ? [Procedures::Service::Stop.new(:only => [cron_service])] : [],
       ]
     else
       [
         'cron jobs: not running',
-        mode_on ? [] : [Procedures::Service::Start.new(:only => [cron_service])]
+        mode_on ? [] : [Procedures::Service::Start.new(:only => [cron_service])],
       ]
     end
   end

data/definitions/features/dynflow_sidekiq.rb

@@ -14,14 +14,14 @@ class Features::DynflowSidekiq < ForemanMaintain::Feature
     end
     [
       '/etc/foreman/dynflow',
-      service_symlinks
+      service_symlinks,
     ].flatten
   end
 
   def services
     service_names.map do |service|
       system_service service, instance_priority(service),
-                     :instance_parent_unit => 'dynflow-sidekiq@'
+        :instance_parent_unit => 'dynflow-sidekiq@'
     end
   end
 

data/definitions/features/foreman_cockpit.rb

@@ -9,7 +9,7 @@ class Features::ForemanCockpit < ForemanMaintain::Feature
 
   def services
     [
-      system_service('foreman-cockpit')
+      system_service('foreman-cockpit'),
     ]
   end
 end