foreman_maintain 0.5.5 → 0.5.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88713e93aedca954a3162bfcb296a4e34702d3d5ffa4378b6f913081a5377e2c
-  data.tar.gz: 561a9cf651b6a8676efe9471eb2cde54e30cec37cf37f311f59ee7a886f44642
+  metadata.gz: d771ecfd4783e176608d1a0263299997e9dcf3f60c141b20be197d61a726085c
+  data.tar.gz: b90a67972a8b670b25ab8eab34aac663239244f170e2bd31a7a617e576cd41c0
 SHA512:
-  metadata.gz: 0d0d4a7cbdad45bcfd35be8029fa7be9b458b72df62a9e83a72ffdd1e3b049fcff2ba72b2368531f2a40a40ac6578381fe57a91ef8abbcd7edd63908b9759071
-  data.tar.gz: 4635df0f060dd06372cb9ff77cbc6f0ac8756dbd4b7814f47e27444e4e1d480b648b5175391f4c337e1dd3934a5b077d5db4caa22b74b4c085ac66c9ba81dba9
+  metadata.gz: 0b215ba50227dab2f5d95db8046d078212ccf7cb5fe6dc450a77488472c293bad4b70b3384b477b095cde78d4428e1033af8fd3f2f13d42588e5867834e58903
+  data.tar.gz: ffea4e522836f6e28a32f2c6ad33a1ca0c3449561eed1104d11c5308e79dd695706cdc2cf41ea34d80201bbf591fca65a73d5b83aa32abfe8366b932c90eaef3

data/definitions/checks/foreman/check_duplicate_permission.rb

@@ -0,0 +1,33 @@
+module Checks
+  module Foreman
+    class CheckDuplicatePermissions < ForemanMaintain::Check
+      metadata do
+        label :duplicate_permissions
+        for_feature :foreman_database
+        description 'Check for duplicate permissions from database'
+        tags :pre_upgrade
+      end
+
+      def run
+        duplicate_permissions = find_duplicate_permissions
+        assert(
+          duplicate_permissions.empty?,
+          'Duplicate permissions in your database',
+          :next_steps => [
+            Procedures::Foreman::RemoveDuplicatePermissions.new
+          ]
+        )
+      end
+
+      def find_duplicate_permissions
+        feature(:foreman_database).query(self.class.query_to_get_duplicate_permission)
+      end
+
+      def self.query_to_get_duplicate_permission
+        <<-SQL
+          SELECT id,name FROM permissions p WHERE (SELECT count(name) FROM permissions pr WHERE p.name =pr.name) > 1
+        SQL
+      end
+    end
+  end
+end

data/definitions/procedures/foreman/remove_duplicate_permissions.rb

@@ -0,0 +1,70 @@
+module Procedures::Foreman
+  class RemoveDuplicatePermissions < ForemanMaintain::Procedure
+    metadata do
+      for_feature :foreman_database
+      description 'Remove duplicate permissions from database'
+    end
+
+    def run
+      duplicate_permissions = feature(:foreman_database).query(
+        Checks::Foreman::CheckDuplicatePermissions.query_to_get_duplicate_permission
+      ).group_by { |permission| permission['name'] }
+      unassigned_permissions = []
+      duplicate_permissions.each_value do |permissions|
+        permission_ids = permissions.map { |i| i['id'] }
+        filterings = check_permissions_assign_to_filter(permission_ids)
+        assigned_permissions = filterings.keys
+        unassigned_permissions << permission_ids - assigned_permissions
+        fix_permissions(assigned_permissions) if assigned_permissions.length > 1
+      end
+      delete_permission(unassigned_permissions.flatten) unless unassigned_permissions.empty?
+    end
+
+    private
+
+    def check_permissions_assign_to_filter(permission_ids)
+      sql = <<-SQL
+        SELECT id, filter_id, permission_id FROM filterings WHERE permission_id IN (#{permission_ids.join(',')})
+      SQL
+      feature(:foreman_database).query(sql).group_by { |filtering| filtering['permission_id'] }
+    end
+
+    def fix_permissions(assigned_permissions)
+      persist_permission = assigned_permissions.shift
+      filter_ids = filters_for_permission(persist_permission)
+      update_filtering(assigned_permissions, persist_permission, filter_ids)
+      delete_filtering(assigned_permissions)
+      delete_permission(assigned_permissions)
+    end
+
+    def filters_for_permission(permission)
+      feature(:foreman_database).query(
+        "SELECT filter_id FROM filterings WHERE permission_id = #{permission.to_i}"
+      ).map { |filter| filter['filter_id'] }
+    end
+
+    def update_filtering(old_ids, new_id, filter_ids)
+      sql = <<-SQL
+      WITH rows AS (
+        UPDATE filterings SET permission_id = '#{new_id}' WHERE permission_id IN (#{old_ids.join(',')}) AND filter_id NOT IN (#{filter_ids.join(',')})
+        RETURNING id
+      )
+      SELECT id
+      FROM rows
+      SQL
+      feature(:foreman_database).query(sql)
+    end
+
+    def delete_filtering(permission_ids)
+      feature(:foreman_database).psql(
+        "DELETE FROM filterings where permission_id IN (#{permission_ids.join(',')})"
+      )
+    end
+
+    def delete_permission(permission_ids)
+      feature(:foreman_database).psql(
+        "DELETE FROM permissions where id IN (#{permission_ids.join(',')})"
+      )
+    end
+  end
+end

data/lib/foreman_maintain/version.rb

@@ -1,3 +1,3 @@
 module ForemanMaintain
-  VERSION = '0.5.5'.freeze
+  VERSION = '0.5.6'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_maintain
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 0.5.6
 platform: ruby
 authors:
 - Ivan Nečas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-08 00:00:00.000000000 Z
+date: 2020-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: clamp
@@ -128,6 +128,7 @@ files:
 - definitions/checks/disk/available_space.rb
 - definitions/checks/disk/performance.rb
 - definitions/checks/foreman/check_corrupted_roles.rb
+- definitions/checks/foreman/check_duplicate_permission.rb
 - definitions/checks/foreman/check_duplicate_roles.rb
 - definitions/checks/foreman/db_up.rb
 - definitions/checks/foreman/facts_names.rb
@@ -212,6 +213,7 @@ files:
 - definitions/procedures/foreman/apipie_cache.rb
 - definitions/procedures/foreman/fix_corrupted_roles.rb
 - definitions/procedures/foreman/remove_duplicate_obsolete_roles.rb
+- definitions/procedures/foreman/remove_duplicate_permissions.rb
 - definitions/procedures/foreman_docker/remove_foreman_docker.rb
 - definitions/procedures/foreman_openscap/invalid_report_associations.rb
 - definitions/procedures/foreman_proxy/features.rb