foreman_hyperv 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65f805250cc59658795113cc0d201de9c2da857b8dc0868bc5a7450be52619ef
-  data.tar.gz: dfbe2e15421b902d38f2747a07ff83dc68661178914a7b2de992d1d4d905003d
+  metadata.gz: 3cf1610103bdfad147e262399c3c50667bf4450831ebb8e9a4f20211307a3d18
+  data.tar.gz: a4623968a974d9de60af94cd0dfaa9957a89354f640897e8138c6c0b32f95b9a
 SHA512:
-  metadata.gz: 3487dfa1b123b714d5fc093ff23d85fbc49253a0f7cd24308461b2117436e181c38380e9b2acdf3bc1bae3669eabb5dd87475e7946376c6da79aa1eaae5b982b
-  data.tar.gz: 32dc60ede4f1bd60f7c74e56a7c9e648f58757a4bac64cef8e3d09858380984bdf059093e016fb72de3c2bede1f6c94f39cfb7db4a1c5071e4d846777939f0ea
+  metadata.gz: a1007568c30b112299208b00a5df11c8d88c0b0e390365ede46efc67900489b7cdb40b6ca83a318505e6ff6f3fc167c6bb2239c18e910710a45572e161213852
+  data.tar.gz: 51d064f97547b16ec490a6c9d9436c87efbed149957a6f66b6fef85d652ff0c91201e44c13a039ed53871db51b26487181ee11410bb45f45663ce6b6068ec1d3

data/app/helpers/foreman_hyperv/compute_resources_vms_helper.rb

@@ -1,17 +1,21 @@
+# frozen_string_literal: true
+
 module ForemanHyperv
   module ComputeResourcesVmsHelper
     def hyperv_networks(compute_resource)
       compute_resource.switches(nil).map do |sw|
-        [ sw.id, "#{sw.name}#{sw.switch_type ? " (#{sw.switch_type})" : nil}" ]
+        [sw.id, "#{sw.name}#{" (#{sw.switch_type})" if sw.switch_type}"]
       end
     end
 
     def hyperv_generations
       Fog::Hyperv::Compute::Server::VM_GENERATION_VALUES.map { |gen, num| [gen, "Generation #{num} (#{gen})"] }
     end
+
     def hyperv_vlan_modes
       Fog::Hyperv::Compute::NetworkAdapterVlan::VLAN_OPERATION_MODE.map { |mode| [mode, mode] }
     end
+
     def hyperv_private_vlan_modes
       Fog::Hyperv::Compute::NetworkAdapterVlan::PRIVATE_VLAN_MODE.reject { |mode| mode == :Unknown }.map { |mode| [mode, mode] }
     end

data/app/models/concerns/fog_extensions/hyperv/compute.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FogExtensions
   module Hyperv
     module Compute

data/app/models/concerns/fog_extensions/hyperv/hard_drive.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FogExtensions
   module Hyperv
     module HardDrive
@@ -27,8 +29,8 @@ module FogExtensions
           .slice(:id)
           .merge(
             {
-              basename:,
-              size_bytes:
+              basename: basename,
+              size_bytes: size_bytes
             }.compact
           )
       end

data/app/models/concerns/fog_extensions/hyperv/network_adapter.rb

@@ -7,16 +7,17 @@ module FogExtensions
 
       def mac
         return unless mac_address
-        return if mac_address.to_i(16) == 0
+        return if mac_address.to_i(16).zero?
 
         # Downcase and split every 2 chars, join with :
-        mac_address.downcase.scan(%r{.{2}}).join(':')
+        mac_address.downcase.scan(/.{2}/).join(':')
       end
 
       def mac=(m)
         mac_address = m&.upcase&.delete(':')
         mac_address = Fog::Hyperv::Compute::NetworkAdapter::NIC_FALLBACK_MAC if mac_address.nil? || mac_address.blank?
-        dynamic_mac_address_enabled = (mac_address.to_i(16) == 0)
+        mac_address.to_i(16)
+        0
       end
 
       # VLAN settings
@@ -24,6 +25,7 @@ module FogExtensions
       def vlan_operation_mode
         vlan_setting.operation_mode
       end
+
       def vlan_operation_mode=(mode)
         vlan_setting.operation_mode = mode
       end
@@ -33,6 +35,7 @@ module FogExtensions
 
         vlan_setting.private_vlan_mode
       end
+
       def vlan_private_mode=(mode)
         vlan_setting.private_vlan_mode = mode
       end
@@ -42,24 +45,23 @@ module FogExtensions
 
         vlan_setting.access_vlan_id
       end
-      def access_vlan_id=(id)
-        vlan_setting.access_vlan_id = id
-      end
+
+      delegate :access_vlan_id=, to: :vlan_setting
 
       def native_vlan_id
         return nil if vlan_setting.native_vlan_id.zero?
 
         vlan_setting.native_vlan_id
       end
-      def native_vlan_id=(id)
-        vlan_setting.native_vlan_id = id
-      end
+
+      delegate :native_vlan_id=, to: :vlan_setting
 
       def allowed_vlan_ids
         return nil unless vlan_setting.allowed_vlan_id_list&.any?
 
         Fog::Hyperv::Compute::NetworkAdapterVlan.render_vlan_list vlan_setting.allowed_vlan_id_list
       end
+
       def allowed_vlan_ids=(ids)
         ids ||= ''
         vlan_setting.allowed_vlan_id_list = parse_vlan_list(ids)
@@ -70,24 +72,23 @@ module FogExtensions
 
         vlan_setting.primary_vlan_id
       end
-      def primary_vlan_id=(id)
-        vlan_setting.primary_vlan_id = id
-      end
+
+      delegate :primary_vlan_id=, to: :vlan_setting
 
       def secondary_vlan_id
         return nil if vlan_setting.secondary_vlan_id.zero?
 
         vlan_setting.secondary_vlan_id
       end
-      def secondary_vlan_id=(id)
-        vlan_setting.secondary_vlan_id = id
-      end
+
+      delegate :secondary_vlan_id=, to: :vlan_setting
 
       def secondary_vlan_ids
         return nil unless vlan_setting.secondary_vlan_id_list&.any?
 
         Fog::Hyperv::Compute::NetworkAdapterVlan.render_vlan_list vlan_setting.secondary_vlan_id_list
       end
+
       def secondary_vlan_ids=(ids)
         ids ||= ''
         vlan_setting.secondary_vlan_id_list = parse_vlan_list(ids)
@@ -100,17 +101,20 @@ module FogExtensions
             :switch_id
           )
           .merge(
-            {
-              vlan_operation_mode:,
-              vlan_private_mode:,
-              access_vlan_id:,
-              native_vlan_id:,
-              allowed_vlan_ids:,
-              primary_vlan_id:,
-              secondary_vlan_id:,
-              secondary_vlan_ids:
-            }.compact
+            vlan_setting.attributes.slice(
+              :vlan_operation_mode,
+              :vlan_private_mode,
+              :access_vlan_id,
+              :native_vlan_id,
+              :primary_vlan_id,
+              :secondary_vlan_id
+            )
+          )
+          .merge(
+            secondary_vlan_ids: secondary_vlan_ids,
+            allowed_vlan_ids: allowed_vlan_ids
           )
+          .compact
       end
 
       private

data/app/models/concerns/fog_extensions/hyperv/server.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FogExtensions
   module Hyperv
     module Server
@@ -9,7 +11,7 @@ module FogExtensions
       end
 
       def folder_name
-        name.gsub(/[^0-9A-Za-z.\-]/, '_')
+        name.gsub(/[^0-9A-Za-z.-]/, '_')
       end
 
       def mac
@@ -40,7 +42,6 @@ module FogExtensions
       def cluster_name=(name)
         @cluster = service.clusters.get(name)
       end
-      #
 
       def vlan
         nic = network_adapters.first
@@ -51,7 +52,7 @@ module FogExtensions
       def vlan=(vlan)
         logger.warn "using vlan=#{vlan.inspect} on Hyper-V VM, this can lead to unexpected results"
         nic = network_adapters.first
-        if vlan.present? && vlan.to_i > 0
+        if vlan.present? && vlan.to_i.positive?
           nic.vlan_operation_mode = :Access if nic.vlan_operation_mode == :Untagged
           case nic.vlan_operation_mode
           when :Access
@@ -103,29 +104,35 @@ module FogExtensions
         match ||= fog_nics.detect { |fn| fn.mac == nic.mac }
         # match ||= fog_nics.detect { |fn| fn.name == nic_attrs['name'].presence }
 
-        if !match
+        unless match
           # Match on networking, limit potentials down to identical configuration and then pick the first
           potential = fog_nics.select do |fn|
             fn.switch_id == nic_attrs['switch_id'].presence || fn.switch_name == nic_attrs['switch_name'].presence
           end
           potential.select! { |fn| fn.vlan_operation_mode.to_s == nic_attrs['vlan_operation_mode'] }
-          if nic_attrs['vlan_operation_mode'] == 'Access'
+          case nic_attrs['vlan_operation_mode']
+          when 'Access'
             potential.select! { |fn| fn.access_vlan_id.to_s == nic_attrs['access_vlan_id'] }
-          elsif nic_attrs['vlan_operation_mode'] == 'Trunk'
+          when 'Trunk'
             potential.select! { |fn| fn.native_vlan_id.to_s == nic_attrs['native_vlan_id'] }
-            potential.select! { |fn| fn.allowed_vlan_ids.split(',').map(&:strip) == nic_attrs['allowed_vlan_ids'].split(',').map(&:strip) } \
-              if nic_attrs['allowed_vlan_ids'].present?
-          elsif nic_attrs['vlan_operation_mode'] == 'Private'
+            if nic_attrs['allowed_vlan_ids'].present?
+              potential.select! do |fn|
+                fn.allowed_vlan_ids.split(',').map(&:strip) == nic_attrs['allowed_vlan_ids'].split(',').map(&:strip)
+              end
+            end
+          when 'Private'
             potential.select! { |fn| fn.vlan_private_mode.to_s == nic_attrs['vlan_private_mode'] }
             potential.select! { |fn| fn.primary_vlan_id.to_s == nic_attrs['primary_vlan_id'].to_s } \
               if nic_attrs['primary_vlan_id'].present?
 
             if nic_attrs['vlan_private_mode'] == 'Promiscuous'
-              potential.select! { |fn| fn.secondary_vlan_ids.split(',').map(&:strip) == nic_attrs['secondary_vlan_ids'].split(',').map(&:strip) } \
-                if nic_attrs['secondary_vlan_ids'].present?
-            else
-              potential.select! { |fn| fn.secondary_vlan_id.to_s == nic_attrs['secondary_vlan_id'].to_s } \
-                if nic_attrs['secondary_vlan_id'].present?
+              if nic_attrs['secondary_vlan_ids'].present?
+                potential.select! do |fn|
+                  fn.secondary_vlan_ids.split(',').map(&:strip) == nic_attrs['secondary_vlan_ids'].split(',').map(&:strip)
+                end
+              end
+            elsif nic_attrs['secondary_vlan_id'].present?
+              potential.select! { |fn| fn.secondary_vlan_id.to_s == nic_attrs['secondary_vlan_id'].to_s }
             end
           end
 

data/app/models/concerns/foreman_hyperv/host_managed_extensions.rb

@@ -16,9 +16,9 @@ module ForemanHyperv
 
       begin
         hyperv_sync_interfaces
-      rescue => e
+      rescue StandardError => e
         failure _("Failed to update a compute %{compute_resource} instance %{name}: %{e}") %
-                { compute_resource:, name:, e: }, e
+                { compute_resource: compute_resource, name: name, e: e }, e
       end
       true
     end
@@ -41,8 +41,7 @@ module ForemanHyperv
         selected_nic = vm.select_nic(fog_nics, nic)
         if selected_nic.nil?
           logger.warn "Orchestration::Compute: Could not match network interface #{nic.inspect}"
-          raise ArgumentError, \
-            _("Could not find virtual machine network interface matching %s") %
+          raise ArgumentError, _("Could not find virtual machine network interface matching %s") %
             [nic.identifier, nic.ip, nic.name, nic.type].find(&:present?)
         end
 

data/app/models/foreman_hyperv/hyperv.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ForemanHyperv
   class Hyperv < ::ComputeResource
     include ComputeResourceCaching
@@ -37,7 +39,7 @@ module ForemanHyperv
       validate_connectivity(options)
     end
 
-    def validate_connectivity(options = {})
+    def validate_connectivity(_options = {})
       return unless connection_properties_valid?
       return false if errors.any?
 
@@ -66,10 +68,6 @@ module ForemanHyperv
       super.merge(mac: :mac)
     end
 
-    def editable_network_interfaces?
-      true
-    end
-
     # TODO
     def max_cpu_count(host = nil)
       (host || hypervisor).logical_processor_count
@@ -127,7 +125,7 @@ module ForemanHyperv
       iface_nested_attrs = nested_attributes_for :interfaces, attr[:interfaces_attributes]
       vm.network_adapters = iface_nested_attrs.map do |attr|
         attr.delete :id
-        Fog::Hyperv::Compute::NetworkAdapter.new(service: vm.service, vm:).tap do |nic|
+        Fog::Hyperv::Compute::NetworkAdapter.new(service: vm.service, vm: vm).tap do |nic|
           attr.select { |_, v| v.present? }.each do |k, v|
             nic.send(:"#{k}=", v)
           end
@@ -136,7 +134,7 @@ module ForemanHyperv
       volume_nested_attrs = nested_attributes_for :volumes, attr[:volumes_attributes]
       vm.hard_drives = volume_nested_attrs.map do |attr|
         attr.delete :id
-        Fog::Hyperv::Compute::HardDrive.new(service: vm.service, vm:).tap do |hdd|
+        Fog::Hyperv::Compute::HardDrive.new(service: vm.service, vm: vm).tap do |hdd|
           attr.select { |_, v| v.present? }.each do |k, v|
             hdd.send(:"#{k}=", v)
           end
@@ -234,28 +232,28 @@ module ForemanHyperv
     end
 
     def update_required?(old_attrs, new_attrs)
-      new_attrs.deep_symbolize_keys[:volumes_attributes]&.each do |_, hdd|
+      new_attrs.deep_symbolize_keys[:volumes_attributes]&.each_value do |hdd|
         if hdd[:id].present? && hdd[:_delete] == '1'
-          Rails.logger.debug "Scheduling compute instance update because a volume was removed"
+          Rails.logger.debug 'Scheduling compute instance update because a volume was removed'
           return true
-        elsif !hdd[:id].present? && hdd[:_delete] != '1'
-          Rails.logger.debug "Scheduling compute instance update because a new volume was added"
+        elsif hdd[:id].blank? && hdd[:_delete] != '1'
+          Rails.logger.debug 'Scheduling compute instance update because a new volume was added'
           return true
         end
       end
-      new_attrs.deep_symbolize_keys[:interfaces_attributes]&.each do |_, iface|
+      new_attrs.deep_symbolize_keys[:interfaces_attributes]&.each_value do |iface|
         if iface[:id].present? && iface[:_destroy] == '1'
-          Rails.logger.debug "Scheduling compute instance update because an interface was removed"
+          Rails.logger.debug 'Scheduling compute instance update because an interface was removed'
           return true
-        elsif !iface[:id].present? && iface[:_destroy] != '1'
-          Rails.logger.debug "Scheduling compute instance update because a new interface was added"
+        elsif iface[:id].blank? && iface[:_destroy] != '1'
+          Rails.logger.debug 'Scheduling compute instance update because a new interface was added'
           return true
         end
       end
 
       deep_update_required = proc do |old, new|
         old.merge(new) do |k, old_v, new_v|
-          if k == :allowed_vlan_ids || k == :secondary_vlan_ids
+          if %i[allowed_vlan_ids secondary_vlan_ids].include?(k)
             tmp = Fog::Hyperv::Compute::NetworkAdapter.new
 
             old_v = Fog::Hyperv::Compute::NetworkAdapterVlan.render_vlan_list(tmp.send(:parse_vlan_list, old_v.to_s))
@@ -265,7 +263,9 @@ module ForemanHyperv
           if old_v.is_a?(Hash) && new_v.is_a?(Hash)
             deep_update_required.call(old_v, new_v)
           elsif old_v.to_s != new_v.to_s
-            Rails.logger.debug "Scheduling compute instance update because #{k} changed it's value from '#{old_v}' (#{old_v.class}) to '#{new_v}' (#{new_v.class})"
+            Rails.logger.debug do
+              "Scheduling compute instance update because #{k} changed it's value from '#{old_v}' (#{old_v.class}) to '#{new_v}' (#{new_v.class})"
+            end
             return true
           end
           new_v
@@ -293,8 +293,8 @@ module ForemanHyperv
       basename = attr.delete(:basename) { 'Disk' }
       size = attr.delete(:size)
 
-      vhd = client.vhds.new({ basename:, size: }.compact)
-      Fog::Hyperv::Compute::HardDrive.new vhd:, **attr
+      vhd = client.vhds.new({ basename: basename, size: size }.compact)
+      Fog::Hyperv::Compute::HardDrive.new vhd: vhd, **attr
     end
 
     def new_cdrom(attr = {})
@@ -303,10 +303,10 @@ module ForemanHyperv
 
     def vm_instance_defaults
       super.merge(
-        generation:      2,
-        memory_startup:  1024.megabytes,
+        generation: 2,
+        memory_startup: 1024.megabytes,
         processor_count: 1,
-        interfaces:      [new_interface]
+        interfaces: [new_interface]
       )
     end
 
@@ -344,25 +344,22 @@ module ForemanHyperv
     private
 
     def _clusters
-      if client.respond_to? :supports_clusters?
-        return [] unless client.supports_clusters?
-      end
+      return [] if client.respond_to?(:supports_clusters?) && !client.supports_clusters?
 
       client.clusters.all
-    rescue
+    rescue StandardError
       []
     end
 
     def validate_vm(attr, new: false)
       # logger.debug "Validate VM #{attr.inspect}"
-      raise Foreman::Exception, 'VM lacks generation' if new && !attr[:generation].present?
-      raise Foreman::Exception, 'VM lacks memory' unless attr[:memory_startup].to_i > 0
-      raise Foreman::Exception, 'VM lacks CPUs' unless attr[:processor_count].to_i > 0
+      raise Foreman::Exception, 'VM lacks generation' if new && attr[:generation].blank?
+      raise Foreman::Exception, 'VM lacks memory' unless attr[:memory_startup].to_i.positive?
+      raise Foreman::Exception, 'VM lacks CPUs' unless attr[:processor_count].to_i.positive?
 
-      if Foreman::Cast.to_bool(attr[:dynamic_memory_enabled])
-        raise Foreman::Exception, 'VM lacks memory minimum' unless attr[:memory_minimum].to_i > 0
-        raise Foreman::Exception, 'VM lacks memory maximum' unless attr[:memory_maximum].to_i > 0
-      end
+      return unless Foreman::Cast.to_bool(attr[:dynamic_memory_enabled])
+      raise Foreman::Exception, 'VM lacks memory minimum' unless attr[:memory_minimum].to_i.positive?
+      raise Foreman::Exception, 'VM lacks memory maximum' unless attr[:memory_maximum].to_i.positive?
     end
 
     def validate_interfaces(attr)
@@ -373,18 +370,26 @@ module ForemanHyperv
         compute = iface[:compute_attributes] || iface
         case compute[:vlan_operation_mode].to_s
         when 'Untagged'
+          # No VLAN settings to verify
         when 'Access'
-          raise Foreman::Exception, 'Interface is missing access VLAN' unless compute[:access_vlan_id].to_i > 0
+          raise Foreman::Exception, 'Interface is missing access VLAN' unless compute[:access_vlan_id].to_i.positive?
         when 'Trunk'
-          raise Foreman::Exception, 'Interface is missing native VLAN' unless compute[:native_vlan_id].to_i > 0
-          raise Foreman::Exception, 'Interface is missing allowed VLANs' unless compute[:allowed_vlan_ids].present?
+          raise Foreman::Exception, 'Interface is missing native VLAN' unless compute[:native_vlan_id].to_i.positive?
+          raise Foreman::Exception, 'Interface is missing allowed VLANs' if compute[:allowed_vlan_ids].blank?
         when 'Private'
-          raise Foreman::Exception, 'Interface is missing primary VLAN' unless compute[:primary_vlan_id].to_i > 0
+          raise Foreman::Exception, 'Interface is missing primary VLAN' unless compute[:primary_vlan_id].to_i.positive?
+
           case compute[:vlan_private_mode].to_s
           when 'Promiscuous'
-            raise Foreman::Exception, 'Interface is missing secondary VLANs' unless compute[:secondary_vlan_ids].present?
+            if compute[:secondary_vlan_ids].blank?
+              raise Foreman::Exception,
+                    'Interface is missing secondary VLANs'
+            end
           else
-            raise Foreman::Exception, 'Interface is missing secondary VLAN' unless compute[:secondary_vlan_id].to_i > 0
+            unless compute[:secondary_vlan_id].to_i.positive?
+              raise Foreman::Exception,
+                    'Interface is missing secondary VLAN'
+            end
           end
         else
           raise Foreman::Exception, 'Interface has unknown VLAN mode'
@@ -411,7 +416,9 @@ module ForemanHyperv
         nic.save
       end
 
-      return unless vm.network_adapters.all(_return_fields: %i[dynamic_mac_address_enabled]).any?(&:dynamic_mac_address_enabled)
+      unless vm.network_adapters.all(_return_fields: %i[dynamic_mac_address_enabled]).any?(&:dynamic_mac_address_enabled)
+        return
+      end
 
       # Populate all non-populated MAC addresses
       vm.start
@@ -456,11 +463,13 @@ module ForemanHyperv
       volumes.reject! { |vol| vol[:_delete] == '1' }
       # logger.debug "Validate Volume #{volumes.inspect}"
       volumes.each do |vol|
-        raise Foreman::Exception, 'Volume lacks name' unless vol[:basename].present?
+        raise Foreman::Exception, 'Volume lacks name' if vol[:basename].blank?
         raise Foreman::Exception, 'Volume name should not include a file extension' if vol[:basename] =~ /\.vhd[sx]?$/
-        raise Foreman::Exception, 'Volume lacks size' unless vol[:size_bytes].to_i > 0
+        raise Foreman::Exception, 'Volume lacks size' unless vol[:size_bytes].to_i.positive?
       end
-      raise Foreman::Exception, 'Volume names need to be unique' if volumes.group_by { |vol| vol[:basename].downcase }.any? { |k, v| v.count > 1 }
+      return unless volumes.group_by { |vol| vol[:basename].downcase }.any? { |_k, v| v.many? }
+
+      raise Foreman::Exception, 'Volume names need to be unique'
     end
 
     def create_volumes(vm, attr)
@@ -468,7 +477,7 @@ module ForemanHyperv
       logger.debug "Creating volumes with: #{volumes}"
       volumes.each do |vol|
         vhd = vm.vhds.create basename: vol[:basename], size: vol[:size_bytes].to_i
-        vm.hard_drives.create vhd:
+        vm.hard_drives.create vhd: vhd
       end
     end
 

data/lib/foreman_hyperv/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ForemanHyperv
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_hyperv
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Alexander Olofsson
@@ -51,6 +51,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -105,7 +133,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="