foreman_fog_proxmox 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 48e7b9e4bf809304a237b6523af9f5fd3b857734
-  data.tar.gz: f8e212e7b449f735deb8ebcdb9f7a53e742d555c
+  metadata.gz: 475afb51f19055c5bf62055527903df576d3eafe
+  data.tar.gz: ed7c4afa8aee30e7e80f7fcc7258d13ae3dbca72
 SHA512:
-  metadata.gz: e4f01062b1b8fa2d850ff0552abbe36a3616e01a82e1710e08907d0d1ae81c0690f292372df469dc5721c8c5fb96fc2656646a4498571a6f4cca05ed067cb9f3
-  data.tar.gz: 85d5e82a63ac3a7e264b4c1884dcfa44f4409884b24955f2d542bc9ae7d0ef9e2f06f26fc29250a911fd59117eb76f0f06eecb35ba5bf781490446ba185bfd2a
+  metadata.gz: 604c52d8435cbda0f9fe498d07c2fe3a58576152303148f9005fff7c59c3b2dbe1bb24e50bd6c8a77f79e8a8584b54cd895e60fbe40a5936a4cb696c79e74995
+  data.tar.gz: a4afeaac998b8e596efb70a48dfc2a5ea44701dcd8688566e791644d54c0a9f5cfe4c31bc9a452a1684d58d2bf4b2879868c19933c459a7721a4f3684e7b2346

data/README.md

@@ -1,8 +1,8 @@
 ![ForemanFogProxmox](.github/images/foremanproxmox.png)
 
-[![Build Status](https://travis-ci.com/tristanrobert/foreman_proxmox.svg?branch=master)](https://travis-ci.com/tristanrobert/foreman_proxmox)
-[![Maintainability](https://api.codeclimate.com/v1/badges/922162c278e0fa9207ba/maintainability)](https://codeclimate.com/github/tristanrobert/foreman_proxmox/maintainability)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/922162c278e0fa9207ba/test_coverage)](https://codeclimate.com/github/tristanrobert/foreman_proxmox/test_coverage)
+[![Build Status](https://travis-ci.com/tristanrobert/foreman_fog_proxmox.svg?branch=master)](https://travis-ci.com/tristanrobert/foreman_fog_proxmox)
+[![Maintainability](https://api.codeclimate.com/v1/badges/922162c278e0fa9207ba/maintainability)](https://codeclimate.com/github/tristanrobert/foreman_fog_proxmox/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/922162c278e0fa9207ba/test_coverage)](https://codeclimate.com/github/tristanrobert/foreman_fog_proxmox/test_coverage)
 
 # ForemanFogProxmox
 
@@ -14,8 +14,8 @@ It is intended to satisfy this [feature](http://projects.theforeman.org/issues/2
 
 Tested with:
 
-* Foreman = 1.17.1
-* Fog-proxmox >= 0.4.0
+* Foreman = 1.17.3
+* Fog-proxmox >= 0.5.1
 
 ## Installation
 
@@ -54,6 +54,12 @@ sudo -u foreman /usr/bin/foreman-ruby /usr/bin/bundle install
 /usr/bin/foreman-ruby /usr/bin/bundle exec bin/rake plugin:assets:precompile[foreman_fog_proxmox]
 ```
 
+* Compile plugin translations if (french) needed :
+
+```shell
+/usr/bin/foreman-ruby /usr/bin/bundle exec bin/rake plugin:gettext[foreman_fog_proxmox]
+```
+
 * Complete installation of foreman 1.17 with foreman-installer:
 
 ```shell
@@ -99,18 +105,18 @@ You also need nodejs in your dev machine to run webpack-dev-server.
 
 * Fork this github repo.
 * Clone it on your local machine
-* Install foreman v1.17 on your machine:
+* Install foreman v1.17.3 on your machine:
 
 ```shell
 git clone https://github.com/theforeman/foreman
-git checkout tags/1.17
+git checkout tags/1.17.3
 ```
 
 * Create a Gemfile.local.rb file in foreman/bundler.d/
 * Add this line:
 
 ```ruby
-gem 'foreman_fog_proxmox', :path => '/your_path_to/foreman_proxmox'
+gem 'foreman_fog_proxmox', :path => '/your_path_to/foreman_fog_proxmox'
 ```
 
 * In foreman directory, install dependencies:
@@ -129,20 +135,26 @@ cp config/settings.yaml.example config/settings.yaml
 
 ```shell
 cp config/database.yaml.example config/database.yaml
-bundle exec rake db:migrate
-bundle exec rake db:seed
+bundle exec bin/rake db:migrate
+bundle exec bin/rake db:seed
 ```
 
 * You can reset admin password if needed:
 
 ```shell
-bundle exec rake permissions:reset
+bundle exec bin/rake permissions:reset
 ```
 
 * In foreman directory, after you modify foreman_fog_proxmox specific assets (proxmox.js, etc) you have to precompile it:
 
 ```shell
-bundle plugin:assets:precompile[foreman_fog_proxmox]
+bundle exec bin/rake plugin:assets:precompile[foreman_fog_proxmox]
+```
+
+* In foreman directory, after you modify foreman_fog_proxmox translations (language, texts in new files, etc) you have to compile it:
+
+```shell
+bundle exec bin/rake plugin:gettext[foreman_fog_proxmox]
 ```
 
 * In foreman directory, run rails server:

data/app/assets/javascripts/foreman_fog_proxmox/proxmox_compute_resource.js

@@ -0,0 +1,26 @@
+// Copyright 2018 Tristan Robert
+
+// This file is part of ForemanFogProxmox.
+
+// ForemanFogProxmox is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// ForemanFogProxmox is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+function sslVerifyPeerSelected(item){
+  var selected = $(item).is(':checked');
+  var ssl_certs_form = $('#compute_resource_ssl_certs').parents('.clearfix');
+  if (selected) {
+    ssl_certs_form.show();
+  } else {
+    ssl_certs_form.hide();
+  }
+}

data/app/assets/javascripts/foreman_fog_proxmox/proxmox_vm.js

@@ -0,0 +1,92 @@
+// Copyright 2018 Tristan Robert
+
+// This file is part of ForemanFogProxmox.
+
+// ForemanFogProxmox is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// ForemanFogProxmox is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+$(document).on('ContentLoad', tfm.numFields.initAll);
+$(document).ready(vmTypeSelected);
+
+function vmTypeSelected() {
+  var selected = $("#host_compute_attributes_type").val();
+  if (selected == undefined) selected = $("#compute_attribute_vm_attrs_type").val();
+  var host_uuid = $("input[id='host_uuid']").val();
+  var new_vm =  host_uuid == undefined;
+  var fieldsets = [];
+  fieldsets.push({id: 'config_advanced_options', toggle: true, new_vm: new_vm, selected: selected});
+  fieldsets.push({id: 'config_ext', toggle: true, new_vm: new_vm, selected: selected});
+  fieldsets.push({id: 'volume', toggle: true, new_vm: new_vm, selected: selected});
+  fieldsets.push({id: 'network', toggle: true, new_vm: true, selected: selected});
+  fieldsets.push({id: 'config_options', toggle: false, new_vm: new_vm, selected: selected});
+  fieldsets.push({id: 'config_cpu', toggle: false, new_vm: new_vm, selected: selected});
+  fieldsets.push({id: 'config_memory', toggle: false, new_vm: new_vm, selected: selected});
+  fieldsets.push({id: 'config_cdrom', toggle: false, new_vm: new_vm, selected: selected});
+  fieldsets.push({id: 'config_os', toggle: false, new_vm: new_vm, selected: selected});
+  fieldsets.push({id: 'config_dns', toggle: false, new_vm: new_vm, selected: selected});
+  fieldsets.forEach(toggleFieldset);
+  toggleVolumes(selected);
+  return false;
+}
+
+function toggleVolumes(selected){
+  var div_container = $("div[id^='container_volumes']");
+  var div_server = $("div[id^='server_volumes']");
+  var a_container = $("a[data-association='container_volumes']");
+  var a_server = $("a[data-association='server_volumes']");
+  switch (selected) {
+    case 'qemu':
+      div_container.hide();
+      div_server.show();
+      a_container.hide();
+      a_server.show();
+    break;
+    case 'lxc':
+      div_container.show();
+      div_server.hide();
+      a_container.show();
+      a_server.hide();
+    break;
+  }
+}
+
+function toggleFieldset(fieldset, index, fieldsets){
+  var server_input_hidden = $("div[id^='server_volumes']" + " > input:hidden");
+  var container_input_hidden = $("div[id^='container_volumes']" + " > input:hidden");
+  var server_fieldset = $("fieldset[id^='server_"+fieldset.id+"']");
+  var container_fieldset = $("fieldset[id^='container_"+fieldset.id+"']");
+  switch (fieldset.selected) {
+    case 'qemu':
+      if (fieldset.toggle && fieldset.new_vm){
+        server_fieldset.show();
+        container_fieldset.hide();
+      }
+      server_fieldset.removeAttr('disabled');
+      container_fieldset.attr('disabled','disabled');
+      server_input_hidden.removeAttr('disabled');
+      container_input_hidden.attr('disabled','disabled');
+      break;
+    case 'lxc':
+      if (fieldset.toggle && fieldset.new_vm){
+        server_fieldset.hide();
+        container_fieldset.show();
+      }
+      server_fieldset.attr('disabled','disabled');
+      container_fieldset.removeAttr('disabled');
+      container_input_hidden.removeAttr('disabled');
+      server_input_hidden.attr('disabled','disabled');
+      break;
+    default:
+      break;
+  }
+}

data/app/assets/javascripts/foreman_fog_proxmox/proxmox_vm_container.js

@@ -0,0 +1,60 @@
+// Copyright 2018 Tristan Robert
+
+// This file is part of ForemanFogProxmox.
+
+// ForemanFogProxmox is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// ForemanFogProxmox is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+function initOstemplateStorage(){
+    var select = '#host_compute_attributes_ostemplate_storage';
+    $(select + ' option:selected').prop('selected',false);
+    $(select).val('');
+  }
+  
+  function initOstemplateOptions(){
+    var select_ids = ['#host_compute_attributes_ostemplate_file','#compute_attribute_vm_attrs_ostemplate_file'];
+    select_ids.forEach(emptySelect);
+  }
+
+  function emptySelect(select, index, select_ids){
+    $(select).empty();
+    $(select).append($("<option></option>").val('').text(''));
+    $(select).val('');
+  }
+
+
+function storageOstemplateSelected(item) {
+    var storage = $(item).val();
+    if (storage != '') {
+      tfm.tools.showSpinner();
+      $.getJSON({
+        type: 'get',
+        url: '/foreman_fog_proxmox/ostemplates/'+storage,
+        complete: function(){
+          tfm.tools.hideSpinner();
+        },
+        error: function(j,status,error){
+          console.log("Error=" + error +", status=" + status + " loading os templates for storage=" + storage);
+        },
+        success: function(ostemplates) {
+          initOstemplateOptions();
+          $.each(ostemplates, function(i,ostemplate){
+            $('#host_compute_attributes_ostemplate_file').append($("<option></option>").val(ostemplate.volid).text(ostemplate.volid));
+            $('#compute_attribute_vm_attrs_ostemplate_file').append($("<option></option>").val(ostemplate.volid).text(ostemplate.volid));
+          });
+        }
+      });
+    } else {
+      initOstemplateOptions();
+    }
+  }

data/app/assets/javascripts/foreman_fog_proxmox/{proxmox.js → proxmox_vm_server.js}

@@ -21,18 +21,18 @@ function cdromSelected(item) {
 
   switch (selected) {
     case 'none':
-      initStorage();
-      initOptions('iso');
+      initCdromStorage();
+      initCdromOptions('iso');
       cdrom_image_form.hide();
       break;
     case 'cdrom':
-      initStorage();
-      initOptions('iso');
+      initCdromStorage();
+      initCdromOptions('iso');
       cdrom_image_form.hide();
       break;
     case 'image':
-      initStorage();
-      initOptions('iso');
+      initCdromStorage();
+      initCdromOptions('iso');
       cdrom_image_form.show();
       break;
     default:
@@ -41,13 +41,13 @@ function cdromSelected(item) {
   return false;
 }
 
-function initStorage(){
+function initCdromStorage(){
   var select = '#host_compute_attributes_config_attributes_cdrom_storage';
   $(select + ' option:selected').prop('selected',false);
   $(select).val('');
 }
 
-function initOptions(name){
+function initCdromOptions(name){
   var select = '#host_compute_attributes_config_attributes_cdrom_'+name;
   $(select).empty();
   $(select).append($("<option></option>").val('').text(''));
@@ -68,14 +68,14 @@ function initOptions(name){
           console.log("Error=" + error +", status=" + status + " loading isos for storage=" + storage);
         },
         success: function(isos) {
-          initOptions('iso');
+          initCdromOptions('iso');
           $.each(isos, function(i,iso){
             $('#host_compute_attributes_config_attributes_cdrom_iso').append($("<option></option>").val(iso.volid).text(iso.volid));
           });
         }
       });
     } else {
-      initOptions('iso');
+      initCdromOptions('iso');
     }
   }
 

data/app/controllers/concerns/foreman_fog_proxmox/controller/parameters/compute_resource.rb

@@ -27,7 +27,7 @@ module ForemanFogProxmox
           def compute_resource_params_filter
             super.tap do |filter|   
               filter.permit :ssl_verify_peer,
-                :ssl_certs, :disable_proxy
+                :ssl_certs, :node_name, :disable_proxy
             end
           end
 

data/app/controllers/foreman_fog_proxmox/compute_resources_controller.rb

@@ -23,7 +23,15 @@ module ForemanFogProxmox
 
     # GET foreman_fog_proxmox/isos/:storage
     def isos
-      volumes = @compute_resource.isos(params[:storage])
+      volumes = @compute_resource.images_by_storage('iso',params[:storage])
+      respond_to do |format|
+        format.json { render :json => volumes }
+      end
+    end
+
+    # GET foreman_fog_proxmox/ostemplates/:storage
+    def ostemplates
+      volumes = @compute_resource.images_by_storage('vztmpl',params[:storage])
       respond_to do |format|
         format.json { render :json => volumes }
       end

data/app/helpers/node_dashboard_helper.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+module NodeDashboardHelper
+    
+    def compute_data(statistics)
+        data = []
+        statistics.each do |statistic| 
+            t = Time.at(statistic['time'])
+            x = t.hour.to_s + ':' + t.min.to_s
+            data << [x,statistic['loadavg']*100]
+        end
+        data
+    end
+
+    def render_node_statistics(statistics,options = {})
+        data = compute_data(statistics)
+        flot_bar_chart("node_statistics", _("Time"), _("Average load (x100)"), data, options)
+    end
+end

data/app/helpers/proxmox_compute_selectors_helper.rb

@@ -18,6 +18,29 @@
 # along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
 
 module ProxmoxComputeSelectorsHelper
+
+  def proxmox_types_map
+    [OpenStruct.new(id: 'qemu', name: 'KVM/Qemu server'),
+     OpenStruct.new(id: 'lxc', name: 'LXC container')]
+  end
+
+  def proxmox_archs_map
+    [OpenStruct.new(id: 'amd64', name: '64 bits'),
+     OpenStruct.new(id: 'i386', name: '32 bits')]
+  end
+  
+  def proxmox_ostypes_map
+    [OpenStruct.new(id: 'debian', name: 'Debian'),
+     OpenStruct.new(id: 'ubuntu', name: 'Ubuntu'),
+     OpenStruct.new(id: 'centos', name: 'CentOS'),
+     OpenStruct.new(id: 'fedora', name: 'Fedora'),
+     OpenStruct.new(id: 'opensuse', name: 'OpenSuse'),
+     OpenStruct.new(id: 'archlinux', name: 'ArchLinux'),
+     OpenStruct.new(id: 'gentoo', name: 'Gentoo'),
+     OpenStruct.new(id: 'alpine', name: 'Alpine'),
+     OpenStruct.new(id: 'unmanaged', name: 'Unmanaged')]
+  end
+
   def proxmox_controllers_map
     [ForemanFogProxmox::OptionsSelect.new(id:'ide', name: 'IDE', range: 3), 
       ForemanFogProxmox::OptionsSelect.new(id:'sata', name: 'SATA', range: 5), 

data/app/helpers/proxmox_container_helper.rb

@@ -0,0 +1,157 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'fog/proxmox/helpers/disk_helper'
+require 'fog/proxmox/helpers/nic_helper'
+require 'foreman_fog_proxmox/value'
+
+module ProxmoxContainerHelper
+
+  KILO = 1024
+  MEGA = KILO * KILO
+  GIGA = KILO * MEGA
+
+  def parse_container_vm(args)
+    args = ActiveSupport::HashWithIndifferentAccess.new(args)
+    return {} unless args
+    return {} if args.empty?
+    return {} unless args['type'] == 'lxc'
+    config = args['config_attributes']
+    main_a = %w[name type node vmid]
+    config = args.reject { |key,_value| main_a.include? key } unless config
+    ostemplate_a = %w[ostemplate ostemplate_storage ostemplate_file]
+    ostemplate = parse_container_ostemplate(args.select { |key,_value| ostemplate_a.include? key })
+    ostemplate = parse_container_ostemplate(config.select { |key,_value| ostemplate_a.include? key }) unless ostemplate[:ostemplate]
+    volumes = parse_container_volumes(args['volumes_attributes'])
+    cpu_a = %w[arch cpulimit cpuunits cores]
+    cpu = parse_container_cpu(config.select { |key,_value| cpu_a.include? key })
+    memory_a = %w[memory swap]
+    memory = parse_container_memory(config.select { |key,_value| memory_a.include? key })
+    interfaces_attributes = args['interfaces_attributes']
+    networks = parse_container_interfaces(interfaces_attributes)
+    general_a = %w[node name type config_attributes volumes_attributes interfaces_attributes firmware_type provision_method container_volumes server_volumes]
+    logger.debug("general_a: #{general_a}")
+    parsed_vm = args.reject { |key,value| general_a.include?(key) || ostemplate_a.include?(key) || ForemanFogProxmox::Value.empty?(value) }
+    config_a = []
+    config_a += cpu_a
+    config_a += memory_a
+    config_a += main_a
+    config_a += general_a
+    parsed_config = config.reject { |key,value| config_a.include?(key) || ForemanFogProxmox::Value.empty?(value) }
+    logger.debug("parse_container_config(): #{parsed_config}")
+    parsed_vm = parsed_vm.merge(parsed_config).merge(cpu).merge(memory).merge(ostemplate)
+    networks.each { |network| parsed_vm = parsed_vm.merge(network) }
+    volumes.each { |volume| parsed_vm = parsed_vm.merge(volume) }
+    logger.debug("parse_container_vm(): #{parsed_vm}")
+    parsed_vm
+  end
+
+  def parse_container_memory(args)
+    memory = {} 
+    args.delete_if { |_key,value| ForemanFogProxmox::Value.empty?(value) }
+    memory.store(:memory, args['memory'].to_i) if args['memory']
+    memory.store(:swap, args['swap'].to_i) if args['swap']
+    logger.debug("parse_container_memory(): #{memory}")
+    memory
+  end
+
+  def parse_container_cpu(args)
+    cpu = {}
+    args.delete_if { |_key,value| ForemanFogProxmox::Value.empty?(value) }
+    cpu.store(:arch, args['arch'].to_s) if args['arch']
+    cpu.store(:cpulimit, args['cpulimit'].to_i) if args['cpulimit']
+    cpu.store(:cpuunits, args['cpuunits'].to_i) if args['cpuunits']
+    cpu.store(:cores, args['cores'].to_i) if args['cores']
+    logger.debug("parse_container_cpu(): #{cpu}")
+    cpu
+  end
+
+  def parse_container_ostemplate(args)
+    ostemplate = args['ostemplate']
+    ostemplate_file = args['ostemplate_file']
+    ostemplate = ostemplate ? ostemplate : ostemplate_file
+    ostemplate_storage = args['ostemplate_storage']
+    ostemplate_storage, ostemplate_file, _size  = Fog::Proxmox::DiskHelper.extract_storage_volid_size(ostemplate) unless ForemanFogProxmox::Value.empty?(ostemplate)
+    parsed_ostemplate = {ostemplate: ostemplate, ostemplate_file: ostemplate_file, ostemplate_storage: ostemplate_storage}
+    logger.debug("parse_container_ostemplate(): #{parsed_ostemplate}")
+    parsed_ostemplate
+  end
+
+  def parse_container_volume(args)
+    disk = {}
+    id = args['id']
+    id = "mp#{args['device']}" unless id
+    delete = args['_delete'].to_i == 1
+    logger.debug("parse_container_volume() args=#{args}")
+    args.delete_if { |_key,value| ForemanFogProxmox::Value.empty?(value) }
+    if delete
+      logger.debug("parse_container_volume(): delete id=#{id}")
+      disk.store(:delete, id)
+      disk
+    else
+      disk.store(:id, id)
+      disk.store(:volid, args['volid'])
+      disk.store(:storage, args['storage'].to_s)
+      disk.store(:size, args['size'].to_i)
+      options = args.reject { |key,_value| %w[id volid device storage size _delete].include? key}
+      disk.store(:options, options)
+      logger.debug("parse_container_volume(): add disk=#{disk}")
+      Fog::Proxmox::DiskHelper.flatten(disk)
+    end 
+  end
+
+  def parse_container_volumes(args)
+    logger.debug("parse_container_volumes() args=#{args}")
+    volumes = []
+    args.each_value { |value| volumes.push(parse_container_volume(value))} if args
+    logger.debug("parse_container_volumes(): volumes=#{volumes}")
+    volumes
+  end
+
+  def parse_container_interfaces(args)
+    nics = []
+    args.each_value { |value| nics.push(parse_container_interface(value))} if args
+    logger.debug("parse_container_interfaces(): nics=#{nics}")
+    nics
+  end
+
+  def parse_container_interface(args)
+    args.delete_if { |_key,value| ForemanFogProxmox::Value.empty?(value) }
+    nic = {}
+    id = args['id']
+    logger.debug("parse_container_interface(): id=#{id}")
+    delete = args['_delete'].to_i == 1
+    if delete
+      logger.debug("parse_container_interface(): delete id=#{id}")
+      nic.store(:delete, id)
+      nic
+    else
+      nic.store(:id, id)
+      nic.store(:name, args['name'].to_s)
+      nic.store(:bridge, args['bridge'].to_s) if args['bridge']
+      nic.store(:ip, args['ip'].to_s) if args['ip']
+      nic.store(:ip6, args['ip6'].to_s) if args['ip6']
+      nic.store(:rate, args['rate'].to_i) if args['rate']
+      nic.store(:tag, args['tag'].to_i) if args['tag']
+      logger.debug("parse_container_interface(): add nic=#{nic}")
+      Fog::Proxmox::NicHelper.container_flatten(nic)
+    end 
+  end
+
+end