foreman_custom_tab 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 33a87ef0fdaeba196f93a466aed1c46674af6fd5
-  data.tar.gz: 0324756000e6a7caef3c89d2031192961b1a93af
+  metadata.gz: 193542ee87777c74b898096451c7dfb169441eb3
+  data.tar.gz: 5fc5dd2d13b1be5ac4b9559dbffbe72e5bb5cc4b
 SHA512:
-  metadata.gz: 0a0c11658a57a0bbc448af52c5d8ede9b524f0eb9174949b4a96d1729ee7351d6668f639acf0a78d748d0ea52a31ae127af41985e85db2fb523e4ea89b02aa2b
-  data.tar.gz: cdf067d2c6d06f786deb56823982dcd2b424cb17d83e9125e051574241e18f4c5fd36f2cfac6a584cdbf720cbd0f3886b906d5377cc671b1204f87c55fd39923
+  metadata.gz: c985a2f2e0e4c5bcc7b7142964b3109ca9ef582752e46bd6d306d755e394e724141059a96b38412dc45e92ec829102ef0e67eb222551a755beb49f22e98d4432
+  data.tar.gz: 5c9ff283052091fd658c7eafd219d9ebf10b11997e362b4c5139225330026cc00ef1871a8952d9b29f492428349de40ede5cbf6df20f3514bde139d2c3e0d505

data/README.md

@@ -18,23 +18,38 @@ If there is no configuration file then the tab should not appear on the detailed
 there is one and it is empty then it will appear without any fields. To setup the configuration file create
 a new file named 'foreman_custom_tab.yaml' at the location /etc/foreman/plugins/
 
-The format for your yaml file should look like the following:
+The keys are the display title and the values are the methods that are actually called to produce the value.
 
-	---
-	  :custom_tab:
-	    :fields:
-	      IP Address, ip
-	      MAC Address, mac
+Example configuration:
 
-##TODO
+```
+:custom_tab:
+  :fields:
+    'Host Name': name
+    'MAC Address': mac
+    'IP Address': ip
+    'Architecture': arch
+    'Certificate Name': certname
+    'OS Title': operatingsystem.title
+    'OS Type': operatingsystem.type
+  :title: foo
+```
 
-*add plugin settings file
+## Verify the Custom Tab is loaded
+Navigate to /hosts/, click on one of the listed host. There should be tabs: 'Properties', 'Metrics', 'Templates', 'NICs' and 'custom_tab.title or Custom Tab'
+
+## Development mode
+Add the custom_tab config to <foreman_repo>/config/settings.yaml
+
+Note: foreman running locally (i.e not installed via rpm/debian package) does not use settings from /etc/foreman/plugins/
+
+## TODO
+
+* add plugin settings file
 
 ## Notes
 
-This project is still incomplete and in development. If the controller still cannot add the ':summary' filter 
-to the list in foreman then this plugin will probably not work with any other plugins. As of now the only fields
-that work are ones in the form "host.'field'"
+This project is still incomplete and in development. 
 
 Copyright (c) 2017 Joe Lyons Stannard III
 

data/Rakefile

@@ -30,7 +30,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << 'lib'
   t.libs << 'test'
   t.pattern = 'test/**/*_test.rb'
-  t.verbose = false
+  t.verbose = true
 end
 
 task default: :test
@@ -38,7 +38,7 @@ task default: :test
 begin
   require 'rubocop/rake_task'
   RuboCop::RakeTask.new
-rescue => _
+rescue StandardError => _
   puts 'Rubocop not loaded.'
 end
 

data/app/controllers/concerns/foreman_custom_tab/hosts_controller_extensions.rb

@@ -3,20 +3,20 @@ module ForemanCustomTab
   module HostsControllerExtensions
     extend ActiveSupport::Concern
 
-    def summary
+    def custom_tab
       # We can't add a before_filter :find_resource for Cockpit actions as
       # it'll override the default find_resource filter.
       find_resource
-      render :partial => 'foreman_custom_tab/hosts/summary', :locals => { :host => @host }
+      render :partial => 'foreman_custom_tab/hosts/custom_tab', :locals => { :host => @host }
     rescue ActionView::Template::Error => exception
-      process_ajax_error exception, 'fetch summary information'
+      process_ajax_error exception, 'fetch custom tab information'
     end
-    
+
     private
-    
+
     def action_permission
       case params[:action]
-      when 'summary'
+      when 'custom_tab'
         :view
       else
         super

data/app/helpers/concerns/foreman_custom_tab/hosts_helper_extensions.rb

@@ -1,20 +1,23 @@
 module ForemanCustomTab
   module HostsHelperExtensions
     extend ActiveSupport::Concern
-    
-    
-    def summary_fields(host)
+
+    def custom_tab_fields(host)
       fields = []
-      rows = SETTINGS[:custom_tab][:fields] || []
-      rows.each do |name, value|
-        result = nil
+      config_fields = SETTINGS[:custom_tab][:fields] || []
+      config_fields.each do |key, value|
+        host_attr_val = nil
+        # chain the method calls for attibutes like operatingsystem.title
         value.split('.').each_with_index do |method, index|
-          result = index.eql?(0) ? host.try(method) : result.try(method)
+          host_attr_val = index.eql?(0) ? host.try(method) : host_attr_val.try(method)
         end
-        fields += [[_(name.to_s), result]] if result.present?
+        fields += [[_(key.to_s), host_attr_val]] if host_attr_val.present?
       end
       fields
     end
-    
+
+    def custom_tab_title
+      SETTINGS[:custom_tab][:title] || 'Custom Tab'
+    end
   end
 end

data/app/overrides/add_tab.rb

@@ -1,8 +1,7 @@
 if SETTINGS[:custom_tab]
-  Deface::Override.new(
-                     :virtual_path => "hosts/show",
-                     :name => "add_tab_link",
-                     :insert_bottom => "ul#myTab",
-                     :text => "  <li><a href=\"#summary\" data-toggle=\"tab\"><%= _('Summary') %></a></li>"
-                     )
-end
+  Deface::Override.new(:virtual_path => 'hosts/show',
+                       :name => 'add_tab_link',
+                       :insert_bottom => 'ul#myTab',
+                       :text =>
+                       "<li><a href='#custom_tab' data-toggle='tab'><%= _(custom_tab_title) %></a></li>")
+end

data/app/overrides/add_tab_link.rb

@@ -1,10 +1,10 @@
 if SETTINGS[:custom_tab]
-  Deface::Override.new(
-                    :virtual_path => 'hosts/show',
-                    :name => 'create_link',
-                    :insert_bottom => 'div#myTabContent',
-                    :text => "\n  <div id='summary' class='tab-pane' data-ajax-url='<%= summary_host_path(@host)%>' data-on-complete='onContentLoad'>
-                                    <%= spinner(_('Loading Summary information ...')) %>
-                                   </div>"
-                    )
+  Deface::Override.new(:virtual_path => 'hosts/show',
+                       :name => 'create_link',
+                       :insert_bottom => 'div#myTabContent',
+                       :text =>
+                       "\n  <div id='custom_tab' class='tab-pane'
+                       data-ajax-url='<%= custom_tab_host_path(@host)%>' data-on-complete='onContentLoad'>
+                       <%= spinner(_('Loading Custom Tab information ...')) %>
+                       </div>")
 end

data/app/views/foreman_custom_tab/hosts/{_summary.html.erb → _custom_tab.html.erb}

@@ -1,11 +1,11 @@
 <table id="custom_table" class="<%= table_css_classes %>">
   <thead>
     <tr>
-      <th colspan="2"><%= _('Summary') %></th>
+      <th colspan="2"><%= _(custom_tab_title) %></th>
     </tr>
   </thead>
   <tbody>
-    <% summary_fields(host).each do |name, value| %>
+    <% custom_tab_fields(host).each do |name, value| %>
       <tr>
         <td><%= name %></td>
         <td><%= value %></td>

data/config/foreman_custom_tab.yaml.example

@@ -0,0 +1,11 @@
+:custom_tab:
+  :fields:
+    'Host Name': name
+    'MAC Address': mac
+    'IP Address': ip
+    'Architecture': arch
+    'Certificate Name': certname
+    'OS Title': operatingsystem.title
+    'OS Type': operatingsystem.type
+  :title: foo
+

data/config/routes.rb

@@ -1,11 +1,9 @@
 Rails.application.routes.draw do
-  #scope :foreman_custom_tab, :path => '/custom_tab' do
-    constraints(:id => /[^\/]+/) do
-      resources :hosts do
-        member do
-          get 'summary'
-        end
+  constraints(:id => %r{[^\/]+}) do
+    resources :hosts do
+      member do
+        get 'custom_tab'
       end
     end
-  #end
+  end
 end

data/lib/foreman_custom_tab/engine.rb

@@ -9,35 +9,33 @@ module ForemanCustomTab
     config.autoload_paths += Dir["#{config.root}/app/helpers/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/models/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/overrides"]
-  
-    
-    initializer 'foreman_custom_tab.configure_assets', :group => :assets do
-      SETTINGS[:foreman_custom_tab] = { assets: { precompile: assets_to_precompile } }
-    end
-    
+
+    # requires_foreman version as per
+    # http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Requiring-Foreman-version
+
+    # Adding permission to controller action
+    # http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Adding-permission
     initializer('foreman_custom_tab.register_plugin', :before => :finisher_hook) do
       Foreman::Plugin.register :foreman_custom_tab do
         requires_foreman '>= 1.7'
-        
+
         security_block :foreman_custom_tab do
           permission :view_hosts,
-              { :hosts => [:summary] },
-              :resource_type => 'Host'
+                     { :hosts => [:custom_tab] },
+                     :resource_type => 'Host'
         end
-        
-        
-        
       end
     end
-    
-    
+
+    # Extending a controller
     # Include concerns in this config.to_prepare block
+    # http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Extending-a-Controller
     config.to_prepare do
       begin
         HostsHelper.send(:include, ForemanCustomTab::HostsHelperExtensions)
         ::HostsController.send(:include,
                                ForemanCustomTab::HostsControllerExtensions)
-      rescue => e
+      rescue StandardError => e
         Rails.logger.warn "ForemanCustomTab: skipping engine hook (#{e})"
       end
     end

data/lib/foreman_custom_tab/version.rb

@@ -1,3 +1,3 @@
 module ForemanCustomTab
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.1.0'.freeze
 end

data/lib/tasks/foreman_custom_tab_tasks.rake

@@ -0,0 +1,40 @@
+# Tests
+namespace :test do
+  desc 'Test Foreman Custom Tab'
+  Rake::TestTask.new(:foreman_custom_tab) do |t|
+    test_dir = File.join(File.dirname(__FILE__), '../..', 'test')
+    t.libs << ['test', test_dir]
+    t.pattern = "#{test_dir}/**/*_test.rb"
+    t.verbose = true
+    t.warning = false
+  end
+end
+
+namespace :foreman_custom_tab do
+  task :rubocop do
+    begin
+      require 'rubocop/rake_task'
+      RuboCop::RakeTask.new(:rubocop_foreman_custom_tab) do |task|
+        task.patterns = ["#{ForemanCustomTab::Engine.root}/app/**/*.rb",
+                         "#{ForemanCustomTab::Engine.root}/lib/**/*.rb",
+                         "#{ForemanCustomTab::Engine.root}/test/**/*.rb"]
+      end
+    rescue StandardError => e
+      puts "Rubocop not loaded #{e.message}"
+    end
+
+    Rake::Task['rubocop_foreman_custom_tab'].invoke
+  end
+end
+
+Rake::Task[:test].enhance do
+  Rake::Task['test:foreman_custom_tab'].invoke
+end
+
+load 'tasks/jenkins.rake'
+if Rake::Task.task_defined?(:'jenkins:unit')
+  Rake::Task['jenkins:unit'].enhance do
+    Rake::Task['test:foreman_custom_tab'].invoke
+    Rake::Task['foreman_custom_tab:rubocop'].invoke
+  end
+end

data/locale/gemspec.rb

@@ -1,2 +1,2 @@
 # Matches foreman_custom_tab.gemspec
-_('TODO: Description of ForemanCustomTab.')
+_('Foreman Plugin that makes a new tab with different fields depending on the settings file')

data/test/functional/concerns/hosts_controller_extensions_test.rb

@@ -0,0 +1,74 @@
+require 'test_plugin_helper'
+
+class HostsControllerTest < ActionController::TestCase
+  let(:os) { FactoryBot.create(:operatingsystem, name: 'CentOS', major: '7', type: 'Redhat') }
+  let(:arch) { FactoryBot.create(:architecture) }
+  let(:host_id) { 'foreman.example.com' }
+  # rubocop:disable Metrics/LineLength
+  let(:host) { FactoryBot.create(:host, id: host_id, mac: '00:00:00:00:00:00', ip: '127.0.0.1', operatingsystem: os, arch: arch) }
+  # rubocop:enable Metrics/LineLength
+  let(:custom_tab_title) { SETTINGS[:custom_tab][:title] }
+
+  # rubocop:disable Metrics/LineLength, Style/StringLiterals, HttpPositionalArguments
+  test 'GET hosts/:id displays tabs' do
+    get :show, { :id => host.id }, set_session_user
+    assert_includes response.headers['Content-Type'], 'text/html'
+    assert_equal response.status, 200
+    assert_includes response.body, "ul id=\"myTab\""
+  end
+
+  test "host overview displays tabs 'Properties', 'Metrics', 'NICs'" do
+    get :show, { :id => host.id }, set_session_user
+    assert_includes response.headers['Content-Type'], 'text/html'
+    assert_equal response.status, 200
+    assert_includes response.body, "<ul id=\"myTab\""
+    assert_includes response.body, "<li class=\"active\"><a href=\"#properties\" data-toggle=\"tab\">Properties</a></li>"
+    assert_includes response.body, "<li><a href=\"#metrics\" data-toggle=\"tab\">Metrics</a></li>"
+    assert_includes response.body, "<li><a href=\"#nics\" data-toggle=\"tab\">NICs</a></li>"
+  end
+
+  test "host overview displays the Custom Tab" do
+    get :show, { :id => host.id }, set_session_user
+    assert_includes response.headers['Content-Type'], 'text/html'
+    assert_includes response.body, "<ul id=\"myTab\""
+    assert_equal response.status, 200
+    assert_includes response.body, "<li><a href=\"#custom_tab\" data-toggle=\"tab\">#{custom_tab_title}</a></li>"
+  end
+
+  test "host/:id contains custom_tab ajax link" do
+    get :show, { :id => host.id }, set_session_user
+
+    assert_equal response.status, 200
+    assert_includes response.headers['Content-Type'], 'text/html'
+    assert_includes response.body, "<ul id=\"myTab\""
+    assert_includes response.body, "<li><a href=\"#custom_tab\" data-toggle=\"tab\">#{custom_tab_title}</a></li>"
+    assert_includes response.body, "<div id=\"custom_tab\" class=\"tab-pane\" data-ajax-url=\"/hosts/#{host.name}/custom_tab\" data-on-complete=\"onContentLoad\">"
+  end
+
+  describe 'When hosts#show' do
+    before do
+      host_id = 'foreman.example.com'
+      Rails.application.routes.draw do
+        get "/hosts/#{host_id}/custom_tab" => 'hosts_controller#custom_tab'
+      end
+    end
+    after do
+      Rails.application.reload_routes!
+    end
+
+    test 'AJAX request hosts/:id/custom_tab displays custom host data' do
+      skip("xhr route missing: ActionController::UrlGenerationError:
+            No route matches {:action=>'/hosts/host6/custom_tab', :controller=>'hosts'}")
+      # get "/hosts/#{host.name}/custom_tab", xhr: true
+      # xhr :get, custom_tab_host_path(host), delivery_method: :deliver, status: :pending, format: 'js'
+      get custom_tab_host_path(host), params: { xhr: true }
+      # get "/hosts/#{host_id}/custom_tab"
+
+      SETTINGS[:custom_tab][:fields].each do |title, attr|
+        assert_includes response.body, "<td>#{title}</td>"
+        assert_includes response.body, "<td>#{host.get_chained_attr_val(attr)}</td>"
+      end
+    end
+  end
+  # rubocop:enable Metrics/LineLength, Style/StringLiterals, HttpPositionalArguments
+end

data/test/helpers/concerns/foreman_custom_tab/hosts_helper_extensions_test.rb

@@ -0,0 +1,37 @@
+require 'test_plugin_helper'
+
+class HostsHelperExtensionsTest < ActiveSupport::TestCase
+  include ForemanCustomTab::HostsHelperExtensions
+
+  let(:os) { FactoryBot.create(:operatingsystem, name: 'CentOS', major: '7', type: 'Redhat') }
+  let(:arch) { FactoryBot.create(:architecture) }
+  # rubocop:disable Metrics/LineLength
+  let(:host) { FactoryBot.create(:host, id: 'foreman.example.com', mac: '00:00:00:00:00:00', ip: '127.0.0.1', operatingsystem: os, arch: arch) }
+  # rubocop:enable Metrics/LineLength
+  let(:expected_fields) do
+    fields = []
+    SETTINGS[:custom_tab][:fields].each do |title, host_attr|
+      fields << [title, host.get_chained_attr_val(host_attr)]
+    end
+    fields
+  end
+
+  describe '#custom_tab_fields(host)' do
+    test 'returns fields as expected' do
+      assert_equal custom_tab_fields(host), expected_fields
+    end
+  end
+
+  describe '#custom_tab_title' do
+    title_orig = SETTINGS[:custom_tab][:title]
+    test 'returns correct title' do
+      assert_equal custom_tab_title, title_orig
+    end
+
+    test 'settings title is not present' do
+      SETTINGS[:custom_tab][:title] = nil
+      assert_equal custom_tab_title, 'Custom Tab'
+      SETTINGS[:custom_tab][:title] = title_orig
+    end
+  end
+end

data/test/test_plugin_helper.rb

@@ -1,6 +1,23 @@
+# populate custom tab settings for test env
+# NOTE: this needs to be updated before calling foreman test_helper
+SETTINGS[:custom_tab] = { fields: { 'Host Name' => 'name',
+                                    'MAC Address' => 'mac',
+                                    'IP Address' => 'ip',
+                                    'Architecture' => 'arch',
+                                    'Certificate Name' => 'certname',
+                                    'OS Title' => 'operatingsystem.title',
+                                    'OS Type' => 'operatingsystem.type' },
+                          title: 'foo' }
+
 # This calls the main test_helper in Foreman-core
 require 'test_helper'
 
-# Add plugin to FactoryGirl's paths
-FactoryGirl.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
-FactoryGirl.reload
+class Object
+  def get_chained_attr_val(attrs)
+    attr_val = nil
+    attrs.split('.').each_with_index do |method, index|
+      attr_val = index.eql?(0) ? try(method) : attr_val.try(method)
+    end
+    attr_val
+  end
+end

data/test/unit/foreman_custom_tab_test.rb

@@ -2,7 +2,7 @@ require 'test_plugin_helper'
 
 class ForemanCustomTabTest < ActiveSupport::TestCase
   setup do
-    User.current = User.find_by_login 'admin'
+    User.current = User.find_by(login: 'admin')
   end
 
   test 'the truth' do

data/test/views/foreman_custom_tab/hosts/_custom_tab_test.rb

@@ -0,0 +1,30 @@
+require 'test_plugin_helper'
+
+class CustomTabTest < ActionView::TestCase
+  let(:os) { FactoryBot.create(:operatingsystem, name: 'CentOS', major: '7', type: 'Redhat') }
+  let(:arch) { FactoryBot.create(:architecture) }
+  # rubocop:disable Metrics/LineLength
+  let(:host) { FactoryBot.create(:host, id: 'foreman.example.com', mac: '00:00:00:00:00:00', ip: '127.0.0.1', operatingsystem: os, arch: arch) }
+  # rubocop:enable Metrics/LineLength
+  let(:custom_tab_title) { SETTINGS[:custom_tab][:title] }
+
+  class FakeHostsController < ActionController::Base
+    include ForemanCustomTab::HostsHelperExtensions
+    include LayoutHelper
+
+    def index
+      os = FactoryBot.create(:operatingsystem, name: 'CentOS', major: '7', type: 'Redhat')
+      # rubocop:disable Metrics/LineLength
+      @host = FactoryBot.create(:host, id: 'foreman.example.com', mac: '00:00:00:00:00:00', ip: '127.0.0.1', operatingsystem: os, arch: FactoryBot.create(:architecture))
+      # rubocop:enable Metrics/LineLength
+      render :partial => 'foreman_custom_tab/hosts/custom_tab', :locals => { :host => @host }
+    end
+  end
+
+  test 'successfully render custom_tab partial' do
+    skip("NoMethodError: undefined method 'content_type' for nil:NilClass")
+    get FakeHostsController.new.index
+
+    assert_select 'custom_table'
+  end
+end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: foreman_custom_tab
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Joe Stannard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-02 00:00:00.000000000 Z
+date: 2017-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rdoc
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -38,7 +38,28 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Makes a new tab that has different fields depending on the settings file
+- !ruby/object:Gem::Dependency
+  name: deface
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.2.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.2.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+description: Foreman Plugin that makes a new tab with different fields depending on
+  the settings file
 email:
 - stannajl@miamioh.edu
 executables: []
@@ -52,20 +73,23 @@ files:
 - app/helpers/concerns/foreman_custom_tab/hosts_helper_extensions.rb
 - app/overrides/add_tab.rb
 - app/overrides/add_tab_link.rb
-- app/views/foreman_custom_tab/hosts/_summary.html.erb
+- app/views/foreman_custom_tab/hosts/_custom_tab.html.erb
+- config/foreman_custom_tab.yaml.example
 - config/routes.rb
-- config/tab.yaml
 - lib/foreman_custom_tab.rb
 - lib/foreman_custom_tab/engine.rb
 - lib/foreman_custom_tab/version.rb
+- lib/tasks/foreman_custom_tab_tasks.rake
 - locale/Makefile
 - locale/en/foreman_custom_tab.po
 - locale/foreman_custom_tab.pot
 - locale/gemspec.rb
-- test/factories/foreman_custom_tab_factories.rb
+- test/functional/concerns/hosts_controller_extensions_test.rb
+- test/helpers/concerns/foreman_custom_tab/hosts_helper_extensions_test.rb
 - test/test_plugin_helper.rb
 - test/unit/foreman_custom_tab_test.rb
-homepage: https://github.com/rougehero/foreman_custom_tab
+- test/views/foreman_custom_tab/hosts/_custom_tab_test.rb
+homepage: https://github.com/MiamiOH/foreman_custom_tab
 licenses:
 - GPL-3.0
 metadata: {}
@@ -85,11 +109,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
-summary: creates custom tab for hosts
+summary: Creates custom tab for hosts in Foreman
 test_files:
-- test/factories/foreman_custom_tab_factories.rb
 - test/test_plugin_helper.rb
+- test/functional/concerns/hosts_controller_extensions_test.rb
 - test/unit/foreman_custom_tab_test.rb
+- test/views/foreman_custom_tab/hosts/_custom_tab_test.rb
+- test/helpers/concerns/foreman_custom_tab/hosts_helper_extensions_test.rb

data/config/tab.yaml

@@ -1 +0,0 @@
-IP Address, ip

data/test/factories/foreman_custom_tab_factories.rb

@@ -1,5 +0,0 @@
-FactoryGirl.define do
-  factory :host do
-    name 'foreman_custom_tab'
-  end
-end