foreman-tasks 13.2.0 → 13.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a192677704918d5f7e81554fb38e70f389a795c021c4889f6f910fa992a1bed7
-  data.tar.gz: 000732f9d423e0bc8ba6293f7150a631de785535a94d6b5004d40922768897d1
+  metadata.gz: 3a911bd4cd6b5bc47ec2aeb30c804aacf1151b9b0deadb3b1c1c9307f93057d1
+  data.tar.gz: db6d6432425484dd28740260c4de5e2a45ad16e18a5b1d49969750d6dbfe85e6
 SHA512:
-  metadata.gz: d6e131b3624a79ef45aca8c87674938bcc7b2b8c1c0be6652251b6818f0bb1a4ad3843b976d2394901ffe861d7e153fdaeb764c1b44c0cdcbddb46d73d06c6f9
-  data.tar.gz: 95888cc143cb58b40d0485d6c67f71c95e9e8e88d08f086b31982f9cfc3693aee68cecd885984581e7fb704feee3978d6e601551b6b200413036f6cbfd0c3336
+  metadata.gz: 4acd3a055ec83f16c6d4fb22e909d80d3d2a130f7d1d2c57f5d6bbdb76634a6d97cb2d24209b6d540557b93ca0c379869e4d676ffc261cd7ce4c3a6409d3bca4
+  data.tar.gz: d86f68e0b10de405487963ff0565456f592ddca298b6b37cb32b1e243245b949b5b9011d46662d8ad0d58f3b54bc714cdef4f22a1f500a805f39ac4db381d76f

data/lib/foreman_tasks/version.rb

@@ -1,3 +1,3 @@
 module ForemanTasks
-  VERSION = '13.2.0'.freeze
+  VERSION = '13.2.1'.freeze
 end

data/webpack/ForemanTasks/Components/TaskDetails/Components/TaskInfo.js

@@ -79,12 +79,13 @@ MetadataField.defaultProps = {
   span: undefined,
 };
 
-const copyableText = text =>
+const copyableText = (text, ouiaId) =>
   text ? (
     <ClipboardCopy
       variant="inline-compact"
       hoverTip={__('Copy')}
       clickTip={__('Copied')}
+      ouiaId={ouiaId}
     >
       {text}
     </ClipboardCopy>
@@ -161,7 +162,7 @@ const TaskInfo = props => {
       <MetadataField
         labelOuiaId="task-info-metadata-id-label"
         title={__('Id')}
-        value={copyableText(id)}
+        value={copyableText(id, 'task-info-id-copy')}
       />
 
       <GridItem span={12}>
@@ -225,7 +226,7 @@ const TaskInfo = props => {
             <MetadataField
               labelOuiaId="task-info-metadata-external-id-label"
               title={__('External Id')}
-              value={copyableText(externalId)}
+              value={copyableText(externalId, 'task-info-ext-id-copy')}
             />
             {help && (
               <MetadataField

data/webpack/ForemanTasks/Components/TasksDashboard/Components/TasksTimeRow/TasksTimeRow.test.js

@@ -1,15 +1,56 @@
-import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
+import React from 'react';
+import {
+  render,
+  screen,
+  fireEvent,
+  waitFor,
+  within,
+} from '@testing-library/react';
+import '@testing-library/jest-dom';
 
 import { TASKS_DASHBOARD_AVAILABLE_TIMES } from '../../TasksDashboardConstants';
 import TasksTimeRow from './TasksTimeRow';
 
-const fixtures = {
-  'render with minimal props': {},
-  'render with props': {
-    time: TASKS_DASHBOARD_AVAILABLE_TIMES.WEEK,
-    updateTime: jest.fn(),
-  },
-};
+describe('TasksTimeRow', () => {
+  it('renders the time label and defaults the dropdown to 24h', () => {
+    render(<TasksTimeRow />);
 
-describe('TasksTimeRow', () =>
-  testComponentSnapshotsWithFixtures(TasksTimeRow, fixtures));
+    expect(screen.getByText('With focus on last')).toBeInTheDocument();
+    expect(screen.getByRole('button', { name: /24h/i })).toBeInTheDocument();
+  });
+
+  it('renders the dropdown with the provided time selection', () => {
+    render(
+      <TasksTimeRow
+        time={TASKS_DASHBOARD_AVAILABLE_TIMES.WEEK}
+        updateTime={jest.fn()}
+      />
+    );
+
+    expect(screen.getByText('With focus on last')).toBeInTheDocument();
+    expect(screen.getByRole('button', { name: /^week$/i })).toBeInTheDocument();
+  });
+
+  it('calls updateTime when a different time option is selected', async () => {
+    const updateTime = jest.fn();
+
+    render(
+      <TasksTimeRow
+        time={TASKS_DASHBOARD_AVAILABLE_TIMES.H24}
+        updateTime={updateTime}
+      />
+    );
+
+    fireEvent.click(screen.getByRole('button', { name: /24h/i }));
+
+    const menu = await screen.findByRole('menu');
+    fireEvent.click(within(menu).getByRole('menuitem', { name: /^12h$/i }));
+
+    await waitFor(() => {
+      expect(updateTime).toHaveBeenCalledTimes(1);
+      expect(updateTime).toHaveBeenCalledWith(
+        TASKS_DASHBOARD_AVAILABLE_TIMES.H12
+      );
+    });
+  });
+});

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman-tasks
 version: !ruby/object:Gem::Version
-  version: 13.2.0
+  version: 13.2.1
 platform: ruby
 authors:
 - Ivan Nečas
@@ -436,7 +436,6 @@ files:
 - webpack/ForemanTasks/Components/TasksDashboard/Components/TasksTimeRow/TasksTimeRow.js
 - webpack/ForemanTasks/Components/TasksDashboard/Components/TasksTimeRow/TasksTimeRow.scss
 - webpack/ForemanTasks/Components/TasksDashboard/Components/TasksTimeRow/TasksTimeRow.test.js
-- webpack/ForemanTasks/Components/TasksDashboard/Components/TasksTimeRow/__snapshots__/TasksTimeRow.test.js.snap
 - webpack/ForemanTasks/Components/TasksDashboard/TasksDashboard.js
 - webpack/ForemanTasks/Components/TasksDashboard/TasksDashboard.scss
 - webpack/ForemanTasks/Components/TasksDashboard/TasksDashboardActions.js

data/webpack/ForemanTasks/Components/TasksDashboard/Components/TasksTimeRow/__snapshots__/TasksTimeRow.test.js.snap

@@ -1,37 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`TasksTimeRow render with minimal props 1`] = `
-<div
-  className="tasks-time-row"
->
-  <span
-    className="time-label"
-  >
-    With focus on last
-  </span>
-  <TimeDropDown
-    className=""
-    id="tasks-dashboard-time-period-dropdown"
-    onChange={[Function]}
-    selectedTime="H24"
-  />
-</div>
-`;
-
-exports[`TasksTimeRow render with props 1`] = `
-<div
-  className="tasks-time-row"
->
-  <span
-    className="time-label"
-  >
-    With focus on last
-  </span>
-  <TimeDropDown
-    className=""
-    id="tasks-dashboard-time-period-dropdown"
-    onChange={[MockFunction]}
-    selectedTime="WEEK"
-  />
-</div>
-`;