foreman-tasks 11.0.4 → 11.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8727c799c331337534ad6e826edfc65c25c5b76fff264065535e0bf6b0e6c7f9
-  data.tar.gz: d1e9f35147ad693323614d5b4c293a02d694135be01cf1d0bfca349441b2bac5
+  metadata.gz: 446616be3e90ffc5981df96ebcec976c1ff72f71b9a69cf80504f23dc7675c31
+  data.tar.gz: 91943a059401554d4a39f32022ec3fd6c33403fae2ff9dff787620c69e736140
 SHA512:
-  metadata.gz: f75e8f7b86f28931be8e8b0d5c153f0386c17b05004bbe1c657f9bed4e52d6f1295fb0ea8923a531daf28b0c3abb8c8e1fa159f607428321e001a71ccc5a6603
-  data.tar.gz: f7d331cfa5d37aa0daf82a01aec928418d3a749c3bb5e36327954e11834d47cc9e94dbd3492eb28d24c2603eeec2bb4de6ba37c90744723f35c13277ee675a67
+  metadata.gz: 71978faa23f25d3c58cec3f6000737090593d9a139fdf9abef7c3ce98c156cd0d2d20a0306fba4019eb3c0fe33051b7a63a191743a2c3919061c3886939797d3
+  data.tar.gz: 61bc6b31186d145a44aba4f8257d030b6d7e14739490955c584f9825eaa569cc0b8e63523eb1d287a87ce915010ddf82a6a8b002f8addb81ddc88333470fd2a6

data/.github/workflows/test-breaking.yaml

@@ -0,0 +1,15 @@
+name: Label a PR `breaks-robottelo` on appropriate comment
+on:
+  issue_comment:
+    types: [created]
+jobs:
+  breaks-robottelo:
+    uses: theforeman/actions/.github/workflows/breaks-robottelo.yml@v0
+    permissions:
+      pull-requests: write
+    with:
+      repo: ${{ github.repository }}
+      issue: ${{ github.event.issue.number }}
+    secrets:
+      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+

data/app/assets/javascripts/foreman-tasks/locale/de/foreman_tasks.js

@@ -798,6 +798,9 @@
       "is hour (range: 0-23)": [
         "Stunde (im Bereich: 0-23)"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "Minute (im Bereich: 0-59)"
       ],
@@ -816,6 +819,9 @@
       "mode has to be one of %{allowed_modes}": [
         "Modus muss einer von %{allowed_modes} sein"
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         "älter"
       ],

data/app/assets/javascripts/foreman-tasks/locale/en/foreman_tasks.js

@@ -798,6 +798,9 @@
       "is hour (range: 0-23)": [
         ""
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         ""
       ],
@@ -816,6 +819,9 @@
       "mode has to be one of %{allowed_modes}": [
         ""
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         ""
       ],

data/app/assets/javascripts/foreman-tasks/locale/es/foreman_tasks.js

@@ -799,6 +799,9 @@
       "is hour (range: 0-23)": [
         "es hora (rango: 0-23)"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "es minuto (rango: 0-59)"
       ],
@@ -817,6 +820,9 @@
       "mode has to be one of %{allowed_modes}": [
         "modo tiene que ser uno de %.{allowed_modes}"
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         "más antiguo"
       ],

data/app/assets/javascripts/foreman-tasks/locale/fr/foreman_tasks.js

@@ -799,6 +799,9 @@
       "is hour (range: 0-23)": [
         "est heure (plage: 0-23)"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "est minute (plage: 0-59)"
       ],
@@ -817,6 +820,9 @@
       "mode has to be one of %{allowed_modes}": [
         "mode doit être un parmi %%{allowed_modes}"
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         "plus ancien"
       ],

data/app/assets/javascripts/foreman-tasks/locale/ja/foreman_tasks.js

@@ -797,6 +797,9 @@
       "is hour (range: 0-23)": [
         "時間 (範囲: 0 - 23)"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "分 (範囲: 0 - 59)"
       ],
@@ -815,6 +818,9 @@
       "mode has to be one of %{allowed_modes}": [
         "モードは %%{allowed_modes} のいずれかである必要があります"
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         "前"
       ],

data/app/assets/javascripts/foreman-tasks/locale/ka/foreman_tasks.js

@@ -798,6 +798,9 @@
       "is hour (range: 0-23)": [
         "საათი (0-23)"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "წუთი (0-59)"
       ],
@@ -816,6 +819,9 @@
       "mode has to be one of %{allowed_modes}": [
         "რეჟიმი შეიძლება იყოს ერთ ერთი %{allowed_modes} -დან"
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         "ძველი"
       ],

data/app/assets/javascripts/foreman-tasks/locale/ko/foreman_tasks.js

@@ -798,6 +798,9 @@
       "is hour (range: 0-23)": [
         "시간(범위: 0-23)"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "분(범위: 0-59)"
       ],
@@ -816,6 +819,9 @@
       "mode has to be one of %{allowed_modes}": [
         ""
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         ""
       ],

data/app/assets/javascripts/foreman-tasks/locale/pt_BR/foreman_tasks.js

@@ -799,6 +799,9 @@
       "is hour (range: 0-23)": [
         "é a hora (intervalo: 0-23)"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "é o minuto (intervalo: 0-59) "
       ],
@@ -817,6 +820,9 @@
       "mode has to be one of %{allowed_modes}": [
         "modo tem que ser um de %{allowed_modes}"
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         "mais antigo"
       ],

data/app/assets/javascripts/foreman-tasks/locale/ru/foreman_tasks.js

@@ -798,6 +798,9 @@
       "is hour (range: 0-23)": [
         "— часы (1–24)"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "— минуты (0–59)"
       ],
@@ -816,6 +819,9 @@
       "mode has to be one of %{allowed_modes}": [
         ""
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         ""
       ],

data/app/assets/javascripts/foreman-tasks/locale/zh_CN/foreman_tasks.js

@@ -797,6 +797,9 @@
       "is hour (range: 0-23)": [
         "小时（范围：0-23）"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "分钟（范围：0-59）"
       ],
@@ -815,6 +818,9 @@
       "mode has to be one of %{allowed_modes}": [
         "模式必须是 %%{allowed_modes} 之一"
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         "较老"
       ],

data/app/assets/javascripts/foreman-tasks/locale/zh_TW/foreman_tasks.js

@@ -798,6 +798,9 @@
       "is hour (range: 0-23)": [
         "是小時（範圍：0-23）"
       ],
+      "is in the past": [
+        ""
+      ],
       "is minute (range: 0-59)": [
         "是分鐘（範圍：0-59）"
       ],
@@ -816,6 +819,9 @@
       "mode has to be one of %{allowed_modes}": [
         ""
       ],
+      "must be set": [
+        ""
+      ],
       "older": [
         ""
       ],

data/lib/foreman_tasks/engine.rb

@@ -93,7 +93,8 @@ module ForemanTasks
                                     'It should contain %{label} placeholder, that will be replaced with normalized task label '\
                                     '(restricted to only alphanumeric characters)). %{version} placeholder is also available.'),
                     default: nil,
-                    full_name: N_('Tasks troubleshooting URL'))
+                    full_name: N_('Tasks troubleshooting URL'),
+                    validate: ->(value) { ForemanTasks.troubleshooting_url_with_placeholders(value) })
             setting('foreman_tasks_polling_multiplier',
                     type: :integer,
                     description: N_('Polling multiplier which is used to multiply the default polling intervals. '\
@@ -204,4 +205,20 @@ module ForemanTasks
   def use_relative_model_naming
     true
   end
+
+  def self.troubleshooting_url_with_placeholders(value)
+    return true if value.blank?
+    test_url = value.dup
+    test_url.gsub!(/%\{label\}/, 'validation_label')
+    test_url.gsub!(/%\{version\}/, '1.0')
+    begin
+      uri = URI.parse(test_url)
+      unless (uri.is_a?(URI::HTTP) || uri.is_a?(URI::HTTPS)) && !uri.host.nil?
+        raise URI::InvalidURIError
+      end
+      true
+    rescue URI::InvalidURIError
+      raise Foreman::SettingValueException, N_("Invalid URL")
+    end
+  end
 end

data/lib/foreman_tasks/version.rb

@@ -1,3 +1,3 @@
 module ForemanTasks
-  VERSION = '11.0.4'.freeze
+  VERSION = '11.0.5'.freeze
 end

data/locale/de/foreman_tasks.po

@@ -807,6 +807,9 @@ msgstr "Wochentag (im Bereich: 0-6)"
 msgid "is hour (range: 0-23)"
 msgstr "Stunde (im Bereich: 0-23)"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "Minute (im Bereich: 0-59)"
@@ -827,6 +830,9 @@ msgstr "Modus"
 msgid "mode has to be one of %{allowed_modes}"
 msgstr "Modus muss einer von %{allowed_modes} sein"
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr "älter"
 

data/locale/en/foreman_tasks.po

@@ -803,6 +803,9 @@ msgstr ""
 msgid "is hour (range: 0-23)"
 msgstr ""
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr ""
@@ -823,6 +826,9 @@ msgstr ""
 msgid "mode has to be one of %{allowed_modes}"
 msgstr ""
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr ""
 

data/locale/es/foreman_tasks.po

@@ -808,6 +808,9 @@ msgstr "es día de la semana (rango: 0-6)"
 msgid "is hour (range: 0-23)"
 msgstr "es hora (rango: 0-23)"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "es minuto (rango: 0-59)"
@@ -828,6 +831,9 @@ msgstr "modo"
 msgid "mode has to be one of %{allowed_modes}"
 msgstr "modo tiene que ser uno de %.{allowed_modes}"
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr "más antiguo"
 

data/locale/foreman_tasks.pot

@@ -8,8 +8,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: foreman_tasks 1.0.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2024-07-17 17:08+0200\n"
-"PO-Revision-Date: 2024-07-17 17:08+0200\n"
+"POT-Creation-Date: 2025-09-12 13:20+0200\n"
+"PO-Revision-Date: 2025-09-12 13:20+0200\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
 "Language: \n"
@@ -312,32 +312,32 @@ msgstr ""
 msgid "%{total} task(s), %{success} success, %{failed} fail"
 msgstr ""
 
-#: ../app/lib/actions/bulk_action.rb:29
+#: ../app/lib/actions/bulk_action.rb:26 action_names.rb:3
 msgid "Bulk action"
 msgstr ""
 
-#: ../app/lib/actions/bulk_action.rb:63
+#: ../app/lib/actions/bulk_action.rb:58
 msgid "Empty bulk action"
 msgstr ""
 
-#: ../app/lib/actions/bulk_action.rb:65
+#: ../app/lib/actions/bulk_action.rb:60
 msgid "The targets are of different types"
 msgstr ""
 
-#: ../app/lib/actions/check_long_running_tasks.rb:40 action_names.rb:3
+#: ../app/lib/actions/check_long_running_tasks.rb:40 action_names.rb:4
 msgid "Check for long running tasks"
 msgstr ""
 
 #: ../app/lib/actions/deliver_long_running_tasks_notification.rb:19
-#: action_names.rb:4
+#: action_names.rb:5
 msgid "Deliver notifications about long running tasks"
 msgstr ""
 
-#: ../app/lib/actions/foreman/host/import_facts.rb:43 action_names.rb:6
+#: ../app/lib/actions/foreman/host/import_facts.rb:43 action_names.rb:7
 msgid "Import facts"
 msgstr ""
 
-#: ../app/lib/actions/foreman/puppetclass/import.rb:18 action_names.rb:5
+#: ../app/lib/actions/foreman/puppetclass/import.rb:18 action_names.rb:6
 msgid "Import Puppet classes"
 msgstr ""
 
@@ -491,43 +491,51 @@ msgstr ""
 msgid "Subscribe"
 msgstr ""
 
-#: ../app/models/foreman_tasks/triggering.rb:29
+#: ../app/models/foreman_tasks/triggering.rb:27
 msgid "%{value} is not allowed triggering mode"
 msgstr ""
 
-#: ../app/models/foreman_tasks/triggering.rb:32
+#: ../app/models/foreman_tasks/triggering.rb:30
 msgid "%{value} is not allowed input type"
 msgstr ""
 
+#: ../app/models/foreman_tasks/triggering.rb:32
 #: ../app/models/foreman_tasks/triggering.rb:34
-#: ../app/models/foreman_tasks/triggering.rb:36
 msgid "%{value} is wrong format"
 msgstr ""
 
-#: ../app/models/foreman_tasks/triggering.rb:60
+#: ../app/models/foreman_tasks/triggering.rb:58
 msgid "mode has to be one of %{allowed_modes}"
 msgstr ""
 
-#: ../app/models/foreman_tasks/triggering.rb:103
+#: ../app/models/foreman_tasks/triggering.rb:101
 msgid "is not a valid format"
 msgstr ""
 
-#: ../app/models/foreman_tasks/triggering.rb:114
+#: ../app/models/foreman_tasks/triggering.rb:117
 msgid "No task could be started"
 msgstr ""
 
-#: ../app/models/foreman_tasks/triggering.rb:115
+#: ../app/models/foreman_tasks/triggering.rb:118
 msgid "Active or disabled recurring logic with purpose %s already exists"
 msgstr ""
 
-#: ../app/models/foreman_tasks/triggering.rb:116
+#: ../app/models/foreman_tasks/triggering.rb:119
 msgid "%s is not valid format of cron line"
 msgstr ""
 
-#: ../app/models/foreman_tasks/triggering.rb:122
+#: ../app/models/foreman_tasks/triggering.rb:125
+msgid "must be set"
+msgstr ""
+
+#: ../app/models/foreman_tasks/triggering.rb:126
 msgid "The task could not be started"
 msgstr ""
 
+#: ../app/models/foreman_tasks/triggering.rb:130
+msgid "is in the past"
+msgstr ""
+
 #: ../app/services/foreman_tasks/troubleshooting_help_generator.rb:67
 msgid ""
 "A paused task represents a process that has not finished properly. Any task in"

data/locale/fr/foreman_tasks.po

@@ -807,6 +807,9 @@ msgstr "est jour de la semaine (plage: 0-6)"
 msgid "is hour (range: 0-23)"
 msgstr "est heure (plage: 0-23)"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "est minute (plage: 0-59)"
@@ -827,6 +830,9 @@ msgstr "mode"
 msgid "mode has to be one of %{allowed_modes}"
 msgstr "mode doit être un parmi %%{allowed_modes}"
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr "plus ancien"
 

data/locale/ja/foreman_tasks.po

@@ -804,6 +804,9 @@ msgstr "曜日 (範囲: 0 - 6)"
 msgid "is hour (range: 0-23)"
 msgstr "時間 (範囲: 0 - 23)"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "分 (範囲: 0 - 59)"
@@ -824,6 +827,9 @@ msgstr "モード"
 msgid "mode has to be one of %{allowed_modes}"
 msgstr "モードは %%{allowed_modes} のいずれかである必要があります"
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr "前"
 

data/locale/ka/foreman_tasks.po

@@ -807,6 +807,9 @@ msgstr "კვირის დღე (0-6)"
 msgid "is hour (range: 0-23)"
 msgstr "საათი (0-23)"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "წუთი (0-59)"
@@ -827,6 +830,9 @@ msgstr "რეჟიმი"
 msgid "mode has to be one of %{allowed_modes}"
 msgstr "რეჟიმი შეიძლება იყოს ერთ ერთი %{allowed_modes} -დან"
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr "ძველი"
 

data/locale/ko/foreman_tasks.po

@@ -803,6 +803,9 @@ msgstr "요일(범위: 0-6)"
 msgid "is hour (range: 0-23)"
 msgstr "시간(범위: 0-23)"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "분(범위: 0-59)"
@@ -823,6 +826,9 @@ msgstr ""
 msgid "mode has to be one of %{allowed_modes}"
 msgstr ""
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr ""
 

data/locale/pt_BR/foreman_tasks.po

@@ -808,6 +808,9 @@ msgstr "é o dia da semana (intervalo: 0-6)"
 msgid "is hour (range: 0-23)"
 msgstr "é a hora (intervalo: 0-23)"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "é o minuto (intervalo: 0-59) "
@@ -828,6 +831,9 @@ msgstr "modo"
 msgid "mode has to be one of %{allowed_modes}"
 msgstr "modo tem que ser um de %{allowed_modes}"
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr "mais antigo"
 

data/locale/ru/foreman_tasks.po

@@ -807,6 +807,9 @@ msgstr "— день недели (0–6)"
 msgid "is hour (range: 0-23)"
 msgstr "— часы (1–24)"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "— минуты (0–59)"
@@ -827,6 +830,9 @@ msgstr ""
 msgid "mode has to be one of %{allowed_modes}"
 msgstr ""
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr ""
 

data/locale/zh_CN/foreman_tasks.po

@@ -803,6 +803,9 @@ msgstr "星期几（范围：0-6）"
 msgid "is hour (range: 0-23)"
 msgstr "小时（范围：0-23）"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "分钟（范围：0-59）"
@@ -823,6 +826,9 @@ msgstr "模式"
 msgid "mode has to be one of %{allowed_modes}"
 msgstr "模式必须是 %%{allowed_modes} 之一"
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr "较老"
 

data/locale/zh_TW/foreman_tasks.po

@@ -804,6 +804,9 @@ msgstr "是星期幾（範圍：0-6）"
 msgid "is hour (range: 0-23)"
 msgstr "是小時（範圍：0-23）"
 
+msgid "is in the past"
+msgstr ""
+
 #. TRANSLATORS: this translation is referring to an option which is a time interval
 msgid "is minute (range: 0-59)"
 msgstr "是分鐘（範圍：0-59）"
@@ -824,6 +827,9 @@ msgstr ""
 msgid "mode has to be one of %{allowed_modes}"
 msgstr ""
 
+msgid "must be set"
+msgstr ""
+
 msgid "older"
 msgstr ""
 

data/test/unit/tasks_setting_test.rb

@@ -0,0 +1,22 @@
+require 'foreman_tasks_test_helper'
+
+class TasksSettingTest < ActiveSupport::TestCase
+  describe "foreman_tasks_troubleshooting_url" do
+    test "invalid url for foreman_tasks_troubleshooting_url are rejected" do
+      url_setting = Setting.new(name: 'foreman_tasks_troubleshooting_url', value: 'invalid url')
+      url_setting.valid?
+    rescue => e
+      assert_includes e.message, "Invalid URL"
+    end
+
+    test "valid foreman_tasks_troubleshooting_url values are accepted" do
+      url_setting = Setting.new(name: 'foreman_tasks_troubleshooting_url', value: 'https://example.com')
+      assert url_setting.valid?
+    end
+
+    test "valid foreman_tasks_troubleshooting_url values with placeholder are accepted" do
+      url_setting = Setting.new(name: 'foreman_tasks_troubleshooting_url', value: 'https://example/%{label}/%{version}.com')
+      assert url_setting.valid?
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman-tasks
 version: !ruby/object:Gem::Version
-  version: 11.0.4
+  version: 11.0.5
 platform: ruby
 authors:
 - Ivan Nečas
@@ -124,6 +124,7 @@ files:
 - ".github/workflows/js_tests.yml"
 - ".github/workflows/release.yml"
 - ".github/workflows/ruby_tests.yml"
+- ".github/workflows/test-breaking.yaml"
 - ".gitignore"
 - ".prettierrc"
 - ".rubocop.yml"
@@ -386,6 +387,7 @@ files:
 - test/unit/summarizer_test.rb
 - test/unit/task_groups_test.rb
 - test/unit/task_test.rb
+- test/unit/tasks_setting_test.rb
 - test/unit/triggering_test.rb
 - test/unit/troubleshooting_help_generator_test.rb
 - test/unit/ui_notifications_test.rb
@@ -686,6 +688,7 @@ test_files:
 - test/unit/summarizer_test.rb
 - test/unit/task_groups_test.rb
 - test/unit/task_test.rb
+- test/unit/tasks_setting_test.rb
 - test/unit/triggering_test.rb
 - test/unit/troubleshooting_help_generator_test.rb
 - test/unit/ui_notifications_test.rb