foreman-tasks 0.3.3 → 0.3.4

data/app/models/foreman_tasks/concerns/action_subject.rb

@@ -132,15 +132,21 @@ module ForemanTasks
                    raise 'unexpected method'
                  end
         if action
-          if self.class.connection.open_transactions > 0
-            raise "Executing dynflow action inside a transaction is not a good idea"
-          end
+          ensure_not_in_transaction!
           yield.tap { |result| execute_planned_action if result }
         else
           yield
         end
       end
 
+      # we don't want to start executing the task calling to external services
+      # when inside some other transaction. Might lead to unexpected results
+      def ensure_not_in_transaction!
+        if self.class.connection.open_transactions > 0
+          raise "Executing dynflow action inside a transaction is not a good idea"
+        end
+      end
+
       # Execute the prepared execution plan after the db transaction was commited
       def execute_planned_action
         if @execution_plan

data/lib/foreman_tasks/version.rb

@@ -1,3 +1,3 @@
 module ForemanTasks
-  VERSION = "0.3.3"
+  VERSION = "0.3.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman-tasks
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-03 00:00:00.000000000 Z
+date: 2014-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails