foreigner 1.1.6 → 1.2.0

data/README.rdoc

@@ -31,7 +31,7 @@ For example, given the following model:
   end
   
   class Post < ActiveRecord::Base
-    has_many :comments, :dependent => :delete_all
+    has_many :comments, dependent: :delete_all
   end
   
 You should add a foreign key in your migration:
@@ -40,15 +40,15 @@ You should add a foreign key in your migration:
 
 The :dependent option can be moved from the has_many definition to the foreign key:
 
-  add_foreign_key(:comments, :posts, :dependent => :delete)
+  add_foreign_key(:comments, :posts, dependent: :delete)
 
 If the column is named article_id instead of post_id, use the :column option:
 
-  add_foreign_key(:comments, :posts, :column => 'article_id')
+  add_foreign_key(:comments, :posts, column: 'article_id')
   
 A name can be specified for the foreign key constraint:
 
-  add_foreign_key(:comments, :posts, :name => 'comment_article_foreign_key')
+  add_foreign_key(:comments, :posts, name: 'comment_article_foreign_key')
 
 == Change Table Methods
 
@@ -57,7 +57,7 @@ Foreigner adds extra methods to change_table.
 Add a missing foreign key to comments:
 
   change_table :comments do |t|
-    t.foreign_key :posts, :dependent => :delete
+    t.foreign_key :posts, dependent: :delete
   end
 
 Remove an unwanted foreign key:
@@ -66,6 +66,10 @@ Remove an unwanted foreign key:
     t.remove_foreign_key :users
   end
 
+== Finding Missing Foreign Keys
+
+Use {Immigrant}[https://github.com/jenseng/immigrant] to generate a migration that includes all missing foreign keys.
+
 == License
 
 Copyright (c) 2012 Matthew Higgins, released under the MIT license

data/lib/foreigner.rb

@@ -26,6 +26,7 @@ Foreigner::Adapter.register 'mysql2', 'foreigner/connection_adapters/mysql2_adap
 Foreigner::Adapter.register 'jdbcmysql', 'foreigner/connection_adapters/mysql2_adapter'
 Foreigner::Adapter.register 'postgresql', 'foreigner/connection_adapters/postgresql_adapter'
 Foreigner::Adapter.register 'jdbcpostgresql', 'foreigner/connection_adapters/postgresql_adapter'
+Foreigner::Adapter.register 'sqlite3', 'foreigner/connection_adapters/noop_adapter'
 
 require 'foreigner/loader'
 require 'foreigner/railtie' if defined?(Rails)

data/lib/foreigner/adapter.rb

@@ -11,11 +11,14 @@ module Foreigner
       def load!
         if registered.key?(configured_name)
           require registered[configured_name]
+        else
+          p "Database adapter #{configured_name} not supported. Use:\n" +
+            "Foreigner::Adapter.register '#{configured_name}', 'path/to/adapter'"
         end
       end
 
       def configured_name
-        ActiveRecord::Base.connection_pool.spec.config[:adapter]
+        @configured_name ||= ActiveRecord::Base.connection_pool.spec.config[:adapter]
       end
     end
   end

data/lib/foreigner/connection_adapters/abstract/schema_definitions.rb

@@ -22,11 +22,11 @@ module Foreigner
       # ====== Creating a simple foreign key
       #  t.foreign_key(:people)
       # ====== Defining the column
-      #  t.foreign_key(:people, :column => :sender_id)
+      #  t.foreign_key(:people, column: :sender_id)
       # ====== Creating a named foreign key
-      #  t.foreign_key(:people, :column => :sender_id, :name => 'sender_foreign_key')
+      #  t.foreign_key(:people, column: :sender_id, name: 'sender_foreign_key')
       # ====== Defining the column of the +to_table+.
-      #  t.foreign_key(:people, :column => :sender_id, :primary_key => :person_id)
+      #  t.foreign_key(:people, column: :sender_id, primary_key: :person_id)
       def foreign_key(to_table, options = {})
         @base.add_foreign_key(@table_name, to_table, options)
       end
@@ -40,11 +40,11 @@ module Foreigner
       #   end
       # ====== Remove the foreign key named accounts_branch_id_fk in the accounts table.
       #   change_table :accounts do |t|
-      #     t.remove_foreign_key :column => :branch_id
+      #     t.remove_foreign_key column: :branch_id
       #   end
       # ====== Remove the foreign key named party_foreign_key in the accounts table.
       #   change_table :accounts do |t|
-      #     t.remove_index :name => :party_foreign_key
+      #     t.remove_index name: :party_foreign_key
       #   end
       def remove_foreign_key(options)
         @base.remove_foreign_key(@table_name, options)

data/lib/foreigner/connection_adapters/abstract/schema_statements.rb

@@ -26,13 +26,13 @@ module Foreigner
       #     `comments_post_id_fk` FOREIGN KEY (`post_id`) REFERENCES `posts` (`id`)
       # 
       # ====== Creating a named foreign key
-      #  add_foreign_key(:comments, :posts, :name => 'comments_belongs_to_posts')
+      #  add_foreign_key(:comments, :posts, name: 'comments_belongs_to_posts')
       # generates
       #  ALTER TABLE `comments` ADD CONSTRAINT
       #     `comments_belongs_to_posts` FOREIGN KEY (`post_id`) REFERENCES `posts` (`id`)
       # 
       # ====== Creating a cascading foreign_key on a custom column
-      #  add_foreign_key(:people, :people, :column => 'best_friend_id', :dependent => :nullify)
+      #  add_foreign_key(:people, :people, column: 'best_friend_id', dependent: :nullify)
       # generates
       #  ALTER TABLE `people` ADD CONSTRAINT
       #     `people_best_friend_id_fk` FOREIGN KEY (`best_friend_id`) REFERENCES `people` (`id`)
@@ -62,9 +62,9 @@ module Foreigner
       # ====== Remove the suppliers_company_id_fk in the suppliers table.
       #   remove_foreign_key :suppliers, :companies
       # ====== Remove the foreign key named accounts_branch_id_fk in the accounts table.
-      #   remove_foreign_key :accounts, :column => :branch_id
+      #   remove_foreign_key :accounts, column: :branch_id
       # ====== Remove the foreign key named party_foreign_key in the accounts table.
-      #   remove_foreign_key :accounts, :name => :party_foreign_key
+      #   remove_foreign_key :accounts, name: :party_foreign_key
       def remove_foreign_key(from_table, options)
       end
 

data/lib/foreigner/connection_adapters/noop_adapter.rb

@@ -0,0 +1,7 @@
+module Foreigner
+  module ConnectionAdapters
+    module NoopAdapter
+      # Used mainly for sqlite3
+    end
+  end
+end

data/test/foreigner/adapter_test.rb

@@ -0,0 +1,11 @@
+require 'helper'
+
+class Foreigner::AdapterTest < ActiveSupport::TestCase
+  test "load" do
+    Foreigner::Adapter.register 'foo', 'bar'
+    Foreigner::Adapter.expects(:configured_name).at_least_once.returns('foo')
+    Foreigner::Adapter.expects(:require).with('bar')
+
+    Foreigner::Adapter.load!
+  end
+end

data/test/helper.rb

@@ -3,6 +3,7 @@ Bundler.require(:default)
 
 require 'test/unit'
 require 'active_record'
+require 'mocha'
 
 # Foreigner::Adapter.registered.values.each do |file_name|
 #   require file_name

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreigner
 version: !ruby/object:Gem::Version
-  version: 1.1.6
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-04 00:00:00.000000000 Z
+date: 2012-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70302659050020 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70302659050020
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70302659074460 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +37,12 @@ dependencies:
         version: 3.1.0
   type: :development
   prerelease: false
-  version_requirements: *70302659074460
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.1.0
 description: Adds helpers to migrations and dumps foreign keys to schema.rb
 email: developer@matthewhiggins.com
 executables: []
@@ -49,6 +59,7 @@ files:
 - lib/foreigner/connection_adapters/abstract/schema_statements.rb
 - lib/foreigner/connection_adapters/mysql2_adapter.rb
 - lib/foreigner/connection_adapters/mysql_adapter.rb
+- lib/foreigner/connection_adapters/noop_adapter.rb
 - lib/foreigner/connection_adapters/postgresql_adapter.rb
 - lib/foreigner/connection_adapters/sql2003.rb
 - lib/foreigner/loader.rb
@@ -56,13 +67,14 @@ files:
 - lib/foreigner/railtie.rb
 - lib/foreigner/schema_dumper.rb
 - lib/foreigner.rb
+- test/foreigner/adapter_test.rb
+- test/foreigner/connection_adapters/mysql2_adapter_test.rb
+- test/foreigner/connection_adapters/mysql_adapter_test.rb
+- test/foreigner/connection_adapters/postgresql_adapter_test.rb
+- test/foreigner/connection_adapters/sql2003_test.rb
+- test/foreigner/migration/command_recorder_test.rb
+- test/foreigner/schema_dumper_test.rb
 - test/helper.rb
-- test/unit/command_recorder_test.rb
-- test/unit/mysql2_adapter_test.rb
-- test/unit/mysql_adapter_test.rb
-- test/unit/postgresql_adapter_test.rb
-- test/unit/schema_dumper_test.rb
-- test/unit/sql2003_test.rb
 homepage: http://github.com/matthuhiggins/foreigner
 licenses: []
 post_install_message: 
@@ -83,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.5
 requirements: []
 rubyforge_project: foreigner
-rubygems_version: 1.8.17
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Foreign Keys for Rails