foreign_key_validation 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2da928f68d5283f2afdbdf6f91f8a838bea9a56e
-  data.tar.gz: 5f979905a156bc8d56bb2510b25808a9ce5ef968
+  metadata.gz: 6efa881cebd85a67f4706bf7251ee36caa3cc710
+  data.tar.gz: 52bcaf493a5508f7f519e6af787082ad82ead28e
 SHA512:
-  metadata.gz: e285968bf2b4e9b799679a4f7eecfe7f1d62aaa47b086f738a989acef715e22f55864b958d0ba5779b6cf398762ca455764c58c2de674a0bd3526baf50a6ecef
-  data.tar.gz: 771db50df035df9566356e647e162b2462fecd2c17c152e31cb1f22aed2783b4200719694acba0b2625f0d76a45498cf913d16a03769bfac766e5299ae5927d1
+  metadata.gz: 353a11c25d79edd2b1148118dc08989f972244f9592f5414a24826418a66789343b32cecf6959fa511237d4131101c761731a1b252fcc62d000aa7a1bb79dad8
+  data.tar.gz: 6a9c0ed52a1e93b28435bc87dcd977304c3f15aee5b2f516c84b1683d7de7c2864514e4c7c0ab1946946efc3b04f91be6f2c29ec3a3f4b2e6bb6595971322fb8

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/.ruby-gemset

@@ -0,0 +1 @@
+foreign_key_validation

data/.ruby-version

@@ -0,0 +1 @@
+2.1.2

data/foreign_key_validation.gemspec

@@ -18,6 +18,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "rails", ">= 3.2"
+
   spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rake", "~> 10.1"
+  spec.add_development_dependency "rspec-rails", "~> 3.0"
+  spec.add_development_dependency "sqlite3", '~> 1.3'
+  spec.add_development_dependency "pry", '~> 0.10'
+
 end

data/lib/foreign_key_validation/model_extension.rb

@@ -28,7 +28,7 @@ module ForeignKeyValidation
         keys_to_validate_with = (Array(with).map(&:to_s) if with) || self.column_names.select {|n| n.match(/\w_id/)}
 
         # reject keys that match either the key_to_validate_against or the current class name key (needed for sti models)
-        keys_to_validate_with.reject! {|n| n == key_to_validate_against.to_s || n == "#{self.class.name.underscore}_id"  }
+        keys_to_validate_with.reject! {|n| n.to_s == key_to_validate_against.to_s || n.to_s == "#{self.class.name.underscore}_id"  }
 
         define_method "validate_foreign_keys_on_#{key_to_validate_against}" do
 

data/lib/foreign_key_validation/version.rb

@@ -1,3 +1,3 @@
 module ForeignKeyValidation
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/models/model_spec.rb

@@ -0,0 +1,80 @@
+require 'spec_helper'
+
+class User < ActiveRecord::Base
+  has_many :projects
+  has_many :ideas
+end
+
+class Project < ActiveRecord::Base
+  belongs_to :user
+  has_many :ideas
+  validates_presence_of :user_id, presence: true
+end
+
+class Idea < ActiveRecord::Base
+  belongs_to :project
+  belongs_to :user
+  validates_presence_of :user_id, :project_id, presence: true
+end
+
+describe "Behaviour without validate_foreign_keys" do
+
+  let!(:user) { User.create }
+  let!(:project) { user.projects.create }
+  let!(:idea) { project.ideas.create user: user }
+
+  it "uses same user ids by default" do
+    expect(project.user_id).to eq(user.id)
+    expect(user.id).to eq(user.id)
+    expect(idea.user_id).to eq(user.id)
+  end
+
+  it "allow to rewrite user id of idea" do
+    idea.user_id = 42
+    idea.save
+    idea.reload
+    expect(idea.user_id).to eq(42)
+  end
+
+  it "allow to rewrite user id of project" do
+    project.user_id = 42
+    project.save
+    project.reload
+    expect(project.user_id).to eq(42)
+  end
+
+end
+
+describe "Behaviour with validate_foreign_keys" do
+
+  before do
+    Idea.class_eval do
+      validate_foreign_keys
+    end
+  end
+
+  let!(:user) { User.create }
+  let!(:project) { user.projects.create }
+  let!(:idea) { project.ideas.create user: user }
+
+  it "uses same user ids by default" do
+    expect(project.user_id).to eq(user.id)
+    expect(user.id).to eq(user.id)
+    expect(idea.user_id).to eq(user.id)
+  end
+
+  it "does not allow to rewrite user id of idea" do
+    idea.user_id = 42
+    idea.save
+    expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id")
+    expect(idea.reload.user_id).to_not eq(42)
+  end
+
+  it "does allow to rewrite user id of project" do
+    project.user_id = 42
+    project.save
+    expect(project.errors).to be_empty
+    expect(project.reload.user_id).to eq(42)
+  end
+
+end

data/spec/schema.rb

@@ -0,0 +1,15 @@
+ActiveRecord::Schema.define(:version => 20130730063732) do
+
+  create_table "users", :force => true do |t|
+  end
+
+  create_table "projects", :force => true do |t|
+    t.integer   "user_id"
+  end
+
+  create_table "ideas", :force => true do |t|
+    t.integer   "user_id"
+    t.integer   "project_id"
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,18 @@
+require "rails/all"
+require 'foreign_key_validation'
+require 'rspec/rails'
+require 'pry'
+
+RSpec.configure do |config|
+  config.run_all_when_everything_filtered = true
+  config.filter_run :focus
+  config.infer_base_class_for_anonymous_controllers = true
+
+  # config.order = 'random'
+end
+
+setup_sqlite_db = lambda do
+  ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
+  load "schema.rb"
+end
+silence_stream(STDOUT, &setup_sqlite_db)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreign_key_validation
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Marcus Geißler
@@ -10,6 +10,20 @@ bindir: bin
 cert_chain: []
 date: 2014-08-29 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '3.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -28,16 +42,58 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.1'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
 description: Protect the foreign keys in your Rails models. Really.
 email:
 - marcus3006@gmail.com
@@ -46,6 +102,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".ruby-gemset"
+- ".ruby-version"
 - Gemfile
 - LICENSE
 - LICENSE.txt
@@ -55,6 +114,9 @@ files:
 - lib/foreign_key_validation.rb
 - lib/foreign_key_validation/model_extension.rb
 - lib/foreign_key_validation/version.rb
+- spec/models/model_spec.rb
+- spec/schema.rb
+- spec/spec_helper.rb
 homepage: https://github.com/marcusg/foreign_key_validation
 licenses:
 - MIT
@@ -79,4 +141,7 @@ rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Protect the foreign keys in your Rails models.
-test_files: []
+test_files:
+- spec/models/model_spec.rb
+- spec/schema.rb
+- spec/spec_helper.rb