foodcritic 6.3.0 → 7.0.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (54) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +302 -681
  3. data/Gemfile +4 -0
  4. data/README.md +15 -11
  5. data/Rakefile +2 -1
  6. data/chef_dsl_metadata/chef_12.11.18.json +17597 -0
  7. data/features/009_check_for_unrecognised_resource_attributes.feature +6 -17
  8. data/features/032_check_for_invalid_notification_timing.feature +16 -12
  9. data/features/038_check_for_invalid_action.feature +6 -9
  10. data/features/043_check_for_old_notification_style.feature +0 -7
  11. data/features/step_definitions/cookbook_steps.rb +17 -11
  12. data/features/support/command_helpers.rb +1 -1
  13. data/foodcritic.gemspec +1 -2
  14. data/lib/foodcritic/api.rb +41 -13
  15. data/lib/foodcritic/linter.rb +1 -2
  16. data/lib/foodcritic/notifications.rb +1 -1
  17. data/lib/foodcritic/rules.rb +6 -12
  18. data/lib/foodcritic/version.rb +1 -1
  19. data/man/foodcritic.1 +81 -0
  20. data/spec/foodcritic/api_spec.rb +82 -0
  21. metadata +7 -38
  22. data/chef_dsl_metadata/chef_0.10.0.json +0 -7107
  23. data/chef_dsl_metadata/chef_0.10.10.json +0 -7900
  24. data/chef_dsl_metadata/chef_0.10.2.json +0 -7107
  25. data/chef_dsl_metadata/chef_0.10.4.json +0 -7302
  26. data/chef_dsl_metadata/chef_0.10.6.json +0 -7367
  27. data/chef_dsl_metadata/chef_0.10.8.json +0 -7367
  28. data/chef_dsl_metadata/chef_0.8.14.json +0 -6373
  29. data/chef_dsl_metadata/chef_0.8.16.json +0 -6373
  30. data/chef_dsl_metadata/chef_0.9.0.json +0 -6816
  31. data/chef_dsl_metadata/chef_0.9.10.json +0 -7480
  32. data/chef_dsl_metadata/chef_0.9.12.json +0 -7480
  33. data/chef_dsl_metadata/chef_0.9.14.json +0 -7484
  34. data/chef_dsl_metadata/chef_0.9.16.json +0 -7484
  35. data/chef_dsl_metadata/chef_0.9.18.json +0 -7484
  36. data/chef_dsl_metadata/chef_0.9.2.json +0 -6816
  37. data/chef_dsl_metadata/chef_0.9.4.json +0 -6861
  38. data/chef_dsl_metadata/chef_0.9.6.json +0 -6861
  39. data/chef_dsl_metadata/chef_0.9.8.json +0 -6865
  40. data/chef_dsl_metadata/chef_10.12.0.json +0 -7900
  41. data/chef_dsl_metadata/chef_10.14.0.json +0 -8457
  42. data/chef_dsl_metadata/chef_10.14.2.json +0 -8457
  43. data/chef_dsl_metadata/chef_10.14.4.json +0 -8457
  44. data/chef_dsl_metadata/chef_10.16.0.json +0 -8458
  45. data/chef_dsl_metadata/chef_10.16.2.json +0 -8458
  46. data/chef_dsl_metadata/chef_10.16.4.json +0 -8458
  47. data/chef_dsl_metadata/chef_10.16.6.json +0 -8458
  48. data/chef_dsl_metadata/chef_10.18.0.json +0 -8459
  49. data/chef_dsl_metadata/chef_10.18.2.json +0 -8459
  50. data/chef_dsl_metadata/chef_10.20.0.json +0 -8459
  51. data/chef_dsl_metadata/chef_10.22.0.json +0 -8459
  52. data/chef_dsl_metadata/chef_10.24.0.json +0 -8459
  53. data/chef_dsl_metadata/chef_10.24.4.json +0 -8459
  54. data/chef_dsl_metadata/chef_10.26.0.json +0 -8459
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 4754ca9d95c898d23ab75a5948d4ce29daae2288
4
- data.tar.gz: fab2d1a8c86789ff2000d7d093bc6c6f65a291d7
3
+ metadata.gz: ab21e44cb35458bdde51809afaf69be64ccd16a8
4
+ data.tar.gz: aebcdd5966b420f5c6e2aa12e09f6c24f2fb0202
5
5
  SHA512:
6
- metadata.gz: 406e069e18f83de9de736575b0efbdf6cef23651777f93b91c9a3f461f6ea1f32ba91d5e89aed5e264887d96f03d0afd17a8d04fe12b96d3b2175a57a4daa9c5
7
- data.tar.gz: 162c3981b83a3cc531e8523b9049c091f251bd03fc07f487fb4755733470c795189b58c777121c0e23e3a71c36e893730bde1b6151e237c8cbe3e107e712a68e
6
+ metadata.gz: 67ed960a8a0f9fc6fafa1bc14c93be58148147ba48db18bd708727ac5dde5e3d32de1d824b613b6c295ade38fe3bfbb2b6bbbf2021391e4931b788a36f5bc12c
7
+ data.tar.gz: 80323007683dd446666cbee36f0bcd16e0fb1370ef8543280eb2b630557787b81598142702f40ae160662d7474e92b4ab7194ab43a8003ed8df74650619c09b0
data/CHANGELOG.md CHANGED
@@ -1,46 +1,91 @@
1
- # Foodcritic Changelog
1
+ # FoodCritic Changelog:
2
2
 
3
- ## 6.3.0 (16 May, 2016)
4
- - Added Chef 12.10.24 metadata
3
+ ## [7.0.0](https://github.com/acrmp/foodcritic/tree/7.0.0) (2016-07-02)
5
4
 
6
- ## 6.2.0 (26 April, 2016)
7
- - Added Chef 12.9.38 metadata
8
- - Made Chef 12.9.38 the default Chef release. Previously this was 12.4.1. This prevents Foodcritic from warning on new resource attributes that have been releases since 12.4.1
5
+ [Full Changelog](https://github.com/acrmp/foodcritic/compare/v6.3.0...7.0.0)
9
6
 
10
- ## 6.1.1 (07 April, 2016)
7
+ **Implemented enhancements:**
11
8
 
12
- - Replace gherkin dev dependency with cucumber-core to avoid slow gherkin installs
9
+ - Remove support for Ruby 2.0 [#465](https://github.com/acrmp/foodcritic/pull/465) ([tas50](https://github.com/tas50))
10
+ - Remove chef version support for Chef 0.7, 0.8, 0.9, and 0.10 [#464](https://github.com/acrmp/foodcritic/pull/464) ([tas50](https://github.com/tas50))
11
+ - Add chef 12.11.18 metadata and make it the default [#461](https://github.com/acrmp/foodcritic/pull/461) ([tas50](https://github.com/tas50))
12
+ - FC032 allow the new :before timing on resource notifications in Chef >= 12.6.0 [#441](https://github.com/acrmp/foodcritic/pull/441) ([gnjack](https://github.com/gnjack))
13
+ - New cookbook_maintainer api methods [#248](https://github.com/acrmp/foodcritic/pull/248) ([miguelcnf](https://github.com/miguelcnf))
13
14
 
14
- ## 6.1.0 (06 April, 2016)
15
+ **Merged pull requests:**
15
16
 
16
- Features:
17
- - Added Chef 12.8.1 metadata
18
- - Ship the Rakefile, Gemfile, and gemspec files with the gem for simplified testing
19
- - Added chef12 tag to FC064 and FC065 since these check for functionality introduced in Chef 12
17
+ - Resolve a few simple Rubocop lint / performance cops [#463](https://github.com/acrmp/foodcritic/pull/463) ([tas50](https://github.com/tas50))
18
+ - Remove unnecessary requires [#460](https://github.com/acrmp/foodcritic/pull/460) ([tas50](https://github.com/tas50))
20
19
 
21
- Bugfixes:
22
- - Fix incorrect instructions for the generation of metadata files
23
- - Fix deprecation warnings on Rake 11
24
- - Fail better if cucumber/rubocop aren't installed when running the Rakefile
20
+ ## [v6.3.0](https://github.com/acrmp/foodcritic/tree/v6.3.0) (2016-05-16)
25
21
 
22
+ [Full Changelog](https://github.com/acrmp/foodcritic/compare/v6.2.0...v6.3.0)
26
23
 
27
- ## 6.0.1 (22 February, 2016)
24
+ **Implemented enhancements:**
28
25
 
29
- Bugfixes:
26
+ - Add Chef 12.10.24 metadata and release 6.3.0 [#456](https://github.com/acrmp/foodcritic/pull/456) ([tas50](https://github.com/tas50))
27
+
28
+ ## [v6.2.0](https://github.com/acrmp/foodcritic/tree/v6.2.0) (2016-04-26)
29
+
30
+ [Full Changelog](https://github.com/acrmp/foodcritic/compare/v6.1.1...v6.2.0)
31
+
32
+ **Implemented enhancements:**
33
+
34
+ - Add 12.9.38 metadata and make it the default chef version [#452](https://github.com/acrmp/foodcritic/pull/452) ([tas50](https://github.com/tas50))
35
+
36
+ ## [v6.1.1](https://github.com/acrmp/foodcritic/tree/v6.1.1) (2016-04-08)
37
+
38
+ [Full Changelog](https://github.com/acrmp/foodcritic/compare/v6.1.0...v6.1.1)
39
+
40
+ **Implemented enhancements:**
41
+
42
+ - Use latest gherkin for faster installs [#447](https://github.com/acrmp/foodcritic/pull/447) ([jkeiser](https://github.com/jkeiser))
43
+
44
+ ## [v6.1.0](https://github.com/acrmp/foodcritic/tree/v6.1.0) (2016-04-06)
45
+
46
+ [Full Changelog](https://github.com/acrmp/foodcritic/compare/v6.0.1...v6.1.0)
47
+
48
+ **Implemented enhancements:**
49
+
50
+ - Don't require cucumber and rubocop to run rake [#444](https://github.com/acrmp/foodcritic/pull/444) ([jkeiser](https://github.com/jkeiser))
51
+ - Add metadata for Chef 12.7.2 and update instructions [#427](https://github.com/acrmp/foodcritic/pull/427) ([tas50](https://github.com/tas50))
52
+ - Add 12.8.1 metadata + update metadata process [#438](https://github.com/acrmp/foodcritic/pull/438) ([tas50](https://github.com/tas50))
53
+
54
+ **Merged pull requests:**
55
+
56
+ - Include gemspec and Gemfiles in distributed gem for ease of working with / running tests [#443](https://github.com/acrmp/foodcritic/pull/443) ([jkeiser](https://github.com/jkeiser))
57
+ - Test on Ruby 2.3.0 [#439](https://github.com/acrmp/foodcritic/pull/439) ([tas50](https://github.com/tas50))
58
+ - Rake.last_comment was depreciated in Rake11\. [#434](https://github.com/acrmp/foodcritic/pull/434) ([gkuchta](https://github.com/gkuchta))
30
59
 
31
- - Fixed false positives for FC058
60
+ ## [v6.0.1](https://github.com/acrmp/foodcritic/tree/v6.0.1) (2016-02-22)
32
61
 
33
- ## 6.0.0 (14 January, 2016)
62
+ [Full Changelog](https://github.com/acrmp/foodcritic/compare/v6.0.0...v6.0.1)
63
+
64
+ **Implemented enhancements:**
65
+
66
+ - Check for URLs that are helpful to the Supermarket [#421](https://github.com/acrmp/foodcritic/pull/421) ([nathenharvey](https://github.com/nathenharvey))
67
+
68
+ **Fixed bugs:**
69
+
70
+ - Fix FC058 false positives [#423](https://github.com/acrmp/foodcritic/pull/423) ([jaym](https://github.com/jaym))
71
+
72
+ ## v6.0.0 (14 January, 2016)
34
73
 
35
74
  Features:
36
75
 
37
76
  - Added FC055 to ensure that metadata.rb contains a maintainer
38
77
  - Added FC056 to ensure that metadata.rb contains a maintainer_email
39
78
  - Added FC057 to ensure that library providers include use_inline_resources
40
- - Added FC058 to ensure that library providers that include use_inline_resources and action_<name> methods
79
+ - Added FC058 to ensure that library providers that include use_inline_resources and action_
80
+
81
+ <name> methods</name>
82
+
41
83
  - Added FC059 to ensure that LWRPs include use_inline_resources
84
+
42
85
  - Added FC060 to ensure that LWRPs don't use bad action methods
86
+
43
87
  - Added FC061 to ensure that the cookbook version is valid
88
+
44
89
  - Added FC062 to ensure that metadata includes a version
45
90
  - Added FC063 to ensure that a cookbook doesn't depend on itself in the metadata
46
91
  - Added DSL metadata for Chef 12.5.1 and 12.6.0
@@ -56,922 +101,498 @@ Bugfixes:
56
101
  - Fixed the Rake tasks
57
102
  - Fixed FC048 incorrectly firing when a method name included "system"
58
103
 
59
-
60
104
  ## 5.0.0 (17 September, 2015)
61
105
 
62
106
  Features:
63
107
 
64
- - DSL metadata updated for Chef 11.18.x and up to Chef 12.4.1.
65
- ([related issue](https://github.com/acrmp/foodcritic/issues/362)).
66
- - Set default `chef_version` to 12.4.1
67
- ([related issue](https://github.com/acrmp/foodcritic/pull/364)).
68
- - add warnings for use of recommends/suggests.
69
- ([related issue](https://github.com/acrmp/foodcritic/pull/309)).
70
- - Show progress with --progress
71
- ([related issue](https://github.com/acrmp/foodcritic/pull/244)).
72
- - Added -l option to list enabled rules and descriptions
73
- ([related issue](https://github.com/acrmp/foodcritic/pull/285)).
108
+ - DSL metadata updated for Chef 11.18.x and up to Chef 12.4.1\. ([related issue](https://github.com/acrmp/foodcritic/issues/362)).
109
+ - Set default `chef_version` to 12.4.1 ([related issue](https://github.com/acrmp/foodcritic/pull/364)).
110
+ - add warnings for use of recommends/suggests. ([related issue](https://github.com/acrmp/foodcritic/pull/309)).
111
+ - Show progress with --progress ([related issue](https://github.com/acrmp/foodcritic/pull/244)).
112
+ - Added -l option to list enabled rules and descriptions ([related issue](https://github.com/acrmp/foodcritic/pull/285)).
74
113
 
75
114
  Bugfixes:
76
115
 
77
- - Fixed `node.force_default` and `node.force_override` along with many other methods on Chef::Node::Attribute that
78
- `Chef::Node#method_missing` was forwarding methods to.
79
- ([related issue](https://github.com/acrmp/foodcritic/pull/364)).
80
- - merge default options before check instead of during intialization (in Rake task)
81
- ([related issue](https://github.com/acrmp/foodcritic/pull/321)).
82
- - Fix UTF-8 errors in template checking
83
- ([related issue](https://github.com/acrmp/foodcritic/pull/317)).
84
- - Make FC041 smarter about CURL usage
85
- ([related issue](https://github.com/acrmp/foodcritic/pull/313)).
86
- - pinned moustache gem to 0.99 for ruby 1.9.3 compatibility
87
- Thanks @jdmundrawala
88
- - Added metadata for missing Chef 11 versions.
89
- Thanks @jdmundrawala
90
- - [FC044: Avoid bare attribute keys](http://acrmp.github.com/foodcritic/#FC044) would fire on parameterized attributes.
91
- Thanks @odcinek
92
- - [FC048: Prefer Mixlib::ShellOut](http://foodcritic.io/#FC048) would false positive on system attribute of user resource.
93
- Thanks @odcinek
94
- - Handle flagging binary files properly.
95
- Thanks @odcinek
96
- - [FC002: Avoid string interpolation where not required](http://acrmp.github.com/foodcritic/#FC002) would erroneously trigger on heredoc on ruby 2.2
97
- Thanks @ryansouza and @odcinek
116
+ - Fixed `node.force_default` and `node.force_override` along with many other methods on Chef::Node::Attribute that `Chef::Node#method_missing` was forwarding methods to. ([related issue](https://github.com/acrmp/foodcritic/pull/364)).
117
+ - merge default options before check instead of during intialization (in Rake task) ([related issue](https://github.com/acrmp/foodcritic/pull/321)).
118
+ - Fix UTF-8 errors in template checking ([related issue](https://github.com/acrmp/foodcritic/pull/317)).
119
+ - Make FC041 smarter about CURL usage ([related issue](https://github.com/acrmp/foodcritic/pull/313)).
120
+ - pinned moustache gem to 0.99 for ruby 1.9.3 compatibility Thanks @jdmundrawala
121
+ - Added metadata for missing Chef 11 versions. Thanks @jdmundrawala
122
+ - [FC044: Avoid bare attribute keys](http://acrmp.github.com/foodcritic/#FC044) would fire on parameterized attributes. Thanks @odcinek
123
+ - [FC048: Prefer Mixlib::ShellOut](http://foodcritic.io/#FC048) would false positive on system attribute of user resource. Thanks @odcinek
124
+ - Handle flagging binary files properly. Thanks @odcinek
125
+ - [FC002: Avoid string interpolation where not required](http://acrmp.github.com/foodcritic/#FC002) would erroneously trigger on heredoc on ruby 2.2 Thanks @ryansouza and @odcinek
98
126
 
99
127
  Other:
100
128
 
101
- - 1.9.3 is removed from the travis matrix and no longer supported
102
- ([related issue](https://github.com/acrmp/foodcritic/pull/315)).
103
- - 1.9.3 compat is removed from the gemspec (v4.0.0 will be the last version that will install on 1.9.3)
104
- ([related issue](https://github.com/acrmp/foodcritic/pull/377)).
105
- - removed cookbooks no longer present in the chef-cookbooks repo from regression tests
129
+ - 1.9.3 is removed from the travis matrix and no longer supported ([related issue](https://github.com/acrmp/foodcritic/pull/315)).
130
+ - 1.9.3 compat is removed from the gemspec (v4.0.0 will be the last version that will install on 1.9.3) ([related issue](https://github.com/acrmp/foodcritic/pull/377)).
131
+ - removed cookbooks no longer present in the chef-cookbooks repo from regression tests
106
132
 
107
133
  ## 4.0.0 (12th June, 2014)
108
134
 
109
135
  Features:
110
136
 
111
- - AST parsing is cached with a LRU cache, significantly reducing execution time
112
- ([related issue](https://github.com/acrmp/foodcritic/issues/200)).
113
- Thanks @dougbarth.
114
- - [FC001: Use strings in preference to symbols to access node attributes](http://foodcritic.io/#FC001)
115
- rule re-instated
116
- ([related issue](https://github.com/acrmp/foodcritic/issues/97)).
117
- Thanks @sethvargo.
118
- - Relaxed nokogiri and yajl-ruby dependencies for bundling with other gems
119
- ([related issue](https://github.com/acrmp/foodcritic/issues/217))
120
- ([related issue](https://github.com/acrmp/foodcritic/issues/197)).
121
- Thanks @lamont-granquist, @elgalu.
122
- - DSL metadata for Chef versions 11.6.2 through 11.10.4 added
123
- ([related issue](https://github.com/acrmp/foodcritic/issues/220)).
124
- Thanks @lamont-granquist.
125
- - Improved rake task output on failure
126
- ([related issue](https://github.com/acrmp/foodcritic/issues/190)).
127
- Thanks @mlafeldt.
128
- - Allow rake task description to be specified
129
- ([related issue](https://github.com/acrmp/foodcritic/issues/190)).
130
- Thanks @mlafeldt.
131
- - Allow the rake task to use context output
132
- ([related issue](https://github.com/acrmp/foodcritic/issues/204)).
133
- Thanks @docwhat.
134
- - Add support for excluding paths at the command line with `-X`
135
- ([related issue](https://github.com/acrmp/foodcritic/issues/207)).
136
- Thanks @juanje, @docwhat.
137
+ - AST parsing is cached with a LRU cache, significantly reducing execution time ([related issue](https://github.com/acrmp/foodcritic/issues/200)). Thanks @dougbarth.
138
+ - [FC001: Use strings in preference to symbols to access node attributes](http://foodcritic.io/#FC001) rule re-instated ([related issue](https://github.com/acrmp/foodcritic/issues/97)). Thanks @sethvargo.
139
+ - Relaxed nokogiri and yajl-ruby dependencies for bundling with other gems ([related issue](https://github.com/acrmp/foodcritic/issues/217)) ([related issue](https://github.com/acrmp/foodcritic/issues/197)). Thanks @lamont-granquist, @elgalu.
140
+ - DSL metadata for Chef versions 11.6.2 through 11.10.4 added ([related issue](https://github.com/acrmp/foodcritic/issues/220)). Thanks @lamont-granquist.
141
+ - Improved rake task output on failure ([related issue](https://github.com/acrmp/foodcritic/issues/190)). Thanks @mlafeldt.
142
+ - Allow rake task description to be specified ([related issue](https://github.com/acrmp/foodcritic/issues/190)). Thanks @mlafeldt.
143
+ - Allow the rake task to use context output ([related issue](https://github.com/acrmp/foodcritic/issues/204)). Thanks @docwhat.
144
+ - Add support for excluding paths at the command line with `-X` ([related issue](https://github.com/acrmp/foodcritic/issues/207)). Thanks @juanje, @docwhat.
137
145
 
138
146
  Bugfixes:
139
147
 
140
- - [FC003: Check whether you are running with chef server before using server-specific features](http://foodcritic.io/#FC003)
141
- would warn incorrectly against ternary expressions
142
- ([related issue](https://github.com/acrmp/foodcritic/issues/185)). Thanks @zts.
143
- - [FC006: Mode should be quoted or fully specified when setting file permissions](http://foodcritic.io/#FC006)
144
- would warn incorrectly if the mode was a reference to an array
145
- ([related issue](https://github.com/acrmp/foodcritic/issues/211)). Thanks @zts.
146
- - [FC022: Resource condition within loop may not behave as expected](http://foodcritic.io/#FC022)
147
- could warn incorrectly if the resource guard contained a loop
148
- ([related issue](https://github.com/acrmp/foodcritic/issues/69)). Thanks
149
- @jaymzh.
150
- - [FC022: Resource condition within loop may not behave as expected](http://foodcritic.io/#FC022)
151
- could warn incorrectly against definitions
152
- ([related issue](https://github.com/acrmp/foodcritic/issues/195)). Thanks
153
- @bpaquet.
154
- - [FC034: Unused template variables](http://foodcritic.io/#FC034)
155
- could warn incorrectly when different templates may be used based on platform.
156
- - [FC040: Execute resource used to run git commands](http://foodcritic.io/#FC040)
157
- would fail to warn for subsequent resources
158
- ([related issue](https://github.com/acrmp/foodcritic/issues/186)). Thanks
159
- @nkammah.
160
- - [FC047: Attribute assignment does not specify precedence](http://foodcritic.io/#FC047)
161
- would warn incorrectly on force attributes
162
- ([related issue](https://github.com/acrmp/foodcritic/issues/226)). Thanks
163
- @v-a.
148
+ - [FC003: Check whether you are running with chef server before using server-specific features](http://foodcritic.io/#FC003) would warn incorrectly against ternary expressions ([related issue](https://github.com/acrmp/foodcritic/issues/185)). Thanks @zts.
149
+ - [FC006: Mode should be quoted or fully specified when setting file permissions](http://foodcritic.io/#FC006) would warn incorrectly if the mode was a reference to an array ([related issue](https://github.com/acrmp/foodcritic/issues/211)). Thanks @zts.
150
+ - [FC022: Resource condition within loop may not behave as expected](http://foodcritic.io/#FC022) could warn incorrectly if the resource guard contained a loop ([related issue](https://github.com/acrmp/foodcritic/issues/69)). Thanks @jaymzh.
151
+ - [FC022: Resource condition within loop may not behave as expected](http://foodcritic.io/#FC022) could warn incorrectly against definitions ([related issue](https://github.com/acrmp/foodcritic/issues/195)). Thanks @bpaquet.
152
+ - [FC034: Unused template variables](http://foodcritic.io/#FC034) could warn incorrectly when different templates may be used based on platform.
153
+ - [FC040: Execute resource used to run git commands](http://foodcritic.io/#FC040) would fail to warn for subsequent resources ([related issue](https://github.com/acrmp/foodcritic/issues/186)). Thanks @nkammah.
154
+ - [FC047: Attribute assignment does not specify precedence](http://foodcritic.io/#FC047) would warn incorrectly on force attributes ([related issue](https://github.com/acrmp/foodcritic/issues/226)). Thanks @v-a.
164
155
 
165
156
  Other:
166
157
 
167
- - Ruby 1.9.2 support has been removed.
168
- - The default DSL metadata version has been bumped to 11.10.4
169
- ([related issue](https://github.com/acrmp/foodcritic/issues/210)).
170
- Thanks @kmshultz.
158
+ - Ruby 1.9.2 support has been removed.
159
+ - The default DSL metadata version has been bumped to 11.10.4 ([related issue](https://github.com/acrmp/foodcritic/issues/210)). Thanks @kmshultz.
171
160
 
172
161
  ## 3.0.3 (13th October, 2013)
173
162
 
174
163
  Bugfixes:
175
164
 
176
- - [FC051: Template partials loop indefinitely](http://foodcritic.io/#FC051)
177
- would cause an error for partials included from a subdirectory or where the
178
- partial did not exist
179
- ([related issue](https://github.com/acrmp/foodcritic/issues/176)). Thanks
180
- @claco, @michaelglass.
165
+ - [FC051: Template partials loop indefinitely](http://foodcritic.io/#FC051) would cause an error for partials included from a subdirectory or where the partial did not exist ([related issue](https://github.com/acrmp/foodcritic/issues/176)). Thanks @claco, @michaelglass.
181
166
 
182
167
  ## 3.0.2 (5th October, 2013)
183
168
 
184
169
  Bugfixes:
185
170
 
186
- - [FC051: Template partials loop indefinitely](http://foodcritic.io/#FC051)
187
- can cause foodcritic to exit with an error on encountering a file that
188
- cannot be read as UTF-8. We now explicitly exclude `.DS_Store` and `*.swp`
189
- as a workaround
190
- ([related issue](https://github.com/acrmp/foodcritic/issues/172)). Thanks
191
- @tmatilai, @claco.
192
- - [FC022: Resource condition within loop may not behave as expected](http://foodcritic.io/#FC022)
193
- would warn incorrectly against loops where the block accepts more than one
194
- argument
195
- ([related issue](https://github.com/acrmp/foodcritic/issues/69)). Thanks
196
- @Ips1975, @jaymzh.
171
+ - [FC051: Template partials loop indefinitely](http://foodcritic.io/#FC051) can cause foodcritic to exit with an error on encountering a file that cannot be read as UTF-8\. We now explicitly exclude `.DS_Store` and `*.swp` as a workaround ([related issue](https://github.com/acrmp/foodcritic/issues/172)). Thanks @tmatilai, @claco.
172
+ - [FC022: Resource condition within loop may not behave as expected](http://foodcritic.io/#FC022) would warn incorrectly against loops where the block accepts more than one argument ([related issue](https://github.com/acrmp/foodcritic/issues/69)). Thanks @Ips1975, @jaymzh.
197
173
 
198
174
  ## 3.0.1 (25th September, 2013)
199
175
 
200
176
  Other:
201
177
 
202
- - Rake version constraint removed to make packaging easier for users who
203
- deploy foodcritic alongside Omnibus Chef.
178
+ - Rake version constraint removed to make packaging easier for users who deploy foodcritic alongside Omnibus Chef.
204
179
 
205
180
  ## 3.0.0 (14th September, 2013)
206
181
 
207
182
  Features:
208
183
 
209
- - [FC047: Attribute assignment does not specify precedence](http://foodcritic.io/#FC047)
210
- rule added
211
- ([related issue](https://github.com/acrmp/foodcritic/issues/81)). Thanks
212
- @jtimberman, @miketheman.
213
- - [FC048: Prefer Mixlib::ShellOut](http://foodcritic.io/#FC048)
214
- rule added
215
- ([related issue](https://github.com/acrmp/foodcritic/issues/111)). Thanks
216
- @jaymzh.
217
- - [FC049: Role name does not match containing file name](http://foodcritic.io/#FC049)
218
- rule added
219
- ([related issue](https://github.com/acrmp/foodcritic/issues/19)). Thanks
220
- @jaymzh.
221
- - [FC050: Name includes invalid characters](http://foodcritic.io/#FC050)
222
- rule added.
223
- - [FC051: Template partials loop indefinitely](http://foodcritic.io/#FC051)
224
- rule added.
225
- - Added support for checking Chef environment and role files
226
- ([related issue](https://github.com/acrmp/foodcritic/issues/19)). Thanks
227
- @jaymzh.
228
- - Added metadata for Chef 11.6.0.
229
- - API methods `#field`, `#field_value` and `#templates_included` added.
230
- - The API now exposes access to whether individual warnings should be viewed
231
- as failures
232
- ([related issue](https://github.com/acrmp/foodcritic/issues/150)). Thanks
233
- @jamesdburgess.
234
-
235
- Bugfixes:
236
-
237
- - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://foodcritic.io/#FC007)
238
- would warn if specifying dependencies in a multi-line word list with leading whitespace
239
- ([related issue](https://github.com/acrmp/foodcritic/issues/160)). Thanks to
240
- @philk for identifying and fixing this issue.
241
- - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://foodcritic.io/#FC007)
242
- would not warn if `include_recipe` used parentheses
243
- ([related issue](https://github.com/acrmp/foodcritic/issues/155)). Thanks
244
- @jamesdburgess.
245
- - [FC017: LWRP does not notify when updated](http://foodcritic.io/#FC017)
246
- would warn even if `converge_by` or `use_inline_resources` was used
247
- ([related issue](https://github.com/acrmp/foodcritic/issues/90)). Thanks
248
- @stevendanna, @nevir.
249
- - [FC017: LWRP does not notify when updated](http://foodcritic.io/#FC017)
250
- would not warn if any action within the provider notified. Updated to report
251
- against actions individually
252
- ([related issue](https://github.com/acrmp/foodcritic/issues/90)).
253
- - [FC019: Access node attributes in a consistent manner](http://foodcritic.io/#FC019)
254
- would warn incorrectly against `node.run_state`
255
- ([related issue](https://github.com/acrmp/foodcritic/issues/66)). Thanks
256
- @jtimberman.
257
- - [FC033: Missing template](http://foodcritic.io/#FC033)
258
- would warn if the template filename began with a dot
259
- ([related issue](https://github.com/acrmp/foodcritic/issues/165)). Thanks
260
- @eherot.
261
- - [FC034: Unused template variables](http://foodcritic.io/#FC034)
262
- would warn incorrectly if variables were used by partials
263
- ([related issue](https://github.com/acrmp/foodcritic/issues/140)). Thanks to
264
- @v-a for implementing initial support for partials.
265
- - [FC034: Unused template variables](http://foodcritic.io/#FC034)
266
- would not be shown against inferred templates.
267
- - [FC038: Invalid resource action](http://foodcritic.io/#FC038)
268
- would warn incorrectly for log resources that specified a `write` action
269
- ([related issue](https://github.com/acrmp/foodcritic/issues/154)). Thanks
270
- @sethvargo.
271
- - The foodcritic gem was missing a dependency on rake which broke
272
- thor-foodcritic
273
- ([related issue](https://github.com/acrmp/foodcritic/issues/157)). Thanks
274
- @douglaswth.
275
- - Template warnings should now be shown against the correct line number.
276
- Previously warnings were always shown against line 1
277
- ([related issue](https://github.com/acrmp/foodcritic/issues/102)). Thanks
278
- @juliandunn.
279
- - The `#declared_dependencies` API method could return duplicates for old
280
- versions of LibXML.
281
- ([related issue](https://github.com/acrmp/foodcritic/issues/163)). Thanks
282
- @danleyden.
184
+ - [FC047: Attribute assignment does not specify precedence](http://foodcritic.io/#FC047) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/81)). Thanks @jtimberman, @miketheman.
185
+ - [FC048: Prefer Mixlib::ShellOut](http://foodcritic.io/#FC048) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/111)). Thanks @jaymzh.
186
+ - [FC049: Role name does not match containing file name](http://foodcritic.io/#FC049) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/19)). Thanks @jaymzh.
187
+ - [FC050: Name includes invalid characters](http://foodcritic.io/#FC050) rule added.
188
+ - [FC051: Template partials loop indefinitely](http://foodcritic.io/#FC051) rule added.
189
+ - Added support for checking Chef environment and role files ([related issue](https://github.com/acrmp/foodcritic/issues/19)). Thanks @jaymzh.
190
+ - Added metadata for Chef 11.6.0.
191
+ - API methods `#field`, `#field_value` and `#templates_included` added.
192
+ - The API now exposes access to whether individual warnings should be viewed as failures ([related issue](https://github.com/acrmp/foodcritic/issues/150)). Thanks @jamesdburgess.
193
+
194
+ Bugfixes:
195
+
196
+ - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://foodcritic.io/#FC007) would warn if specifying dependencies in a multi-line word list with leading whitespace ([related issue](https://github.com/acrmp/foodcritic/issues/160)). Thanks to @philk for identifying and fixing this issue.
197
+ - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://foodcritic.io/#FC007) would not warn if `include_recipe` used parentheses ([related issue](https://github.com/acrmp/foodcritic/issues/155)). Thanks @jamesdburgess.
198
+ - [FC017: LWRP does not notify when updated](http://foodcritic.io/#FC017) would warn even if `converge_by` or `use_inline_resources` was used ([related issue](https://github.com/acrmp/foodcritic/issues/90)). Thanks @stevendanna, @nevir.
199
+ - [FC017: LWRP does not notify when updated](http://foodcritic.io/#FC017) would not warn if any action within the provider notified. Updated to report against actions individually ([related issue](https://github.com/acrmp/foodcritic/issues/90)).
200
+ - [FC019: Access node attributes in a consistent manner](http://foodcritic.io/#FC019) would warn incorrectly against `node.run_state` ([related issue](https://github.com/acrmp/foodcritic/issues/66)). Thanks @jtimberman.
201
+ - [FC033: Missing template](http://foodcritic.io/#FC033) would warn if the template filename began with a dot ([related issue](https://github.com/acrmp/foodcritic/issues/165)). Thanks @eherot.
202
+ - [FC034: Unused template variables](http://foodcritic.io/#FC034) would warn incorrectly if variables were used by partials ([related issue](https://github.com/acrmp/foodcritic/issues/140)). Thanks to @v-a for implementing initial support for partials.
203
+ - [FC034: Unused template variables](http://foodcritic.io/#FC034) would not be shown against inferred templates.
204
+ - [FC038: Invalid resource action](http://foodcritic.io/#FC038) would warn incorrectly for log resources that specified a `write` action ([related issue](https://github.com/acrmp/foodcritic/issues/154)). Thanks @sethvargo.
205
+ - The foodcritic gem was missing a dependency on rake which broke thor-foodcritic ([related issue](https://github.com/acrmp/foodcritic/issues/157)). Thanks @douglaswth.
206
+ - Template warnings should now be shown against the correct line number. Previously warnings were always shown against line 1 ([related issue](https://github.com/acrmp/foodcritic/issues/102)). Thanks @juliandunn.
207
+ - The `#declared_dependencies` API method could return duplicates for old versions of LibXML. ([related issue](https://github.com/acrmp/foodcritic/issues/163)). Thanks @danleyden.
283
208
 
284
209
  Other:
285
210
 
286
- - This release introduces breaking changes to programmatic use of foodcritic.
211
+ - This release introduces breaking changes to programmatic use of foodcritic.
287
212
 
288
213
  ## 2.2.0 (10th July, 2013)
289
214
 
290
215
  Features:
291
216
 
292
- - Additional rules may now be shipped as gems. Files matching the path
293
- `foodcritic/rules/**/*.rb` will be loaded if the `--search-gems` option is
294
- specified
295
- ([related issue](https://github.com/acrmp/foodcritic/issues/143)). Thanks
296
- to @rteabeault for implementing this feature.
297
- - You can now control the rules applied to individual cookbooks by including
298
- a `.foodcritic` file at the root of your cookbook with the tags you want
299
- checked
300
- ([related issue](https://github.com/acrmp/foodcritic/issues/141)). Thanks
301
- to @sabat for implementing this feature.
302
- - The [project license](https://github.com/acrmp/foodcritic/blob/master/LICENSE)
303
- is now included in the built gem
304
- ([related issue](https://github.com/acrmp/foodcritic/issues/145)).
305
- Thanks @stefanor.
306
- - Foodcritic no longer uses the `rak` gem to generate output with context
307
- ([related issue](https://github.com/acrmp/foodcritic/issues/146)).
308
- Thanks to @stefanor for re-implementing context output to remove this
309
- dependency.
310
- - A man page is now included with foodcritic in
311
- [ronn-format](http://rtomayko.github.io/ronn/).
312
- Thanks @stefanor.
217
+ - Additional rules may now be shipped as gems. Files matching the path `foodcritic/rules/**/*.rb` will be loaded if the `--search-gems` option is specified ([related issue](https://github.com/acrmp/foodcritic/issues/143)). Thanks to @rteabeault for implementing this feature.
218
+ - You can now control the rules applied to individual cookbooks by including a `.foodcritic` file at the root of your cookbook with the tags you want checked ([related issue](https://github.com/acrmp/foodcritic/issues/141)). Thanks to @sabat for implementing this feature.
219
+ - The [project license](https://github.com/acrmp/foodcritic/blob/master/LICENSE) is now included in the built gem ([related issue](https://github.com/acrmp/foodcritic/issues/145)). Thanks @stefanor.
220
+ - Foodcritic no longer uses the `rak` gem to generate output with context ([related issue](https://github.com/acrmp/foodcritic/issues/146)). Thanks to @stefanor for re-implementing context output to remove this dependency.
221
+ - A man page is now included with foodcritic in [ronn-format](http://rtomayko.github.io/ronn/). Thanks @stefanor.
313
222
 
314
223
  Bugfixes:
315
224
 
316
- - Definitions are now included in the files that are linted
317
- ([related issue](https://github.com/acrmp/foodcritic/issues/142)). Thanks
318
- @bpaquet.
319
- - [FC009: Resource attribute not recognised](http://acrmp.github.com/foodcritic/#FC009)
320
- would warn against Windows-specific resource attributes
321
- ([related issue](https://github.com/acrmp/foodcritic/issues/135)). Thanks
322
- @stormtrooperguy.
323
- - [FC011: Missing README in markdown format](http://acrmp.github.com/foodcritic/#FC011)
324
- was not shown when outputting with context enabled
325
- ([related issue](https://github.com/acrmp/foodcritic/issues/146)). Thanks
326
- @stefanor.
327
- - [FC014: Consider extracting long ruby_block to library](http://acrmp.github.com/foodcritic/#FC014)
328
- previously used the number of AST nodes to determine block length. This
329
- was a poor proxy for length and this rule has been updated to warn if the
330
- number of lines > 15
331
- ([related issue](https://github.com/acrmp/foodcritic/issues/130)). Thanks
332
- @adamjk-dev.
333
- - [FC014: Consider extracting long ruby_block to library](http://acrmp.github.com/foodcritic/#FC014)
334
- would warn against other blocks incorrectly
335
- ([related issue](https://github.com/acrmp/foodcritic/issues/130)). Thanks
336
- @adamjk-dev.
337
- - [FC014: Consider extracting long ruby_block to library](http://acrmp.github.com/foodcritic/#FC014)
338
- would raise an error if the ruby_block did not contain a nested `block`
339
- attribute
340
- ([related issue](https://github.com/acrmp/foodcritic/issues/139)). Thanks
341
- @stevendanna.
342
- - [FC033: Missing template](http://acrmp.github.com/foodcritic/#FC033)
343
- would warn when the template file did not have an erb extension
344
- ([related issue](https://github.com/acrmp/foodcritic/issues/131)). Thanks
345
- @nvwls.
346
- - [FC034: Unused template variables](http://acrmp.github.com/foodcritic/#FC034)
347
- would warn when the template file did not have an erb extension
348
- ([related issue](https://github.com/acrmp/foodcritic/issues/131)). Thanks
349
- @nvwls.
225
+ - Definitions are now included in the files that are linted ([related issue](https://github.com/acrmp/foodcritic/issues/142)). Thanks @bpaquet.
226
+ - [FC009: Resource attribute not recognised](http://acrmp.github.com/foodcritic/#FC009) would warn against Windows-specific resource attributes ([related issue](https://github.com/acrmp/foodcritic/issues/135)). Thanks @stormtrooperguy.
227
+ - [FC011: Missing README in markdown format](http://acrmp.github.com/foodcritic/#FC011) was not shown when outputting with context enabled ([related issue](https://github.com/acrmp/foodcritic/issues/146)). Thanks @stefanor.
228
+ - [FC014: Consider extracting long ruby_block to library](http://acrmp.github.com/foodcritic/#FC014) previously used the number of AST nodes to determine block length. This was a poor proxy for length and this rule has been updated to warn if the number of lines > 15 ([related issue](https://github.com/acrmp/foodcritic/issues/130)). Thanks @adamjk-dev.
229
+ - [FC014: Consider extracting long ruby_block to library](http://acrmp.github.com/foodcritic/#FC014) would warn against other blocks incorrectly ([related issue](https://github.com/acrmp/foodcritic/issues/130)). Thanks @adamjk-dev.
230
+ - [FC014: Consider extracting long ruby_block to library](http://acrmp.github.com/foodcritic/#FC014) would raise an error if the ruby_block did not contain a nested `block` attribute ([related issue](https://github.com/acrmp/foodcritic/issues/139)). Thanks @stevendanna.
231
+ - [FC033: Missing template](http://acrmp.github.com/foodcritic/#FC033) would warn when the template file did not have an erb extension ([related issue](https://github.com/acrmp/foodcritic/issues/131)). Thanks @nvwls.
232
+ - [FC034: Unused template variables](http://acrmp.github.com/foodcritic/#FC034) would warn when the template file did not have an erb extension ([related issue](https://github.com/acrmp/foodcritic/issues/131)). Thanks @nvwls.
350
233
 
351
234
  ## 2.1.0 (17th April, 2013)
352
235
 
353
236
  Features:
354
237
 
355
- - DSL metadata will now reflect the version of Chef selected with
356
- `--chef-version`. For example this means that
357
- [FC009: Resource attribute not recognised](http://acrmp.github.com/foodcritic/#FC009)
358
- will warn about attributes not present in the specified version of Chef.
238
+ - DSL metadata will now reflect the version of Chef selected with `--chef-version`. For example this means that [FC009: Resource attribute not recognised](http://acrmp.github.com/foodcritic/#FC009) will warn about attributes not present in the specified version of Chef.
359
239
 
360
240
  Bugfixes:
361
241
 
362
- - [FC045: Consider setting cookbook name in metadata](http://acrmp.github.com/foodcritic/#FC045)
363
- would warn incorrectly and other rules would fail to work when activesupport
364
- had been loaded
365
- ([related issue](https://github.com/acrmp/foodcritic/issues/118)). This
366
- affected Berkshelf users. Thanks @scalp42 and @c-nolic.
367
- - Upgrade the version of Gherkin dependency to avoid deprecation warnings
368
- ([related issue](https://github.com/acrmp/foodcritic/pull/122)).
369
- Thanks @tmatilai.
242
+ - [FC045: Consider setting cookbook name in metadata](http://acrmp.github.com/foodcritic/#FC045) would warn incorrectly and other rules would fail to work when activesupport had been loaded ([related issue](https://github.com/acrmp/foodcritic/issues/118)). This affected Berkshelf users. Thanks @scalp42 and @c-nolic.
243
+ - Upgrade the version of Gherkin dependency to avoid deprecation warnings ([related issue](https://github.com/acrmp/foodcritic/pull/122)). Thanks @tmatilai.
370
244
 
371
245
  Other:
372
246
 
373
- - Known to run on MRI 2.0.0 - added to Travis CI matrix.
247
+ - Known to run on MRI 2.0.0 - added to Travis CI matrix.
374
248
 
375
249
  ## 2.0.1 (31st March, 2013)
376
250
 
377
251
  Bugfixes:
378
252
 
379
- - Matches that should be ignored were not if the rule implementation used the
380
- `cookbook` block
381
- ([related issue](https://github.com/acrmp/foodcritic/issues/119)).
382
- - [FC033: Missing Template](http://acrmp.github.com/foodcritic/#FC033)
383
- would warn incorrectly when the template resource was nested within another
384
- resource
385
- ([related issue](https://github.com/acrmp/foodcritic/issues/96)).
386
- Thanks @justinforce.
387
- - The `#resource_attributes` API method now copes with nested resources.
253
+ - Matches that should be ignored were not if the rule implementation used the `cookbook` block ([related issue](https://github.com/acrmp/foodcritic/issues/119)).
254
+ - [FC033: Missing Template](http://acrmp.github.com/foodcritic/#FC033) would warn incorrectly when the template resource was nested within another resource ([related issue](https://github.com/acrmp/foodcritic/issues/96)). Thanks @justinforce.
255
+ - The `#resource_attributes` API method now copes with nested resources.
388
256
 
389
257
  ## 2.0.0 (24th March, 2013)
390
258
 
391
259
  Features
392
260
 
393
- - Support added for ignoring individual matches. To ignore a match add a
394
- comment to the affected line in your cookbook of the format `# ~FC006`
395
- ([related issue](https://github.com/acrmp/foodcritic/issues/119)).
396
- Big thanks to @grosser.
397
- - Command line help now specifies the tag to use to fail the build on any
398
- rule match
399
- ([related issue](https://github.com/acrmp/foodcritic/issues/108)).
400
- Thanks @grosser.
401
- - FC046: Attribute assignment uses assign unless nil
402
- rule added
403
- ([related issue](https://github.com/acrmp/foodcritic/issues/52)).
404
- Thanks @jaymzh.
261
+ - Support added for ignoring individual matches. To ignore a match add a comment to the affected line in your cookbook of the format `# ~FC006` ([related issue](https://github.com/acrmp/foodcritic/issues/119)). Big thanks to @grosser.
262
+ - Command line help now specifies the tag to use to fail the build on any rule match ([related issue](https://github.com/acrmp/foodcritic/issues/108)). Thanks @grosser.
263
+ - FC046: Attribute assignment uses assign unless nil rule added ([related issue](https://github.com/acrmp/foodcritic/issues/52)). Thanks @jaymzh.
405
264
 
406
265
  Bugfixes:
407
266
 
408
- - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003)
409
- updated to recognise checks that use return
410
- ([related issue](https://github.com/acrmp/foodcritic/issues/92)).
411
- Thanks @sethvargo, @miketheman.
412
- - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003)
413
- updated to recognise checks that test for Chef Solo with alternation
414
- ([related issue](https://github.com/acrmp/foodcritic/issues/103)).
415
- Thanks @promisedlandt.
416
- - [FC017: LWRP does not notify when updated](http://acrmp.github.com/foodcritic/#FC017)
417
- modified to no longer warn when a notification is made without parentheses
418
- ([related issue](https://github.com/acrmp/foodcritic/issues/121)).
419
- Thanks @justinforce.
420
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019)
421
- would previously only show warnings for the first matching file.
422
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019)
423
- updated to avoid showing a false positive where a search is passed an
424
- argument based on a node attribute accessed with a string.
425
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019)
426
- updated to exclude specs, removing a source of false positives.
427
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019)
428
- fixed regression in var_ref handling.
429
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019)
430
- updated to not trigger on quoted symbols
431
- ([related issue](https://github.com/acrmp/foodcritic/issues/88)).
432
- Thanks @spheromak.
433
- - [FC024: Consider adding platform equivalents](http://acrmp.github.com/foodcritic/#FC024)
434
- updated to only warn about platform equivalents that are listed in the
435
- cookbook metadata
436
- ([related issue](https://github.com/acrmp/foodcritic/issues/59)).
437
- Thanks @tknerr.
438
- - [FC037: Invalid notification action](http://acrmp.github.com/foodcritic/#FC037)
439
- would cause foodcritic to halt with an error when a notification action was
440
- specified as an expression
441
- ([related issue](https://github.com/acrmp/foodcritic/issues/104)).
442
- Thanks @jaymzh.
443
- - [FC040: Execute resource used to run git commands](http://acrmp.github.com/foodcritic/#FC040)
444
- updated to not match if the git command cannot be expressed as a `git`
445
- resource.
446
- ([related issue](https://github.com/acrmp/foodcritic/pull/98)).
447
- Thanks @trobrock for raising this issue and implementing the fix.
448
- - [FC043: Prefer new notification syntax](http://acrmp.github.com/foodcritic/#FC043)
449
- updated to apply only to Chef versions >= 0.9.10
450
- ([related issue](https://github.com/acrmp/foodcritic/issues/114)).
451
- Thanks @iainbeeston.
452
- - [FC044: Avoid bare attribute keys](http://acrmp.github.com/foodcritic/#FC044)
453
- changed to not raise false positives against block variables
454
- ([related issue](https://github.com/acrmp/foodcritic/issues/105)).
455
- Thanks @jaymzh.
267
+ - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003) updated to recognise checks that use return ([related issue](https://github.com/acrmp/foodcritic/issues/92)). Thanks @sethvargo, @miketheman.
268
+ - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003) updated to recognise checks that test for Chef Solo with alternation ([related issue](https://github.com/acrmp/foodcritic/issues/103)). Thanks @promisedlandt.
269
+ - [FC017: LWRP does not notify when updated](http://acrmp.github.com/foodcritic/#FC017) modified to no longer warn when a notification is made without parentheses ([related issue](https://github.com/acrmp/foodcritic/issues/121)). Thanks @justinforce.
270
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) would previously only show warnings for the first matching file.
271
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) updated to avoid showing a false positive where a search is passed an argument based on a node attribute accessed with a string.
272
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) updated to exclude specs, removing a source of false positives.
273
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) fixed regression in var_ref handling.
274
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) updated to not trigger on quoted symbols ([related issue](https://github.com/acrmp/foodcritic/issues/88)). Thanks @spheromak.
275
+ - [FC024: Consider adding platform equivalents](http://acrmp.github.com/foodcritic/#FC024) updated to only warn about platform equivalents that are listed in the cookbook metadata ([related issue](https://github.com/acrmp/foodcritic/issues/59)). Thanks @tknerr.
276
+ - [FC037: Invalid notification action](http://acrmp.github.com/foodcritic/#FC037) would cause foodcritic to halt with an error when a notification action was specified as an expression ([related issue](https://github.com/acrmp/foodcritic/issues/104)). Thanks @jaymzh.
277
+ - [FC040: Execute resource used to run git commands](http://acrmp.github.com/foodcritic/#FC040) updated to not match if the git command cannot be expressed as a `git` resource. ([related issue](https://github.com/acrmp/foodcritic/pull/98)). Thanks @trobrock for raising this issue and implementing the fix.
278
+ - [FC043: Prefer new notification syntax](http://acrmp.github.com/foodcritic/#FC043) updated to apply only to Chef versions >= 0.9.10 ([related issue](https://github.com/acrmp/foodcritic/issues/114)). Thanks @iainbeeston.
279
+ - [FC044: Avoid bare attribute keys](http://acrmp.github.com/foodcritic/#FC044) changed to not raise false positives against block variables ([related issue](https://github.com/acrmp/foodcritic/issues/105)). Thanks @jaymzh.
456
280
 
457
281
  Other:
458
282
 
459
- - The `--repl` command line flag has been removed. This feature little used
460
- and was problematic for users attempting to use newer versions of pry or
461
- guard
462
- ([related issue](https://github.com/acrmp/foodcritic/issues/50)).
463
- Thanks @jperry, @miketheman, @jtimberman.
464
- - The `os_command?` api method has been removed.
465
- - The deprecated `cookbook_path` and `valid_path?` methods have been removed.
466
- This may cause breakage if you are using foodcritic programatically from
467
- Ruby. Please update your code to use the `cookbook_paths` and `valid_paths?`
468
- methods instead.
469
- - Added regression test for expected output against opscode-cookbooks. Run
470
- `bundle exec rake regressions` to perform this test.
283
+ - The `--repl` command line flag has been removed. This feature little used and was problematic for users attempting to use newer versions of pry or guard ([related issue](https://github.com/acrmp/foodcritic/issues/50)). Thanks @jperry, @miketheman, @jtimberman.
284
+ - The `os_command?` api method has been removed.
285
+ - The deprecated `cookbook_path` and `valid_path?` methods have been removed. This may cause breakage if you are using foodcritic programatically from Ruby. Please update your code to use the `cookbook_paths` and `valid_paths?` methods instead.
286
+ - Added regression test for expected output against opscode-cookbooks. Run `bundle exec rake regressions` to perform this test.
471
287
 
472
288
  ## 1.7.0 (27th December, 2012)
473
289
 
474
290
  Features
475
291
 
476
- - [FC038: Invalid resource action](http://acrmp.github.com/foodcritic/#FC038)
477
- rule added
478
- ([related issue](https://github.com/acrmp/foodcritic/issues/61)).
479
- Thanks @jaymzh.
480
- - [FC039: Node method cannot be accessed with key](http://acrmp.github.com/foodcritic/#FC039)
481
- rule added.
482
- - [FC040: Execute resource used to run git commands](http://acrmp.github.com/foodcritic/#FC040)
483
- rule stolen from Etsy rules (ETSY003)
484
- ([related issue](https://github.com/acrmp/foodcritic/issues/72)).
485
- Thanks @jonlives.
486
- - [FC041: Execute resource used to run curl or wget commands](http://acrmp.github.com/foodcritic/#FC041)
487
- rule stolen from Etsy rules (ETSY002)
488
- ([related issue](https://github.com/acrmp/foodcritic/issues/73)).
489
- Thanks @jonlives.
490
- - [FC042: Prefer include_recipe](http://acrmp.github.com/foodcritic/#FC042)
491
- rule added
492
- ([related issue](https://github.com/acrmp/foodcritic/pull/77)).
493
- Thanks @pwelch.
494
- - [FC043: Prefer new notification syntax](http://acrmp.github.com/foodcritic/#FC043)
495
- rule added
496
- ([related issue](https://github.com/acrmp/foodcritic/issues/80)).
497
- Thanks @jtimberman.
498
- - [FC044: Avoid bare attribute keys](http://acrmp.github.com/foodcritic/#FC044)
499
- rule added
500
- ([related issue](https://github.com/acrmp/foodcritic/issues/75)).
501
- Thanks @jtimberman.
502
- - [FC045: Consider setting cookbook name in metadata](http://acrmp.github.com/foodcritic/#FC045)
503
- rule added
504
- ([related issue](https://github.com/acrmp/foodcritic/issues/64)).
505
- Thanks @miketheman.
506
- - Linter `#check` method no longer requires options to be explicitly passed if
507
- you are using the defaults
508
- ([related issue](https://github.com/acrmp/foodcritic/pull/71)).
509
- Thanks @kreynolds.
510
-
511
- Bugfixes:
512
-
513
- - Bump version of Nokogiri to
514
- [fix installation failure on Ubuntu 12.10](https://github.com/sparklemotion/nokogiri/issues/680)
515
- ([related issue](https://github.com/acrmp/foodcritic/issues/83)).
516
- Thanks @dracoater.
517
- - Support added for quoted symbols as notification actions
518
- ([related issue](https://github.com/acrmp/foodcritic/pull/94)).
519
- Thanks @ohm.
520
- - Add `spec/**/*` and `features/**/*` to default rake task `:exclude_paths`
521
- ([related issue](https://github.com/acrmp/foodcritic/pull/84)).
522
- Thanks @fnichol.
523
- - Remove unnecessary whitespace from rake task output
524
- ([related issue](https://github.com/acrmp/foodcritic/pull/78)).
525
- Thanks @ketan.
526
- - Removed [FC001: Use strings in preference to symbols to access node attributes](http://acrmp.github.com/foodcritic/#FC001)
527
- ([related issue](https://github.com/acrmp/foodcritic/issues/86)).
528
- Thanks @jtimberman.
529
- - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003)
530
- updated to also match `unless`
531
- ([related issue](https://github.com/acrmp/foodcritic/issues/58)).
532
- Thanks @cap10morgan.
533
- - Decode numeric attributes.
534
- This could cause [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005)
535
- to warn incorrectly
536
- ([related issue](https://github.com/acrmp/foodcritic/issues/79)).
537
- Thanks @masterkorp.
538
- - Recognise attributes correctly within a block.
539
- This could cause [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005)
540
- to warn incorrectly
541
- ([related issue](https://github.com/acrmp/foodcritic/issues/76)).
542
- Thanks @masterkorp.
543
- - [FC009: Resource attribute not recognised](http://acrmp.github.com/foodcritic/#FC009)
544
- would warn incorrectly on methods used within a resource block
545
- ([related issue](https://github.com/acrmp/foodcritic/issues/85)).
546
- Thanks @arangamani.
547
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019)
548
- would warn incorrectly when referencing node attributes from a user-created
549
- hash.
550
- ([related issue](https://github.com/acrmp/foodcritic/issues/54)).
551
- Thanks @schubert.
552
- - [FC033: Missing Template](http://acrmp.github.com/foodcritic/#FC033)
553
- would warn incorrectly when using templates from another cookbook
554
- ([related issue](https://github.com/acrmp/foodcritic/issues/74)).
555
- Thanks @woohgit.
292
+ - [FC038: Invalid resource action](http://acrmp.github.com/foodcritic/#FC038) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/61)). Thanks @jaymzh.
293
+ - [FC039: Node method cannot be accessed with key](http://acrmp.github.com/foodcritic/#FC039) rule added.
294
+ - [FC040: Execute resource used to run git commands](http://acrmp.github.com/foodcritic/#FC040) rule stolen from Etsy rules (ETSY003) ([related issue](https://github.com/acrmp/foodcritic/issues/72)). Thanks @jonlives.
295
+ - [FC041: Execute resource used to run curl or wget commands](http://acrmp.github.com/foodcritic/#FC041) rule stolen from Etsy rules (ETSY002) ([related issue](https://github.com/acrmp/foodcritic/issues/73)). Thanks @jonlives.
296
+ - [FC042: Prefer include_recipe](http://acrmp.github.com/foodcritic/#FC042) rule added ([related issue](https://github.com/acrmp/foodcritic/pull/77)). Thanks @pwelch.
297
+ - [FC043: Prefer new notification syntax](http://acrmp.github.com/foodcritic/#FC043) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/80)). Thanks @jtimberman.
298
+ - [FC044: Avoid bare attribute keys](http://acrmp.github.com/foodcritic/#FC044) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/75)). Thanks @jtimberman.
299
+ - [FC045: Consider setting cookbook name in metadata](http://acrmp.github.com/foodcritic/#FC045) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/64)). Thanks @miketheman.
300
+ - Linter `#check` method no longer requires options to be explicitly passed if you are using the defaults ([related issue](https://github.com/acrmp/foodcritic/pull/71)). Thanks @kreynolds.
301
+
302
+ Bugfixes:
303
+
304
+ - Bump version of Nokogiri to [fix installation failure on Ubuntu 12.10](https://github.com/sparklemotion/nokogiri/issues/680) ([related issue](https://github.com/acrmp/foodcritic/issues/83)). Thanks @dracoater.
305
+ - Support added for quoted symbols as notification actions ([related issue](https://github.com/acrmp/foodcritic/pull/94)). Thanks @ohm.
306
+ - Add `spec/**/*` and `features/**/*` to default rake task `:exclude_paths` ([related issue](https://github.com/acrmp/foodcritic/pull/84)). Thanks @fnichol.
307
+ - Remove unnecessary whitespace from rake task output ([related issue](https://github.com/acrmp/foodcritic/pull/78)). Thanks @ketan.
308
+ - Removed [FC001: Use strings in preference to symbols to access node attributes](http://acrmp.github.com/foodcritic/#FC001) ([related issue](https://github.com/acrmp/foodcritic/issues/86)). Thanks @jtimberman.
309
+ - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003) updated to also match `unless` ([related issue](https://github.com/acrmp/foodcritic/issues/58)). Thanks @cap10morgan.
310
+ - Decode numeric attributes. This could cause [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005) to warn incorrectly ([related issue](https://github.com/acrmp/foodcritic/issues/79)). Thanks @masterkorp.
311
+ - Recognise attributes correctly within a block. This could cause [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005) to warn incorrectly ([related issue](https://github.com/acrmp/foodcritic/issues/76)). Thanks @masterkorp.
312
+ - [FC009: Resource attribute not recognised](http://acrmp.github.com/foodcritic/#FC009) would warn incorrectly on methods used within a resource block ([related issue](https://github.com/acrmp/foodcritic/issues/85)). Thanks @arangamani.
313
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) would warn incorrectly when referencing node attributes from a user-created hash. ([related issue](https://github.com/acrmp/foodcritic/issues/54)). Thanks @schubert.
314
+ - [FC033: Missing Template](http://acrmp.github.com/foodcritic/#FC033) would warn incorrectly when using templates from another cookbook ([related issue](https://github.com/acrmp/foodcritic/issues/74)). Thanks @woohgit.
556
315
 
557
316
  ## 1.6.1 (31st August, 2012)
558
317
 
559
318
  Bugfixes:
560
319
 
561
- - [FC030: Cookbook contains debugger breakpoints](http://acrmp.github.com/foodcritic/#FC030)
562
- could prevent other rules from processing depending on the tags passed.
563
- - [FC037: Invalid notification action](http://acrmp.github.com/foodcritic/#FC037)
564
- would incorrectly warn against `subscribes` notifications
565
- ([related issue](https://github.com/acrmp/foodcritic/issues/65)).
566
- Thanks @jtimberman.
320
+ - [FC030: Cookbook contains debugger breakpoints](http://acrmp.github.com/foodcritic/#FC030) could prevent other rules from processing depending on the tags passed.
321
+ - [FC037: Invalid notification action](http://acrmp.github.com/foodcritic/#FC037) would incorrectly warn against `subscribes` notifications ([related issue](https://github.com/acrmp/foodcritic/issues/65)). Thanks @jtimberman.
567
322
 
568
323
  ## 1.6.0 (28th August, 2012)
569
324
 
570
325
  Bugfixes:
571
326
 
572
- - Removed FC035: Template uses node attribute directly. For a discussion of
573
- the reasons for removal see the
574
- [related issue](https://github.com/acrmp/foodcritic/issues/60).
327
+ - Removed FC035: Template uses node attribute directly. For a discussion of the reasons for removal see the [related issue](https://github.com/acrmp/foodcritic/issues/60).
575
328
 
576
329
  ## 1.5.1 (21st August, 2012)
577
330
 
578
331
  Bugfixes:
579
332
 
580
- - Remove pry-doc dependency to resolve pry version conflict.
333
+ - Remove pry-doc dependency to resolve pry version conflict.
581
334
 
582
335
  ## 1.5.0 (21st August, 2012)
583
336
 
584
337
  Features:
585
338
 
586
- - [FC033: Missing template](http://acrmp.github.com/foodcritic/#FC033) rule
587
- added.
588
- - [FC034: Unused template variables](http://acrmp.github.com/foodcritic/#FC034)
589
- rule added
590
- ([related issue](https://github.com/acrmp/foodcritic/issues/36)).
591
- - [FC035: Template uses node attribute directly](http://acrmp.github.com/foodcritic/#FC035)
592
- rule added. This is a style rule that may prove controversial.
593
- - [FC037: Invalid notification action](http://acrmp.github.com/foodcritic/#FC037)
594
- rule added.
595
- - The `#read_ast` API method now supports Erb templates.
596
- - API method `#resource_action?` added.
597
- - DSL extended to include `library`, `metadata` and `template`.
339
+ - [FC033: Missing template](http://acrmp.github.com/foodcritic/#FC033) rule added.
340
+ - [FC034: Unused template variables](http://acrmp.github.com/foodcritic/#FC034) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/36)).
341
+ - [FC035: Template uses node attribute directly](http://acrmp.github.com/foodcritic/#FC035) rule added. This is a style rule that may prove controversial.
342
+ - [FC037: Invalid notification action](http://acrmp.github.com/foodcritic/#FC037) rule added.
343
+ - The `#read_ast` API method now supports Erb templates.
344
+ - API method `#resource_action?` added.
345
+ - DSL extended to include `library`, `metadata` and `template`.
598
346
 
599
347
  Bugfixes:
600
348
 
601
- - [FC020: Conditional execution string attribute looks like Ruby](http://acrmp.github.com/foodcritic/#FC033)
602
- rule has been removed as unreliable.
603
- - The `#attribute_access` API method now correctly allows a type of `:any`.
604
- - The `#notifications` API method now supports notifications enclosed in braces
605
- ([related issue](https://github.com/etsy/foodcritic-rules/issues/3)).
606
- - Ensure command-line help is shown when an invalid option is passed. Thanks
607
- to @juanje for finding and fixing this issue.
349
+ - [FC020: Conditional execution string attribute looks like Ruby](http://acrmp.github.com/foodcritic/#FC033) rule has been removed as unreliable.
350
+ - The `#attribute_access` API method now correctly allows a type of `:any`.
351
+ - The `#notifications` API method now supports notifications enclosed in braces ([related issue](https://github.com/etsy/foodcritic-rules/issues/3)).
352
+ - Ensure command-line help is shown when an invalid option is passed. Thanks to @juanje for finding and fixing this issue.
608
353
 
609
354
  ## 1.4.0 (15th June, 2012)
610
355
 
611
356
  Features:
612
357
 
613
- - [FC027: Resource sets internal attribute](http://acrmp.github.com/foodcritic/#FC027)
614
- rule added.
615
- Thanks @macros.
616
- - [FC028: Incorrect #platform? usage](http://acrmp.github.com/foodcritic/#FC028)
617
- rule added.
618
- - [FC029: No leading cookbook name in recipe metadata](http://acrmp.github.com/foodcritic/#FC029)
619
- rule added.
620
- - [FC030: Cookbook contains debugger breakpoints](http://acrmp.github.com/foodcritic/#FC030)
621
- rule added
622
- ([related issue](https://github.com/acrmp/foodcritic/issues/36)).
623
- Thanks @bryanwb.
624
- - [FC031: Cookbook without metadata file](http://acrmp.github.com/foodcritic/#FC031)
625
- rule added
626
- ([related issue](https://github.com/acrmp/foodcritic/issues/43)).
627
- Thanks to @juanje for proposing and implementing this rule.
628
- - [FC032: Invalid notification timing](http://acrmp.github.com/foodcritic/#FC032)
629
- rule added.
630
- - Added the [notifications](http://acrmp.github.com/foodcritic/#notifications)
631
- API method to provide more convenient access to resource notifications
632
- ([related issue](https://github.com/acrmp/foodcritic/issues/31)).
358
+ - [FC027: Resource sets internal attribute](http://acrmp.github.com/foodcritic/#FC027) rule added. Thanks @macros.
359
+ - [FC028: Incorrect #platform? usage](http://acrmp.github.com/foodcritic/#FC028) rule added.
360
+ - [FC029: No leading cookbook name in recipe metadata](http://acrmp.github.com/foodcritic/#FC029) rule added.
361
+ - [FC030: Cookbook contains debugger breakpoints](http://acrmp.github.com/foodcritic/#FC030) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/36)). Thanks @bryanwb.
362
+ - [FC031: Cookbook without metadata file](http://acrmp.github.com/foodcritic/#FC031) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/43)). Thanks to @juanje for proposing and implementing this rule.
363
+ - [FC032: Invalid notification timing](http://acrmp.github.com/foodcritic/#FC032) rule added.
364
+ - Added the [notifications](http://acrmp.github.com/foodcritic/#notifications) API method to provide more convenient access to resource notifications ([related issue](https://github.com/acrmp/foodcritic/issues/31)).
633
365
 
634
366
  Bugfixes:
635
367
 
636
- - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003)
637
- would warn if solo was checked for with `Chef::Config.solo`
638
- ([related issue](https://github.com/acrmp/foodcritic/issues/26)).
639
- Thanks to @miketheman for identifying and fixing this issue.
640
- - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://acrmp.github.com/foodcritic/#FC007)
641
- would incorrectly warn if the cookbook name specified for `include_recipe`
642
- was dynamic
643
- ([related issue](https://github.com/acrmp/foodcritic/issues/44)).
644
- Thanks @markjreed.
645
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019)
646
- has been modified to no longer warn if the method called on node is called
647
- explicitly with brackets
648
- ([related issue](https://github.com/acrmp/foodcritic/issues/22)).
649
- Thanks @jaymzh.
650
- - The [resource_attributes](http://acrmp.github.com/foodcritic/#resource_attributes)
651
- API method has been updated to return boolean values correctly.
368
+ - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003) would warn if solo was checked for with `Chef::Config.solo` ([related issue](https://github.com/acrmp/foodcritic/issues/26)). Thanks to @miketheman for identifying and fixing this issue.
369
+ - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://acrmp.github.com/foodcritic/#FC007) would incorrectly warn if the cookbook name specified for `include_recipe` was dynamic ([related issue](https://github.com/acrmp/foodcritic/issues/44)). Thanks @markjreed.
370
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) has been modified to no longer warn if the method called on node is called explicitly with brackets ([related issue](https://github.com/acrmp/foodcritic/issues/22)). Thanks @jaymzh.
371
+ - The [resource_attributes](http://acrmp.github.com/foodcritic/#resource_attributes) API method has been updated to return boolean values correctly.
652
372
 
653
373
  ## 1.3.1 (9th June, 2012)
654
374
 
655
375
  Bugfixes:
656
376
 
657
- - Changes made to support multiple cookbook paths in 1.3.0 broke
658
- compatibility with earlier versions of the linting API. This release
659
- restores compatibility with third party code that uses the linter
660
- `#cookbook_path` or `#valid_path?` methods.
661
- - The Nokogiri dependency constraint has been locked to 1.5.0 again as
662
- Nokogiri 1.5.3 also appears to segfault in certain circumstances.
377
+ - Changes made to support multiple cookbook paths in 1.3.0 broke compatibility with earlier versions of the linting API. This release restores compatibility with third party code that uses the linter `#cookbook_path` or `#valid_path?` methods.
378
+ - The Nokogiri dependency constraint has been locked to 1.5.0 again as Nokogiri 1.5.3 also appears to segfault in certain circumstances.
663
379
 
664
380
  ## 1.3.0 (21st May, 2012)
665
381
 
666
382
  Features:
667
383
 
668
- - [FC026: Conditional execution block attribute contains only string](http://acrmp.github.com/foodcritic/#FC026)
669
- rule added
670
- ([related issue](https://github.com/acrmp/foodcritic/issues/30)).
671
- Thanks to @mkocher for proposing this rule.
672
- - Foodcritic now accepts multiple cookbook paths as arguments and supports
673
- linting of individual files only. Big thanks to @cgriego for these changes.
674
- These lay the groundwork for his new
675
- [guard-foodcritic](https://github.com/cgriego/guard-foodcritic) project.
384
+ - [FC026: Conditional execution block attribute contains only string](http://acrmp.github.com/foodcritic/#FC026) rule added ([related issue](https://github.com/acrmp/foodcritic/issues/30)). Thanks to @mkocher for proposing this rule.
385
+ - Foodcritic now accepts multiple cookbook paths as arguments and supports linting of individual files only. Big thanks to @cgriego for these changes. These lay the groundwork for his new [guard-foodcritic](https://github.com/cgriego/guard-foodcritic) project.
676
386
 
677
387
  Bugfixes:
678
388
 
679
- - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003)
680
- would still warn if solo was checked for as a string
681
- ([related issue](https://github.com/acrmp/foodcritic/issues/26)).
682
- Thanks to @miketheman for identifying and fixing this issue.
683
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019)
684
- would warn when the node object had been re-opened for extension
685
- ([related issue](https://github.com/acrmp/foodcritic/issues/22)).
686
- Thanks @jaymzh.
687
- - [FC020: Conditional execution string attribute looks like Ruby](http://acrmp.github.com/foodcritic/#FC020)
688
- updated to not warn against strings that appear to contain file paths or Windows `net use`
689
- ([related issue](https://github.com/acrmp/foodcritic/issues/30)).
690
- Thanks @eherot and @mconigliaro.
691
- - [FC022: Resource condition within loop may not behave as expected](http://acrmp.github.com/foodcritic/#FC022)
692
- would warn incorrectly if the resource name was set directly to the block
693
- variable rather than being a string expression
694
- ([related issue](https://github.com/acrmp/foodcritic/issues/29)).
695
- Thanks @eherot.
696
- - The [resource_attributes](http://acrmp.github.com/foodcritic/#resource_attributes)
697
- API method has been updated to return the AST for resource notifications
698
- ([related issue](https://github.com/acrmp/foodcritic/issues/31)).
699
- Thanks @jonlives.
389
+ - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003) would still warn if solo was checked for as a string ([related issue](https://github.com/acrmp/foodcritic/issues/26)). Thanks to @miketheman for identifying and fixing this issue.
390
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) would warn when the node object had been re-opened for extension ([related issue](https://github.com/acrmp/foodcritic/issues/22)). Thanks @jaymzh.
391
+ - [FC020: Conditional execution string attribute looks like Ruby](http://acrmp.github.com/foodcritic/#FC020) updated to not warn against strings that appear to contain file paths or Windows `net use` ([related issue](https://github.com/acrmp/foodcritic/issues/30)). Thanks @eherot and @mconigliaro.
392
+ - [FC022: Resource condition within loop may not behave as expected](http://acrmp.github.com/foodcritic/#FC022) would warn incorrectly if the resource name was set directly to the block variable rather than being a string expression ([related issue](https://github.com/acrmp/foodcritic/issues/29)). Thanks @eherot.
393
+ - The [resource_attributes](http://acrmp.github.com/foodcritic/#resource_attributes) API method has been updated to return the AST for resource notifications ([related issue](https://github.com/acrmp/foodcritic/issues/31)). Thanks @jonlives.
700
394
 
701
395
  Other:
702
396
 
703
- - [Etsy have open-sourced their Foodcritic rules](https://github.com/etsy/foodcritic-rules).
704
- You should definitely check these out.
705
- - The effective Chef version for determining the rules to apply has been
706
- bumped to 0.10.10.
397
+ - [Etsy have open-sourced their Foodcritic rules](https://github.com/etsy/foodcritic-rules). You should definitely check these out.
398
+ - The effective Chef version for determining the rules to apply has been bumped to 0.10.10.
707
399
 
708
400
  ## 1.2.0 (21st April, 2012)
709
401
 
710
402
  Features:
711
403
 
712
- - [FC025: Prefer chef_gem to compile-time gem install](http://acrmp.github.com/foodcritic/#FC025)
713
- rule added.
714
- - Rules can now declare which versions of Chef they `apply_to`. The new
715
- command line argument `-c` (`--chef-version`) should be used to specify the
716
- effective Chef version.
404
+ - [FC025: Prefer chef_gem to compile-time gem install](http://acrmp.github.com/foodcritic/#FC025) rule added.
405
+ - Rules can now declare which versions of Chef they `apply_to`. The new command line argument `-c` (`--chef-version`) should be used to specify the effective Chef version.
717
406
 
718
407
  Bugfixes:
719
408
 
720
- - [FC001: Use strings in preference to symbols to access node attributes](http://acrmp.github.com/foodcritic/#FC001)
721
- could show false positives when using Chef search.
722
- - [FC001: Use strings in preference to symbols to access node attributes](http://acrmp.github.com/foodcritic/#FC001)
723
- would overlook the use of symbols to access node attributes when passing
724
- template variables.
725
- - [FC002: Avoid string interpolation where not required](http://acrmp.github.com/foodcritic/#FC002)
726
- fixed to no longer ignore the first keypair in a Hash
727
- ([related issue](https://github.com/acrmp/foodcritic/issues/24)).
728
- Thanks @Ips1975.
729
- - [FC004: Use a service resource to start and stop services](http://acrmp.github.com/foodcritic/#FC004)
730
- modified not to warn if the action is not supported by the `service`
731
- resource.
732
- - [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005)
733
- modified not to warn when resources are branched within conditionals or
734
- provider actions.
735
- - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://acrmp.github.com/foodcritic/#FC007)
736
- modified to ignore the use of `include_recipe` with embedded expressions.
737
- - [FC023: Prefer conditional attributes](http://acrmp.github.com/foodcritic/#FC023)
738
- modified not to warn if the conditional expression has an `else`.
739
- - The `resource_attributes` API method has been updated to return block
740
- attributes which were previously ignored
741
- ([related issue](https://github.com/acrmp/foodcritic/issues/23)).
742
- Thanks @jonlives.
409
+ - [FC001: Use strings in preference to symbols to access node attributes](http://acrmp.github.com/foodcritic/#FC001) could show false positives when using Chef search.
410
+ - [FC001: Use strings in preference to symbols to access node attributes](http://acrmp.github.com/foodcritic/#FC001) would overlook the use of symbols to access node attributes when passing template variables.
411
+ - [FC002: Avoid string interpolation where not required](http://acrmp.github.com/foodcritic/#FC002) fixed to no longer ignore the first keypair in a Hash ([related issue](https://github.com/acrmp/foodcritic/issues/24)). Thanks @Ips1975.
412
+ - [FC004: Use a service resource to start and stop services](http://acrmp.github.com/foodcritic/#FC004) modified not to warn if the action is not supported by the `service` resource.
413
+ - [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005) modified not to warn when resources are branched within conditionals or provider actions.
414
+ - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://acrmp.github.com/foodcritic/#FC007) modified to ignore the use of `include_recipe` with embedded expressions.
415
+ - [FC023: Prefer conditional attributes](http://acrmp.github.com/foodcritic/#FC023) modified not to warn if the conditional expression has an `else`.
416
+ - The `resource_attributes` API method has been updated to return block attributes which were previously ignored ([related issue](https://github.com/acrmp/foodcritic/issues/23)). Thanks @jonlives.
743
417
 
744
418
  ## 1.1.0 (25th March, 2012)
745
419
 
746
420
  Features:
747
421
 
748
- - [FC024: Consider adding platform equivalents](http://acrmp.github.com/foodcritic/#FC024) rule added.
749
- - When writing new rules it is no longer necessary to explicitly map
750
- matching AST nodes to matches. You can now just return the AST nodes.
422
+ - [FC024: Consider adding platform equivalents](http://acrmp.github.com/foodcritic/#FC024) rule added.
423
+ - When writing new rules it is no longer necessary to explicitly map matching AST nodes to matches. You can now just return the AST nodes.
751
424
 
752
425
  Bugfixes:
753
426
 
754
- - The `cookbook_name` method now reflects the cookbook name if specified in
755
- metadata. This prevents a warning from being shown by
756
- [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://acrmp.github.com/foodcritic/#FC007)
757
- if the cookbook is in a differently named directory.
758
- - The `declared_dependencies` method previously would intermix version strings
759
- in the list of cookbook names.
427
+ - The `cookbook_name` method now reflects the cookbook name if specified in metadata. This prevents a warning from being shown by [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://acrmp.github.com/foodcritic/#FC007) if the cookbook is in a differently named directory.
428
+ - The `declared_dependencies` method previously would intermix version strings in the list of cookbook names.
760
429
 
761
430
  Other:
762
431
 
763
- - Chef 0.10.10 will include a new DSL method for defining a `default_action`
764
- for resources. Rule
765
- [FC016: LWRP does not declare a default action](http://acrmp.github.com/foodcritic/#FC016)
766
- has been updated to recognise the DSL change.
767
- - Nokogiri dependency constraint changed to no longer lock to 1.5.0 as their
768
- next release should include the fix for custom XPath functions.
432
+ - Chef 0.10.10 will include a new DSL method for defining a `default_action` for resources. Rule [FC016: LWRP does not declare a default action](http://acrmp.github.com/foodcritic/#FC016) has been updated to recognise the DSL change.
433
+ - Nokogiri dependency constraint changed to no longer lock to 1.5.0 as their next release should include the fix for custom XPath functions.
769
434
 
770
435
  ## 1.0.1 (15th March, 2012)
771
436
 
772
437
  Bugfixes:
773
438
 
774
- - Nokogiri 1.5.1 and 1.5.2 cause a segfault so prevent their use until a fix
775
- is released
776
- ([related issue](https://github.com/acrmp/foodcritic/issues/18)).
777
- Thanks @miah.
439
+ - Nokogiri 1.5.1 and 1.5.2 cause a segfault so prevent their use until a fix is released ([related issue](https://github.com/acrmp/foodcritic/issues/18)). Thanks @miah.
778
440
 
779
441
  ## 1.0.0 (4th March, 2012)
780
442
 
781
443
  Features:
782
444
 
783
- - New `-I` option added to specify the path to your own custom rules
784
- ([related issue](https://github.com/acrmp/foodcritic/issues/8)).
785
- - The
786
- [Rule API](https://github.com/acrmp/foodcritic/blob/v1.0.0/lib/foodcritic/api.rb)
787
- was previously not supported and subject to change without warning. From
788
- this release it will now follow the
789
- [same versioning policy](http://docs.rubygems.org/read/chapter/7) as the
790
- command line interface.
791
- - A version flag (--version or -V) has been added ([related issue](https://github.com/acrmp/foodcritic/issues/16)).
445
+ - New `-I` option added to specify the path to your own custom rules ([related issue](https://github.com/acrmp/foodcritic/issues/8)).
446
+ - The [Rule API](https://github.com/acrmp/foodcritic/blob/v1.0.0/lib/foodcritic/api.rb) was previously not supported and subject to change without warning. From this release it will now follow the [same versioning policy](http://docs.rubygems.org/read/chapter/7) as the command line interface.
447
+ - A version flag (--version or -V) has been added ([related issue](https://github.com/acrmp/foodcritic/issues/16)).
792
448
 
793
449
  Bugfixes:
794
450
 
795
- - The evaluation of rule tags has been updated to be consistent with Cucumber.
796
- The major version number of foodcritic has been bumped to indicate that this
797
- is a breaking change. If you make use of tags (for example in a CI build)
798
- you may need to update your syntax. See the
799
- [related issue](https://github.com/acrmp/foodcritic/issues/11) for more
800
- information. Thanks @jaymzh.
801
- - [FC003: Check whether you are running with chef server before using
802
- server-specific features](http://acrmp.github.com/foodcritic/#FC003) has
803
- been updated to correctly identify the new version of chef-solo-search
804
- ([related issue](https://github.com/acrmp/foodcritic/issues/17)).
451
+ - The evaluation of rule tags has been updated to be consistent with Cucumber. The major version number of foodcritic has been bumped to indicate that this is a breaking change. If you make use of tags (for example in a CI build) you may need to update your syntax. See the [related issue](https://github.com/acrmp/foodcritic/issues/11) for more information. Thanks @jaymzh.
452
+ - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003) has been updated to correctly identify the new version of chef-solo-search ([related issue](https://github.com/acrmp/foodcritic/issues/17)).
805
453
 
806
454
  ## 0.11.1 (29th February, 2012)
807
455
 
808
456
  Bugfixes:
809
457
 
810
- - Foodcritic could fail to activate yajl-json in some circumstances, failing
811
- with a runtime error. Whether this occurred was dependent on the version of
812
- yajl-ruby activated by Chef, which would vary dependent on the other gems
813
- installed on the system. See the
814
- [related issue](https://github.com/acrmp/foodcritic/issues/14) for more
815
- information. Thanks @jaymzh for identifying the issue and striving to get
816
- Foodcritic playing well with Omnibus.
458
+ - Foodcritic could fail to activate yajl-json in some circumstances, failing with a runtime error. Whether this occurred was dependent on the version of yajl-ruby activated by Chef, which would vary dependent on the other gems installed on the system. See the [related issue](https://github.com/acrmp/foodcritic/issues/14) for more information. Thanks @jaymzh for identifying the issue and striving to get Foodcritic playing well with Omnibus.
817
459
 
818
460
  ## 0.11.0 (22nd February, 2012)
819
461
 
820
462
  Bugfixes:
821
463
 
822
- - Major bugfix to [FC006: Mode should be quoted or fully specified when setting file permissions](http://acrmp.github.com/foodcritic/#FC006). In earlier versions a four-digit literal file mode that set the first octet would not have been picked up by this rule ([related issue](https://github.com/acrmp/foodcritic/pull/9)). Thanks @aia for finding and fixing this bug. Check your cookbooks against FC006 after upgrading to see if you are affected.
464
+ - Major bugfix to [FC006: Mode should be quoted or fully specified when setting file permissions](http://acrmp.github.com/foodcritic/#FC006). In earlier versions a four-digit literal file mode that set the first octet would not have been picked up by this rule ([related issue](https://github.com/acrmp/foodcritic/pull/9)). Thanks @aia for finding and fixing this bug. Check your cookbooks against FC006 after upgrading to see if you are affected.
823
465
 
824
466
  ## 0.10.0 (20th February, 2012)
825
467
 
826
468
  Features:
827
469
 
828
- - Performance improvements.
829
- - [FC023: Prefer conditional attributes](http://acrmp.github.com/foodcritic/#FC023) rule added. Stolen from @ampledata with thanks.
830
- - New `-S` option added to allow an alternate search grammar to be specified.
470
+ - Performance improvements.
471
+ - [FC023: Prefer conditional attributes](http://acrmp.github.com/foodcritic/#FC023) rule added. Stolen from @ampledata with thanks.
472
+ - New `-S` option added to allow an alternate search grammar to be specified.
831
473
 
832
474
  Other:
833
475
 
834
- - Chef is no longer loaded at startup for performance reasons. Foodcritic now ships with Chef DSL metadata.
476
+ - Chef is no longer loaded at startup for performance reasons. Foodcritic now ships with Chef DSL metadata.
835
477
 
836
478
  ## 0.9.0 (26th January, 2012)
837
479
 
838
480
  Features:
839
481
 
840
- - New experimental `-C` option added to output context for rule matches.
841
- - [FC021: Resource condition in provider may not behave as expected](http://acrmp.github.com/foodcritic/#FC021) rule
842
- added.
843
- - [FC022: Resource condition within loop may not behave as expected](http://acrmp.github.com/foodcritic/#FC022) rule
844
- added.
482
+ - New experimental `-C` option added to output context for rule matches.
483
+ - [FC021: Resource condition in provider may not behave as expected](http://acrmp.github.com/foodcritic/#FC021) rule added.
484
+ - [FC022: Resource condition within loop may not behave as expected](http://acrmp.github.com/foodcritic/#FC022) rule added.
845
485
 
846
486
  Bugfixes:
847
487
 
848
- - [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005) rule modified to only
849
- warn when there are at least three *consecutive* resources of the same type that could be 'rolled up' into a loop.
850
- - [FC016: LWRP does not declare a default action](http://acrmp.github.com/foodcritic/#FC016) rule restored. Thanks @stevendanna
851
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) rule modified to no
852
- longer treat DSL mixin methods as auto-vivified attributes. Identification of least used access method should now be
853
- accurate.
488
+ - [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005) rule modified to only warn when there are at least three _consecutive_ resources of the same type that could be 'rolled up' into a loop.
489
+ - [FC016: LWRP does not declare a default action](http://acrmp.github.com/foodcritic/#FC016) rule restored. Thanks @stevendanna
490
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) rule modified to no longer treat DSL mixin methods as auto-vivified attributes. Identification of least used access method should now be accurate.
854
491
 
855
492
  Other:
856
493
 
857
- - [FC020: Conditional execution string attribute looks like Ruby](http://acrmp.github.com/foodcritic/#FC020) rule now
858
- grabs conditions from within single quotes.
494
+ - [FC020: Conditional execution string attribute looks like Ruby](http://acrmp.github.com/foodcritic/#FC020) rule now grabs conditions from within single quotes.
859
495
 
860
496
  ## 0.8.1 (20th January, 2012)
861
497
 
862
498
  Bugfixes:
863
499
 
864
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) modified
865
- to avoid false positives on methods invoked on values in a Mash.
500
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) modified to avoid false positives on methods invoked on values in a Mash.
866
501
 
867
502
  ## 0.8.0 (19th January, 2012)
868
503
 
869
504
  Features:
870
505
 
871
- - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) rule added.
872
- - [FC020: Conditional execution string attribute looks like Ruby](http://acrmp.github.com/foodcritic/#FC020) rule added.
506
+ - [FC019: Access node attributes in a consistent manner](http://acrmp.github.com/foodcritic/#FC019) rule added.
507
+ - [FC020: Conditional execution string attribute looks like Ruby](http://acrmp.github.com/foodcritic/#FC020) rule added.
873
508
 
874
509
  Other:
875
510
 
876
- - Rule 'FC016: LWRP does not declare a default action' was incorrectly checking the provider for a default action
877
- rather than the resource. Removed this rule temporarily to avoid showing false positives. A user has patched this
878
- and will be submitting a pull request shortly.
511
+ - Rule 'FC016: LWRP does not declare a default action' was incorrectly checking the provider for a default action rather than the resource. Removed this rule temporarily to avoid showing false positives. A user has patched this and will be submitting a pull request shortly.
879
512
 
880
513
  ## 0.7.0 (31st December, 2011)
881
514
 
882
515
  Features:
883
516
 
884
- - New `-f` option added to allow you to specify which warnings should result in the build being failed. See the new
885
- documentation on [using Foodcritic in Continuous Integration](http://acrmp.github.com/foodcritic/#ci) for more
886
- information.
887
- - New `-r` option added to drop you into the Pry REPL to interactively develop rules. See the updated documentation on
888
- [Writing a new rule](http://acrmp.github.com/foodcritic/#writing-a-new-rule) for more information.
517
+ - New `-f` option added to allow you to specify which warnings should result in the build being failed. See the new documentation on [using Foodcritic in Continuous Integration](http://acrmp.github.com/foodcritic/#ci) for more information.
518
+ - New `-r` option added to drop you into the Pry REPL to interactively develop rules. See the updated documentation on [Writing a new rule](http://acrmp.github.com/foodcritic/#writing-a-new-rule) for more information.
889
519
 
890
520
  Bugfixes:
891
521
 
892
- - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003) rule
893
- modified to not warn if the [edelight chef-solo-search library](https://github.com/edelight/chef-solo-search) has been installed. Thanks @tobami.
894
- - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://acrmp.github.com/foodcritic/#FC007) rule
895
- modified to flag undeclared dependencies against the offending file rather than metadata.rb.
896
- - Removed the unused description field from the rule dsl.
522
+ - [FC003: Check whether you are running with chef server before using server-specific features](http://acrmp.github.com/foodcritic/#FC003) rule modified to not warn if the [edelight chef-solo-search library](https://github.com/edelight/chef-solo-search) has been installed. Thanks @tobami.
523
+ - [FC007: Ensure recipe dependencies are reflected in cookbook metadata](http://acrmp.github.com/foodcritic/#FC007) rule modified to flag undeclared dependencies against the offending file rather than metadata.rb.
524
+ - Removed the unused description field from the rule dsl.
897
525
 
898
526
  Other:
899
527
 
900
- - Project features now run much faster, running in-process by default. You can set an environment variable
901
- (`FC_FORK_PROCESS`) to specify that Cucumber runs should match the earlier behaviour and spawn a separate process
902
- using Aruba.
528
+ - Project features now run much faster, running in-process by default. You can set an environment variable (`FC_FORK_PROCESS`) to specify that Cucumber runs should match the earlier behaviour and spawn a separate process using Aruba.
903
529
 
904
530
  ## 0.6.0 (18th December, 2011)
905
531
 
906
532
  Features:
907
533
 
908
- - [FC001: Use strings in preference to symbols to access node attributes](http://acrmp.github.com/foodcritic/#FC001)
909
- rule added.
910
- - [FC004: Use a service resource to start and stop services](http://acrmp.github.com/foodcritic/#FC004) rule extended
911
- to recognise upstart and invoke-rc.d.
912
- - [FC011: Missing README in markdown format](http://acrmp.github.com/foodcritic/#FC011) rule added.
913
- - [FC012: Use Markdown for README rather than RDoc](http://acrmp.github.com/foodcritic/#FC012) rule added.
914
- - [FC013: Use file_cache_path rather than hard-coding tmp paths ](http://acrmp.github.com/foodcritic/#FC013) rule added.
915
- - [FC014: Consider extracting long ruby_block to library](http://acrmp.github.com/foodcritic/#FC014) rule added.
916
- - [FC015: Consider converting definition to a LWRP](http://acrmp.github.com/foodcritic/#FC015) rule added.
917
- - [FC016: LWRP does not declare a default action](http://acrmp.github.com/foodcritic/#FC016) rule added.
918
- - [FC017: LWRP does not notify when updated](http://acrmp.github.com/foodcritic/#FC017) rule added.
919
- - [FC018: LWRP uses deprecated notification syntax](http://acrmp.github.com/foodcritic/#FC018) rule added.
534
+ - [FC001: Use strings in preference to symbols to access node attributes](http://acrmp.github.com/foodcritic/#FC001) rule added.
535
+ - [FC004: Use a service resource to start and stop services](http://acrmp.github.com/foodcritic/#FC004) rule extended to recognise upstart and invoke-rc.d.
536
+ - [FC011: Missing README in markdown format](http://acrmp.github.com/foodcritic/#FC011) rule added.
537
+ - [FC012: Use Markdown for README rather than RDoc](http://acrmp.github.com/foodcritic/#FC012) rule added.
538
+ - [FC013: Use file_cache_path rather than hard-coding tmp paths](http://acrmp.github.com/foodcritic/#FC013) rule added.
539
+ - [FC014: Consider extracting long ruby_block to library](http://acrmp.github.com/foodcritic/#FC014) rule added.
540
+ - [FC015: Consider converting definition to a LWRP](http://acrmp.github.com/foodcritic/#FC015) rule added.
541
+ - [FC016: LWRP does not declare a default action](http://acrmp.github.com/foodcritic/#FC016) rule added.
542
+ - [FC017: LWRP does not notify when updated](http://acrmp.github.com/foodcritic/#FC017) rule added.
543
+ - [FC018: LWRP uses deprecated notification syntax](http://acrmp.github.com/foodcritic/#FC018) rule added.
920
544
 
921
545
  Bugfixes:
922
546
 
923
- - Ensure warnings are line sorted numerically. Commit eb1762fd0fbf99fa513783d7838ceac0147c37bc
924
- - [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005) rule made less aggressive.
547
+ - Ensure warnings are line sorted numerically. Commit eb1762fd0fbf99fa513783d7838ceac0147c37bc
548
+ - [FC005: Avoid repetition of resource declarations](http://acrmp.github.com/foodcritic/#FC005) rule made less aggressive.
925
549
 
926
550
  ## 0.5.2 (15th December, 2011)
927
551
 
928
552
  Bugfixes:
929
553
 
930
- - Fix JSON version range for compatibility with Bundler / Chef 0.10.6. ([related issue](https://github.com/acrmp/foodcritic/issues/6)). Thanks @dysinger.
554
+ - Fix JSON version range for compatibility with Bundler / Chef 0.10.6\. ([related issue](https://github.com/acrmp/foodcritic/issues/6)). Thanks @dysinger.
931
555
 
932
556
  ## 0.5.1 (14th December, 2011)
933
557
 
934
558
  Features:
935
559
 
936
- - Relaxed Ruby version constraint so we can run on 1.9.2 ([related issue](https://github.com/acrmp/foodcritic/issues/5)). Yay. Thanks @someara.
560
+ - Relaxed Ruby version constraint so we can run on 1.9.2 ([related issue](https://github.com/acrmp/foodcritic/issues/5)). Yay. Thanks @someara.
937
561
 
938
562
  ## 0.5.0 (13th December, 2011)
939
563
 
940
564
  Features:
941
565
 
942
- - Added the ability to choose rules to apply via tags ([related issue](https://github.com/acrmp/foodcritic/issues/4)).
943
- This uses the same syntax as [Cucumber tag expressions](https://github.com/cucumber/cucumber/wiki/tags).
944
- - [FC010: Invalid search syntax](http://acrmp.github.com/foodcritic/#FC010) rule added.
566
+ - Added the ability to choose rules to apply via tags ([related issue](https://github.com/acrmp/foodcritic/issues/4)). This uses the same syntax as [Cucumber tag expressions](https://github.com/cucumber/cucumber/wiki/tags).
567
+ - [FC010: Invalid search syntax](http://acrmp.github.com/foodcritic/#FC010) rule added.
945
568
 
946
569
  ## 0.4.0 (10th December, 2011)
947
570
 
948
571
  Features:
949
572
 
950
- - [Spiffy new home page and documentation](http://acrmp.github.com/foodcritic/)
951
- - [FC008: Generated cookbook metadata needs updating](http://acrmp.github.com/foodcritic/#FC008) rule added.
952
- - [FC009: Resource attribute not recognised rule added](http://acrmp.github.com/foodcritic/#FC009).
953
- This adds a dependency on the Chef gem.
954
- - Performance improvement.
573
+ - [Spiffy new home page and documentation](http://acrmp.github.com/foodcritic/)
574
+ - [FC008: Generated cookbook metadata needs updating](http://acrmp.github.com/foodcritic/#FC008) rule added.
575
+ - [FC009: Resource attribute not recognised rule added](http://acrmp.github.com/foodcritic/#FC009). This adds a dependency on the Chef gem.
576
+ - Performance improvement.
955
577
 
956
578
  Bugfixes:
957
579
 
958
- - Fixed typo in FC004 feature description ([related issue](https://github.com/acrmp/foodcritic/issues/2)). Thanks @smith.
959
- - Prevented statements within nested resource blocks from being interpreted as resource attributes.
580
+ - Fixed typo in FC004 feature description ([related issue](https://github.com/acrmp/foodcritic/issues/2)). Thanks @smith.
581
+ - Prevented statements within nested resource blocks from being interpreted as resource attributes.
960
582
 
961
583
  ## 0.3.0 (4th December, 2011)
962
584
 
963
585
  Features:
964
586
 
965
- - Significantly slower! But now you can write rules using [xpath or css selectors](http://nokogiri.org/).
966
- - FC006: File mode rule added.
967
- - FC007: Undeclared recipe dependencies rule added.
587
+ - Significantly slower! But now you can write rules using [xpath or css selectors](http://nokogiri.org/).
588
+ - FC006: File mode rule added.
589
+ - FC007: Undeclared recipe dependencies rule added.
968
590
 
969
591
  ## 0.2.0 (1st December, 2011)
970
592
 
971
593
  Bugfixes:
972
594
 
973
- - Removed 'FC001: Use symbols in preference to strings to access node attributes' until a policy mechanism is
974
- introduced ([related issue](https://github.com/acrmp/foodcritic/issues/1)). Thanks @jtimberman
595
+ - Removed 'FC001: Use symbols in preference to strings to access node attributes' until a policy mechanism is introduced ([related issue](https://github.com/acrmp/foodcritic/issues/1)). Thanks @jtimberman
975
596
 
976
597
  ## 0.1.0 (30th November, 2011)
977
598