foodcritic 4.0.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d4e873dc6e071eb72a49fc84c1fa537425bfabb
-  data.tar.gz: e7eb57ee447bcfd2addf994d496f04f87c49cc5b
+  metadata.gz: 457c24aef4f9d97251b4e3d5de85d8c8493b03ed
+  data.tar.gz: 1c95919076ec046db9a2ee277e050876c7c4e8c5
 SHA512:
-  metadata.gz: 6499f3688277afd2f4bf8775e23622403161b3b4234509618a5931e8e73a8b3e8c97d3e2ad46275ddd2cca57b58ab38c33107bc93dfab3063ae1d8d84c5a2ecb
-  data.tar.gz: f7640240d2b5f7d6ece42ef5a29cdd0fb4443d1d0645880a748a6c5c0914b685fe967ea385657ce3595dc8e47fb2d651412714a498a7c29e71d4d2596004bbb9
+  metadata.gz: 2eb8bbe9158ef5e84534156af51014e39987b999ffee168a9d6f77f9baaf4686026860d936f091d6bafe9bf8d26e63a00c5558d17f3b8e043a8c06d497deba1e
+  data.tar.gz: 20a2cce77e1c649d4fb511dc5a3a2ef1efea38593b5fccce0f5b472c423d8fcfa981ad05fa8989353ebb3fb3ee15ec1c85a40342f6ad4acd9463750a946dee89

data/CHANGELOG.md

@@ -1,3 +1,50 @@
+## Unreleased
+
+Features:
+
+  - DSL metadata updated for Chef 11.18.x and up to Chef 12.4.1.
+  ([related issue](https://github.com/acrmp/foodcritic/issues/362)).
+  - Set default `chef_version` to 12.4.1
+  ([related issue](https://github.com/acrmp/foodcritic/pull/364)).
+  - add warnings for use of recommends/suggests.
+  ([related issue](https://github.com/acrmp/foodcritic/pull/309)).
+  - Show progress with --progress
+  ([related issue](https://github.com/acrmp/foodcritic/pull/244)).
+  - Added -l option to list enabled rules and descriptions
+  ([related issue](https://github.com/acrmp/foodcritic/pull/285)).
+
+Bugfixes:
+
+  - Fixed `node.force_default` and `node.force_override` along with many other methods on Chef::Node::Attribute that
+  `Chef::Node#method_missing` was forwarding methods to.
+  ([related issue](https://github.com/acrmp/foodcritic/pull/364)).
+  - merge default options before check instead of during intialization (in Rake task)
+    ([related issue](https://github.com/acrmp/foodcritic/pull/321)).
+  - Fix UTF-8 errors in template checking
+    ([related issue](https://github.com/acrmp/foodcritic/pull/317)).
+  - Make FC041 smarter about CURL usage
+    ([related issue](https://github.com/acrmp/foodcritic/pull/313)).
+  - pinned moustache gem to 0.99 for ruby 1.9.3 compatibility
+    Thanks @jdmundrawala
+  - Added metadata for missing Chef 11 versions. 
+    Thanks @jdmundrawala
+  - [FC044: Avoid bare attribute keys](http://acrmp.github.com/foodcritic/#FC044) would fire on parameterized attributes.
+    Thanks @odcinek
+  - [FC048: Prefer Mixlib::ShellOut](http://foodcritic.io/#FC048) would false positive on system attribute of user resource.
+    Thanks @odcinek
+  - Handle flagging binary files properly.
+    Thanks @odcinek
+  - [FC002: Avoid string interpolation where not required](http://acrmp.github.com/foodcritic/#FC002) would erroneously trigger on heredoc on ruby 2.2
+    Thanks @ryansouza and @odcinek
+
+Other:
+
+  - 1.9.3 is removed from the travis matrix and no longer supported
+    ([related issue](https://github.com/acrmp/foodcritic/pull/315)).
+  - 1.9.3 compat is removed from the gemspec (v4.0.0 will be the last version that will install on 1.9.3)
+    ([related issue](https://github.com/acrmp/foodcritic/pull/377)).
+  - removed cookbooks no longer present in the chef-cookbooks repo from regression tests
+
 ## 4.0.0 (12th June, 2014)
 
 Features:

data/README.md

@@ -1,9 +1,11 @@
-# Food Critic
+# Foodcritic
+[![Build Status](https://travis-ci.org/acrmp/foodcritic.svg?branch=master)](https://travis-ci.org/acrmp/foodcritic)
+[![Gem Version](https://badge.fury.io/rb/foodcritic.svg)](http://badge.fury.io/rb/foodcritic)
 
-Food Critic is a lint tool for Chef cookbooks. It requires Ruby 1.9.3+.
+Foodcritic is a lint tool for Chef cookbooks. It requires Ruby 2.0.0+.
 
 # Homepage
-[http://acrmp.github.com/foodcritic/](http://acrmp.github.com/foodcritic/)
+[http://foodcritic.io/](http://foodcritic.io/)
 
 # Building
 
@@ -11,16 +13,14 @@ Food Critic is a lint tool for Chef cookbooks. It requires Ruby 1.9.3+.
     $ bundle exec rake
 
 # Continuous Integration
-[Food Critic on Travis CI](http://travis-ci.org/acrmp/foodcritic)
-
-![Built on Travis](https://secure.travis-ci.org/acrmp/foodcritic.png?branch=master)
+[Foodcritic on Travis CI](http://travis-ci.org/acrmp/foodcritic)
 
 # License
 MIT - see the accompanying [LICENSE](https://github.com/acrmp/foodcritic/blob/master/LICENSE) file for details.
 
 # Changelog
 To see what has changed in recent versions see the [CHANGELOG](https://github.com/acrmp/foodcritic/blob/master/CHANGELOG.md).
-Food Critic follows the [Rubygems RationalVersioningPolicy](http://docs.rubygems.org/read/chapter/7).
+Foodcritic follows the [Rubygems Semantic Versioning Policy](http://guides.rubygems.org/patterns/#semantic-versioning).
 
 # Contributing
 Additional [rules](http://acrmp.github.com/foodcritic/#writing-a-new-rule) and bugfixes are welcome! Please fork and

data/bin/foodcritic

@@ -2,7 +2,7 @@
 require_relative '../lib/foodcritic'
 module FoodCritic
   cmd_line = CommandLine.new(ARGV)
-  review, status = Linter.check(cmd_line)
+  review, status = Linter.run(cmd_line)
   printer = cmd_line.show_context? ? ContextOutput.new : SummaryOutput.new
   printer.output(review)
   exit status.to_i

data/chef_dsl_metadata/chef_11.0.0.json

@@ -51,6 +51,8 @@
     "extend",
     "filename_to_qualified_string",
     "for_json",
+    "force_default",
+    "force_override",
     "freeze",
     "from_file",
     "frozen?",
@@ -193,6 +195,8 @@
     "extend",
     "filename_to_qualified_string",
     "for_json",
+    "force_default",
+    "force_override",
     "freeze",
     "from_file",
     "frozen?",

data/chef_dsl_metadata/chef_11.10.0.json

@@ -67,6 +67,7 @@
     "instance_variable_set",
     "instance_variables",
     "is_a?",
+    "itself",
     "key?",
     "keys",
     "kind_of?",
@@ -155,56 +156,112 @@
     "===",
     "=~",
     "[]",
+    "[]=",
     "__id__",
     "__send__",
+    "all?",
+    "any?",
     "apply_expansion_attributes",
+    "assoc",
     "attribute",
     "attribute?",
     "attributes",
+    "automatic",
+    "automatic=",
     "automatic_attrs",
     "automatic_attrs=",
     "chef_environment",
     "chef_environment=",
     "chef_server_rest",
+    "chunk",
     "class",
     "class_from_file",
+    "clear",
     "clone",
+    "collect",
+    "collect_concat",
+    "combined_default",
+    "combined_override",
+    "compare_by_identity",
+    "compare_by_identity?",
     "construct_attributes",
     "consume_attributes",
     "consume_external_attrs",
     "consume_run_list",
     "convert_to_class_name",
     "convert_to_snake_case",
+    "count",
     "create",
+    "cycle",
+    "debug_value",
     "default",
     "default!",
+    "default=",
     "default_attrs",
     "default_attrs=",
+    "default_proc",
+    "default_proc=",
     "default_unless",
     "define_singleton_method",
+    "delete",
+    "delete_if",
     "destroy",
+    "detect",
     "display",
     "display_hash",
+    "drop",
+    "drop_while",
     "dup",
     "each",
     "each_attribute",
+    "each_cons",
+    "each_entry",
     "each_key",
+    "each_pair",
+    "each_slice",
     "each_value",
+    "each_with_index",
+    "each_with_object",
+    "empty?",
+    "entries",
     "enum_for",
+    "env_default",
+    "env_default=",
+    "env_override",
+    "env_override=",
     "environment",
     "eql?",
     "equal?",
+    "except",
     "expand!",
     "extend",
+    "fetch",
     "filename_to_qualified_string",
+    "find",
+    "find_all",
+    "find_index",
+    "first",
+    "flat_map",
+    "flatten",
     "for_json",
+    "force_default",
+    "force_default=",
+    "force_override",
+    "force_override=",
     "freeze",
     "from_file",
     "frozen?",
     "gem",
+    "grep",
+    "group_by",
     "has_key?",
+    "has_value?",
     "hash",
+    "immutablize",
+    "include?",
     "include_attribute",
+    "index",
+    "inject",
     "inspect",
     "instance_eval",
     "instance_exec",
@@ -213,29 +270,50 @@
     "instance_variable_get",
     "instance_variable_set",
     "instance_variables",
+    "invert",
     "is_a?",
+    "itself",
+    "keep_if",
+    "key",
     "key?",
     "keys",
     "kind_of?",
     "lazy",
+    "length",
     "loaded_recipe",
+    "map",
+    "max",
+    "max_by",
+    "member?",
+    "merge",
+    "merge!",
+    "merged_attributes",
     "method",
     "method_missing",
     "methods",
+    "min",
+    "min_by",
+    "minmax",
+    "minmax_by",
     "name",
     "nil?",
     "node",
+    "none?",
     "normal",
+    "normal=",
     "normal_attrs",
     "normal_attrs=",
     "normal_unless",
     "object_id",
+    "one?",
     "override",
     "override!",
+    "override=",
     "override_attrs",
     "override_attrs=",
     "override_unless",
     "parse_attribute_file_spec",
+    "partition",
     "platform?",
     "platform_family?",
     "pretty_inspect",
@@ -249,13 +327,28 @@
     "public_method",
     "public_methods",
     "public_send",
+    "rassoc",
     "recipe?",
     "recipe_list",
     "recipe_list=",
+    "reduce",
+    "regular_update",
+    "regular_writer",
+    "rehash",
+    "reject",
+    "reject!",
     "remove_instance_variable",
+    "replace",
+    "reset",
+    "reset_cache",
     "reset_defaults_and_overrides",
     "respond_to?",
+    "reverse_each",
     "role?",
+    "role_default",
+    "role_default=",
+    "role_override",
+    "role_override=",
     "run_context",
     "run_context=",
     "run_list",
@@ -264,34 +357,58 @@
     "run_state",
     "run_state=",
     "save",
+    "select",
+    "select!",
     "send",
     "set",
     "set_or_return",
     "set_unless",
+    "set_unless?",
+    "set_unless_value_present=",
+    "shift",
     "singleton_class",
     "singleton_method",
     "singleton_methods",
+    "size",
+    "slice_after",
+    "slice_before",
+    "slice_when",
     "snake_case_basename",
+    "sort",
+    "sort_by",
+    "store",
+    "stringify_keys!",
+    "symbolize_keys",
     "systemu",
     "tag",
     "tags",
     "taint",
     "tainted?",
+    "take",
+    "take_while",
     "tap",
+    "to_a",
     "to_enum",
+    "to_h",
     "to_hash",
     "to_json",
     "to_s",
+    "to_set",
     "to_yaml",
     "to_yaml_properties",
     "trust",
     "untaint",
     "untrust",
     "untrusted?",
+    "update",
     "update_from!",
     "validate",
+    "value?",
     "value_for_platform",
-    "value_for_platform_family"
+    "value_for_platform_family",
+    "values",
+    "values_at",
+    "zip"
   ],
   "actions": {
     "apt_package": [
@@ -721,6 +838,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -889,6 +1007,7 @@
       "interpreter",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -1060,6 +1179,7 @@
       "is",
       "is_a?",
       "is_i386_windows_process?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -1222,6 +1342,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -1381,6 +1502,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -1535,6 +1657,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -1705,6 +1828,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -1871,6 +1995,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -2040,6 +2165,7 @@
       "interpreter",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -2216,6 +2342,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "keep_releases",
       "kind_of?",
       "lazy",
@@ -2413,6 +2540,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "keep_releases",
       "kind_of?",
       "lazy",
@@ -2610,6 +2738,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "keep_releases",
       "kind_of?",
       "lazy",
@@ -2792,6 +2921,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -2951,6 +3081,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -3111,6 +3242,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -3273,6 +3405,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "key_name",
       "kind_of?",
       "lazy",
@@ -3431,6 +3564,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -3592,6 +3726,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -3760,6 +3895,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -3920,6 +4056,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -4080,6 +4217,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -4247,6 +4385,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -4416,6 +4555,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -4574,6 +4714,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -4734,6 +4875,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -4895,6 +5037,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -5057,6 +5200,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "link_type",
@@ -5218,6 +5362,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "level",
@@ -5373,6 +5518,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -5536,6 +5682,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "level",
@@ -5698,6 +5845,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -5857,6 +6005,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -6011,6 +6160,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -6170,6 +6320,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -6338,6 +6489,7 @@
       "interpreter",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -6496,6 +6648,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -6668,6 +6821,7 @@
       "is",
       "is_a?",
       "is_i386_windows_process?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -6839,6 +6993,7 @@
       "interpreter",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -6998,6 +7153,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "key",
       "kind_of?",
       "lazy",
@@ -7163,6 +7319,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -7337,6 +7494,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -7507,6 +7665,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -7666,6 +7825,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -7834,6 +7994,7 @@
       "interpreter",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -7994,6 +8155,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -8153,6 +8315,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -8325,6 +8488,7 @@
       "interpreter",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -8485,6 +8649,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -8648,6 +8813,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -8807,6 +8973,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -8966,6 +9133,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -9131,6 +9299,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -9310,6 +9479,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -9491,6 +9661,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "keep_releases",
       "kind_of?",
       "lazy",
@@ -9674,6 +9845,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -9836,6 +10008,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -10002,6 +10175,7 @@
       "is",
       "is_a?",
       "is_i386_windows_process?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",
@@ -10167,6 +10341,7 @@
       "instance_variables",
       "is",
       "is_a?",
+      "itself",
       "kind_of?",
       "lazy",
       "load_prior_resource",