foodcritic 13.0.0 → 13.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 739fc9f5acc20cfab79ae4174106deb6a1826d49b0b9765f4637ef3fd2087f77
-  data.tar.gz: aeccbfab2ce840a61664b2a9dd6057ba325a09b7c85938c32f6f803d5660e6d2
+  metadata.gz: 4043ba45f55c8b88b96eeb28ecb5111dd92e98ba45d1c74dc3ca86bc92c57cdc
+  data.tar.gz: 2f9bd70e42c3cbdec213e727c33b568d21ed72578dca8a173110f2944375d1e6
 SHA512:
-  metadata.gz: d032449a47b49bb875c3ec04f693dfd7d88ef3575ea21842d50931592a6a3847568fc4ea55660f629d51c04380c3882e7a4159c8626c8e30cf7820151953b4cd
-  data.tar.gz: 8c7e61eb1f449259f65ec08b72958089e92ccc8600071540c637c2f5415cb1361405f81d4e4008d75943c789edb35dc3d80f7f0172c5e002df97019464a40974
+  metadata.gz: d7d07e5748a0a19265b0d26d7347d07e90d79bd1aff1565c1c210501f1f29205e7d433cdeeea5646bdb2793e1517f78b76134639e2bab5add1433e161a65f2de
+  data.tar.gz: c17b5b064688c41d3a397202314df1938f549071dc07d1f368e730e5f795f73626d8e958524931bdf45b8d0523ce94f236c77814cd1196d5651f3d8edd3c5f85

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Foodcritic Changelog:
 
+## [13.0.1](https://github.com/Foodcritic/foodcritic/tree/v13.0.1) (2018-04-11)
+
+- Properly discover templates not in templates/default/. Templates in the root of the templates directory would be skipped previously
+- Force encoding to UTF8 to prevent errors when encoding isn't set on the host
+- Alert with the filename when an improperly encoded file is encountered instead of silently failing
+- Removed the chef13 tag from FC085
+
 ## [13.0.0](https://github.com/Foodcritic/foodcritic/tree/v13.0.0) (2018-03-07)
 
 ### Chef 12 Support

data/lib/foodcritic.rb

@@ -1,3 +1,6 @@
+Encoding.default_external = Encoding::UTF_8
+Encoding.default_internal = Encoding::UTF_8
+
 require "pathname"
 require "cucumber/core"
 require "treetop"

data/lib/foodcritic/api.rb

@@ -557,7 +557,11 @@ module FoodCritic
                else
                  File.read(file).encode("utf-8", "binary", :undef => :replace)
                end
-      build_xml(Ripper::SexpBuilder.new(source).parse)
+      begin
+        build_xml(Ripper::SexpBuilder.new(source).parse)
+      rescue RuntimeError => e # this generally means bad encoding
+        raise "Could not parse the file at #{file}. #{e}"
+      end
     end
 
     # XPath custom function

data/lib/foodcritic/linter.rb

@@ -242,8 +242,10 @@ module FoodCritic
       end
     end
 
-    # Return the files within a cookbook tree that we are interested in trying
-    # to match rules against.
+    # Return the files within a cookbook tree that we are interested in trying to match rules against.
+    #
+    # @param [Hash] paths - paths of interest: {:exclude=>[], :cookbook=>[], :role=>[], :environment=>[]}
+    # @return [Array] array of hashes for each file {:filename=>"./metadata.rb", :path_type=>:cookbook}
     def files_to_process(paths)
       paths.reject { |type, _| type == :exclude }.map do |path_type, dirs|
         dirs.map do |dir|
@@ -258,7 +260,7 @@ module FoodCritic
           if File.directory?(dir)
             glob = if path_type == :cookbook
                      "{metadata.rb,attributes.rb,recipe.rb,{attributes,definitions,libraries,"\
-                     "providers,recipes,resources}/*.rb,templates/*/*.erb}"
+                     "providers,recipes,resources}/*.rb,templates/**/*.erb}"
                    else
                      "*.rb"
                    end

data/lib/foodcritic/rules/fc085.rb

@@ -1,5 +1,5 @@
 rule "FC085", "Resource using new_resource.updated_by_last_action to converge resource" do
-  tags %w{chef13 deprecated}
+  tags %w{correctness}
   def updated_by(ast)
     # we need to handle both @new_resource.updated_by_last_action(true) or new_resource.updated_by_last_action(true)
     # Here's the ast that xpath sees in all 3 possible scenarios from those two:

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "13.0.0"
+  VERSION = "13.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 13.0.0
+  version: 13.0.1
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-08 00:00:00.000000000 Z
+date: 2018-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -548,5 +548,5 @@ rubyforge_project:
 rubygems_version: 2.7.5
 signing_key: 
 specification_version: 4
-summary: foodcritic-13.0.0
+summary: foodcritic-13.0.1
 test_files: []