foodcritic 12.2.2 → 12.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 4cca4b9220b37c61b2a6787963597afc99c36c91
-  data.tar.gz: 3efa091b16afb38ed2ba05425ac378ca410cb450
+SHA256:
+  metadata.gz: d2c822721f854188805664e8d9d8402c276d7bf107206e82efbc3dd182913b4d
+  data.tar.gz: 906e425bf8eb50f982a17d6b94e7295caa8ec55b61ad247fb6922fd12907e9f1
 SHA512:
-  metadata.gz: 22978558516fe2c9f8880ccd148155070d88ae8457c4861bf13b8963dcacd5a8dc12c85f4de74bedb564611765c3f980703365826bb3e45da6ab38a0c1b93df6
-  data.tar.gz: 46a58bedda591bf9ab373b56229d76173b11b4a8b5e7173b8b4eda45799616e02df3d090448ce376079d7d3763504092d0ef6a57c4cd257aa1aa3a1f4f381c8c
+  metadata.gz: 9a5bb0f99a420531ec5cc5d413fb9c7c9838e6eb9f369c03f2b544fd7361fd53cfc01b1482a511df2497f2616e49b463cf558032144495c8eed89754770bdc5b
+  data.tar.gz: 9d68253b11de0c814ffb4120e133779149b4f9670e7c3b2206ae3c0893d18cd627e1d612f47cbb9b6d6077a1b1315e7d9cced6a69e4bb6de2ec209903d64f61f

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Foodcritic Changelog:
 
+## [12.3.0](https://github.com/Foodcritic/foodcritic/tree/v12.3.0) (2018-01-18)
+
+**Implemented enhancements:**
+
+- Removed FC017, FC057, and FC059 as use_inline_resources is the default in Chef 13 and no longer required
+- Added FC110: Script resources should use 'code' property not 'command' property
+- Added FC111: search using deprecated sort flag
+- Added FC112 Resource using deprecated dsl_name method
+- Added FC113 Resource declares deprecated use_inline_resources
+- Added FC114 Cookbook uses legacy Ohai config syntax
+- Extended the find_resources method to allow accepting an array of resource names not just a single resource name
+
 ## [12.2.2](https://github.com/Foodcritic/foodcritic/tree/v12.2.2) (2017-12-13)
 
 **Fixed bugs:**

data/features/step_definitions/cookbook_steps.rb

@@ -1618,11 +1618,6 @@ Then "the execute resource used to run git commands warning 040 should be displa
   expect_warning "FC040", { :line => 7 }
 end
 
-Then /^the LWRP does not notify when updated warning 017 should( not)? be shown against the :([^ ]+) action$/ do |not_shown, action|
-  line = action == "create" ? 1 : 8
-  expect_warning("FC017", :file_type => :provider, :expect_warning => ! not_shown, :line => line)
-end
-
 Then /^the invalid (role|environment) name warning 050 should( not)? be shown$/ do |type, not_shown|
   file = type == "role" ? "roles/webserver.rb" : "environments/production.rb"
   expect_warning "FC050", { :expect_warning => ! not_shown, :file => file }

data/features/support/command_helpers.rb

@@ -17,7 +17,6 @@ module FoodCritic
     WARNINGS = {
       "FC001" => "Use strings in preference to symbols to access node attributes",
       "FC002" => "Avoid string interpolation where not required",
-      # FC003 was yanked and is considered reserved, do not reuse it
       "FC004" => "Use a service resource to start and stop services",
       "FC005" => "Avoid repetition of resource declarations",
       "FC006" => "Mode should be quoted or fully specified when setting file permissions",
@@ -31,12 +30,10 @@ module FoodCritic
       "FC014" => "Consider extracting long ruby_block to library",
       "FC015" => "Consider converting definition to a Custom Resource",
       "FC016" => "LWRP does not declare a default action",
-      "FC017" => "LWRP does not notify when updated",
       "FC018" => "LWRP uses deprecated notification syntax",
       "FC019" => "Access node attributes in a consistent manner",
       "FC021" => "Resource condition in provider may not behave as expected",
       "FC022" => "Resource condition within loop may not behave as expected",
-      # FC023 was yanked and is considered reserved, do not reuse it
       "FC024" => "Consider adding platform equivalents",
       "FC025" => "Prefer chef_gem to compile-time gem install",
       "FC026" => "Conditional execution block attribute contains only string",
@@ -65,12 +62,9 @@ module FoodCritic
       "FC051" => "Template partials loop indefinitely",
       "FC052" => 'Metadata uses the deprecated "suggests" keyword',
       "FC053" => 'Metadata uses the deprecated "recommends" keyword',
-      # FC054 was yanked and is considered reserved, do not reuse it
       "FC055" => "Ensure maintainer is set in metadata",
       "FC056" => "Ensure maintainer_email is set in metadata",
-      "FC057" => "Library provider does not declare use_inline_resources",
       "FC058" => "Library provider declares use_inline_resources and declares #action_<name> methods",
-      "FC059" => "LWRP provider does not declare use_inline_resources",
       "FC060" => "LWRP provider declares use_inline_resources and declares #action_<name> methods",
       "FC061" => "Valid cookbook versions are of the form x.y or x.y.z",
       "FC062" => "Cookbook should have version metadata",

data/lib/foodcritic/api.rb

@@ -179,17 +179,21 @@ module FoodCritic
     # These are equivalent:
     #
     #     find_resources(ast)
-    #     find_resources(ast, :type => :any)
+    #     find_resources(ast, type: :any)
     #
-    # Restrict to a specific type of resource:
+    # Restrict to a specific type of resource(s):
     #
-    #     find_resources(ast, :type => :service)
+    #     find_resources(ast, type: 'service')
+    #     find_resources(ast, type: %w(service file))
     #
     def find_resources(ast, options = {})
       options = { type: :any }.merge!(options)
       return [] unless ast.respond_to?(:xpath)
       scope_type = ""
-      scope_type = "[@value='#{options[:type]}']" unless options[:type] == :any
+      unless options[:type] == :any
+        type_array =  Array(options[:type]).map { |x| "@value='#{x}'" }
+        scope_type = "[#{type_array.join(' or ')}]"
+      end
 
       # TODO: Include nested resources (provider actions)
       no_actions = "[command/ident/@value != 'action']"

data/lib/foodcritic/rules/fc110.rb

@@ -0,0 +1,18 @@
+rule "FC110", "Script resources should use 'code' property not 'command' property" do
+  tags %w{deprecation chef13}
+  recipe do |ast|
+    script_resources = %w{ bash
+                           ksh
+                           cash
+                           script
+                           batch
+                           perl
+                           python
+                           ruby
+                           windows_script
+                         }
+    find_resources(ast, type: script_resources).find_all do |resources|
+      resource_attribute(resources, "command")
+    end
+  end
+end

data/lib/foodcritic/rules/fc111.rb

@@ -0,0 +1,7 @@
+rule "FC111", "search using deprecated sort flag" do
+  tags %w{deprecation chef13}
+  recipe do |ast|
+    # search(:node, 'role:web', :sort => true)
+    ast.xpath("//method_add_arg[fcall/ident/@value='search'][arg_paren/args_add_block/args_add/bare_assoc_hash/assoc_new/symbol/ident/@value = 'sort']")
+  end
+end

data/lib/foodcritic/rules/fc112.rb

@@ -0,0 +1,6 @@
+rule "FC112", "Resource using deprecated dsl_name method" do
+  tags %w{deprecation chef13}
+  recipe do |ast|
+    ast.xpath("//call/ident[@value='dsl_name']")
+  end
+end

data/lib/foodcritic/rules/fc113.rb

@@ -0,0 +1,13 @@
+rule "FC113", "Resource declares deprecated use_inline_resources" do
+  tags %w{deprecation chef15 lwrp}
+  library do |ast|
+    matches = []
+    ast.xpath('//const_path_ref/const[@value="LWRPBase"]/..//const[@value="Provider"]/../../..').select do |x|
+      matches << x.xpath('//*[self::vcall or self::var_ref]/ident[@value="use_inline_resources"]')
+    end
+    matches
+  end
+  provider do |ast|
+    ast.xpath('//*[self::vcall or self::var_ref]/ident[@value="use_inline_resources"]')
+  end
+end

data/lib/foodcritic/rules/fc114.rb

@@ -0,0 +1,32 @@
+rule "FC114", "Cookbook uses legacy Ohai config syntax" do
+  tags %w{chef13 deprecated}
+  recipe do |ast|
+    # Ohai::Config[:something]
+    #
+    # <aref value="aref"> <-- if assigning this will be aref_field
+    #   <const_path_ref value="const_path_ref">
+    #     <var_ref value="var_ref">
+    #       <const value="Ohai">
+    #         <pos line="3" column="0"/>
+    #       </const>
+    #     </var_ref>
+    #     <const value="Config">
+    #       <pos line="3" column="6"/>
+    #     </const>
+    #   </const_path_ref>
+    #   <args_add_block value="false">
+    #     <args_add value="args_add">
+    #       <args_new value="args_new"/>
+    #       <symbol_literal value="symbol_literal">
+    #         <symbol value="symbol">
+    #           <ident value="something">
+    #             <pos line="3" column="14"/>
+    #           </ident>
+    #         </symbol>
+    #       </symbol_literal>
+    #     </args_add>
+    #   </args_add_block>
+    # </aref>
+    ast.xpath('//*[self::aref or self::aref_field][const_path_ref/const/@value="Config"][const_path_ref/var_ref/const/@value="Ohai"][args_add_block/args_add/symbol_literal/symbol]')
+  end
+end

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "12.2.2"
+  VERSION = "12.3.0"
 end

data/spec/functional/fc110_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+
+describe "FC110" do
+  context "with a cookbook with a script resource that uses command" do
+    resource_file <<-EOF
+    bash 'foo' do
+      command 'cat /etc/passwd'
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a script resource that uses code" do
+    resource_file <<-EOF
+    bash 'foo' do
+      code 'cat /etc/passwd'
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc111_spec.rb

@@ -0,0 +1,17 @@
+require "spec_helper"
+
+describe "FC111" do
+  context "with a cookbook with a search that uses the deprecated sort flag" do
+    resource_file <<-EOF
+    search(:node, 'role:web', :sort => true)
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a search that does not use sort" do
+    resource_file <<-EOF
+    search(:node, 'role:web')
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc112_spec.rb

@@ -0,0 +1,17 @@
+require "spec_helper"
+
+describe "FC112" do
+  context "with a cookbook with a resource that uses dsl_name" do
+    library_file <<-EOF
+    my_resource = MyResource.dsl_name
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a resource that uses resource_name" do
+    library_file <<-EOF
+    my_resource = MyResource.resource_name
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/{fc057_spec.rb → fc113_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "FC057" do
+describe "FC113" do
   context "with a cookbook with a library provider with use_inline_resources" do
     library_file <<-EOF
     class MyResources
@@ -24,7 +24,7 @@ describe "FC057" do
       end
     end
     EOF
-    it { is_expected.not_to violate_rule }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a library provider without use_inline_resources" do
@@ -48,7 +48,7 @@ describe "FC057" do
       end
     end
     EOF
-    it { is_expected.to violate_rule }
+    it { is_expected.not_to violate_rule }
   end
 
   context "with a cookbook with plain old library file" do
@@ -59,4 +59,40 @@ describe "FC057" do
     EOF
     it { is_expected.not_to violate_rule }
   end
+
+  context "with a cookbook with LWRP not using use_inline_resources" do
+    provider_file <<-EOF
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with LWRP using use_inline_resources" do
+    provider_file <<-EOF
+    use_inline_resources
+
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook ignoring the rule" do
+    provider_file <<-EOF.gsub(/^    /, "") # When we drop 2.2 support, this can use <<~EOF.
+    # ~FC059
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
 end

data/spec/functional/fc114_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe "FC114" do
+  context "with a cookbook that uses the legacy Ohai config" do
+    library_file <<-EOF
+    Ohai::Config[:something]
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook that sets the legacy Ohai config value" do
+    library_file <<-EOF
+    Ohai::Config[:something] = 'something'
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook that uses the new full form Ohai config" do
+    library_file <<-EOF
+    Ohai::Config.ohai[:something] = 'something'
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook that uses the new short form Ohai config" do
+    library_file <<-EOF
+    Ohai.config[:something] = 'something'
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/regression/expected/aix.txt

@@ -2,3 +2,22 @@ FC009: Resource attribute not recognised: ./recipes/default.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
 FC080: User resource uses deprecated supports property: ./recipes/default.rb:8
+FC113: Resource declares deprecated use_inline_resources: ./providers/altdisk.rb:23
+FC113: Resource declares deprecated use_inline_resources: ./providers/bootlist.rb:24
+FC113: Resource declares deprecated use_inline_resources: ./providers/chdev.rb:23
+FC113: Resource declares deprecated use_inline_resources: ./providers/chsec.rb:23
+FC113: Resource declares deprecated use_inline_resources: ./providers/etchosts.rb:22
+FC113: Resource declares deprecated use_inline_resources: ./providers/fixes.rb:23
+FC113: Resource declares deprecated use_inline_resources: ./providers/inittab.rb:24
+FC113: Resource declares deprecated use_inline_resources: ./providers/multibos.rb:22
+FC113: Resource declares deprecated use_inline_resources: ./providers/nimclient.rb:21
+FC113: Resource declares deprecated use_inline_resources: ./providers/niminit.rb:20
+FC113: Resource declares deprecated use_inline_resources: ./providers/no.rb:23
+FC113: Resource declares deprecated use_inline_resources: ./providers/pagingspace.rb:23
+FC113: Resource declares deprecated use_inline_resources: ./providers/subserver.rb:24
+FC113: Resource declares deprecated use_inline_resources: ./providers/subsystem.rb:13
+FC113: Resource declares deprecated use_inline_resources: ./providers/tcpservice.rb:24
+FC113: Resource declares deprecated use_inline_resources: ./providers/toolboxpackage.rb:23
+FC113: Resource declares deprecated use_inline_resources: ./providers/tunables.rb:23
+FC113: Resource declares deprecated use_inline_resources: ./providers/volume_group.rb:5
+FC113: Resource declares deprecated use_inline_resources: ./providers/wpar.rb:24

data/spec/regression/expected/apt.txt

@@ -1,9 +1,6 @@
-FC017: LWRP does not notify when updated: ./providers/repository.rb:124
 FC043: Prefer new notification syntax: ./providers/repository.rb:112
 FC043: Prefer new notification syntax: ./recipes/default.rb:48
 FC048: Prefer Mixlib::ShellOut: ./providers/repository.rb:26
-FC059: LWRP provider does not declare use_inline_resources: ./providers/preference.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/repository.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/ark.txt

@@ -1,2 +1,3 @@
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC113: Resource declares deprecated use_inline_resources: ./providers/default.rb:25

data/spec/regression/expected/auditd.txt

@@ -1,6 +1,2 @@
-FC017: LWRP does not notify when updated: ./providers/builtins.rb:22
-FC017: LWRP does not notify when updated: ./providers/ruleset.rb:21
-FC059: LWRP provider does not declare use_inline_resources: ./providers/builtins.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/ruleset.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/aws.txt

@@ -1,7 +1,3 @@
-FC059: LWRP provider does not declare use_inline_resources: ./providers/ebs_volume.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/elastic_ip.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/elastic_lb.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/resource_tag.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/bluepill.txt

@@ -1,4 +1,3 @@
-FC059: LWRP provider does not declare use_inline_resources: ./providers/service.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/chef-ingredient.txt

@@ -2,3 +2,4 @@ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
 FC109: Use platform-specific package resources instead of provider property: ./libraries/default_handler.rb:52
+FC113: Resource declares deprecated use_inline_resources: ./libraries/chef_ingredient_provider.rb:26

data/spec/regression/expected/chef-vault.txt

@@ -4,3 +4,4 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
 FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/chef_vault_secret.rb:92
 FC086: Use databag helper methods to load data bag items: ./libraries/helpers.rb:39
+FC113: Resource declares deprecated use_inline_resources: ./libraries/chef_vault_secret.rb:49

data/spec/regression/expected/chef_handler.txt

@@ -1,4 +1,3 @@
-FC059: LWRP provider does not declare use_inline_resources: ./providers/default.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/cron.txt

@@ -1,5 +1,3 @@
-FC017: LWRP does not notify when updated: ./providers/d.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/d.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/dmg.txt

@@ -1,10 +1,8 @@
 FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:19
 FC001: Use strings in preference to symbols to access node attributes: ./attributes/default.rb:20
-FC017: LWRP does not notify when updated: ./providers/package.rb:27
 FC048: Prefer Mixlib::ShellOut: ./providers/package.rb:44
 FC048: Prefer Mixlib::ShellOut: ./providers/package.rb:47
 FC048: Prefer Mixlib::ShellOut: ./providers/package.rb:76
-FC059: LWRP provider does not declare use_inline_resources: ./providers/package.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/dynect.txt

@@ -21,7 +21,6 @@ FC019: Access node attributes in a consistent manner: ./recipes/ec2.rb:25
 FC019: Access node attributes in a consistent manner: ./recipes/ec2.rb:26
 FC019: Access node attributes in a consistent manner: ./recipes/ec2.rb:40
 FC043: Prefer new notification syntax: ./recipes/ec2.rb:69
-FC059: LWRP provider does not declare use_inline_resources: ./providers/rr.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/firewall.txt

@@ -1,8 +1,3 @@
-FC017: LWRP does not notify when updated: ./providers/rule_ufw.rb:23
-FC017: LWRP does not notify when updated: ./providers/rule_ufw.rb:27
-FC017: LWRP does not notify when updated: ./providers/rule_ufw.rb:31
-FC059: LWRP provider does not declare use_inline_resources: ./providers/rule_ufw.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/ufw.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/gunicorn.txt

@@ -1,5 +1,3 @@
-FC059: LWRP provider does not declare use_inline_resources: ./providers/config.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/install.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/heartbeat.txt

@@ -1,7 +1,4 @@
 FC016: LWRP does not declare a default action: ./resources/ipaddr.rb:1
-FC017: LWRP does not notify when updated: ./providers/default.rb:20
-FC059: LWRP provider does not declare use_inline_resources: ./providers/default.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/null.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/homebrew.txt

@@ -1,6 +1,3 @@
-FC017: LWRP does not notify when updated: ./providers/tap.rb:13
-FC017: LWRP does not notify when updated: ./providers/tap.rb:21
-FC059: LWRP provider does not declare use_inline_resources: ./providers/tap.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/iis.txt

@@ -1,25 +1,4 @@
 FC002: Avoid string interpolation where not required: ./providers/site.rb:36
-FC017: LWRP does not notify when updated: ./providers/app.rb:26
-FC017: LWRP does not notify when updated: ./providers/app.rb:40
-FC017: LWRP does not notify when updated: ./providers/app.rb:57
-FC017: LWRP does not notify when updated: ./providers/config.rb:27
-FC017: LWRP does not notify when updated: ./providers/pool.rb:27
-FC017: LWRP does not notify when updated: ./providers/pool.rb:41
-FC017: LWRP does not notify when updated: ./providers/pool.rb:68
-FC017: LWRP does not notify when updated: ./providers/pool.rb:78
-FC017: LWRP does not notify when updated: ./providers/pool.rb:88
-FC017: LWRP does not notify when updated: ./providers/pool.rb:98
-FC017: LWRP does not notify when updated: ./providers/pool.rb:106
-FC017: LWRP does not notify when updated: ./providers/site.rb:26
-FC017: LWRP does not notify when updated: ./providers/site.rb:50
-FC017: LWRP does not notify when updated: ./providers/site.rb:84
-FC017: LWRP does not notify when updated: ./providers/site.rb:94
-FC017: LWRP does not notify when updated: ./providers/site.rb:104
-FC017: LWRP does not notify when updated: ./providers/site.rb:114
-FC059: LWRP provider does not declare use_inline_resources: ./providers/app.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/config.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/pool.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/site.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/libarchive.txt

@@ -1,4 +1,3 @@
-FC059: LWRP provider does not declare use_inline_resources: ./providers/file.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/lvm.txt

@@ -1,8 +1,4 @@
 FC014: Consider extracting long ruby_block to library: ./providers/logical_volume.rb:18
-FC017: LWRP does not notify when updated: ./providers/physical_volume.rb:6
-FC059: LWRP provider does not declare use_inline_resources: ./providers/logical_volume.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/physical_volume.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/volume_group.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/maven.txt

@@ -1,7 +1,4 @@
-FC017: LWRP does not notify when updated: ./providers/default.rb:61
-FC017: LWRP does not notify when updated: ./providers/default.rb:65
 FC045: Metadata does not contain cookbook name: ./metadata.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/default.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/ohai.txt

@@ -5,3 +5,5 @@ FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC072: Metadata should not contain "attribute" keyword: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC114: Cookbook uses legacy Ohai config syntax: ./recipes/default.rb:20
+FC114: Cookbook uses legacy Ohai config syntax: ./recipes/default.rb:21

data/spec/regression/expected/php.txt

@@ -1,8 +1,3 @@
-FC017: LWRP does not notify when updated: ./providers/pear_channel.rb:31
-FC017: LWRP does not notify when updated: ./providers/pear_channel.rb:40
-FC017: LWRP does not notify when updated: ./providers/pear_channel.rb:69
-FC059: LWRP provider does not declare use_inline_resources: ./providers/pear.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/pear_channel.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/powershell.txt

@@ -1,6 +1,4 @@
-FC017: LWRP does not notify when updated: ./providers/default.rb:19
 FC019: Access node attributes in a consistent manner: ./recipes/default.rb:69
-FC059: LWRP provider does not declare use_inline_resources: ./providers/default.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/rsync.txt

@@ -1,8 +1,5 @@
 FC011: Missing README in markdown format: examples/README.md:1
-FC017: LWRP does not notify when updated: ./providers/serve.rb:65
-FC017: LWRP does not notify when updated: ./providers/serve.rb:69
 FC031: Cookbook without metadata.rb file: examples/metadata.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/serve.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/runit.txt

@@ -1,3 +1,4 @@
 FC004: Use a service resource to start and stop services: ./recipes/default.rb:24
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC113: Resource declares deprecated use_inline_resources: ./libraries/provider_runit_service.rb:42

data/spec/regression/expected/smokeping.txt

@@ -1,4 +1,3 @@
-FC059: LWRP provider does not declare use_inline_resources: ./providers/target.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1

data/spec/regression/expected/sudo.txt

@@ -1,5 +1,3 @@
-FC017: LWRP does not notify when updated: ./providers/default.rb:102
-FC059: LWRP provider does not declare use_inline_resources: ./providers/default.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/tar.txt

@@ -6,3 +6,5 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC071: Missing LICENSE file: ./LICENSE:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/package.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC113: Resource declares deprecated use_inline_resources: ./providers/extract.rb:26
+FC113: Resource declares deprecated use_inline_resources: ./providers/package.rb:22

data/spec/regression/expected/transmission.txt

@@ -2,7 +2,6 @@ FC016: LWRP does not declare a default action: ./resources/torrent_file.rb:1
 FC024: Consider adding platform equivalents: ./recipes/default.rb:42
 FC025: Prefer chef_gem to compile-time gem install: ./recipes/default.rb:25
 FC025: Prefer chef_gem to compile-time gem install: ./recipes/default.rb:31
-FC059: LWRP provider does not declare use_inline_resources: ./providers/torrent_file.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/users.txt

@@ -1,6 +1,5 @@
 FC009: Resource attribute not recognised: ./providers/manage.rb:78
 FC047: Attribute assignment does not specify precedence: ./providers/manage.rb:55
-FC059: LWRP provider does not declare use_inline_resources: ./providers/manage.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/webpi.txt

@@ -1,5 +1,3 @@
-FC017: LWRP does not notify when updated: ./providers/product.rb:26
-FC059: LWRP provider does not declare use_inline_resources: ./providers/product.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/windows.txt

@@ -2,42 +2,8 @@ FC002: Avoid string interpolation where not required: ./libraries/registry_helpe
 FC002: Avoid string interpolation where not required: ./libraries/registry_helper.rb:173
 FC002: Avoid string interpolation where not required: ./libraries/windows_privileged.rb:42
 FC002: Avoid string interpolation where not required: ./libraries/windows_privileged.rb:56
-FC017: LWRP does not notify when updated: ./providers/auto_run.rb:21
-FC017: LWRP does not notify when updated: ./providers/auto_run.rb:27
-FC017: LWRP does not notify when updated: ./providers/batch.rb:24
-FC017: LWRP does not notify when updated: ./providers/package.rb:35
-FC017: LWRP does not notify when updated: ./providers/package.rb:53
-FC017: LWRP does not notify when updated: ./providers/package.rb:64
-FC017: LWRP does not notify when updated: ./providers/pagefile.rb:24
-FC017: LWRP does not notify when updated: ./providers/pagefile.rb:66
-FC017: LWRP does not notify when updated: ./providers/path.rb:21
-FC017: LWRP does not notify when updated: ./providers/path.rb:29
-FC017: LWRP does not notify when updated: ./providers/reboot.rb:21
-FC017: LWRP does not notify when updated: ./providers/reboot.rb:27
-FC017: LWRP does not notify when updated: ./providers/registry.rb:27
-FC017: LWRP does not notify when updated: ./providers/registry.rb:31
-FC017: LWRP does not notify when updated: ./providers/registry.rb:35
-FC017: LWRP does not notify when updated: ./providers/registry.rb:61
-FC017: LWRP does not notify when updated: ./providers/task.rb:24
-FC017: LWRP does not notify when updated: ./providers/task.rb:43
-FC017: LWRP does not notify when updated: ./providers/task.rb:58
-FC017: LWRP does not notify when updated: ./providers/task.rb:75
-FC017: LWRP does not notify when updated: ./providers/zipfile.rb:27
-FC017: LWRP does not notify when updated: ./providers/zipfile.rb:44
 FC018: LWRP uses deprecated notification syntax: ./providers/shortcut.rb:54
 FC048: Prefer Mixlib::ShellOut: ./providers/task.rb:106
-FC059: LWRP provider does not declare use_inline_resources: ./providers/auto_run.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/batch.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/feature_dism.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/feature_servermanagercmd.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/package.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/pagefile.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/path.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/reboot.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/registry.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/shortcut.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/task.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/zipfile.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/yum.txt

@@ -1,12 +1,7 @@
 FC009: Resource attribute not recognised: ./recipes/epel.rb:27
-FC017: LWRP does not notify when updated: ./providers/key.rb:25
-FC017: LWRP does not notify when updated: ./providers/repository.rb:28
-FC017: LWRP does not notify when updated: ./providers/repository.rb:45
 FC038: Invalid resource action: ./recipes/epel.rb:27
 FC043: Prefer new notification syntax: ./providers/key.rb:60
 FC043: Prefer new notification syntax: ./providers/repository.rb:94
-FC059: LWRP provider does not declare use_inline_resources: ./providers/key.rb:1
-FC059: LWRP provider does not declare use_inline_resources: ./providers/repository.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/unit/api_spec.rb

@@ -402,7 +402,11 @@ describe FoodCritic::Api do
     it "returns empty unless the ast supports XPath" do
       expect(api.find_resources(nil)).to be_empty
     end
-    it "restricts by resource type when provided" do
+    it "restricts by resource type when provided an array" do
+      expect(ast).to receive(:xpath).with("//method_add_block[command/ident[@value='file' or @value='template']][command/ident/@value != 'action']").and_return(["method_add_block"])
+      api.find_resources(ast, :type => %w{file template})
+    end
+    it "restricts by resource type when provided a string" do
       expect(ast).to receive(:xpath).with("//method_add_block[command/ident[@value='file']][command/ident/@value != 'action']").and_return(["method_add_block"])
       api.find_resources(ast, :type => "file")
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 12.2.2
+  version: 12.3.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-14 00:00:00.000000000 Z
+date: 2018-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -187,7 +187,6 @@ files:
 - features/006_check_file_mode.feature
 - features/009_check_for_unrecognised_resource_attributes.feature
 - features/014_check_for_long_ruby_blocks.feature
-- features/017_check_for_no_lwrp_notifications.feature
 - features/018_check_for_old_lwrp_notification_syntax.feature
 - features/019_check_for_consistent_node_access.feature
 - features/021_check_for_dodgy_lwrp_conditions.feature
@@ -256,7 +255,6 @@ files:
 - lib/foodcritic/rules/fc014.rb
 - lib/foodcritic/rules/fc015.rb
 - lib/foodcritic/rules/fc016.rb
-- lib/foodcritic/rules/fc017.rb
 - lib/foodcritic/rules/fc018.rb
 - lib/foodcritic/rules/fc019.rb
 - lib/foodcritic/rules/fc021.rb
@@ -291,9 +289,7 @@ files:
 - lib/foodcritic/rules/fc053.rb
 - lib/foodcritic/rules/fc055.rb
 - lib/foodcritic/rules/fc056.rb
-- lib/foodcritic/rules/fc057.rb
 - lib/foodcritic/rules/fc058.rb
-- lib/foodcritic/rules/fc059.rb
 - lib/foodcritic/rules/fc060.rb
 - lib/foodcritic/rules/fc061.rb
 - lib/foodcritic/rules/fc062.rb
@@ -343,6 +339,11 @@ files:
 - lib/foodcritic/rules/fc107.rb
 - lib/foodcritic/rules/fc108.rb
 - lib/foodcritic/rules/fc109.rb
+- lib/foodcritic/rules/fc110.rb
+- lib/foodcritic/rules/fc111.rb
+- lib/foodcritic/rules/fc112.rb
+- lib/foodcritic/rules/fc113.rb
+- lib/foodcritic/rules/fc114.rb
 - lib/foodcritic/template.rb
 - lib/foodcritic/version.rb
 - lib/foodcritic/xml.rb
@@ -373,9 +374,7 @@ files:
 - spec/functional/fc053_spec.rb
 - spec/functional/fc055_spec.rb
 - spec/functional/fc056_spec.rb
-- spec/functional/fc057_spec.rb
 - spec/functional/fc058_spec.rb
-- spec/functional/fc059_spec.rb
 - spec/functional/fc060_spec.rb
 - spec/functional/fc061_spec.rb
 - spec/functional/fc062_spec.rb
@@ -425,6 +424,11 @@ files:
 - spec/functional/fc107_spec.rb
 - spec/functional/fc108_spec.rb
 - spec/functional/fc109_spec.rb
+- spec/functional/fc110_spec.rb
+- spec/functional/fc111_spec.rb
+- spec/functional/fc112_spec.rb
+- spec/functional/fc113_spec.rb
+- spec/functional/fc114_spec.rb
 - spec/functional/root_aliases_spec.rb
 - spec/regression/cookbooks.txt
 - spec/regression/expected/activemq.txt
@@ -538,8 +542,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
-summary: foodcritic-12.2.2
+summary: foodcritic-12.3.0
 test_files: []

data/features/017_check_for_no_lwrp_notifications.feature

@@ -1,50 +0,0 @@
-Feature: Check for no LWRP notifications
-
-  In order to ensure resource actions are triggered as expected
-  As a developer
-  I want to identify when a LWRP does not trigger notifications
-
-  Scenario: LWRP with no notifications
-    Given a cookbook that contains a LWRP that does not trigger notifications
-    When I check the cookbook
-    Then the LWRP does not notify when updated warning 017 should be displayed against the provider file
-
-  Scenario: LWRP with a notification
-    Given a cookbook that contains a LWRP with a single notification
-    When I check the cookbook
-    Then the LWRP does not notify when updated warning 017 should not be displayed against the provider file
-
-  Scenario: LWRP with a notification without parentheses
-    Given a cookbook that contains a LWRP with a single notification without parentheses
-    When I check the cookbook
-    Then the LWRP does not notify when updated warning 017 should not be displayed against the provider file
-
-  Scenario: LWRP with multiple notifications
-    Given a cookbook that contains a LWRP with multiple notifications
-    When I check the cookbook
-    Then the LWRP does not notify when updated warning 017 should not be displayed against the provider file
-
-  Scenario Outline: LWRP using converge_by
-    Given a cookbook that contains a LWRP that uses converge_by - <block_type> block <with_parens> parentheses
-    When I check the cookbook
-    Then the LWRP does not notify when updated warning 017 should not be displayed against the provider file
-  Examples:
-    | block_type | with_parens |
-    | brace      | with        |
-    | do         | with        |
-    | do         | without     |
-
-  Scenario: LWRP using use_inline_resources
-    Given a cookbook that contains a LWRP that uses use_inline_resources
-     When I check the cookbook
-     Then the LWRP does not notify when updated warning 017 should not be displayed against the provider file
-
-  Scenario Outline: Warnings raised for actions individually
-    Given a LWRP with an action :create that notifies with <notify_type> and another :delete that does not notify
-    When I check the cookbook
-    Then the LWRP does not notify when updated warning 017 should not be shown against the :create action
-     And the LWRP does not notify when updated warning 017 should be shown against the :delete action
-  Examples:
-    | notify_type            |
-    | converge_by            |
-    | updated_by_last_action |

data/lib/foodcritic/rules/fc017.rb

@@ -1,29 +0,0 @@
-rule "FC017", "LWRP does not notify when updated" do
-  tags %w{correctness lwrp}
-  provider do |ast, filename|
-
-    use_inline_resources = !ast.xpath('//*[self::vcall or self::var_ref]/ident
-      [@value="use_inline_resources"]').empty?
-
-    unless use_inline_resources
-      actions = ast.xpath('//method_add_block/command[ident/@value="action"]/
-        args_add_block/descendant::symbol/ident')
-
-      actions.reject do |action|
-        blk = action.xpath('ancestor::command[1]/
-          following-sibling::*[self::do_block or self::brace_block]')
-        empty = !blk.xpath("stmts_add/void_stmt").empty?
-        converge_by = !blk.xpath('descendant::*[self::command or self::fcall]
-          /ident[@value="converge_by"]').empty?
-
-        updated_by_last_action = !blk.xpath('descendant::*[self::call or
-          self::command_call]/*[self::vcall or self::var_ref/ident/
-          @value="new_resource"]/../ident[@value="updated_by_last_action"]
-        ').empty?
-
-        empty || converge_by || updated_by_last_action
-      end
-    end
-
-  end
-end

data/lib/foodcritic/rules/fc057.rb

@@ -1,8 +0,0 @@
-rule "FC057", "Library provider does not declare use_inline_resources" do
-  tags %w{correctness lwrp}
-  library do |ast|
-    ast.xpath('//const_path_ref/const[@value="LWRPBase"]/..//const[@value="Provider"]/../../..').select do |x|
-      x.xpath('//*[self::vcall or self::var_ref]/ident[@value="use_inline_resources"]').empty?
-    end
-  end
-end

data/lib/foodcritic/rules/fc059.rb

@@ -1,10 +0,0 @@
-rule "FC059", "LWRP provider does not declare use_inline_resources" do
-  tags %w{correctness lwrp}
-  provider do |ast, filename|
-    use_inline_resources = !ast.xpath('//*[self::vcall or self::var_ref]/ident
-      [@value="use_inline_resources"]').empty?
-    unless use_inline_resources
-      [file_match(filename)]
-    end
-  end
-end

data/spec/functional/fc059_spec.rb

@@ -1,39 +0,0 @@
-require "spec_helper"
-
-describe "FC059" do
-  context "with a cookbook with LWRP not using use_inline_resources" do
-    provider_file <<-EOF
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-    end
-    EOF
-    it { is_expected.to violate_rule }
-  end
-
-  context "with a cookbook with LWRP using use_inline_resources" do
-    provider_file <<-EOF
-    use_inline_resources
-
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-
-  context "with a cookbook ignoring the rule" do
-    provider_file <<-EOF.gsub(/^    /, "") # When we drop 2.2 support, this can use <<~EOF.
-    # ~FC059
-    action :create do
-      template "/etc/something.conf" do
-        notifies :restart, "service[something]"
-      end
-    end
-    EOF
-    it { is_expected.not_to violate_rule }
-  end
-end