foodcritic 12.2.1 → 12.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8d7566bbb8e6c6bf3c8f3410e1a2bfc884becee4
-  data.tar.gz: f0e32659516e8f0f191fe0790626b3a6e073694f
+  metadata.gz: 4cca4b9220b37c61b2a6787963597afc99c36c91
+  data.tar.gz: 3efa091b16afb38ed2ba05425ac378ca410cb450
 SHA512:
-  metadata.gz: da2b94c491d43fefed96decc3e375652d478856fef5ce9a770aa935524ba6f2c98ff28a5e2324de20f2e260241be36a3cba0a7264fa465d874a008b54b4b2c0a
-  data.tar.gz: 2da6b12cba8bc43443d6ca5cd888e1d433f595eacd9aa7d1824c0b7eceb2eed010365e5d59058755d07682a37ea6c921a531065395178ebb050e8a42ee474d7a
+  metadata.gz: 22978558516fe2c9f8880ccd148155070d88ae8457c4861bf13b8963dcacd5a8dc12c85f4de74bedb564611765c3f980703365826bb3e45da6ab38a0c1b93df6
+  data.tar.gz: 46a58bedda591bf9ab373b56229d76173b11b4a8b5e7173b8b4eda45799616e02df3d090448ce376079d7d3763504092d0ef6a57c4cd257aa1aa3a1f4f381c8c

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 # Foodcritic Changelog:
 
-## [12.2.1](https://github.com/Foodcritic/foodcritic/tree/v12.2.0) (2017-11-14)
+## [12.2.2](https://github.com/Foodcritic/foodcritic/tree/v12.2.2) (2017-12-13)
+
+**Fixed bugs:**
+
+- Don't require a space before the # in an ignore comment.
+- FC009 should not alert on a raise in a resource
+- Catch systemd service starts in FC004 and resolve several false positives
+
+## [12.2.1](https://github.com/Foodcritic/foodcritic/tree/v12.2.1) (2017-11-14)
 
 **Fixed bugs:**
 

data/features/ignore_via_line_comments.feature

@@ -46,7 +46,7 @@ Feature: Ignoring rules on per line basis
   Examples:
     | comment         | warnings    |
     |                 | FC002,FC039 |
-    | # ~FC002,~FC007 | FC002       |
+    | # ~FC002,~FC007 | FC039       |
     | # ~FC002,~FC039 |             |
     | # ~FC002        | FC039       |
 

data/features/support/cookbook_helpers.rb

@@ -339,22 +339,6 @@ module FoodCritic
       }
     end
 
-    # Create a recipe that controls a service using the specified method.
-    #
-    # @param [Symbol] method How to start the service, one of: :init_d, :invoke_rc_d, :upstart, :service, :service_full_path.
-    # @param [Boolean] do_sleep Whether to prefix the service cmd with a bash sleep
-    # @param [Symbol] action The action to take (start, stop, reload, restart)
-    def recipe_controls_service(method = :service, do_sleep = false, action = :start)
-      cmds = { :init_d => "/etc/init.d/foo #{action}", :invoke_rc_d => "invoke-rc.d foo #{action}", :upstart => "#{action} foo",
-               :service => "service foo #{action}", :service_full_path => "/sbin/service foo #{action}" }
-      write_recipe %Q{
-        execute "#{action}-foo-service" do
-          command "#{do_sleep ? 'sleep 5; ' : ''}#{cmds[method]}"
-          action :run
-        end
-      }
-    end
-
     # Create a recipe with an external dependency on another cookbook.
     #
     # @param [Hash] dep The options to use for dependency

data/lib/foodcritic/linter.rb

@@ -13,7 +13,7 @@ module FoodCritic
     attr_reader :chef_version
 
     # Perform a lint check. This method is intended for use by the command-line
-    # wrapper. If you are programatically using foodcritic you should use
+    # wrapper. If you are programmatically using foodcritic you should use
     # `#check` below.
     def self.run(cmd_line)
       # The first item is the string output, the second is exit code.
@@ -183,7 +183,7 @@ module FoodCritic
     end
 
     def ignore_line_match?(line, rule)
-      ignores = line.to_s[/\s+#\s*(.*)/, 1]
+      ignores = line.to_s[/.*#\s*(.*)/, 1]
       if ignores && ignores.include?("~")
         !rule.matches_tags?(ignores.split(/[ ,]/))
       else

data/lib/foodcritic/rules/fc004.rb

@@ -3,10 +3,11 @@ rule "FC004", "Use a service resource to start and stop services" do
   recipe do |ast|
     find_resources(ast, type: "execute").find_all do |cmd|
       cmd_str = (resource_attribute(cmd, "command") || resource_name(cmd)).to_s
-      (cmd_str.include?("/etc/init.d") || ["service ", "/sbin/service ",
-       "start ", "stop ", "invoke-rc.d "].any? do |service_cmd|
-         cmd_str.start_with?(service_cmd)
-       end) && %w{start stop restart reload}.any? { |a| cmd_str.include?(a) }
+      next if cmd_str.include?(".exe") # don't catch windows commands
+      cmd_str.start_with?( "start ", "stop ", "reload ", "restart ") || # upstart jobs
+        ( [ "/etc/init.d", "service ", "/sbin/service ", "invoke-rc.d ", "systemctl "].any? do |service_cmd| # upstart / sys-v / systemd
+          cmd_str.start_with?(service_cmd)
+        end && [" start", " stop", " restart", " reload"].any? { |a| cmd_str.include?(a) } ) # make sure we get exactly the commands not something like 'daemon-reload'
     end
   end
 end

data/lib/foodcritic/rules/fc009.rb

@@ -5,7 +5,9 @@ rule "FC009", "Resource attribute not recognised" do
     resource_attributes_by_type(ast).each do |type, resources|
       resources.each do |resource|
         resource.keys.map(&:to_sym).reject do |att|
-          resource_attribute?(type.to_sym, att)
+          # look up the resource attribute give it's type (file, package, etc)
+          # raise is a special case. It's questionable, but shouldn't alert
+          resource_attribute?(type.to_sym, att) || att == :raise
         end.each do |invalid_att|
           matches << find_resources(ast, type: type).find do |res|
             resource_attributes(res).include?(invalid_att.to_s)

data/lib/foodcritic/rules/fc108.rb

@@ -4,7 +4,7 @@ rule "FC108", "Resource should not define a property named 'name'" do
     # Make sure we're in a custom resource not an LWRP
     if ast.xpath("//command/ident/@value='action'")
       # command has a child of type ident with a value of "property". That tells us
-      # we're in a property. Quite a ways desecendant from that is another ident
+      # we're in a property. Quite a ways descendant from that is another ident
       # with value of "name"
       ast.xpath("//command[ident/@value='property' and descendant::symbol_literal/symbol/ident/@value='name']")
     end

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "12.2.1"
+  VERSION = "12.2.2"
 end

data/spec/functional/fc004_spec.rb

@@ -0,0 +1,84 @@
+require "spec_helper"
+
+describe "FC004" do
+  context "using a execute to run a service init script" do
+    recipe_file <<-EOH
+      execute 'service stuff' do
+        command '/etc/init.d/foo start'
+        action :run
+      end
+    EOH
+    it { is_expected.to violate_rule }
+  end
+
+  context "using a execute to run a invoke-rc.d" do
+    recipe_file <<-EOH
+      execute 'service stuff' do
+        command 'invoke-rc.d foo restart'
+        action :run
+      end
+    EOH
+    it { is_expected.to violate_rule }
+  end
+
+  %w{reload start stop restart}.each do |command|
+    context "using a execute to run an upstart #{command} command" do
+      recipe_file <<-EOH
+        execute 'service stuff' do
+          command "#{command} foo"
+          action :run
+        end
+      EOH
+      it { is_expected.to violate_rule }
+    end
+
+    context "using a execute to run the upstart service command to #{command}" do
+      recipe_file <<-EOH
+        execute 'service stuff' do
+          command "service foo #{command}"
+          action :run
+        end
+      EOH
+      it { is_expected.to violate_rule }
+    end
+
+    context "using a execute to run systemcl to #{command}" do
+      recipe_file <<-EOH
+        execute 'service stuff' do
+          command "systemctl #{command} foo"
+          action :run
+        end
+      EOH
+      it { is_expected.to violate_rule }
+    end
+  end
+
+  context "using a execute to run a windows start command" do
+    recipe_file <<-EOH
+      execute 'Run setup' do
+        command 'start /wait my_setup.exe --silent'
+      end
+    EOH
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "using a execute to run systemctl daemon-reload" do
+    recipe_file <<-EOH
+      execute 'Run setup' do
+        command 'systemctl daemon-reload'
+      end
+    EOH
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "using a execute to run check the contents of an init script" do
+    recipe_file <<-EOH
+      execute "Configure the scheduler" do
+          user "root"
+          command 'sed -i "s/\([^/]\)ondemand/\1performace/g" /etc/init.d/ondemand'
+          notifies :start, "service[ondemand]"
+      end
+    EOH
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc009_spec.rb

@@ -24,4 +24,19 @@ describe "FC009" do
     EOH
     it { is_expected.to violate_rule }
   end
+
+  context "when the resource attribute is actually a raise" do
+    foodcritic_command("--chef-version", "12.18.31", "--no-progress", ".")
+    recipe_file <<-EOH
+      package package_name do
+        provider case node["platform_family"]
+                 when "debian"; Chef::Provider::Package::Dpkg
+                 when "rhel"; Chef::Provider::Package::Rpm
+                 else
+                  raise RuntimeError("I don't know how to install chef-server packages for this platform family")
+                 end
+      end
+    EOH
+    it { is_expected.not_to violate_rule }
+  end
 end

data/spec/functional/fc059_spec.rb

@@ -24,4 +24,16 @@ describe "FC059" do
     EOF
     it { is_expected.not_to violate_rule }
   end
+
+  context "with a cookbook ignoring the rule" do
+    provider_file <<-EOF.gsub(/^    /, "") # When we drop 2.2 support, this can use <<~EOF.
+    # ~FC059
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+    end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
 end

data/spec/regression/expected/chef-client.txt

@@ -14,3 +14,4 @@ FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
 FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/service.rb:59
 FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/task.rb:49
+FC104: Use the :run action in ruby_block instead of :create: ./recipes/config.rb:78

data/spec/regression/expected/chef-ingredient.txt

@@ -1,3 +1,4 @@
 FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC109: Use platform-specific package resources instead of provider property: ./libraries/default_handler.rb:52

data/spec/regression/expected/chef-server.txt

@@ -2,7 +2,6 @@ FC001: Use strings in preference to symbols to access node attributes: ./librari
 FC001: Use strings in preference to symbols to access node attributes: ./libraries/omnitruck_client.rb:77
 FC001: Use strings in preference to symbols to access node attributes: ./libraries/omnitruck_client.rb:78
 FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./recipes/dev.rb:16
-FC009: Resource attribute not recognised: ./recipes/default.rb:46
 FC019: Access node attributes in a consistent manner: ./libraries/omnitruck_client.rb:76
 FC019: Access node attributes in a consistent manner: ./libraries/omnitruck_client.rb:77
 FC019: Access node attributes in a consistent manner: ./libraries/omnitruck_client.rb:78
@@ -11,3 +10,4 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC109: Use platform-specific package resources instead of provider property: ./recipes/default.rb:46

data/spec/regression/expected/database.txt

@@ -14,8 +14,29 @@ FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./recipes/master.rb:37
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
 FC082: Deprecated node.set or node.set_unless used to set node attributes: ./recipes/master.rb:36
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_mysql.rb:44
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_mysql.rb:56
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_mysql.rb:69
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_mysql_user.rb:39
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_mysql_user.rb:50
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_mysql_user.rb:70
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_postgresql.rb:53
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_postgresql.rb:65
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_postgresql.rb:78
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_postgresql_user.rb:40
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_postgresql_user.rb:51
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_postgresql_user.rb:64
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_sql_server.rb:40
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_sql_server.rb:52
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_sql_server.rb:65
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_sql_server_user.rb:39
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_sql_server_user.rb:49
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_sql_server_user.rb:60
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_sql_server_user.rb:64
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/provider_database_sql_server_user.rb:81
 FC086: Use databag helper methods to load data bag items: ./recipes/ebs_backup.rb:22
 FC086: Use databag helper methods to load data bag items: ./recipes/ebs_backup.rb:38
 FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:27
 FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:70
 FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:78
+FC104: Use the :run action in ruby_block instead of :create: ./recipes/ebs_volume.rb:104

data/spec/regression/expected/iis.txt

@@ -29,3 +29,15 @@ FC074: LWRP should use DSL to define resource's default action: ./resources/conf
 FC074: LWRP should use DSL to define resource's default action: ./resources/pool.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/site.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/app.rb:60
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pool.rb:34
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pool.rb:71
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pool.rb:81
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pool.rb:91
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pool.rb:102
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pool.rb:108
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/site.rb:43
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/site.rb:87
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/site.rb:97
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/site.rb:107
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/site.rb:118

data/spec/regression/expected/lvm.txt

@@ -11,4 +11,8 @@ FC074: LWRP should use DSL to define resource's default action: ./resources/logi
 FC074: LWRP should use DSL to define resource's default action: ./resources/physical_volume.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/volume_group.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/logical_volume.rb:46
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/volume_group.rb:22
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/volume_group.rb:50
 FC098: Deprecated Chef::Mixin::RecipeDefinitionDSLCore mixin used: ./resources/volume_group.rb:1
+FC104: Use the :run action in ruby_block instead of :create: ./providers/volume_group.rb:38

data/spec/regression/expected/powershell.txt

@@ -7,3 +7,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/default.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/default.rb:72

data/spec/regression/expected/webpi.txt

@@ -6,3 +6,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/product.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/product.rb:33

data/spec/regression/expected/windows.txt

@@ -53,3 +53,17 @@ FC074: LWRP should use DSL to define resource's default action: ./resources/shor
 FC074: LWRP should use DSL to define resource's default action: ./resources/task.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/zipfile.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/feature_base.rb:9
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./libraries/feature_base.rb:19
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/batch.rb:42
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/package.rb:48
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/package.rb:59
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/package.rb:68
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pagefile.rb:63
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/pagefile.rb:75
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/registry.rb:70
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/task.rb:38
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/task.rb:50
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/task.rb:68
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/task.rb:79
+FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/zipfile.rb:41

data/spec/regression/expected/yum.txt

@@ -17,3 +17,4 @@ FC074: LWRP should use DSL to define resource's default action: ./resources/repo
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
 FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/key.rb:76
 FC085: Resource using new_resource.updated_by_last_action to converge resource: ./providers/repository.rb:41
+FC104: Use the :run action in ruby_block instead of :create: ./providers/repository.rb:94

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 12.2.1
+  version: 12.2.2
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-14 00:00:00.000000000 Z
+date: 2017-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -183,7 +183,6 @@ files:
 - chef_dsl_metadata/chef_13.5.3.json
 - chef_dsl_metadata/chef_13.6.0.json
 - features/002_check_string_interpolation.feature
-- features/004_check_service_resource_used.feature
 - features/005_check_for_resource_repetition.feature
 - features/006_check_file_mode.feature
 - features/009_check_for_unrecognised_resource_attributes.feature
@@ -351,6 +350,7 @@ files:
 - man/foodcritic.1.ronn
 - misc/lucene.treetop
 - spec/functional/fc001_spec.rb
+- spec/functional/fc004_spec.rb
 - spec/functional/fc007_spec.rb
 - spec/functional/fc008_spec.rb
 - spec/functional/fc009_spec.rb
@@ -541,5 +541,5 @@ rubyforge_project:
 rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
-summary: foodcritic-12.2.1
+summary: foodcritic-12.2.2
 test_files: []

data/features/004_check_service_resource_used.feature

@@ -1,53 +0,0 @@
-Feature: Check for service commands within execute resources
-
-  In order to control services in an idiomatic way
-  As a developer
-  I want to identify if service commands are called by execute resources rather than using the service resource
-
-  Scenario: Execute resource starting a service via init.d
-    Given a cookbook recipe that uses execute to start a service via init.d
-    When I check the cookbook
-    Then the service resource warning 004 should be displayed
-
-  Scenario Outline: Execute resource controlling a service via the service command
-    Given a cookbook recipe that uses execute to <action> a service via the service command
-    When I check the cookbook
-    Then the service resource warning 004 <warning>
-
-  Examples:
-    | action  | warning                 |
-    | start   | should be displayed     |
-    | stop    | should be displayed     |
-    | restart | should be displayed     |
-    | reload  | should be displayed     |
-    | initdb  | should not be displayed |
-
-  Scenario: Execute resource starting a service via upstart
-    Given a cookbook recipe that uses execute to start a service via upstart
-    When I check the cookbook
-    Then the service resource warning 004 should be displayed
-
-  Scenario: Execute resource starting a service via invoke-rc.d
-    Given a cookbook recipe that uses execute to start a service via invoke-rc.d
-    When I check the cookbook
-    Then the service resource warning 004 should be displayed
-
-  Scenario: Execute resource starting a service via the full path to the service command
-    Given a cookbook recipe that uses execute to start a service via the full path to the service command
-    When I check the cookbook
-    Then the service resource warning 004 should be displayed
-
-  Scenario: Execute resource starting a service via init.d (multiple commands)
-    Given a cookbook recipe that uses execute to sleep and then start a service via init.d
-    When I check the cookbook
-    Then the service resource warning 004 should be displayed
-
-  Scenario: Execute resource not controlling a service
-    Given a cookbook recipe that uses execute to list a directory
-    When I check the cookbook
-    Then the service resource warning 004 should not be displayed
-
-  Scenario: Execute resource using name attribute
-    Given a cookbook recipe that uses execute with a name attribute to start a service
-     When I check the cookbook
-    Then the service resource warning 004 should be displayed