foodcritic 12.0.1 → 12.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d778c74e1f690101f1d35779fc916bac4b3d4c7f
-  data.tar.gz: ed2c20f367d97602978301526662285c449c313c
+  metadata.gz: d9dd40715774c5adade3569eb138e040cc91c344
+  data.tar.gz: 9b3632ea45e7e88c43eb6f90c1e0ec92a959844f
 SHA512:
-  metadata.gz: a5778904806b10db9b09c4969a70b849308fc309e8682e81c8f4166c24c364362c4dbcfb5db5d37d9b7d78978de5a9278e70ac06a0f405d71579ec97e749bd5f
-  data.tar.gz: a283a490bed87be173e490848a6831c5b34973d93efd95b6b85ddf183601a7188de7925b2b87bba3e3401192932d36a6b97163e859012356a9806f7079affd21
+  metadata.gz: 7d292e6eb21f89ac2234578ba2857d35d926dfca1f6bd7f06acc3641f0edd4a19a5d9a1c3a7f2aa2020e8539d7732c848742c23355ddafee673b34c0617e1df3
+  data.tar.gz: fd145ba3ce3b168efc7311947d550e21cf68048c02e2bab6883ae937609dae43e8e4a415a8f73f06d3ca24d016482822b080b8e9465a83f7c31e6ce744e4b5b9

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Foodcritic Changelog:
 
+## [12.1.0](https://github.com/Foodcritic/foodcritic/tree/v12.1.0) (2017-10-31)
+
+**Implemented enhancements:**
+
+- Updated FC094 and FC095 tags from chef15 -> chef14 as the deprecation timeline has been changed
+- Updated FC087 to check for all deprecated Chef::Platform methods
+- Added FC101: Cookbook uses the deprecated deploy resource
+- Added FC102: Cookbook uses the deprecated Chef::DSL::Recipe::FullDSL class
+
 ## [12.0.1](https://github.com/Foodcritic/foodcritic/tree/v12.0.1) (2017-10-19)
 
 **Fixed bugs:**

data/lib/foodcritic/rules/fc087.rb

@@ -1,7 +1,7 @@
-rule "FC087", "Library maps provider with deprecated Chef::Platform.set" do
+rule "FC087", "Library uses deprecated Chef::Platform methods" do
   tags %w{chef13 deprecated}
 
   library do |ast|
-    ast.xpath('//const_path_ref/const[@value="Platform"]/..//const[@value="Chef"]/../../../ident[@value="set"]')
+    ast.xpath('//const_path_ref/const[@value="Platform"]/..//const[@value="Chef"]/../../../ident[@value="set" or @value="provider_for_resource" or @value="find_provider"]')
   end
 end

data/lib/foodcritic/rules/fc094.rb

@@ -1,5 +1,5 @@
 rule "FC094", "Cookbook uses deprecated filesystem2 ohai plugin data" do
-  tags %w{deprecated chef15}
+  tags %w{deprecated chef14}
 
   recipe do |ast|
     ast.xpath('//aref[vcall/ident/@value="node"]

data/lib/foodcritic/rules/fc095.rb

@@ -1,5 +1,5 @@
 rule "FC095", "Cookbook uses deprecated cloud_v2 ohai plugin data" do
-  tags %w{deprecated chef15}
+  tags %w{deprecated chef14}
 
   recipe do |ast|
     ast.xpath('//aref[vcall/ident/@value="node"]

data/lib/foodcritic/rules/fc101.rb

@@ -0,0 +1,6 @@
+rule "FC101", "Deprecated deploy resource used" do
+  tags %w{chef14 deprecated}
+  recipe do |ast|
+    find_resources(ast, type: "deploy")
+  end
+end

data/lib/foodcritic/rules/fc102.rb

@@ -0,0 +1,11 @@
+rule "FC102", "Deprecated Chef::DSL::Recipe::FullDSL class used" do
+  tags %w{chef14 deprecated}
+  def full_dsl(ast)
+    # include Chef::DSL::Recipe::FullDSL
+    ast.xpath('//const_path_ref/const[@value="FullDSL"]/..//const[@value="Recipe"]/..//const[@value="DSL"]/..//const[@value="Chef"]')
+  end
+  recipe  { |ast| full_dsl(ast) }
+  library { |ast| full_dsl(ast) }
+  resource { |ast| full_dsl(ast) }
+
+end

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "12.0.1"
+  VERSION = "12.1.0"
 end

data/spec/functional/fc087_spec.rb

@@ -9,6 +9,20 @@ describe "FC087" do
     it { is_expected.to violate_rule }
   end
 
+  context "with a cookbook with a library that maps providers with Chef::Platform.provider_for_resource" do
+    library_file <<-EOF
+      provider = Chef::Platform.provider_for_resource(resource, :create)
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a library that maps providers with Chef::Platform.provider_for_resource" do
+    library_file <<-EOF
+      provider = Chef::Platform.find_provider("ubuntu", "16.04", resource)
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
   context "with a cookbook with a library that includes Chef::Platform.foo" do
     library_file <<-EOF
     module AuditD

data/spec/functional/fc100_spec.rb

@@ -6,7 +6,7 @@ describe "FC100" do
     it { is_expected.to violate_rule }
   end
 
-  context "with a cookbook with a recipe that includes Chef::Mixin::Languagee" do
+  context "with a cookbook with a recipe that includes Chef::Mixin::Language" do
     recipe_file "include Chef::Mixin::Language"
     it { is_expected.to violate_rule }
   end

data/spec/functional/fc101_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe "FC101" do
+  context "with a cookbook with a recipe that includes an deploy resource" do
+    recipe_file <<-EOF
+      deploy 'private_repo' do
+        repo 'git@github.com:acctname/private-repo.git'
+        user 'ubuntu'
+        deploy_to '/tmp/private_code'
+        ssh_wrapper '/tmp/private_code/wrap-ssh4git.sh'
+        action :deploy
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that doesn't include an deploy resource" do
+    recipe_file <<-EOF
+      package "foo"
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc102_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+
+describe "FC102" do
+  context "with a cookbook with a custom resource that includes Chef::DSL::Recipe::FullDSL" do
+    resource_file "include Chef::DSL::Recipe::FullDSL"
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that includes Chef::DSL::Recipe::FullDSL" do
+    recipe_file "include Chef::DSL::Recipe::FullDSL"
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a library that includes Chef::DSL::Recipe::FullDSL" do
+    library_file "include Chef::DSL::Recipe::FullDSL"
+    it { is_expected.to violate_rule }
+  end
+end

data/spec/regression/expected/heartbeat.txt

@@ -7,3 +7,5 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC087: Library uses deprecated Chef::Platform methods: ./libraries/default.rb:64
+FC098: Deprecated Chef::Mixin::RecipeDefinitionDSLCore mixin used: ./libraries/default.rb:24

data/spec/regression/expected/homebrew.txt

@@ -7,4 +7,4 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/tap.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
-FC087: Library maps provider with deprecated Chef::Platform.set: ./libraries/homebrew_package.rb:82
+FC087: Library uses deprecated Chef::Platform methods: ./libraries/homebrew_package.rb:82

data/spec/regression/expected/lvm.txt

@@ -11,3 +11,4 @@ FC074: LWRP should use DSL to define resource's default action: ./resources/logi
 FC074: LWRP should use DSL to define resource's default action: ./resources/physical_volume.rb:1
 FC074: LWRP should use DSL to define resource's default action: ./resources/volume_group.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC098: Deprecated Chef::Mixin::RecipeDefinitionDSLCore mixin used: ./resources/volume_group.rb:1

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 12.0.1
+  version: 12.1.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-19 00:00:00.000000000 Z
+date: 2017-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -334,6 +334,8 @@ files:
 - lib/foodcritic/rules/fc098.rb
 - lib/foodcritic/rules/fc099.rb
 - lib/foodcritic/rules/fc100.rb
+- lib/foodcritic/rules/fc101.rb
+- lib/foodcritic/rules/fc102.rb
 - lib/foodcritic/template.rb
 - lib/foodcritic/version.rb
 - lib/foodcritic/xml.rb
@@ -406,6 +408,8 @@ files:
 - spec/functional/fc098_spec.rb
 - spec/functional/fc099_spec.rb
 - spec/functional/fc100_spec.rb
+- spec/functional/fc101_spec.rb
+- spec/functional/fc102_spec.rb
 - spec/functional/root_aliases_spec.rb
 - spec/regression/cookbooks.txt
 - spec/regression/expected/activemq.txt
@@ -522,5 +526,5 @@ rubyforge_project:
 rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
-summary: foodcritic-12.0.1
+summary: foodcritic-12.1.0
 test_files: []