foodcritic 11.3.0 → 11.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88fc0b6609663a3130b05790fa5b002148959083
-  data.tar.gz: 625351ee8459d8a682782e0afdd3588b055a608e
+  metadata.gz: 649c27ad1db9be0b804920d0787560a4a794b51c
+  data.tar.gz: 005c520265a530401ed166011f99c52b5e823025
 SHA512:
-  metadata.gz: 417a8069b069de299e86ea247954d36da67a55846adee2e31f95ee96ca3d8c951b2d0726ce27f46c99838269d1dbf4b2685379a64291ed501275d613e3497741
-  data.tar.gz: 93162e4cef27844a44bcf91d3b96cfb4d3b7cc2d4205deb3f2218aa07fd3aa5bcf2d3abd5f5de0da533fcb250b2c822390b52bbc74fb5c049d898688cd846af1
+  metadata.gz: 6913668004c53199adb982b16831e5655d89dbd4fef72abc192c02b9269530776e9018b6ccd4a8d2b7d49deea1b7a53da9a18f9f36aac4033a29f49e439cdde9
+  data.tar.gz: 394d84b9f65477ec27eb564c0857859d973b4570120175390420efcef40cac6824a60ce707a106d456bef4fb052d10ee011a93eb88d2f06194d657f82551ca05

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Foodcritic Changelog:
 
+## [11.3.1](https://github.com/Foodcritic/foodcritic/tree/v11.3.1) (2017-08-17)
+
+**Fixed bugs:**
+
+- Allow EncryptedDataBagItem.load_secret in FC086
+
 ## [11.3.0](https://github.com/Foodcritic/foodcritic/tree/v11.3.0) (2017-07-12)
 
 [Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v11.2.0...v11.3.0)

data/lib/foodcritic/rules/fc086.rb

@@ -1,7 +1,7 @@
 rule "FC086", "Use databag helper methods to load data bag items" do
   tags %w{style}
   def old_dbag(ast)
-    ast.xpath('//const_path_ref/const[@value="EncryptedDataBagItem" or @value="DataBagItem"]/..//const[@value="Chef"]/../../..')
+    ast.xpath('//const_path_ref/const[@value="EncryptedDataBagItem" or @value="DataBagItem"]/..//const[@value="Chef"]/../../..//ident[@value!="load_secret"]/..')
   end
 
   resource { |ast| old_dbag(ast) }

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "11.3.0"
+  VERSION = "11.3.1"
 end

data/spec/functional/fc086_spec.rb

@@ -1,17 +1,17 @@
 require "spec_helper"
 
 describe "FC086" do
-  context "with a cookbook with a recipe that uses Chef::EncryptedDataBagItem.load_secret" do
+  context "with a recipe that uses Chef::EncryptedDataBagItem.load" do
     recipe_file 'Chef::EncryptedDataBagItem.load("users", "tsmith", key)'
     it { is_expected.to violate_rule }
   end
 
-  context "with a cookbook with a recipe that uses Chef::DataBagItem.load" do
+  context "with a recipe that uses Chef::DataBagItem.load" do
     recipe_file 'Chef::DataBagItem.load("users", "tsmith")'
     it { is_expected.to violate_rule }
   end
 
-  context "with a cookbook with a resource that uses Chef::EncryptedDataBagItem.load_secret" do
+  context "with a resource that uses Chef::EncryptedDataBagItem.load" do
     resource_file <<-EOF
       action :create do
         data = Chef::EncryptedDataBagItem.load("users", "tsmith", key)
@@ -20,7 +20,7 @@ describe "FC086" do
     it { is_expected.to violate_rule }
   end
 
-  context "with a cookbook with a resource that uses Chef::EncryptedDataBagItem.load_secret" do
+  context "with a resource that uses Chef::DataBagItem.load" do
     resource_file <<-EOF
       action :create do
         data = Chef::DataBagItem.load("users", "tsmith")
@@ -29,8 +29,13 @@ describe "FC086" do
     it { is_expected.to violate_rule }
   end
 
-  context "with a cookbook with a resource that uses data_bag_item" do
-    recipe_file "data_bag_item('bag', 'item', IO.read('secret_file'))"
+  context "with a recipe that uses data_bag_item" do
+    recipe_file "data_bag_item('bag', 'item', IO.read('secret_file').strip)"
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a recipe that uses Chef::EncryptedDataBagItem.load_secret" do
+    recipe_file "data_bag_item('bag', 'item', Chef::EncryptedDataBagItem.load_secret('secret_file'))"
     it { is_expected.not_to violate_rule }
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 11.3.0
+  version: 11.3.1
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-12 00:00:00.000000000 Z
+date: 2017-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -505,8 +505,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
-summary: foodcritic-11.3.0
+summary: foodcritic-11.3.1
 test_files: []