foodcritic 10.3.1 → 10.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 56253bb3557a5445e604382c6c5f17cae29fc1f2
-  data.tar.gz: ad35dc63ea6b20db003313d6291799ca01dcf939
+  metadata.gz: d188b03aeb991046c706c71cbebe4862c1dc56dd
+  data.tar.gz: c401c48d43ea472d45fc24c849202f33c5c6297f
 SHA512:
-  metadata.gz: 669e2805f7e0f7c7f6f7f4e8bc02db0edc2a69cfc49613b74feb3f198059fe529217b64579f1fc792afac8aa6975880a8e1c50009c352ae843692d8cc137b669
-  data.tar.gz: cb0b379d27bd13fc58f4a02d997bef287d5ceaba9825027e0622686edbaae598969afc6faa714419c1cf9de3ff0e4abf01d93a5e4866c07ee49a01f9fb933265
+  metadata.gz: 2505ff285da8b29cd42dd8884954c9b47ec01c1213e4c2fe6ea6a8efff71a58c52db0ef665629c0b236f318819ada2d023e566c0bf5f4573c3c3ace4bdd81046
+  data.tar.gz: 011375b9f658bc3afb31ae51ae84ac3e4742b38e0d20ff2fce7b04024f42425edb1feff5cf358cbda3da5860893f45c38f7cb1bfd19c72c98dccf030ad6cfeff

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Foodcritic Changelog:
 
+## [10.4.0](https://github.com/acrmp/foodcritic/tree/v10.4.0) (2017-04-13)
+
+[Full Changelog](https://github.com/acrmp/foodcritic/compare/v10.3.1...v10.4.0)
+
+**Implemented enhancements:**
+
+- Added FC076 to alert when the deprecated `conflicts` metadata is used
+- Added FC077 to alert when the deprecated `replaces` metadata is used
+- Added FC076 to alert when a non-OSI-approved license is used in metadata. You can disable this rule turning off the new `opensource` tag. For example: `foodcritic -t ~opensource .`
+
+**Fixed bugs:**
+
+- Regression tests now ignore .foodcritic files so we see all possible failures
+- FC053 / FC052 updated to properly refer the metadata as deprecated and not unimplemented
+- FC071 no longer alerts when cookbooks are licensed as "All Rights Reserved"
+
 ## [10.3.1](https://github.com/acrmp/foodcritic/tree/v10.3.1) (2017-04-10)
 
 [Full Changelog](https://github.com/acrmp/foodcritic/compare/v10.3.0...v10.3.1)

data/Rakefile

@@ -74,7 +74,7 @@ task :regen_regression do
       checkout_cmd = Mixlib::ShellOut.new("git", "checkout", ref, cwd: temp)
       checkout_cmd.run_command
       checkout_cmd.error!
-      fc_cmd = Mixlib::ShellOut.new(File.expand_path("../bin/foodcritic", __FILE__), "--no-progress", ".", cwd: temp)
+      fc_cmd = Mixlib::ShellOut.new("#{File.expand_path("../bin/foodcritic", __FILE__)} --tags any --no-progress .", cwd: temp)
       fc_cmd.run_command
       out_path = File.expand_path("../spec/regression/expected/#{name}.txt", __FILE__)
       IO.write(out_path, fc_cmd.stdout)

data/features/support/command_helpers.rb

@@ -62,8 +62,8 @@ module FoodCritic
       "FC049" => "Role name does not match containing file name",
       "FC050" => "Name includes invalid characters",
       "FC051" => "Template partials loop indefinitely",
-      "FC052" => 'Metadata uses the unimplemented "suggests" keyword',
-      "FC053" => 'Metadata uses the unimplemented "recommends" keyword',
+      "FC052" => 'Metadata uses the deprecated "suggests" keyword',
+      "FC053" => 'Metadata uses the deprecated "recommends" keyword',
       # FC054 was yanked and is considered reserved, do not reuse it
       "FC055" => "Ensure maintainer is set in metadata",
       "FC056" => "Ensure maintainer_email is set in metadata",

data/lib/foodcritic/rules/fc052.rb

@@ -1,4 +1,4 @@
-rule "FC052", 'Metadata uses the unimplemented "suggests" keyword' do
+rule "FC052", 'Metadata uses the deprecated "suggests" keyword' do
   tags %w{style metadata deprecated}
   metadata do |ast, filename|
     ast.xpath(%q{//command[ident/@value='suggests']})

data/lib/foodcritic/rules/fc053.rb

@@ -1,4 +1,4 @@
-rule "FC053", 'Metadata uses the unimplemented "recommends" keyword' do
+rule "FC053", 'Metadata uses the deprecated "recommends" keyword' do
   tags %w{style metadata deprecated}
   metadata do |ast, filename|
     ast.xpath(%q{//command[ident/@value='recommends']})

data/lib/foodcritic/rules/fc071.rb

@@ -1,6 +1,8 @@
 rule "FC071", "Missing LICENSE file" do
   tags %w{style license}
   cookbook do |path|
-    ensure_file_exists(path, "LICENSE")
+    unless ::File.exist?("metadata.rb") && field_value(read_ast("metadata.rb"), "license") == "All Rights Reserved"
+      ensure_file_exists(path, "LICENSE")
+    end
   end
 end

data/lib/foodcritic/rules/fc076.rb

@@ -0,0 +1,6 @@
+rule "FC076", 'Metadata uses the deprecated "conflicts" keyword' do
+  tags %w{metadata deprecated chef13}
+  metadata do |ast, filename|
+    [file_match(filename)] if field(ast, "conflicts").any?
+  end
+end

data/lib/foodcritic/rules/fc077.rb

@@ -0,0 +1,6 @@
+rule "FC077", 'Metadata uses the deprecated "replaces" keyword' do
+  tags %w{metadata deprecated chef13}
+  metadata do |ast, filename|
+    [file_match(filename)] if field(ast, "replaces").any?
+  end
+end

data/lib/foodcritic/rules/fc078.rb

@@ -0,0 +1,135 @@
+rule "FC078", "Ensure cookbook shared under an OSI-approved open source license" do
+  tags %w{opensource}
+  metadata do |ast, filename|
+    begin
+      license = ast.xpath(%Q{//command[ident/@value='license']/
+                            descendant::tstring_content}).attribute("value").to_s
+
+      # list of valid SPDX.org license strings. To build an array run this:
+      # require 'json'
+      # require 'net/http'
+      # json_data = JSON.parse(Net::HTTP.get(URI('https://raw.githubusercontent.com/spdx/license-list-data/master/json/licenses.json')))
+      # licenses = json_data['licenses']
+      #  .select { |license| license['isOsiApproved'] }
+      #  .map {|l| l['licenseId'] }
+      #
+      osi_approved_licenses = %w{
+        AFL-1.1
+        AFL-1.2
+        AFL-2.0
+        AFL-2.1
+        AFL-3.0
+        APL-1.0
+        Apache-1.1
+        Apache-2.0
+        APSL-1.0
+        APSL-1.1
+        APSL-1.2
+        APSL-2.0
+        Artistic-1.0
+        Artistic-1.0-Perl
+        Artistic-1.0-cl8
+        Artistic-2.0
+        AAL
+        BSL-1.0
+        BSD-2-Clause
+        BSD-3-Clause
+        0BSD
+        CECILL-2.1
+        CNRI-Python
+        CDDL-1.0
+        CPAL-1.0
+        CPL-1.0
+        CATOSL-1.1
+        CUA-OPL-1.0
+        EPL-1.0
+        ECL-1.0
+        ECL-2.0
+        EFL-1.0
+        EFL-2.0
+        Entessa
+        EUDatagrid
+        EUPL-1.1
+        Fair
+        Frameworx-1.0
+        AGPL-3.0
+        GPL-2.0
+        GPL-3.0
+        LGPL-2.1
+        LGPL-3.0
+        LGPL-2.0
+        HPND
+        IPL-1.0
+        Intel
+        IPA
+        ISC
+        LPPL-1.3c
+        LiLiQ-P-1.1
+        LiLiQ-Rplus-1.1
+        LiLiQ-R-1.1
+        LPL-1.02
+        LPL-1.0
+        MS-PL
+        MS-RL
+        MirOS
+        MIT
+        Motosoto
+        MPL-1.0
+        MPL-1.1
+        MPL-2.0
+        MPL-2.0-no-copyleft-exception
+        Multics
+        NASA-1.3
+        Naumen
+        NGPL
+        Nokia
+        NPOSL-3.0
+        NTP
+        OCLC-2.0
+        OGTSL
+        OSL-1.0
+        OSL-2.0
+        OSL-2.1
+        OSL-3.0
+        OSET-PL-2.1
+        PHP-3.0
+        PostgreSQL
+        Python-2.0
+        QPL-1.0
+        RPSL-1.0
+        RPL-1.1
+        RPL-1.5
+        RSCPL
+        OFL-1.1
+        SimPL-2.0
+        Sleepycat
+        SISSL
+        SPL-1.0
+        Watcom-1.0
+        UPL-1.0
+        NCSA
+        VSL-1.0
+        W3C
+        Xnet
+        Zlib
+        ZPL-2.0
+        GPL-2.0+
+        GPL-2.0-with-autoconf-exception
+        GPL-2.0-with-bison-exception
+        GPL-2.0-with-classpath-exception
+        GPL-2.0-with-font-exception
+        GPL-2.0-with-GCC-exception
+        GPL-3.0+
+        GPL-3.0-with-autoconf-exception
+        GPL-3.0-with-GCC-exception
+        LGPL-2.1+
+        LGPL-3.0+
+        LGPL-2.0+
+        WXwindows
+      }
+      [file_match(filename)] unless osi_approved_licenses.include?(license)
+    rescue NoMethodError # no license in the metadata
+      [file_match(filename)]
+    end
+  end
+end

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "10.3.1"
+  VERSION = "10.4.0"
 end

data/spec/functional/fc071_spec.rb

@@ -11,4 +11,9 @@ describe "FC071" do
     metadata_file "name 'mycookbook'"
     it { is_expected.to violate_rule("FC071") }
   end
+
+  context "with a cookbook without a LICENSE file but with license of 'All Rights Reserved'" do
+    metadata_file "license 'All Rights Reserved'"
+    it { is_expected.not_to violate_rule("FC071") }
+  end
 end

data/spec/functional/fc076_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC076" do
+  context "with a cookbook with a metadata file that does contain the conflicts keyword" do
+    metadata_file "conflicts 'runit'"
+    it { is_expected.to violate_rule("FC076") }
+  end
+
+  context "with a cookbook with a metadata file that does not contain the conflicts keyword" do
+    metadata_file
+    it { is_expected.to_not violate_rule("FC076") }
+  end
+end

data/spec/functional/fc077_spec.rb

@@ -0,0 +1,13 @@
+require "spec_helper"
+
+describe "FC077" do
+  context "with a cookbook with a metadata file that does contain the replaces keyword" do
+    metadata_file "replaces 'runit'"
+    it { is_expected.to violate_rule("FC077") }
+  end
+
+  context "with a cookbook with a metadata file that does not contain the replaces keyword" do
+    metadata_file
+    it { is_expected.to_not violate_rule("FC077") }
+  end
+end

data/spec/functional/fc078_spec.rb

@@ -0,0 +1,25 @@
+require "spec_helper"
+
+describe "FC078" do
+  context "with a cookbook with a metadata file that specifies" do
+    context "a license generated by knife cookbook create" do
+      metadata_file "license 'Apache 2.0'"
+      it { is_expected.to violate_rule("FC078") }
+    end
+
+    context "a license generated by chef generate cookbook" do
+      metadata_file "license 'apache_2'"
+      it { is_expected.to violate_rule("FC078") }
+    end
+
+    context "a valid OSI-approved open source license in SPDX format" do
+      metadata_file "license 'Apache-2.0'"
+      it { is_expected.to_not violate_rule("FC078") }
+    end
+
+    context "ChefDK's non-SPDX all rights reserved string" do
+      metadata_file "license 'All Rights Reserved'"
+      it { is_expected.to violate_rule("FC078") }
+    end
+  end
+end

data/spec/regression/cookbooks.txt

@@ -1,16 +1,25 @@
 activemq:5dce4ca5283d2a6252130a2d800b9387a57d6e01
+aix:f40afb959cc5edc3e838072c6c4f817708657f1b
 apparmor:fd09a6fda4f6fc722d4c8d5b8a5c815feda280c0
 apt:ea834265247cc8b507ac37ab3a34a9b44ed27a11
+ark:950ed665bc82c13194cb7c0cac3154a4b73e40c7
+auditd:eff59f9ca300ac0514e8c96769bc3e8e8c22a76a
 aws:a9530561bf559c6db2cb40a93b125607c5ef3efa
 bluepill:1d6422afcbc910e587c9639e4e0a28c72727c90b
 boost:14f30e36040a4fcd038f030d9ee1c7fb29b08b68
 build-essential:0c636536fb1236f792974f3af38f2950a03ed4b2
 chef:dac09eea9fa0d611b7b010160d6b8fa7f4d6ae1e
 chef-client:7fc4472c9913c9cb1762f979e05047a674318ef5
+chef-ingredient:e9c2f58af73d49b5783754757f0a38aa87abd37f
 chef-server:d98b96d69962c7988b9640fe5bee09f771ba8977
+chef-vault:6ad7e34f9b860dc1b339a0c1814214595098e4b0
+chef_client_updater:01b39eaa81f017cebca3ab3a941683eb962d9bd2
 chef_handler:d147ca9644f146b97a2d53324ca344321799b45f
+chef_hostname:24776c9ea403a82b5aecc6b1a4a829e892f4db95
+chef_nginx:1f22dd7b7e04e60a1ea9fd0cc4ab980a4be05d4d
 cron:dce04363b6a02d36f8da88f202cedfae2daa6a2c
 database:1ab3822ca50824fbdc14f7c89341faa7ae1e90cb
+docker:e0f18072406abf1ade70745a7ef7e5529f00c109
 dmg:11caf56f57a1168a891f01f0614a01b879aff624
 drbd:e65b60894b48855163c3a13ead40fb897d66c4b8
 dynect:5ef2328cc612cc4c36882742367af0e2bdbd0367
@@ -26,9 +35,10 @@ iis:ab7e4823d375e8eb4f927dee5b7ab0591301cb0e
 iptables:da126cf900af3cc36bf212973bb8d0be69fa2b9f
 jetty:d165775c2c7ce3cc484cbe8c7aadf6649505d078
 jpackage:23e6f4b717620455ee9d29cbf82d9a7ab7fa6e5b
-keepalived:629c8e4c5251f6125be9f6eacecb1369fcb1cd4c
+keepalived:0c8bc5ea5aba93b5bc58ebea8661c1e1762ea463
 kickstart:6523fca008362ed72f8fbb25f0c7af70d563b96d
 logwatch:706174796a3bc1d85d57d3aee792e78cb13570ac
+libarchive:5f21a614017c7cffb3fe7f56185c0b988fad7826
 lvm:57bd5291fbaa41e7a13f25c4553cdacbfc3ad3dd
 maradns:e975ded4303432629ad37234cb7a05c9d6edcf73
 maven:e486321f1e89f7ad2b9700c08fcbc68c32daa599
@@ -48,26 +58,26 @@ powershell:4b175affe1a8a7d091a8ca905a580bf975af5edc
 resolver:105ad0a2fc9c065a7c4455cfc07ab7771b8e0da0
 rsync:41756f404fc39f3ce407cce9fe03294dd907c0fe
 rsyslog:8830d558d2ee3126fef56ea3a25a4f0253ce269f
+runit:92c60395a0727bc4941b58e95a4d67cc163a2b98
+smokeping:db0b62ab6d71a782d378c550d37464f024abe144
 sql_server:d9702f8fc29f208c9e712627cda64ccae2d71321
-sqlite:3efb50f4166f04f1afefa21f7f8fe7e9082b37ed
 ssh_known_hosts:a89f0c32e8e2c408a2e153153cc703f1184c6b72
 stompserver:bf81830bb7783f4198565201c825c23267e1d515
 subversion:cad4c069deca1fbbfb6b8f4d21b6c341cc9c6b55
 sudo:00d024f293afb9df4fea23ba127529d67c1daf14
+tar:8586d01346324f413fea9c4b48a214f5e12d3a49
 tftp:f4016b14eae2c0fe7fb48020bf28039c2de043a4
-tomcat:8934392833cef89b7b779b4cd36ad46d088b643b
+tomcat:a99c916e8ec00b2e008c16e8b4aa9adcffbb1056
 transmission:c3d62aa4741a55b693630d9cc48b012ff22d2e7b
 ubuntu:7d21b626873ee397755d59aa222cf7fa681f6e90
 ufw:6bc6de62a84f6fa6f172edf0a490f1a332e89e29
 unicorn:bacbb2400dcb476dd53784aa965fa9329e8c3869
 users:c51c96afca83b382678dc21b8deb25677e6a3d8a
+vcruntime:87ea6e2bb16871ec132f03ca014e481e473f958a
 vim:88e8d018267d2cd5cfa3260ce55a0025f52dae6f
 webpi:6cb4fde9dedf2abc980fa49880753512baa26b23
 whitelist-node-attrs:2d76a2d179096e3ab048547d0d7849238ac2a5d3
 windows:1601558f5fce30bed47bfc6d458a80891e127c61
 wix:422b8da1dcf706bb4742d83abc44a649522afe83
-xfs:7f1033820459324a863b2955e774cfa366fbc70f
 xml:0b538834aa26c4df5918aa193029d285d7b1d4de
 yum:b1191511b011790b2fc5c35cfbc78d0cc7bbc5b8
-zlib:45342f78d2866c3b2f443e693df562317e37963d
-zsh:3bff82836677564478ffc90dfb487ffc986702f3

data/spec/regression/expected/aix.txt

@@ -0,0 +1 @@
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/ark.txt

@@ -0,0 +1 @@
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/auditd.txt

@@ -0,0 +1,5 @@
+FC017: LWRP does not notify when updated: ./providers/builtins.rb:22
+FC017: LWRP does not notify when updated: ./providers/ruleset.rb:21
+FC059: LWRP provider does not declare use_inline_resources: ./providers/builtins.rb:1
+FC059: LWRP provider does not declare use_inline_resources: ./providers/ruleset.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/boost.txt

@@ -1,5 +1,5 @@
 FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./recipes/source.rb:1
-FC053: Metadata uses the unimplemented "recommends" keyword: ./metadata.rb:12
+FC053: Metadata uses the deprecated "recommends" keyword: ./metadata.rb:12
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/build-essential.txt

@@ -1,5 +1,5 @@
 FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./recipes/default.rb:65
-FC052: Metadata uses the unimplemented "suggests" keyword: ./metadata.rb:14
+FC052: Metadata uses the deprecated "suggests" keyword: ./metadata.rb:14
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/chef-ingredient.txt

@@ -0,0 +1,2 @@
+FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/{zlib.txt → chef-vault.txt}

@@ -1,4 +1,3 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
+FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/chef_client_updater.txt

@@ -0,0 +1 @@
+FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1

data/spec/regression/expected/chef_hostname.txt

@@ -0,0 +1,2 @@
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1

data/spec/regression/expected/chef_nginx.txt

@@ -0,0 +1,2 @@
+FC015: Consider converting definition to a Custom Resource: ./definitions/nginx_site.rb:1
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/docker.txt

@@ -0,0 +1,2 @@
+FC005: Avoid repetition of resource declarations: ./libraries/docker_service_manager_sysvinit_debian.rb:5
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/keepalived.txt

@@ -1,4 +1,2 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/{sqlite.txt → libarchive.txt}

@@ -1,3 +1,4 @@
+FC059: LWRP provider does not declare use_inline_resources: ./providers/file.rb:1
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/mysql.txt

@@ -3,8 +3,8 @@ FC002: Avoid string interpolation where not required: ./attributes/server.rb:206
 FC002: Avoid string interpolation where not required: ./attributes/server.rb:207
 FC002: Avoid string interpolation where not required: ./attributes/server.rb:208
 FC007: Ensure recipe dependencies are reflected in cookbook metadata: ./recipes/client.rb:42
-FC052: Metadata uses the unimplemented "suggests" keyword: ./metadata.rb:19
-FC052: Metadata uses the unimplemented "suggests" keyword: ./metadata.rb:20
+FC052: Metadata uses the deprecated "suggests" keyword: ./metadata.rb:19
+FC052: Metadata uses the deprecated "suggests" keyword: ./metadata.rb:20
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1

data/spec/regression/expected/runit.txt

@@ -0,0 +1,2 @@
+FC004: Use a service resource to start and stop services: ./recipes/default.rb:24
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/{zsh.txt → smokeping.txt}

@@ -1,4 +1,3 @@
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
+FC059: LWRP provider does not declare use_inline_resources: ./providers/target.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/{xfs.txt → tar.txt}

@@ -1,4 +1,7 @@
 FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
 FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
+FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
+FC071: Missing LICENSE file: ./LICENSE:1
+FC074: LWRP should use DSL to define resource's default action: ./resources/package.rb:1

data/spec/regression/expected/tomcat.txt

@@ -1,8 +1 @@
-FC043: Prefer new notification syntax: ./recipes/default.rb:50
-FC043: Prefer new notification syntax: ./recipes/default.rb:58
-FC043: Prefer new notification syntax: ./recipes/default.rb:67
-FC043: Prefer new notification syntax: ./recipes/users.rb:22
-FC064: Ensure issues_url is set in metadata: ./metadata.rb:1
-FC065: Ensure source_url is set in metadata: ./metadata.rb:1
-FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/expected/vcruntime.txt

@@ -0,0 +1,7 @@
+FC009: Resource attribute not recognised: ./recipes/vc10.rb:24
+FC009: Resource attribute not recognised: ./recipes/vc11.rb:24
+FC009: Resource attribute not recognised: ./recipes/vc12.rb:24
+FC009: Resource attribute not recognised: ./recipes/vc14.rb:24
+FC009: Resource attribute not recognised: ./recipes/vc6.rb:24
+FC009: Resource attribute not recognised: ./recipes/vc9.rb:24
+FC069: Ensure standardized license defined in metadata: ./metadata.rb:1

data/spec/regression/regression_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 describe "regression test" do
-  command("#{File.expand_path("../../../bin/foodcritic", __FILE__)} .", allow_error: true)
+  command("#{File.expand_path("../../../bin/foodcritic", __FILE__)} --tags any .", allow_error: true)
 
   IO.readlines(File.expand_path("../cookbooks.txt", __FILE__)).each do |line|
     name, ref = line.strip.split(":")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 10.3.1
+  version: 10.4.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-10 00:00:00.000000000 Z
+date: 2017-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -324,6 +324,9 @@ files:
 - lib/foodcritic/rules/fc073.rb
 - lib/foodcritic/rules/fc074.rb
 - lib/foodcritic/rules/fc075.rb
+- lib/foodcritic/rules/fc076.rb
+- lib/foodcritic/rules/fc077.rb
+- lib/foodcritic/rules/fc078.rb
 - lib/foodcritic/template.rb
 - lib/foodcritic/version.rb
 - lib/foodcritic/xml.rb
@@ -384,22 +387,34 @@ files:
 - spec/functional/fc073_spec.rb
 - spec/functional/fc074_spec.rb
 - spec/functional/fc075_spec.rb
+- spec/functional/fc076_spec.rb
+- spec/functional/fc077_spec.rb
+- spec/functional/fc078_spec.rb
 - spec/functional/root_aliases_spec.rb
 - spec/regression/cookbooks.txt
 - spec/regression/expected/activemq.txt
+- spec/regression/expected/aix.txt
 - spec/regression/expected/apparmor.txt
 - spec/regression/expected/apt.txt
+- spec/regression/expected/ark.txt
+- spec/regression/expected/auditd.txt
 - spec/regression/expected/aws.txt
 - spec/regression/expected/bluepill.txt
 - spec/regression/expected/boost.txt
 - spec/regression/expected/build-essential.txt
 - spec/regression/expected/chef-client.txt
+- spec/regression/expected/chef-ingredient.txt
 - spec/regression/expected/chef-server.txt
+- spec/regression/expected/chef-vault.txt
 - spec/regression/expected/chef.txt
+- spec/regression/expected/chef_client_updater.txt
 - spec/regression/expected/chef_handler.txt
+- spec/regression/expected/chef_hostname.txt
+- spec/regression/expected/chef_nginx.txt
 - spec/regression/expected/cron.txt
 - spec/regression/expected/database.txt
 - spec/regression/expected/dmg.txt
+- spec/regression/expected/docker.txt
 - spec/regression/expected/drbd.txt
 - spec/regression/expected/dynect.txt
 - spec/regression/expected/erlang.txt
@@ -416,6 +431,7 @@ files:
 - spec/regression/expected/jpackage.txt
 - spec/regression/expected/keepalived.txt
 - spec/regression/expected/kickstart.txt
+- spec/regression/expected/libarchive.txt
 - spec/regression/expected/logwatch.txt
 - spec/regression/expected/lvm.txt
 - spec/regression/expected/maradns.txt
@@ -436,12 +452,14 @@ files:
 - spec/regression/expected/resolver.txt
 - spec/regression/expected/rsync.txt
 - spec/regression/expected/rsyslog.txt
+- spec/regression/expected/runit.txt
+- spec/regression/expected/smokeping.txt
 - spec/regression/expected/sql_server.txt
-- spec/regression/expected/sqlite.txt
 - spec/regression/expected/ssh_known_hosts.txt
 - spec/regression/expected/stompserver.txt
 - spec/regression/expected/subversion.txt
 - spec/regression/expected/sudo.txt
+- spec/regression/expected/tar.txt
 - spec/regression/expected/tftp.txt
 - spec/regression/expected/tomcat.txt
 - spec/regression/expected/transmission.txt
@@ -449,16 +467,14 @@ files:
 - spec/regression/expected/ufw.txt
 - spec/regression/expected/unicorn.txt
 - spec/regression/expected/users.txt
+- spec/regression/expected/vcruntime.txt
 - spec/regression/expected/vim.txt
 - spec/regression/expected/webpi.txt
 - spec/regression/expected/whitelist-node-attrs.txt
 - spec/regression/expected/windows.txt
 - spec/regression/expected/wix.txt
-- spec/regression/expected/xfs.txt
 - spec/regression/expected/xml.txt
 - spec/regression/expected/yum.txt
-- spec/regression/expected/zlib.txt
-- spec/regression/expected/zsh.txt
 - spec/regression/regression_spec.rb
 - spec/spec_helper.rb
 - spec/unit/api_spec.rb
@@ -490,5 +506,5 @@ rubyforge_project:
 rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
-summary: foodcritic-10.3.1
+summary: foodcritic-10.4.0
 test_files: []