foodcritic 13.1.1 → 14.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b858aa4f622933d71f53374eb8fc6dc128bf64edf373dabe496d479f7e6810a4
-  data.tar.gz: 157fb6af5a3bbbac77b837a045dcf5479375a0107a907387e58cec6cfd557896
+  metadata.gz: 6c8d8788e61de8e4a41fc35bf3ff5358301d95aaa16f2f477a15c468f3dd490e
+  data.tar.gz: da4590ab0a0c648ca9bb0fd3101b664e0b7e80f4d3fef8a78fbbd435ce5ac6b4
 SHA512:
-  metadata.gz: aa6c67bbace23b89f175be01b8a4f2d070713ee4040749cc2747934f85ee64ce2323366ba8298676209bc9623a047eb47ca030c7d57acb3997d26affad8c7919
-  data.tar.gz: 14c7e53a8247e861a2e6edbde44cf95b5b60bde02343cd15cfe4e721dd9c8eebe78170b1f0945a551200fe8764ea80c74bd3bb4c10dcf490cb1b10d33a6a3ffd
+  metadata.gz: c42491fec8d5ccb5fde42a412ae8144a7f9143ea1174c7ea2e13c05f0402149717e9511a08be3cd1d22a4a8da6729c82f71496dd14aa62b1aea3b2772dce51cc
+  data.tar.gz: 287c6017d11d84ea6aa76d07870038a42aa73fd74fe77f06972f84216ee9b048fdc054abe65370961af2b1ad4b7adf8e0f6f59238a3e52471c4552c784119109

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Foodcritic Changelog:
 
+## [14.0.0](https://github.com/Foodcritic/foodcritic/tree/v14.0.0) (2018-06-28)
+
+- Removed Chef 13.0, 13.1, and 13.3 metadata.
+- Added Chef 13.9, 14.1, and 14.2 metadata and made 14.2 the new default, which adds property checking for all new Chef 14 resources to Foodcritic.
+- Renamed FC048 from "Prefer Mixlib::ShellOut" to "Prefer shell_out helper method to shelling out with Ruby" since Chef includes a helpful shell_out helper that is the preferred way to shell out in resources or libraries.
+- Removed FC012, which looked for legacy README.rdoc files. These haven't existed since the very early days of Chef and our existing check for README.MD files will catch any cookbooks still missing the proper format.
+- Added the opensource tag to FC071: Missing LICENSE file. This lets you easily skip this by excluding any rules tagged with opensource.
+- Added a new rule FC121: Cookbook depends on cookbook made obsolete by Chef 14\. This rule detects cookbook which depend on build-essential, dmg, chef_handler, chef_hostname, mac_os_x, swap, or sysctl cookbooks. The resources from these cookbooks now ship in Chef 14 and depending on the cookbooks is no longer necessary. Note removing these dependencies does increase the minimum required chef-client for
+- The non-existent resource UnresolvedSubscribes has been removed from the metadata files slimming Foodcritic's install size by 1500 lines.
+- Updated the list of SPDX licenses in FC069 and FC078 to the current list.
+
 ## [13.1.1](https://github.com/Foodcritic/foodcritic/tree/v13.1.1) (2018-04-12)
 
 - Fixed an error in the detection of attributes.rb files when using root alias functionality

data/chef_dsl_metadata/chef_13.4.19.json

@@ -1216,9 +1216,6 @@
       "nothing",
       "rollback"
     ],
-    "unresolved_subscribes": [
-      "nothing"
-    ],
     "user": [
       "create",
       "lock",
@@ -17515,215 +17512,6 @@
       "wow64_architecture_override_required?",
       "wow64_directory"
     ],
-    "unresolved_subscribes": [
-      "!",
-      "!=",
-      "!~",
-      "<=>",
-      "==",
-      "===",
-      "=~",
-      "__id__",
-      "__send__",
-      "a_to_s",
-      "action",
-      "action=",
-      "after_created",
-      "allowed_actions",
-      "allowed_actions=",
-      "as_json",
-      "assert_valid_windows_architecture!",
-      "before_notifications",
-      "class",
-      "clean_array",
-      "clone",
-      "constantize",
-      "convert_to_class_name",
-      "convert_to_snake_case",
-      "cookbook_name",
-      "cookbook_name=",
-      "cookbook_version",
-      "current_value",
-      "current_value_does_not_exist!",
-      "custom_exception_message",
-      "customize_exception",
-      "data_bag",
-      "data_bag_item",
-      "dclone",
-      "declared_key",
-      "declared_type",
-      "declared_type=",
-      "default_guard_interpreter",
-      "define_singleton_method",
-      "defined_at",
-      "delayed_action",
-      "delayed_notifications",
-      "deny_rights",
-      "deprecated_attr",
-      "deprecated_attr_reader",
-      "deprecated_attr_writer",
-      "deprecated_ivar",
-      "disable_wow64_file_redirection",
-      "display",
-      "docker?",
-      "dup",
-      "elapsed_time",
-      "enclosing_provider",
-      "enclosing_provider=",
-      "encrypted?",
-      "enforce_path_sanity",
-      "enum_for",
-      "epic_fail",
-      "eql?",
-      "equal?",
-      "events",
-      "extend",
-      "ffi_yajl",
-      "filename_to_qualified_string",
-      "forced_32bit_override_required?",
-      "freeze",
-      "frozen?",
-      "gem",
-      "guard_interpreter",
-      "hash",
-      "identity",
-      "ignore_failure",
-      "ignore_failure=",
-      "immediate_notifications",
-      "inherits",
-      "inspect",
-      "instance_eval",
-      "instance_exec",
-      "instance_of?",
-      "instance_variable_defined?",
-      "instance_variable_get",
-      "instance_variable_set",
-      "instance_variables",
-      "is_a?",
-      "is_i386_process_on_x86_64_windows?",
-      "itself",
-      "kind_of?",
-      "lazy",
-      "load_from",
-      "lookup_provider_constant",
-      "method",
-      "method_missing",
-      "methods",
-      "name",
-      "name=",
-      "nil?",
-      "node",
-      "node_supports_windows_architecture?",
-      "node_windows_architecture",
-      "normalize_snake_case_name",
-      "not_if",
-      "notifies",
-      "notifies_before",
-      "notifies_delayed",
-      "notifies_immediately",
-      "object_id",
-      "only_if",
-      "params",
-      "params=",
-      "platform?",
-      "platform_family?",
-      "powershell_out",
-      "powershell_out!",
-      "pretty_inspect",
-      "pretty_print",
-      "pretty_print_cycle",
-      "pretty_print_inspect",
-      "pretty_print_instance_variables",
-      "private_methods",
-      "property_is_set?",
-      "protected_methods",
-      "provider",
-      "provider=",
-      "provider_for_action",
-      "psych_to_yaml",
-      "public_method",
-      "public_methods",
-      "public_send",
-      "reboot_pending?",
-      "recipe_name",
-      "recipe_name=",
-      "registry_data_exists?",
-      "registry_get_subkeys",
-      "registry_get_values",
-      "registry_has_subkeys?",
-      "registry_key_exists?",
-      "registry_value_exists?",
-      "remove_instance_variable",
-      "reset_property",
-      "resolve_notification_references",
-      "resource_initializing",
-      "resource_initializing=",
-      "resource_name",
-      "resources",
-      "respond_to?",
-      "restore_wow64_file_redirection",
-      "retries",
-      "retries=",
-      "retry_delay",
-      "retry_delay=",
-      "rights",
-      "run_action",
-      "run_context",
-      "run_context=",
-      "sanitized_path",
-      "search",
-      "send",
-      "sensitive",
-      "sensitive=",
-      "set_or_return",
-      "shell_out",
-      "shell_out!",
-      "shell_out_compact",
-      "shell_out_compact!",
-      "shell_out_compact_timeout",
-      "shell_out_compact_timeout!",
-      "shell_out_with_systems_locale",
-      "shell_out_with_systems_locale!",
-      "should_skip?",
-      "singleton_class",
-      "singleton_method",
-      "singleton_methods",
-      "snake_case_basename",
-      "source_line",
-      "source_line=",
-      "source_line_file",
-      "source_line_number",
-      "state_for_resource_reporter",
-      "subscribes",
-      "taint",
-      "tainted?",
-      "tap",
-      "to_enum",
-      "to_hash",
-      "to_json",
-      "to_s",
-      "to_text",
-      "to_yaml",
-      "to_yaml_properties",
-      "trust",
-      "untaint",
-      "untrust",
-      "untrusted?",
-      "updated",
-      "updated?",
-      "updated_by_last_action",
-      "updated_by_last_action?",
-      "valid_windows_architecture?",
-      "validate",
-      "validate_action",
-      "validate_resource_spec!",
-      "value_for_platform",
-      "value_for_platform_family",
-      "value_to_text",
-      "with_os_architecture",
-      "wow64_architecture_override_required?",
-      "wow64_directory"
-    ],
     "user": [
       "!",
       "!=",

data/chef_dsl_metadata/chef_13.5.3.json

@@ -1216,9 +1216,6 @@
       "nothing",
       "rollback"
     ],
-    "unresolved_subscribes": [
-      "nothing"
-    ],
     "user": [
       "create",
       "lock",
@@ -17516,215 +17513,6 @@
       "wow64_architecture_override_required?",
       "wow64_directory"
     ],
-    "unresolved_subscribes": [
-      "!",
-      "!=",
-      "!~",
-      "<=>",
-      "==",
-      "===",
-      "=~",
-      "__id__",
-      "__send__",
-      "a_to_s",
-      "action",
-      "action=",
-      "after_created",
-      "allowed_actions",
-      "allowed_actions=",
-      "as_json",
-      "assert_valid_windows_architecture!",
-      "before_notifications",
-      "class",
-      "clean_array",
-      "clone",
-      "constantize",
-      "convert_to_class_name",
-      "convert_to_snake_case",
-      "cookbook_name",
-      "cookbook_name=",
-      "cookbook_version",
-      "current_value",
-      "current_value_does_not_exist!",
-      "custom_exception_message",
-      "customize_exception",
-      "data_bag",
-      "data_bag_item",
-      "dclone",
-      "declared_key",
-      "declared_type",
-      "declared_type=",
-      "default_guard_interpreter",
-      "define_singleton_method",
-      "defined_at",
-      "delayed_action",
-      "delayed_notifications",
-      "deny_rights",
-      "deprecated_attr",
-      "deprecated_attr_reader",
-      "deprecated_attr_writer",
-      "deprecated_ivar",
-      "disable_wow64_file_redirection",
-      "display",
-      "docker?",
-      "dup",
-      "elapsed_time",
-      "enclosing_provider",
-      "enclosing_provider=",
-      "encrypted?",
-      "enforce_path_sanity",
-      "enum_for",
-      "epic_fail",
-      "eql?",
-      "equal?",
-      "events",
-      "extend",
-      "ffi_yajl",
-      "filename_to_qualified_string",
-      "forced_32bit_override_required?",
-      "freeze",
-      "frozen?",
-      "gem",
-      "guard_interpreter",
-      "hash",
-      "identity",
-      "ignore_failure",
-      "ignore_failure=",
-      "immediate_notifications",
-      "inherits",
-      "inspect",
-      "instance_eval",
-      "instance_exec",
-      "instance_of?",
-      "instance_variable_defined?",
-      "instance_variable_get",
-      "instance_variable_set",
-      "instance_variables",
-      "is_a?",
-      "is_i386_process_on_x86_64_windows?",
-      "itself",
-      "kind_of?",
-      "lazy",
-      "load_from",
-      "lookup_provider_constant",
-      "method",
-      "method_missing",
-      "methods",
-      "name",
-      "name=",
-      "nil?",
-      "node",
-      "node_supports_windows_architecture?",
-      "node_windows_architecture",
-      "normalize_snake_case_name",
-      "not_if",
-      "notifies",
-      "notifies_before",
-      "notifies_delayed",
-      "notifies_immediately",
-      "object_id",
-      "only_if",
-      "params",
-      "params=",
-      "platform?",
-      "platform_family?",
-      "powershell_out",
-      "powershell_out!",
-      "pretty_inspect",
-      "pretty_print",
-      "pretty_print_cycle",
-      "pretty_print_inspect",
-      "pretty_print_instance_variables",
-      "private_methods",
-      "property_is_set?",
-      "protected_methods",
-      "provider",
-      "provider=",
-      "provider_for_action",
-      "psych_to_yaml",
-      "public_method",
-      "public_methods",
-      "public_send",
-      "reboot_pending?",
-      "recipe_name",
-      "recipe_name=",
-      "registry_data_exists?",
-      "registry_get_subkeys",
-      "registry_get_values",
-      "registry_has_subkeys?",
-      "registry_key_exists?",
-      "registry_value_exists?",
-      "remove_instance_variable",
-      "reset_property",
-      "resolve_notification_references",
-      "resource_initializing",
-      "resource_initializing=",
-      "resource_name",
-      "resources",
-      "respond_to?",
-      "restore_wow64_file_redirection",
-      "retries",
-      "retries=",
-      "retry_delay",
-      "retry_delay=",
-      "rights",
-      "run_action",
-      "run_context",
-      "run_context=",
-      "sanitized_path",
-      "search",
-      "send",
-      "sensitive",
-      "sensitive=",
-      "set_or_return",
-      "shell_out",
-      "shell_out!",
-      "shell_out_compact",
-      "shell_out_compact!",
-      "shell_out_compact_timeout",
-      "shell_out_compact_timeout!",
-      "shell_out_with_systems_locale",
-      "shell_out_with_systems_locale!",
-      "should_skip?",
-      "singleton_class",
-      "singleton_method",
-      "singleton_methods",
-      "snake_case_basename",
-      "source_line",
-      "source_line=",
-      "source_line_file",
-      "source_line_number",
-      "state_for_resource_reporter",
-      "subscribes",
-      "taint",
-      "tainted?",
-      "tap",
-      "to_enum",
-      "to_hash",
-      "to_json",
-      "to_s",
-      "to_text",
-      "to_yaml",
-      "to_yaml_properties",
-      "trust",
-      "untaint",
-      "untrust",
-      "untrusted?",
-      "updated",
-      "updated?",
-      "updated_by_last_action",
-      "updated_by_last_action?",
-      "valid_windows_architecture?",
-      "validate",
-      "validate_action",
-      "validate_resource_spec!",
-      "value_for_platform",
-      "value_for_platform_family",
-      "value_to_text",
-      "with_os_architecture",
-      "wow64_architecture_override_required?",
-      "wow64_directory"
-    ],
     "user": [
       "!",
       "!=",