foodcritic-rackspace-rules 1.0.3 → 1.1.0

data/foodcritic-rackspace-rules.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["martin@mbs3.org"]
   spec.summary       = %q{Foodcritic rules for rackops cookbooks or stacks}
   spec.description   = %q{See README.md}
-  spec.homepage      = "https://github.com/AutomationSupport/foodcritic-rackspace-rules"
+  spec.homepage      = "https://github.com/racker/foodcritic-rackspace-rules"
   spec.license       = "Apache-2.0"
 
   spec.files         = `git ls-files -z`.split("\x0")
@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
+  spec.add_runtime_dependency 'bundler', '~> 1.6'
+  spec.add_runtime_dependency 'rake'
+  spec.add_runtime_dependency 'foodcritic'
 end

data/lib/foodcritic/rackspace/rules/version.rb

@@ -1,7 +1,7 @@
 module Foodcritic
   module Rackspace
     module Rules
-      VERSION = "1.0.3"
+      VERSION = "1.1.0"
     end
   end
 end

data/lib/foodcritic/rules/rules.rb

@@ -1,4 +1,5 @@
 require 'yaml' # included in ruby
+require 'foodcritic/chef'
 
 rule 'RACK001', 'Missing "# Copyright" declaration' do
   tags %w(style rackspace)
@@ -123,3 +124,21 @@ rule 'RACK004', 'Cookbook is missing a default test suite' do
     matches
   end # cookbook
 end # rule
+
+rack005_required_fields = {
+  'maintainer' => 'Rackspace',
+  'maintainer_email' => 'rackspace-cookbooks@rackspace.com',
+  'license' => 'Apache 2.0'
+}
+req_fields = StringIO.new
+rack005_required_fields.each do |k, v|
+  req_fields << " #{k}='#{v}'"
+end
+rule 'RACK005', "Cookbook metadata must have#{req_fields.string}" do
+  tags %w(style rackspace)
+  metadata do |ast, filename|
+    rack005_required_fields.map do |field, value|
+      ast.xpath(%Q(//command[ident/@value='#{field}']/descendant::tstring_content[@value!='#{value}']))
+    end
+  end # cookbook
+end # rule

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic-rackspace-rules
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-15 00:00:00.000000000 Z
+date: 2014-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -19,7 +19,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -35,7 +35,23 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: foodcritic
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -57,7 +73,7 @@ files:
 - foodcritic-rackspace-rules.gemspec
 - lib/foodcritic/rackspace/rules/version.rb
 - lib/foodcritic/rules/rules.rb
-homepage: https://github.com/AutomationSupport/foodcritic-rackspace-rules
+homepage: https://github.com/racker/foodcritic-rackspace-rules
 licenses:
 - Apache-2.0
 post_install_message: