foobara 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 658b5aeee49a2c42d53b1c27a1bfc1464a62a3688e66e4c074f47c0932cbccd3
-  data.tar.gz: 75e152204e15cf5b6359276533cb0d690c49f729f94bec9bb59f2faac5d99885
+  metadata.gz: 82cde9f69a93f602dfc7c64ae307642920cd755c0406a549e7247e47992982a4
+  data.tar.gz: dd875dcf264ab47d1bc4af1ae08cd391e2bac8771fde7681f213402c3a8ad269
 SHA512:
-  metadata.gz: baaf7fa9a61c7d3cd588a4b9580ea7e8543ee3651ed38cd64dc58389039b21724b2f78c0b2af1fcc5a6199184c15c5205022cc21a4892388629b1e9602c40cec
-  data.tar.gz: 125a737bd0dee217a4f08137f12ed78f8849c7d2392f8948e60d5f7221051f6d149a4f203df4ce3a16a93190ee8e26b3c26136856fd1171c57934f8e15fa5291
+  metadata.gz: b37ae22e17b00b133153a71924c1657b0d64f37c141a48ea0d05309f8316a6afe5387627052d83dadc2b58c09b1906190b4633921615420a26c449d3e660c75c
+  data.tar.gz: 5887b2e59372917e3b2535dd1b918cedf49c5fd7011e241036ace90b0a45478753d394f93f4f5d473079443ad3092ee4bf3865d42a0dadda66fbadf3e68065d6

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# [0.6.2] - 2026-08-24
+
+- Eliminate all direct uses of Foobara.manifest in the test suite and deprecate it
+- Fix bug preventing other combinations an Error missing parent/domain from getting fixed
+
 # [0.6.1] - 2026-08-08
 
 - Reduce gem size by excluding non-production code/artifacts from sub-projects

data/projects/command_connectors/src/command_connector/concerns/reflection.rb

@@ -66,8 +66,14 @@ module Foobara
                       unless o.foobara_root_namespace == command_registry
                         next
                       end
-                    elsif o.is_a?(::Class) && o < Foobara::Command
-                      next
+                    elsif o.is_a?(::Class)
+                      if o < Foobara::Command
+                        next
+                      elsif o < Foobara::Value::Processor
+                        full_domain_name = o.foobara_domain.scoped_full_name
+                        exposed_domain = command_registry.create_exposed_domain_if_needed(full_domain_name)
+                        additional_to_include << exposed_domain
+                      end
                     end
                   elsif o.is_a?(Types::Type)
                     if o.sensitive?
@@ -77,7 +83,6 @@ module Foobara
                             "Make sure these are not included."
                       # simplecov:enable
                     else
-
                       mode = Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE
                       domain_name = o.foobara_domain.scoped_full_name
 
@@ -154,26 +159,67 @@ module Foobara
           root_manifest = Manifest::RootManifest.new(manifest_hash)
 
           error_category = {}
+          reference_to_category = {}
+
+          # The only thing we can scope to an org is a domain so leaving :organization out
+          [
+            :command,
+            :domain,
+            :type,
+            :error,
+            :processor,
+            :processor_class
+          ].each do |category|
+            root_manifest.relevant_manifest[category]&.each_key do |key|
+              reference_to_category[key.to_s] = category
+            end
+          end
 
           root_manifest.errors.each do |error|
-            error_manifest = if (error.parent_category == :command || error.parent_category == :organization) &&
-                                !root_manifest.contains?(error.parent_name, error.parent_category)
-                               domain = error.domain
-                               index = domain.scoped_full_path.size
+            # TODO: let's deprecate parent_name and use parent_path instead.
+            error_manifest = if root_manifest.contains?(error.parent_name, error.parent_category) &&
+                                root_manifest.contains?(error[:domain], :domain) &&
+                                root_manifest.contains?(error.parent[:domain], :domain)
+
+                               error.relevant_manifest
+                             else
+                               parent = nil
+
+                               fixed_scoped_path = error.scoped_path.dup
+                               parent_path = error.scoped_full_path[..-(fixed_scoped_path.size + 1)]
+
+                               loop do
+                                 fixed_scoped_path.unshift(parent_path.pop)
+                                 parent_name = parent_path.join("::")
+
+                                 if parent_path.empty?
+                                   parent = root_manifest.global_domain
+                                   break
+                                 elsif reference_to_category.include?(parent_name)
+                                   possible_parent = root_manifest.lookup(parent_name)
+
+                                   if root_manifest.contains?(possible_parent[:domain], :domain)
+                                     parent = possible_parent
+                                     break
+                                   end
+                                 end
+                               end
+
+                               fixed_parent = parent.manifest_path
+                               fixed_domain = parent[:domain]
+                               fixed_organization = parent[:organization]
 
-                               fixed_scoped_path = error.scoped_full_path[index..]
-                               fixed_scoped_name = fixed_scoped_path.join("::")
                                fixed_scoped_prefix = fixed_scoped_path[..-2]
-                               fixed_parent = [:domain, domain.reference]
+                               fixed_scoped_name = fixed_scoped_path.join("::")
 
                                error.relevant_manifest.merge(
                                  parent: fixed_parent,
                                  scoped_path: fixed_scoped_path,
                                  scoped_name: fixed_scoped_name,
-                                 scoped_prefix: fixed_scoped_prefix
+                                 scoped_prefix: fixed_scoped_prefix,
+                                 domain: fixed_domain,
+                                 organization: fixed_organization
                                )
-                             else
-                               error.relevant_manifest
                              end
 
             error_category[error.scoped_full_name.to_sym] = error_manifest

data/projects/command_connectors/src/command_registry.rb

@@ -204,13 +204,19 @@ module Foobara
       end
     end
 
+    # Why are we calling this _name instead of _reference??
+    def create_exposed_domain_if_needed(full_domain_name)
+      foobara_lookup_domain(
+        full_domain_name,
+        mode: Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE
+      ) || build_and_register_exposed_domain(full_domain_name)
+    end
+
     private
 
     def create_exposed_command(command_class, **opts)
       full_domain_name = command_class.domain.scoped_full_name
-      exposed_domain = foobara_lookup_domain(full_domain_name,
-                                             mode: Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE) ||
-                       build_and_register_exposed_domain(full_domain_name)
+      exposed_domain = create_exposed_domain_if_needed(full_domain_name)
 
       if !opts.key?(:allowed_rule) && allow&.key?(command_class)
         opts = opts.merge(allowed_rule: allow[command_class])

data/projects/typesystem/projects/builtin_types/lib/foobara/builtin_types.rb

@@ -2,6 +2,7 @@ require "foobara/type_declarations"
 
 require "date"
 require "time"
+# TODO: get this out of here
 require "bigdecimal"
 
 module Foobara

data/projects/typesystem/projects/domain/src/extensions/foobara.rb

@@ -1,6 +1,14 @@
 module Foobara
   class << self
     def manifest
+      # simplecov:disable
+      warn "Foobara.manifest is deprecated in favor of CommandConnector#foobara_manifest" \
+           "\nIf this breaks a legit use case for Foobara.manifest please let us know and we will consider keeping it!"
+      debug_manifest
+      # simplecov:enable
+    end
+
+    private def debug_manifest
       to_include = Namespace.global.foobara_all_organization.to_set
 
       TypeDeclarations.with_manifest_context(to_include:) do

data/projects/typesystem/projects/types/lib/foobara/types.rb

@@ -1,5 +1,3 @@
-require "singleton"
-
 module Foobara
   module Types
     class << self

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.6.1".freeze
+    VERSION = "0.6.2".freeze
     MINIMUM_RUBY_VERSION = [">= 3.4.0", "< 4.1"].freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Miles Georgi