foobara 0.5.4 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a96afa4b186236cc708db3bc2a292756816db8e601a5cef7b31d0082a4a97dea
-  data.tar.gz: f184bf52340442842d0e6d9bdaa0f50a7c3a7f07421d4bb4a1c776c634703e4e
+  metadata.gz: 6527e62790180b1aeb2f98e069655d8ac72750fbff834fc63e9b75a01c35cb4e
+  data.tar.gz: a769dd2a642b71bd401dabe3c0917a1fa128069f2a7987ff79df633765ae93ad
 SHA512:
-  metadata.gz: 3c2fa3e1b90cc5f6f31df05683b17fef4ef7ad77c07c5af9190a603696b4470355b357f726dcef2f05dbbdf79213c56e655578a3731f9e03cd25397c4d0fb62e
-  data.tar.gz: 7b832dba231c05086a83d0a56fc799910bcee15fae5c3979eac8923d1f1bd17064d759dc9d0c0b94456400a92e2243d93b942822af16fd1b5f12b3b6c6b479e5
+  metadata.gz: '0359999dd32f56220e88e3e860ff7e415a4fd2b978bf83768868b1e10b0013c9e02597731890d1a2abb2fd11c1e288e1c1e8056b3bd6bf7a11bc9589af371ae3'
+  data.tar.gz: 33cf7a4428854d3016c1ccda045820e6da47a268e34f5bb05505bcc878ecdeff909caf1c411505d97849f4ffd69cc6e9c1c51a046ee92f6ee7ac2afe1919b359

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# [0.5.5] - 2026-02-19
+
+- Fix bug where WeakObjectSet#delete could fail after deactivation
+- Fix bug where arrays of allowed rules run in the wrong context
+- Remove awkward proc defaults from manifest
+
 # [0.5.4] - 2026-02-16
 
 - Fix bug where adding a desugarizer to a subclass had no effect

data/projects/command/src/command_pattern_implementation/concerns/reflection.rb

@@ -60,16 +60,17 @@ module Foobara
               possible_errors:,
               depends_on:,
               # TODO: allow inputs type to be nil or really any type?
-              inputs_type: inputs_type&.reference_or_declaration_data || GlobalDomain.foobara_type_from_declaration(
-                type: "::attributes",
-                element_type_declarations: {},
-                required: []
-              ).declaration_data
+              inputs_type: inputs_type&.reference_or_declaration_data_for_manifest ||
+                GlobalDomain.foobara_type_from_declaration(
+                  type: "::attributes",
+                  element_type_declarations: {},
+                  required: []
+                ).declaration_data
             ).merge(description:)
 
             if result_type
               # TODO: find a way to represent literal types like "nil"
-              h[:result_type] = result_type.reference_or_declaration_data
+              h[:result_type] = result_type.reference_or_declaration_data_for_manifest
             end
 
             super.merge(h)

data/projects/command_connectors/src/command_registry.rb

@@ -263,7 +263,7 @@ module Foobara
         procs = rules.map(&:block)
 
         block = proc do
-          procs.any?(&:call)
+          procs.any? { |p| instance_exec(&p) }
         end
 
         allowed_rule = AllowedRule.new(&block)

data/projects/command_connectors/src/transformed_command.rb

@@ -381,7 +381,7 @@ module Foobara
         end
 
         # TODO: This should support nil as an inputs_type but it breaks other projects for now
-        inputs_type = inputs_type_for_manifest&.reference_or_declaration_data ||
+        inputs_type = inputs_type_for_manifest&.reference_or_declaration_data_for_manifest ||
                       { type: :attributes, element_type_declarations: {} }
 
         # TODO: handle errors_types_depended_on!
@@ -390,7 +390,7 @@ module Foobara
           result_types_depended_on:,
           types_depended_on: types,
           inputs_type:,
-          result_type: result_type&.reference_or_declaration_data,
+          result_type: result_type&.reference_or_declaration_data_for_manifest,
           possible_errors: possible_errors_manifest,
           capture_unknown_error:,
           inputs_transformers:,

data/projects/entities/projects/weak_object_set/src/weak_object_set.rb

@@ -45,7 +45,7 @@ module Foobara
           loop do
             object_id = queue.pop
             if object_id
-              weak_object_set.delete(object_id)
+              weak_object_set&.delete(object_id)
             elsif queue.closed?
               self.queue = nil
               break

data/projects/typesystem/projects/types/src/type.rb

@@ -420,6 +420,10 @@ module Foobara
         scoped_full_name
       end
 
+      def reference_or_declaration_data_for_manifest
+        reference_or_declaration_data(declaration_data_for_manifest)
+      end
+
       def reference_or_declaration_data(declaration_data = self.declaration_data)
         remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
 
@@ -437,6 +441,30 @@ module Foobara
         end
       end
 
+      def declaration_data_for_manifest
+        data = declaration_data
+
+        if data.is_a?(::Hash) && data[:type] == :attributes
+          if data.key?(:defaults)
+            defaults = data[:defaults]
+
+            if defaults.is_a?(::Hash) && defaults.values.any? { it.is_a?(Proc) }
+              cleaned_defaults = defaults.transform_values do |value|
+                if value.is_a?(Proc)
+                  "[<Lazily Set>]"
+                else
+                  value
+                end
+              end
+
+              data = data.merge(defaults: cleaned_defaults)
+            end
+          end
+        end
+
+        data
+      end
+
       # TODO: put this somewhere else
       def foobara_manifest_reference
         scoped_full_name
@@ -462,7 +490,7 @@ module Foobara
           [possible_error.key.to_s, possible_error.foobara_manifest]
         end.sort.to_h
 
-        declaration_data = self.declaration_data
+        declaration_data = declaration_data_for_manifest
 
         if remove_sensitive
           declaration_data = TypeDeclarations.remove_sensitive_types(declaration_data)

data/projects/typesystem/spec/builtin_types/attributes_spec.rb

@@ -1,4 +1,6 @@
 RSpec.describe Foobara::BuiltinTypes::Attributes do
+  after { Foobara.reset_alls }
+
   let(:type) {
     Foobara::Domain.current.foobara_type_from_declaration(type_declaration)
   }
@@ -61,6 +63,26 @@ RSpec.describe Foobara::BuiltinTypes::Attributes do
       end
     end
 
+    context "when default is a proc" do
+      let(:type_declaration) do
+        {
+          type: :attributes,
+          element_type_declarations: {
+            a: :integer,
+            b: :integer
+          },
+          defaults: { a: -> { 10 }, b: 100 }
+        }
+      end
+
+      it "applies defaults and scrubs the value in the manifest data" do
+        expect(type.process_value!({})).to eq(a: 10, b: 100)
+
+        Foobara::GlobalDomain.foobara_register_type(:some_type, type)
+        expect(type.foobara_manifest[:declaration_data][:defaults]).to eq(a: "[<Lazily Set>]", b: 100)
+      end
+    end
+
     context "when defaults contains invalid attribute names" do
       let(:type_declaration) do
         {

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.5.4".freeze
+    VERSION = "0.5.5".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.5.5
 platform: ruby
 authors:
 - Miles Georgi