foobara 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ee98e7512333f9d3e069e3fe8a6c7cbbe2c5f27f2d918a7397cdaeed64b077f
-  data.tar.gz: 6fd8d38c4a30d1b0721fc241b6d09ef890e719fccd795b40d8319a7d77a82c56
+  metadata.gz: a96afa4b186236cc708db3bc2a292756816db8e601a5cef7b31d0082a4a97dea
+  data.tar.gz: f184bf52340442842d0e6d9bdaa0f50a7c3a7f07421d4bb4a1c776c634703e4e
 SHA512:
-  metadata.gz: 0b9e6f6ba2685ee2462811158fefc0d30f4c83122a3701e8b5ab06e2188d1d9c3ce5775846af2a4b4e15ffb7007d19947894fd9e6d4c3a98b92d2636b5b1bbc8
-  data.tar.gz: 14db098dc24293b84247e8a4d44913c902aae7f4058ca148698587c14c7d9f971d5d1e97b04ad94f4ae8b80007cac1b6881348c03d13b1ec41c4213b3a1c2892
+  metadata.gz: 3c2fa3e1b90cc5f6f31df05683b17fef4ef7ad77c07c5af9190a603696b4470355b357f726dcef2f05dbbdf79213c56e655578a3731f9e03cd25397c4d0fb62e
+  data.tar.gz: 7b832dba231c05086a83d0a56fc799910bcee15fae5c3979eac8923d1f1bd17064d759dc9d0c0b94456400a92e2243d93b942822af16fd1b5f12b3b6c6b479e5

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# [0.5.4] - 2026-02-16
+
+- Fix bug where adding a desugarizer to a subclass had no effect
+- Add support for requiring allow_if: by default
+
 # [0.5.3] - 2026-02-12
 
 - Allow registering an allowed rule on an instance of a connector not just its class

data/projects/command_connectors/spec/command_connector_spec.rb

@@ -488,6 +488,20 @@ RSpec.describe Foobara::CommandConnector do
       expect(response.body).to eq("8")
     end
 
+    context "when requires_allowed_rule" do
+      let(:command_connector) do
+        described_class.new(
+          authenticator:,
+          default_serializers:,
+          requires_allowed_rule: true
+        )
+      end
+
+      it "gives a relevant error" do
+        expect { response }.to raise_error(Foobara::CommandConnector::NoAllowedRuleGivenError)
+      end
+    end
+
     context "with default transformers" do
       before do
         identity = proc { |x| x }
@@ -2074,14 +2088,14 @@ RSpec.describe Foobara::CommandConnector do
       end
       let(:command_connector) do
         rule = allowed_rule_d
-        command_connector_class_d.new do
+        command_connector_class_d.new(requires_allowed_rule: true) do
           register_allowed_rule :d, rule
         end
       end
 
       it "puts the expected allowed rules on the command connector" do
         command_connector.connect(command_class, suffix: "A", allow_if: :a)
-        command_connector.connect(command_class, suffix: "B")
+        command_connector.connect(command_class, suffix: "B", allow_if: :always)
         command_connector.connect(command_class, suffix: "C", allowed_rule: :c)
         command_connector.connect(command_class, suffix: "D", allowed_rule: :d)
 
@@ -2091,7 +2105,7 @@ RSpec.describe Foobara::CommandConnector do
 
         response = command_connector.run(full_command_name: "ComputeExponentB", action:, inputs:)
         expect(response.status).to be(0)
-        expect(response.command.allowed_rule).to be_nil
+        expect(response.command.allowed_rule).to be(described_class.always_allowed_rule)
 
         response = command_connector.run(full_command_name: "ComputeExponentC", action:, inputs:)
         expect(response.status).to be(1)

data/projects/command_connectors/src/command_connector/concerns/desugarizers.rb

@@ -36,13 +36,13 @@ module Foobara
           end
 
           def desugarizers
-            @desugarizers ||= []
+            return @desugarizers if defined?(@desugarizers)
 
-            if superclass == Object
-              @desugarizers
-            else
-              @desugarizers + superclass.desugarizers
-            end
+            @desugarizers = if superclass == Object
+                              []
+                            else
+                              superclass.desugarizers.dup
+                            end
           end
         end
       end

data/projects/command_connectors/src/command_connector/no_allowed_rule_given_error.rb

@@ -0,0 +1,6 @@
+module Foobara
+  class CommandConnector
+    class NoAllowedRuleGivenError < StandardError
+    end
+  end
+end

data/projects/command_connectors/src/command_connector.rb

@@ -178,10 +178,19 @@ module Foobara
       def build_auth_mapper(to_type, &)
         TypeDeclarations::TypedTransformer.subclass(to: to_type, &).instance
       end
+
+      def always_allowed_rule
+        # maybe move AllowedRule to CommandConnector:: instead of
+        # CommandRegistry:: which is more of an implementation detail?
+        @always_allowed_rule ||= CommandRegistry::AllowedRule.new(
+          symbol: :always,
+          explanation: "This always passes. Used to override allowed_rule_missing."
+        ) { true }
+      end
     end
 
     attr_accessor :command_registry, :authenticator, :capture_unknown_error, :name,
-                  :auth_map
+                  :auth_map, :requires_allowed_rule
 
     def initialize(name: nil,
                    authenticator: nil,
@@ -190,6 +199,7 @@ module Foobara
                    default_pre_commit_transformers: nil,
                    auth_map: nil,
                    current_user: nil,
+                   requires_allowed_rule: false,
                    &block)
       authenticator = self.class.to_authenticator(authenticator)
 
@@ -214,6 +224,11 @@ module Foobara
         add_default_serializer(serializer)
       end
 
+      if requires_allowed_rule
+        self.requires_allowed_rule = requires_allowed_rule
+        register_allowed_rule(CommandConnector.always_allowed_rule)
+      end
+
       Util.array(default_pre_commit_transformers).each do |pre_commit_transformer|
         add_default_pre_commit_transformer(pre_commit_transformer)
       end
@@ -232,6 +247,7 @@ module Foobara
     end
 
     # TODO: should this be the official way to connect a command instead of #connect ?
+    # Probably not. But what about #export instead?
     def command(...) = connect(...)
 
     def connect(*args, **opts)
@@ -616,6 +632,16 @@ module Foobara
     def run_command(request)
       command = request.command
 
+      if requires_allowed_rule
+        unless command.allowed_rule
+          raise NoAllowedRuleGivenError,
+                "Must connect #{command.full_command_name} with an `allowed_if:` " \
+                "because `requires_allowed_rule` is true. You can use `allow_if: :always` if want to always allow " \
+                "this command to be ran or you can also use `requires_allowed_rule: false` " \
+                "when creating the connector if you don't want to enforce allowed_if: for all connected commands."
+        end
+      end
+
       unless command.outcome
         command.run
       end

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.5.3".freeze
+    VERSION = "0.5.4".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - Miles Georgi
@@ -138,6 +138,7 @@ files:
 - projects/command_connectors/src/command_connector/concerns/desugarizers.rb
 - projects/command_connectors/src/command_connector/concerns/reflection.rb
 - projects/command_connectors/src/command_connector/invalid_context_error.rb
+- projects/command_connectors/src/command_connector/no_allowed_rule_given_error.rb
 - projects/command_connectors/src/command_connector/no_command_found_error.rb
 - projects/command_connectors/src/command_connector/no_command_or_type_found_error.rb
 - projects/command_connectors/src/command_connector/no_type_found_error.rb