foobara 0.0.15 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cec596f3e023a3bb6381c2f4406f6419d15cdeae3b9b1c7140a74ea8d999b4e4
-  data.tar.gz: 7d493bb518a6892cbc483bbdedaa0301e2986a8c90d03249dd9abf2210b52032
+  metadata.gz: a386511b5dd07ad9a067ce02cdf7dfef7436a9db51fe938e26e1dec2c42b836f
+  data.tar.gz: bf3f4960d49e6ca8f9a17ee7f4ceb7d3f04dd433172bc0028d8314081c933049
 SHA512:
-  metadata.gz: f869b1e7749e1388c86de79964d0031eb0bddb00eea9c477bc8336aa41d2941571dceaa506a16fbd9f8dee479e2cf6e708542fb938bae3cc295d8dddc4909a29
-  data.tar.gz: 7755a9dfe9587cbcf7726ba1d25397012e31a6123efa97c8141b63d703c42af56df007d4fd22e604da0b1f05d4f2d84e3484f718c00d917863803921d47aecd7
+  metadata.gz: 7cd69b5365baa7bb77534875bed988c638b2c48d79d28119337adca49c8a2551bd958bd3835da682fc143d57186ba7efbf8a36630fc573d0991ae0c10c4cf6bb
+  data.tar.gz: e00097bd3e762179bd14bfa9e292a2b93c6f063d5dd67b82ec6942d7578af206dd97322a560a7f0e9771bb5b799d2acb34d07e08db4d3f46f6f22ab48f2be642

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.0.16] - 2024-11-22
+
+- Fix bug where mutable not being set explicitly raises
+- Also, make it so models don't default to mutable false when processed by a model type
+
 ## [0.0.15] - 2024-11-20
 
 - Move entity attributes type declaration helpers from Command::EntityHelpers to Entity for convenience.

data/projects/entity/src/extensions/builtin_types/entity/casters/hash.rb

@@ -2,6 +2,7 @@ module Foobara
   module BuiltinTypes
     module Entity
       module Casters
+        # TODO: We need a way of disabling/enabling this and it should probably be disabled by default.
         class Hash < Attributes::Casters::Hash
           class << self
             def requires_parent_declaration_data?

data/projects/model/src/extensions/builtin_types/model/transformers/mutable.rb

@@ -11,11 +11,19 @@ module Foobara
           end
 
           def transform(record)
-            record.mutable = if parent_declaration_data.key?(:mutable)
-                               parent_declaration_data[:mutable]
-                             else
-                               false
-                             end
+            if parent_declaration_data.key?(:mutable)
+              # hmmmm.... can we really just arbitrarily clobber this?
+              # wouldn't that be surprising to calling code that passes in a record/model?
+              # One use-case of this seems to be to reduce the amount of possible errors a command reports
+              # by declaring that only some subset or none of the attributes are mutable.
+              # However, we shouldn't react to this by clobbering the mutable state of the record because it might not
+              # be a fresh record fetched from a primary key it might be an already loaded record/model from some other
+              # context and that context might be surprised to learn that we've clobbered its mutability status.
+              # Solutions?
+              # 1. In the case of models, we could duplicate the model if the mutable value is different.
+              # 2. But what about entities? We almost need some sort of proxy entity that tightens the mutability?
+              record.mutable = parent_declaration_data[:mutable]
+            end
 
             record
           end

data/projects/model/src/model.rb

@@ -207,6 +207,7 @@ module Foobara
         end
       end
 
+      # why do we default to true here but false in the transformers?
       mutable = options.key?(:mutable) ? options[:mutable] : true
 
       self.mutable = if mutable.is_a?(::Array)
@@ -227,7 +228,7 @@ module Foobara
     def write_attribute(attribute_name, value)
       attribute_name = attribute_name.to_sym
 
-      if mutable == true || mutable.include?(attribute_name)
+      if mutable == true || mutable&.include?(attribute_name)
         outcome = cast_attribute(attribute_name, value)
         attributes[attribute_name] = outcome.success? ? outcome.result : value
       else

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.16
 platform: ruby
 authors:
 - Miles Georgi
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-20 00:00:00.000000000 Z
+date: 2024-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foobara-util