foobara 0.0.116 → 0.0.117

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe51e6ab90aafb99246fd2872f0faa452004f71b0d37a7e68a2fc7e8027feff7
-  data.tar.gz: d9027059c2a75b268950b661e5c3bb3fd1d633f52afbbe6d302c8ba3351908bc
+  metadata.gz: 3baedff1b00683e94d063e4a3c3453e89f9d8383aac79fd63a7b80590b7ac2ab
+  data.tar.gz: db340140596337684becb59db82ef8c9f64970195eace6d2cb0032d6e209eb88
 SHA512:
-  metadata.gz: 3beecfb43803f74a01d9f1d6e36c6b6f10c5abbae6dc3eaf9bc9a62afe25d3413313ed6f65262ba4e4c165e8545bbb506f045cafbd3d7673a37d4b87e9202661
-  data.tar.gz: 34554e412fc605f453392d2432f59311abe65498ec0db28e1c617c61b4c7fb1ac4e1bd7140f1ee8064482355a6a90e800cefea7b2ea8f35e23ad00eed59cf674
+  metadata.gz: a9cfde792ff8303519b9b98ca46062a7e0dc4209799e00bd64bf3d5674112e685eb8cce621eb50cda6680c54f76084076007d3c18125baefe14eb052566f9038
+  data.tar.gz: db3398f6804081f01a44ac188a0597831db3b3ffa0dfa81ffb99de75c01685e33d21d4d91dbefae6e7d601bae29676e60c778e7be59cb3120bfde7dd7ba1b19a

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [0.0.117] - 2025-05-05
+
+- Make sure we do not apply an authenticator unless it is applicable
+- Move loaded/unloaded concept up into DetachedEntity from Entity
+  - This allows us to deal with serialization of detached entities as their primary keys
+- Fix bugs preventing connecting/importing types with delegated attributes
+
 # [0.0.116] - 2025-05-03
 
 - Add automatic transaction support to requests, cover in/out mutators/transformers

data/projects/builtin_types/src/date/casters/hash.rb

@@ -4,7 +4,7 @@ module Foobara
       module Casters
         class Hash < Value::Caster
           def applicable?(hash)
-            hash.is_a?(::Hash) && hash.keys.size == 3 && (hash.keys.map(&:to_s).sort == %w[day month year])
+            hash.is_a?(::Hash) && hash.keys.size == 3 && (hash.keys.map(&:to_s).sort == ["day", "month", "year"])
           end
 
           def applies_message

data/projects/callback/src/block.rb

@@ -56,7 +56,7 @@ module Foobara
       end
 
       def has_keyword_args?
-        @has_keyword_args ||= param_types.any? { |type| %i[keyreq keyrest].include?(type) }
+        @has_keyword_args ||= param_types.any? { |type| [:keyreq, :keyrest].include?(type) }
       end
 
       def has_positional_args?

data/projects/command/src/command_pattern_implementation/concerns/callbacks.rb

@@ -28,7 +28,7 @@ module Foobara
           self.subclass_defined_callbacks ||= Foobara::Callback::Registry::SingleAction.new
 
           [self, singleton_class].each do |target|
-            %i[before after].each do |type|
+            [:before, :after].each do |type|
               target.define_method "#{type}_any_transition" do |&block|
                 callback_state_machine_target.register_transition_callback(type) do |state_machine:, **args|
                   block.call(command: state_machine.owner, **args)
@@ -61,7 +61,7 @@ module Foobara
 
           Foobara::Command::StateMachine.transitions.each do |transition|
             [self, singleton_class].each do |target|
-              %i[before after].each do |type|
+              [:before, :after].each do |type|
                 target.define_method "#{type}_#{transition}" do |&block|
                   callback_state_machine_target.register_transition_callback(
                     type, transition:

data/projects/command/src/command_pattern_implementation/concerns/runtime.rb

@@ -27,13 +27,13 @@ module Foobara
           Foobara::Namespace.use self.class do
             invoke_with_callbacks_and_transition(:open_transaction)
 
-            invoke_with_callbacks_and_transition_in_transaction(%i[
-                                                                  cast_and_validate_inputs
-                                                                  load_records
-                                                                  validate_records
-                                                                  validate
-                                                                  run_execute
-                                                                  commit_transaction
+            invoke_with_callbacks_and_transition_in_transaction([
+                                                                  :cast_and_validate_inputs,
+                                                                  :load_records,
+                                                                  :validate_records,
+                                                                  :validate,
+                                                                  :run_execute,
+                                                                  :commit_transaction
                                                                 ])
 
             invoke_with_callbacks_and_transition(:succeed)

data/projects/command/src/state_machine.rb

@@ -1,31 +1,31 @@
 module Foobara
   class Command
     class StateMachine < Foobara::StateMachine
-      transitions = %i[
-        open_transaction
-        cast_and_validate_inputs
-        load_records
-        validate_records
-        validate
-        run_execute
-        commit_transaction
-        succeed
-        error
-        fail
-        reset
+      transitions = [
+        :open_transaction,
+        :cast_and_validate_inputs,
+        :load_records,
+        :validate_records,
+        :validate,
+        :run_execute,
+        :commit_transaction,
+        :succeed,
+        :error,
+        :fail,
+        :reset
       ]
 
-      terminal_states = %i[succeeded errored failed]
+      terminal_states = [:succeeded, :errored, :failed]
 
-      states = %i[
-        initialized
-        transaction_opened
-        inputs_casted_and_validated
-        loaded_records
-        validated_records
-        validated_execution
-        executing
-        transaction_committed
+      states = [
+        :initialized,
+        :transaction_opened,
+        :inputs_casted_and_validated,
+        :loaded_records,
+        :validated_records,
+        :validated_execution,
+        :executing,
+        :transaction_committed
       ] + terminal_states
 
       can_fail_states = states - terminal_states

data/projects/command_connectors/src/authenticator.rb

@@ -30,7 +30,9 @@ module Foobara
       end
 
       def authenticate(request)
-        process_value!(request)
+        if applicable?(request)
+          process_value!(request)
+        end
       end
 
       def to_proc

data/projects/command_connectors/src/command_connector/command_connector_error.rb

@@ -3,7 +3,7 @@ module Foobara
     class CommandConnectorError < Foobara::RuntimeError
       context({})
 
-      def initialize(message:, context: {})
+      def initialize(message:, symbol: nil, context: {})
         super
       end
     end

data/projects/command_connectors/src/command_connector/request.rb

@@ -19,7 +19,7 @@ module Foobara
                     :authenticated_credential
 
       def initialize(**opts)
-        valid_keys = %i[inputs full_command_name action serializers]
+        valid_keys = [:inputs, :full_command_name, :action, :serializers]
 
         invalid_keys = opts.keys - valid_keys
 

data/projects/command_connectors/src/command_registry.rb

@@ -13,7 +13,7 @@ module Foobara
       self.scoped_path = []
       self.authenticator = authenticator
 
-      customized = %i[command]
+      customized = [:command]
 
       Namespace.global.foobara_categories.keys.reverse.each do |symbol|
         next if customized.include?(symbol)

data/projects/detached_entity/src/concerns/attributes.rb

@@ -0,0 +1,28 @@
+module Foobara
+  class DetachedEntity < Model
+    class CannotReadAttributeOnUnloadedRecordError < StandardError; end
+
+    module Concerns
+      module Attributes
+        include Concern
+
+        def read_attribute(attribute_name)
+          attribute_name = attribute_name.to_sym
+
+          if attribute_name != self.class.primary_key_attribute
+            unless can_read_attributes_other_than_primary_key?
+              raise CannotReadAttributeOnUnloadedRecordError,
+                    "Cannot read attribute #{attribute_name} on unloaded record"
+            end
+          end
+
+          super
+        end
+
+        def can_read_attributes_other_than_primary_key?
+          loaded?
+        end
+      end
+    end
+  end
+end

data/projects/detached_entity/src/concerns/initialization.rb

@@ -0,0 +1,57 @@
+module Foobara
+  class DetachedEntity < Model
+    class NoCurrentTransactionError < StandardError; end
+
+    module Concerns
+      module Initialization
+        include Concern
+
+        module ClassMethods
+          def unloaded(primary_key_value)
+            primary_key_value = primary_key_type.process_value!(primary_key_value)
+
+            new({ primary_key_attribute => primary_key_value }, unloaded: true)
+          end
+        end
+
+        ALLOWED_OPTIONS = Model::ALLOWED_OPTIONS + [:unloaded]
+
+        def initialize(attributes = nil, options = {})
+          invalid_options = options.keys - ALLOWED_OPTIONS
+
+          unless invalid_options.empty?
+            # :nocov:
+            raise ArgumentError, "Invalid options #{invalid_options} expected only #{ALLOWED_OPTIONS}"
+            # :nocov:
+          end
+
+          if options[:unloaded]
+            options = options.except(:unloaded)
+
+            unless options.key?(:validate)
+              options[:validate] = false
+            end
+
+            unless options.key?(:skip_validations)
+              options[:skip_validations] = true
+            end
+
+            unless options.key?(:ignore_unexpected_attributes)
+              options[:ignore_unexpected_attributes] = false
+            end
+
+            unless options.key?(:mutable)
+              options[:mutable] = false
+            end
+
+            super
+            self.is_loaded = false
+          else
+            super
+            self.is_loaded = true
+          end
+        end
+      end
+    end
+  end
+end

data/projects/detached_entity/src/concerns/persistence.rb

@@ -0,0 +1,14 @@
+module Foobara
+  class DetachedEntity < Model
+    module Concerns
+      # Too simple to include Concern
+      module Persistence
+        attr_accessor :is_loaded
+
+        def loaded?
+          is_loaded
+        end
+      end
+    end
+  end
+end

data/projects/detached_entity/src/detached_entity.rb

@@ -1,5 +1,7 @@
 module Foobara
   class DetachedEntity < Model
+    include Concerns::Attributes
+    include Concerns::Persistence
     include Concerns::Equality
     include Concerns::Associations
     include Concerns::PrimaryKey
@@ -7,5 +9,6 @@ module Foobara
     include Concerns::Types
     include Concerns::Aliases
     include Concerns::Serialize
+    include Concerns::Initialization
   end
 end

data/projects/detached_entity/src/extensions/builtin_types/detached_entity/casters/primary_key.rb

@@ -0,0 +1,43 @@
+module Foobara
+  module BuiltinTypes
+    module DetachedEntity
+      module Casters
+        class PrimaryKey < Value::Caster
+          class << self
+            def requires_declaration_data?
+              true
+            end
+
+            def requires_type?
+              true
+            end
+          end
+
+          def entity_class
+            declaration_data.target_class
+          end
+
+          def primary_key_type
+            entity_class.primary_key_type
+          end
+
+          def applicable?(value)
+            primary_key_type.applicable?(value)
+          end
+
+          def transform(primary_key)
+            entity_class.send(build_method, primary_key)
+          end
+
+          def applies_message
+            primary_key_type.value_caster.applies_message
+          end
+
+          def build_method
+            :unloaded
+          end
+        end
+      end
+    end
+  end
+end

data/projects/entity/src/concerns/attributes.rb

@@ -6,6 +6,10 @@ module Foobara
 
         include Concern
 
+        def can_read_attributes_other_than_primary_key?
+          loaded? || built? || created?
+        end
+
         def write_attribute_without_callbacks(attribute_name, value)
           without_callbacks do
             write_attribute(attribute_name, value)

data/projects/entity/src/concerns/callbacks.rb

@@ -39,22 +39,22 @@ module Foobara
         module ClassMethods
           def class_callback_registry
             @class_callback_registry ||= begin
-              actions = %i[
-                initialized
-                initialized_built
-                initialized_thunk
-                initialized_loaded
-                initialized_created
-                dirtied
-                undirtied
-                attribute_changed
-                reverted
-                loaded
-                persisted
-                hard_deleted
-                unhard_deleted
-                invalidated
-                uninvalidated
+              actions = [
+                :initialized,
+                :initialized_built,
+                :initialized_thunk,
+                :initialized_loaded,
+                :initialized_created,
+                :dirtied,
+                :undirtied,
+                :attribute_changed,
+                :reverted,
+                :loaded,
+                :persisted,
+                :hard_deleted,
+                :unhard_deleted,
+                :invalidated,
+                :uninvalidated
               ]
 
               if self == Entity

data/projects/entity/src/concerns/initialization.rb

@@ -16,6 +16,7 @@ module Foobara
             record.build(attributes)
             # TODO: rename to something like "detached"
             record.is_built = true
+            record.is_loaded = false
 
             record.fire(:initialized)
             record.fire(:initialized_built)
@@ -39,6 +40,7 @@ module Foobara
             return record if record
 
             record = __private_new__
+            record.is_loaded = false
             record.is_persisted = true
             record.write_attributes_without_callbacks(primary_key_attribute => record_id)
 
@@ -80,6 +82,7 @@ module Foobara
           def create(attributes = {})
             record = __private_new__
             record.is_created = true
+            record.is_loaded = false
 
             defaults = attributes_type.declaration_data[:defaults]
             if defaults && !defaults.empty?

data/projects/entity/src/concerns/persistence.rb

@@ -7,7 +7,7 @@ module Foobara
 
         include Concern
 
-        attr_accessor :is_loaded, :is_persisted, :is_hard_deleted, :is_built, :is_created, :persisted_attributes
+        attr_accessor :is_persisted, :is_hard_deleted, :is_built, :is_created, :persisted_attributes
 
         module ClassMethods
           def entity_base
@@ -50,10 +50,6 @@ module Foobara
           is_created
         end
 
-        def loaded?
-          is_loaded
-        end
-
         # TODO: rename, maybe #detatched? or something?
         def built?
           is_built

data/projects/entity/src/extensions/builtin_types/entity/casters/primary_key.rb

@@ -2,35 +2,9 @@ module Foobara
   module BuiltinTypes
     module Entity
       module Casters
-        class PrimaryKey < Value::Caster
-          class << self
-            def requires_declaration_data?
-              true
-            end
-
-            def requires_type?
-              true
-            end
-          end
-
-          def entity_class
-            declaration_data.target_class
-          end
-
-          def primary_key_type
-            entity_class.primary_key_type
-          end
-
-          def applicable?(value)
-            primary_key_type.applicable?(value)
-          end
-
-          def transform(primary_key)
-            entity_class.thunk(primary_key)
-          end
-
-          def applies_message
-            primary_key_type.value_caster.applies_message
+        class PrimaryKey < DetachedEntity::Casters::PrimaryKey
+          def build_method
+            :thunk
           end
         end
       end

data/projects/enumerated/src/values.rb

@@ -125,7 +125,7 @@ module Foobara
         mod = Module.new
         enumerated = self
 
-        %i[all all_names all_values value?].each do |method_name|
+        [:all, :all_names, :all_values, :value?].each do |method_name|
           mod.singleton_class.define_method method_name do |*args, **opts, &block|
             enumerated.send(method_name, *args, **opts, &block)
           end

data/projects/manifest/src/foobara/manifest/base_manifest.rb

@@ -103,11 +103,11 @@ module Foobara
       end
 
       def global_domain
-        Domain.new(root_manifest, %i[domain global_organization::global_domain])
+        Domain.new(root_manifest, [:domain, :"global_organization::global_domain"])
       end
 
       def global_organization
-        Organization.new(root_manifest, %i[organization global_organization])
+        Organization.new(root_manifest, [:organization, :global_organization])
       end
 
       def method_missing(method_name, *, &)

data/projects/manifest/src/foobara/manifest/root_manifest.rb

@@ -102,7 +102,7 @@ module Foobara
       end
 
       def lookup(reference)
-        prioritized_categories = %i[command type error domain organization processor processor_class]
+        prioritized_categories = [:command, :type, :error, :domain, :organization, :processor, :processor_class]
 
         prioritized_categories.each do |category|
           path = [category, reference]

data/projects/model/src/concerns/types.rb

@@ -199,7 +199,7 @@ module Foobara
             delegates[attribute_name] = delegate_manifest
 
             delegated_type_declaration = model_type.type_at_path(data_path).reference_or_declaration_data
-            attributes attribute_name => delegated_type_declaration
+            attributes(type: :attributes, element_type_declarations: { attribute_name => delegated_type_declaration })
 
             define_method attribute_name do
               data_path.value_at(self)

data/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/delegates_desugarizer.rb

@@ -8,8 +8,8 @@ module Foobara
           end
 
           def desugarize(sugary_type_declaration)
-            desugarized = Util.deep_dup(sugary_type_declaration)
-            delegates = desugarized[:delegates]
+            desugarized = sugary_type_declaration.dup
+            delegates = Util.deep_symbolize_keys(desugarized[:delegates])
 
             if delegates.empty?
               desugarized.delete(:delegates)

data/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/delegates_validator.rb

@@ -21,7 +21,7 @@ module Foobara
               )
             end
 
-            allowed_keys = %i[data_path writer]
+            allowed_keys = [:data_path, :writer]
 
             delegates.each_pair do |attribute_name, delegate_hash|
               invalid_keys = delegate_hash.keys - allowed_keys

data/projects/model/src/model.rb

@@ -171,13 +171,14 @@ module Foobara
 
     attr_accessor :mutable, :skip_validations
 
+    ALLOWED_OPTIONS = [:validate, :mutable, :ignore_unexpected_attributes, :skip_validations].freeze
+
     def initialize(attributes = nil, options = {})
-      allowed_options = %i[validate mutable ignore_unexpected_attributes skip_validations]
-      invalid_options = options.keys - allowed_options
+      invalid_options = options.keys - ALLOWED_OPTIONS
 
       unless invalid_options.empty?
         # :nocov:
-        raise ArgumentError, "Invalid options #{invalid_options} expected only #{allowed_options}"
+        raise ArgumentError, "Invalid options #{invalid_options} expected only #{ALLOWED_OPTIONS}"
         # :nocov:
       end
 

data/projects/model_attribute_helpers/src/attribute_helper_aliases.rb

@@ -7,17 +7,17 @@ module Foobara
         include Foobara::Concern
 
         module ClassMethods
-          %i[
-            attributes_for_update
-            type_from_foobara_model_class
-            attributes_type_from_foobara_model_class
-            primary_key_attribute_from_foobara_model_class
-            foobara_model_class_has_primary_key
-            attributes_for_create
-            attributes_for_aggregate_update
-            attributes_for_atom_update
-            attributes_for_find_by
-            type_declaration_value_at
+          [
+            :attributes_for_update,
+            :type_from_foobara_model_class,
+            :attributes_type_from_foobara_model_class,
+            :primary_key_attribute_from_foobara_model_class,
+            :foobara_model_class_has_primary_key,
+            :attributes_for_create,
+            :attributes_for_aggregate_update,
+            :attributes_for_atom_update,
+            :attributes_for_find_by,
+            :type_declaration_value_at
           ].each do |method_name|
             define_method method_name do |*args, **opts, &block|
               send("foobara_#{method_name}", *args, **opts, &block)

data/projects/persistence/src/entity_base/transaction_table/concerns/record_tracking.rb

@@ -95,11 +95,11 @@ module Foobara
               marked_created.clear
             end
 
-            interesting_record_states = %i[
-              updated
-              hard_deleted
-              created
-              loading
+            interesting_record_states = [
+              :updated,
+              :hard_deleted,
+              :created,
+              :loading
             ]
 
             interesting_record_states.each do |state|

data/projects/type_declarations/lib/foobara/type_declarations.rb

@@ -17,10 +17,10 @@ module Foobara
           end
         end
 
-        %w[
-          foobara_children
-          foobara_registry
-          foobara_type_builder
+        [
+          "foobara_children",
+          "foobara_registry",
+          "foobara_type_builder"
         ].each do |var_name|
           var_name = "@#{var_name}"
 

data/projects/type_declarations/src/handlers/extend_array_type_declaration/type_set_to_array_desugarizer.rb

@@ -8,7 +8,7 @@ module Foobara
         class TypeSetToArrayDesugarizer < ArrayDesugarizer
           def applicable?(sugary_type_declaration)
             if sugary_type_declaration.is_a?(::Hash) && sugary_type_declaration.key?(:type)
-              extra_keys = sugary_type_declaration.keys - %i[type description sensitive sensitive_exposed]
+              extra_keys = sugary_type_declaration.keys - [:type, :description, :sensitive, :sensitive_exposed]
 
               return false if extra_keys.any?
 

data/projects/type_declarations/src/handlers/extend_registered_type_declaration/to_type_transformer.rb

@@ -74,7 +74,7 @@ module Foobara
           end
 
           def non_processor_keys
-            %i[type _desugarized description sensitive sensitive_exposed]
+            [:type, :_desugarized, :description, :sensitive, :sensitive_exposed]
           end
         end
       end

data/projects/type_declarations/src/type_declarations.rb

@@ -96,8 +96,8 @@ module Foobara
         Thread.inheritable_thread_local_var_get("foobara_manifest_context")
       end
 
-      allowed_context_keys = %i[detached to_include mode remove_sensitive]
-      booleans = %i[detached remove_sensitive]
+      allowed_context_keys = [:detached, :to_include, :mode, :remove_sensitive]
+      booleans = [:detached, :remove_sensitive]
 
       booleans.each do |context_item|
         define_method "foobara_manifest_context_#{context_item}?" do

data/projects/value/src/caster.rb

@@ -16,8 +16,8 @@ module Foobara
         end
 
         def subclass(name: nil, **options)
-          arity_zero = %i[name applies_message]
-          arity_one = %i[applicable? cast]
+          arity_zero = [:name, :applies_message]
+          arity_one = [:applicable?, :cast]
           allowed = arity_zero + arity_one
 
           invalid_options = options.keys - allowed

data/projects/value/src/processor.rb

@@ -48,7 +48,7 @@ module Foobara
         end
 
         def new_with_agnostic_args(**rest)
-          allowed_keys = %i[declaration_data parent_declaration_data]
+          allowed_keys = [:declaration_data, :parent_declaration_data]
 
           invalid_keys = rest.keys - allowed_keys
 
@@ -283,7 +283,7 @@ module Foobara
       end
 
       def dup_processor(**opts)
-        valid_opts = %i[declaration_data parent_declaration_data]
+        valid_opts = [:declaration_data, :parent_declaration_data]
 
         invalid_opts = opts.keys - valid_opts
 

data/projects/value/src/transformer.rb

@@ -24,8 +24,8 @@ module Foobara
 
         # TODO: make transform the first argument for convenience
         def subclass(name: nil, **options)
-          arity_zero = %i[always_applicable? priority]
-          arity_one = %i[applicable? transform]
+          arity_zero = [:always_applicable?, :priority]
+          arity_one = [:applicable?, :transform]
           allowed = arity_zero + arity_one
 
           invalid_options = options.keys - allowed

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.116
+  version: 0.0.117
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-05-03 00:00:00.000000000 Z
+date: 2025-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -234,7 +234,10 @@ files:
 - projects/detached_entity/lib/foobara/detached_entity.rb
 - projects/detached_entity/src/concerns/aliases.rb
 - projects/detached_entity/src/concerns/associations.rb
+- projects/detached_entity/src/concerns/attributes.rb
 - projects/detached_entity/src/concerns/equality.rb
+- projects/detached_entity/src/concerns/initialization.rb
+- projects/detached_entity/src/concerns/persistence.rb
 - projects/detached_entity/src/concerns/primary_key.rb
 - projects/detached_entity/src/concerns/reflection.rb
 - projects/detached_entity/src/concerns/serialize.rb
@@ -243,6 +246,7 @@ files:
 - projects/detached_entity/src/detached_entity_type.rb
 - projects/detached_entity/src/extensions/builtin_types/detached_entity.rb
 - projects/detached_entity/src/extensions/builtin_types/detached_entity/casters/hash.rb
+- projects/detached_entity/src/extensions/builtin_types/detached_entity/casters/primary_key.rb
 - projects/detached_entity/src/extensions/builtin_types/detached_entity/validators/model_instance_is_valid.rb
 - projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration.rb
 - projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration/attributes_handler_desugarizer.rb