foobara-empty-ruby-project-generator 0.0.20 → 0.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e82a8d6af3338fe69f43a3a4573720791a5d93064c50d2fa3d1e1f95a42f12aa
-  data.tar.gz: 4d788a75115bf60b4bbb89089d3cfab7393fd95a3acb7b035f1e10fef6c93bf3
+  metadata.gz: f2b61d99024ebd625a84d1c39fa2dbc52a9535f67d38c55b5b34268e31d3c37a
+  data.tar.gz: 3059a9f887c3bfa08d9a059d8019be6e8267559be9992a12657b0ebf5edd1a62
 SHA512:
-  metadata.gz: 875efa4b26a347baf98f9c4b347f15b472cc24bc1226691fe60cad7cf284db329b7df5d4c0ae8d73d486d6f0ceeeec4642f5e13550eb05128b4cf4425bd2310e
-  data.tar.gz: f2ff5fbb32e62bf21d33ace1292257524f0023e35a6b1960561187529c7245ec21881cc570b06782c461622dfd7171cf2a276af4ece464e575dbfae8af9f8c2f
+  metadata.gz: 3f6d0cd0812dea545d4dc7e2498bb4830e2688dfc63109d0877fb9a3dde07b26fc29d56214977f14ad41c9f41884a6855a35b266e44637867a8463aba439680d
+  data.tar.gz: d1e492b3b824500c4675f8f69d2d74816617341bd0742bb627a89b30ad177d3d1e3c2f4beed2d1022b0991368b724f6f5e4cafca100ea26be5a51bdf1bc48881

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.21] - 2025-05-03
+
+- Make optional things fail-safe when shelling out and simplify the code a bit, too
+
 ## [0.0.20] - 2025-05-03
 
 - Add use_git, push_to_github, and turn_on_rbenv_bundler options and default them to false

data/src/write_empty_ruby_project_to_disk.rb

@@ -35,6 +35,8 @@ module Foobara
           output
         end
 
+        attr_accessor :use_git_failed, :push_to_github_failed
+
         def create_output_directory_if_needed
           FileUtils.mkdir_p output_directory
         end
@@ -106,22 +108,15 @@ module Foobara
 
         def bundle_install
           puts "bundling..."
-          do_it = proc do
-            Open3.popen3("bundle install") do |_stdin, _stdout, stderr, wait_thr|
-              exit_status = wait_thr.value
-              unless exit_status.success?
-                # :nocov:
-                raise "could not bundle install. #{stderr.read}"
-                # :nocov:
-              end
-            end
-          end
+          cmd = "bundle install"
 
           if Bundler.respond_to?(:with_unbundled_env)
-            Bundler.with_unbundled_env(&do_it)
+            Bundler.with_unbundled_env do
+              run_cmd_and_return_output(cmd)
+            end
           else
             # :nocov:
-            do_it.call
+            run_cmd_and_return_output(cmd)
             # :nocov:
           end
         end
@@ -129,15 +124,15 @@ module Foobara
         def rubocop_autocorrect
           puts "linting..."
 
-          do_it = -> { run_cmd_and_return_output("bundle exec rubocop --no-server -A") }
+          cmd = "bundle exec rubocop --no-server -A"
 
           if Bundler.respond_to?(:with_unbundled_env)
             Bundler.with_unbundled_env do
-              do_it.call
+              run_cmd_and_return_output(cmd)
             end
           else
             # :nocov:
-            do_it.call
+            run_cmd_and_return_output(cmd)
             # :nocov:
           end
         end
@@ -145,90 +140,106 @@ module Foobara
         def make_bin_files_executable
           Dir["bin/*"].each do |file|
             if File.file?(file)
-              system("chmod u+x #{file}")
+              cmd = "chmod u+x #{file}"
+              begin
+                run_cmd_and_return_output(cmd)
+              rescue CouldNotExecuteError => e
+                # :nocov:
+                warn e.message
+                # :nocov:
+              end
             end
           end
         end
 
         def git_init
-          cmd = "git init"
+          return if use_git_failed
 
-          Open3.popen3(cmd) do |_stdin, _stdout, stderr, wait_thr|
-            exit_status = wait_thr.value
-            unless exit_status.success?
-              # :nocov:
-              raise "could not #{cmd}\n#{stderr.read}"
-              # :nocov:
-            end
-          end
+          cmd = "git init"
+          run_cmd_and_return_output(cmd)
+        rescue CouldNotExecuteError => e
+          # :nocov:
+          self.use_git_failed = true
+          warn e.message
+          # :nocov:
         end
 
         def git_add_all
-          cmd = "git add ."
+          return if use_git_failed
 
-          Open3.popen3(cmd) do |_stdin, _stdout, stderr, wait_thr|
-            exit_status = wait_thr.value
-            unless exit_status.success?
-              # :nocov:
-              raise "could not #{cmd}\n#{stderr.read}"
-              # :nocov:
-            end
-          end
+          cmd = "git add ."
+          run_cmd_and_return_output(cmd)
+        rescue CouldNotExecuteError => e
+          # :nocov:
+          self.use_git_failed = true
+          warn e.message
+          # :nocov:
         end
 
         def git_commit
-          # TODO: set author/name with git config in CI so we don't have to skip this
+          return if use_git_failed
+
+          cmd = "git commit -m 'Create ruby project files'"
+          run_cmd_and_return_output(cmd)
+        rescue CouldNotExecuteError => e
           # :nocov:
-          Open3.popen3("git commit -m 'Create ruby project files'") do |_stdin, stdout, stderr, wait_thr|
-            exit_status = wait_thr.value
-            unless exit_status.success?
-              raise "could not git commit -m 'Initial commit'. OUTPUT\n#{stdout.read}\nERROR:#{stderr.read}"
-            end
-          end
+          self.use_git_failed = true
+          warn e.message
           # :nocov:
         end
 
         def github_create_repo
+          return if push_to_github_failed
+
           puts "pushing to github..."
 
           cmd = "gh repo create --private #{project_config.org_slash_project_kebab}"
-          run_cmd_and_write_output(cmd, raise_if_fails: false)
+          exit_status = run_cmd_and_write_output(cmd, raise_if_fails: false)
+
+          unless exit_status&.success?
+            self.push_to_github_failed = true
+          end
         end
 
         def git_add_remote_origin
-          unless system("git remote add origin git@github.com:#{project_config.org_slash_project_kebab}.git")
+          return if push_to_github_failed
+
+          cmd = "git remote add origin git@github.com:#{project_config.org_slash_project_kebab}.git"
+          exit_status = run_cmd_and_write_output(cmd, raise_if_fails: false)
+
+          unless exit_status&.success?
             # :nocov:
-            raise "could not git remote add origin git@github.com:#{project_config.org_slash_project_kebab}.git"
+            self.push_to_github_failed = true
             # :nocov:
           end
         end
 
         def git_branch_main
-          unless system("git branch -M main")
+          return if use_git_failed
+
+          cmd = "git branch -M main"
+          exit_status = run_cmd_and_write_output(cmd, raise_if_fails: false)
+
+          unless exit_status&.success?
             # :nocov:
-            raise "could not git branch -M main"
+            self.use_git_failed = true
             # :nocov:
           end
         end
 
         def push_to_github
-          Open3.popen3("git push -u origin main") do |_stdin, _stdout, stderr, wait_thr|
-            exit_status = wait_thr.value
-            unless exit_status.success?
-              warn "WARNING: could not git push -u origin main \n #{stderr.read}"
-            end
-          end
+          return if push_to_github_failed
+
+          cmd = "git push -u origin main"
+          run_cmd_and_return_output(cmd)
+        rescue CouldNotExecuteError => e
+          self.push_to_github_failed = true
+          warn e.message
         end
 
         def rbenv_bundler_on
-          # :nocov:
-          Open3.popen3("rbenv bundler on") do |_stdin, _stdout, stderr, wait_thr|
-            exit_status = wait_thr.value
-            unless exit_status.success?
-              warn "WARNING: could not rbenv bundler on \n #{stderr.read}"
-            end
-          end
-          # :nocov:
+          cmd = "rbenv bundler on"
+          run_cmd_and_write_output(cmd, raise_if_fails: false)
         end
 
         def output

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara-empty-ruby-project-generator
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.0.21
 platform: ruby
 authors:
 - Miles Georgi