fog-vsphere 3.7.3 → 3.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 007c81c87f05ab21ba0a6adb8a8bb48a43a6ed64642a463af8d65a12211fae44
-  data.tar.gz: 40124e384e184ffbacd47fd37f1e564f5cdb6a3be87611df65493866f5a55885
+  metadata.gz: e15bb39e301de755701847ea587fd678e5717fc75408c03ac0ed7d295716f386
+  data.tar.gz: fc273115526f3dd9ebf4d37d83b9f89db85eea61926f24df1227268c959fb3a8
 SHA512:
-  metadata.gz: ef28241d40f0026f973f0a8660dc9d9a905201fe78c1bc45f8978b86aa1a631580dbb1f257b068f49c5409fdf34849b61d5c3f5512201f0a0494c6a0bbd66b79
-  data.tar.gz: fd3a32c0ad6d6ee14fa7b592d9b872eaeefa022fe5134e6312a5c5cc159f6f21884eec70e35a2aa9b343e806a487c74baf61504238a7095d81dab1d777f34bce
+  metadata.gz: 879ed96c76c460c8872cb4322e7e9daa27ab21e7627f54ffb7776e6724a7938d47c20f47c8a6d0f25accbb5acbe046b6afede16283dd7b793674541f2e61ad3e
+  data.tar.gz: b57fb164b9f54f4fa9b6902c904190166a3cc85e27e970b5fc61874a3df0310edece6fae1ae7add7f52d20f4c7a02fb48607bf13842e919b54ce139ffa6d9e32

data/lib/fog/vsphere/compute.rb

@@ -385,7 +385,7 @@ module Fog
                     }],
                   'scsi_controllers' =>
                     [{ 'shared_bus' => 'noSharing',
-                       'type'        => 'VirtualLsiLogicController',
+                       'type'        => 'ParaVirtualSCSIController',
                        'unit_number' => 7,
                        'key'         => 1000 }],
                   'nvme_controllers' =>

data/lib/fog/vsphere/models/compute/scsicontroller.rb

@@ -9,7 +9,7 @@ module Fog
         attribute :server_id
 
         DEFAULT_KEY = 1000
-        DEFAULT_TYPE = "VirtualLsiLogicController".freeze
+        DEFAULT_TYPE = "ParaVirtualSCSIController".freeze
 
         def initialize(attributes = {})
           super

data/lib/fog/vsphere/requests/compute/create_vm.rb

@@ -273,7 +273,11 @@ module Fog
         end
 
         def controller_default_options
-          { operation: :add, type: RbVmomi::VIM.VirtualLsiLogicController.class, shared: false }
+          {
+            operation: :add,
+            type: Fog::Vsphere.class_from_string(Fog::Vsphere::Compute::SCSIController::DEFAULT_TYPE, 'RbVmomi::VIM'),
+            shared: false
+          }
         end
 
         def controller_get_shared_from_options(options)

data/lib/fog/vsphere/version.rb

@@ -1,5 +1,5 @@
 module Fog
   module Vsphere
-    VERSION = '3.7.3'.freeze
+    VERSION = '3.7.4'.freeze
   end
 end

data/tests/models/compute/scsicontroller_tests.rb

@@ -0,0 +1,25 @@
+require_relative '../../helper'
+
+require 'fog/vsphere/models/compute/scsicontroller'
+
+describe Fog::Vsphere::Compute::SCSIController do
+  describe '#type' do
+    it 'defaults to ParaVirtualSCSIController when not given a type' do
+      controller = Fog::Vsphere::Compute::SCSIController.new
+
+      assert_equal('ParaVirtualSCSIController', controller.type)
+    end
+
+    %w[
+      VirtualLsiLogicController
+      VirtualLsiLogicSASController
+      VirtualBusLogicController
+    ].each do |legacy_type|
+      it "preserves an explicitly requested #{legacy_type}" do
+        controller = Fog::Vsphere::Compute::SCSIController.new(:type => legacy_type)
+
+        assert_equal(legacy_type, controller.type)
+      end
+    end
+  end
+end

data/tests/requests/compute/create_controller_tests.rb

@@ -0,0 +1,39 @@
+require_relative '../../helper'
+
+require 'rbvmomi'
+require 'fog/vsphere/models/compute/scsicontroller'
+require 'fog/vsphere/requests/compute/create_vm'
+
+describe Fog::Vsphere::Compute::Real do
+  let(:real) { Fog::Vsphere::Compute::Real.allocate }
+
+  describe '#create_controller' do
+    it 'defaults to ParaVirtualSCSIController when no controller is given' do
+      result = real.send(:create_controller)
+
+      assert_equal(RbVmomi::VIM::ParaVirtualSCSIController, result[:device].class)
+    end
+
+    it 'defaults a freshly built SCSIController model to ParaVirtualSCSIController' do
+      controller = Fog::Vsphere::Compute::SCSIController.new
+
+      result = real.send(:create_controller, controller)
+
+      assert_equal(RbVmomi::VIM::ParaVirtualSCSIController, result[:device].class)
+    end
+
+    %w[
+      VirtualLsiLogicController
+      VirtualLsiLogicSASController
+      VirtualBusLogicController
+    ].each do |legacy_type|
+      it "still builds a #{legacy_type} when explicitly requested" do
+        controller = Fog::Vsphere::Compute::SCSIController.new(:type => legacy_type)
+
+        result = real.send(:create_controller, controller)
+
+        assert_equal(RbVmomi::VIM.const_get(legacy_type), result[:device].class)
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fog-vsphere
 version: !ruby/object:Gem::Version
-  version: 3.7.3
+  version: 3.7.4
 platform: ruby
 authors:
 - J.R. Garcia
@@ -403,11 +403,13 @@ files:
 - tests/models/compute/cluster_tests.rb
 - tests/models/compute/hosts_tests.rb
 - tests/models/compute/rules_tests.rb
+- tests/models/compute/scsicontroller_tests.rb
 - tests/models/compute/server_tests.rb
 - tests/models/compute/server_unit_tests.rb
 - tests/models/compute/servers_tests.rb
 - tests/models/compute/ticket_tests.rb
 - tests/models/compute/tickets_tests.rb
+- tests/requests/compute/create_controller_tests.rb
 - tests/requests/compute/create_folder_tests.rb
 - tests/requests/compute/current_time_tests.rb
 - tests/requests/compute/destroy_iso_tests.rb
@@ -470,7 +472,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.8.0.dev
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Module for the 'fog' gem to support VMware vSphere.
 test_files:
@@ -496,11 +498,13 @@ test_files:
 - tests/models/compute/cluster_tests.rb
 - tests/models/compute/hosts_tests.rb
 - tests/models/compute/rules_tests.rb
+- tests/models/compute/scsicontroller_tests.rb
 - tests/models/compute/server_tests.rb
 - tests/models/compute/server_unit_tests.rb
 - tests/models/compute/servers_tests.rb
 - tests/models/compute/ticket_tests.rb
 - tests/models/compute/tickets_tests.rb
+- tests/requests/compute/create_controller_tests.rb
 - tests/requests/compute/create_folder_tests.rb
 - tests/requests/compute/current_time_tests.rb
 - tests/requests/compute/destroy_iso_tests.rb