fog-vsphere 3.5.0 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18ada3fe97234aa0bf59aaab14ea04ba2ceaa40cb62abc6189026b6214d85759
-  data.tar.gz: 7894e6c462e8501eb2c9a16170300d75516ba8e4431a64be14d5cc6140271fbe
+  metadata.gz: a217d08496a46e7dac6d2d8dc64deb846a3c10bd46ab68bdb23a2eacad4e5e72
+  data.tar.gz: 8bfb514ee9c268109026c9dc71cca9b68eaa5f9b875d6b900ed0d0d82755b126
 SHA512:
-  metadata.gz: 8db1f07c4c800261506a22d0be60cc2c777a2da9e6001cee6a39a22218719af8eb4f105071383732c40f20201818645954a388420f7291bd0d3fecee0adc1a91
-  data.tar.gz: ba9313ddc1af94248d965ae9cda4734766cf36c494f33f5f84fc40581be22532ff96700539f63dce3583d955a60e86b75e367795bd3c0ca29291fa921717d1db
+  metadata.gz: 66e404157f86b584f7032b1bf30ccbf6dd7286d5864afd458f16d01dce6da6d6d88131612e1d2112da9c8405c26770a7da0e1b28ac596844953f7594cde6b89e
+  data.tar.gz: d696ad6d363c8e85322330d03c7f3b6709108274faa394b750187dc4af85203d040e0c283dbfafd5706c2387e4a6ec9aa9c8d8bdf77ab10e44a5a2a79b1f46f1

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## v3.5.1
+* Creating ESX compute resource on vcenter 7.x fails with InvalidArgument: A specified parameter was not correct: deviceChange[1].device.key (#272)
+
 ## v3.5.0
 * Clone vm from different datacenter (#263)
 * Fix autoload issues (#267)

data/CONTRIBUTORS.md

@@ -53,6 +53,7 @@
 * Ohad Levy <ohadlevy@redhat.com>
 * Ondrej Prazak <oprazak@redhat.com>
 * Oscar Elfving <sofam84@gmail.com>
+* Pablo Hess <phess@redhat.com>
 * Paul Thornthwaite <paul@brightbox.co.uk>
 * Paul Thornthwaite <tokengeek@gmail.com>
 * Paulo Henrique Lopes Ribeiro <plribeiro3000@gmail.com>

data/lib/fog/vsphere/requests/compute/get_network.rb

@@ -38,7 +38,7 @@ module Fog
             # only the one will do
             proc do |n|
               n._ref == ref_or_name || (
-                n.is_a?(RbVmomi::VIM::DistributedVirtualPortgroup) && (n.name == ref_or_name || n.key == ref_or_name) &&
+                n.is_a?(RbVmomi::VIM::DistributedVirtualPortgroup) && (n.name == ref_or_name) &&
                 (n.config.distributedVirtualSwitch.name == distributedswitch)
               )
             end
@@ -46,12 +46,12 @@ module Fog
             # the first distributed virtual switch will do - selected by network - gives control to vsphere
             proc do |n|
               n._ref == ref_or_name || (
-                n.is_a?(RbVmomi::VIM::DistributedVirtualPortgroup) && (n.name == ref_or_name || n.key == ref_or_name)
+                n.is_a?(RbVmomi::VIM::DistributedVirtualPortgroup) && (n.name == ref_or_name)
               )
             end
           else
             # the first matching network will do, seems like the non-distributed networks come first
-            proc { |n| n._ref == ref_or_name || n.name == ref_or_name || (n.is_a?(RbVmomi::VIM::DistributedVirtualPortgroup) && n.key == ref_or_name) }
+            proc { |n| n._ref == ref_or_name || n.name == ref_or_name }
           end
         end
       end

data/lib/fog/vsphere/requests/compute/list_networks.rb

@@ -30,17 +30,15 @@ module Fog
                 virtualswitch: dvswitches[network['config.distributedVirtualSwitch']._ref]
               )
             elsif network.obj.is_a?(RbVmomi::VIM::OpaqueNetwork)
-              map_attrs_to_hash(network, network_dvportgroup_attribute_mapping).merge(
-                id: network.obj._ref,
+              map_attrs_to_hash(network, network_attribute_mapping).merge(
                 opaqueNetworkId: network.obj.summary.opaqueNetworkId
               )
             else
-              map_attrs_to_hash(network, network_attribute_mapping).merge(
-                id: network.obj._ref
-              )
+              map_attrs_to_hash(network, network_attribute_mapping)
             end.merge(
-              datacenter: datacenter_name,
-              _ref: network.obj._ref
+              _ref: network.obj._ref,
+              id: managed_obj_id(network.obj),
+              datacenter: datacenter_name
             )
           end.compact
         end
@@ -56,7 +54,7 @@ module Fog
 
         def network_dvportgroup_attribute_mapping
           network_attribute_mapping.merge(
-            id: 'config.key'
+            dvp_uuid: 'config.key'
           )
         end
 

data/lib/fog/vsphere/requests/compute/vm_clone.rb

@@ -812,7 +812,7 @@ module Fog
           end
 
           new_nics.each do |interface|
-            specs << create_interface(interface, 0, :add, datacenter: datacenter)
+            specs << create_interface(interface, -rand(25000..29999), :add, datacenter: datacenter)
           end
 
           specs

data/lib/fog/vsphere/requests/compute/vm_take_snapshot.rb

@@ -5,13 +5,17 @@ module Fog
         def vm_take_snapshot(options = {})
           raise ArgumentError, 'instance_uuid is a required parameter' unless options.key? 'instance_uuid'
           raise ArgumentError, 'name is a required parameter' unless options.key? 'name'
+          defaults = {
+            description: '',
+            memory: true,
+            quiesce: false
+          }
+          opts = options.clone
+          defaults.each do |k, v|
+            opts[k] = v unless opts.key?(k) || opts.key?(k.to_s)
+          end
           vm = get_vm_ref(options['instance_uuid'])
-          task = vm.CreateSnapshot_Task(
-            name: options['name'],
-            description: options['description'] || '',
-            memory: options['memory'] || true,
-            quiesce: options['quiesce'] || false
-          )
+          task = vm.CreateSnapshot_Task(opts)
 
           task.wait_for_completion
 

data/lib/fog/vsphere/version.rb

@@ -1,5 +1,5 @@
 module Fog
   module Vsphere
-    VERSION = '3.5.0'.freeze
+    VERSION = '3.5.1'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fog-vsphere
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.1
 platform: ruby
 authors:
 - J.R. Garcia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-09 00:00:00.000000000 Z
+date: 2022-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog-core