fog-google 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: c6cd15c3ff3e7cf034e00dd6d7ff6b1180a9f4ec900cd33ea668df67fd76e054
-  data.tar.gz: f6023c601325a7657682515525d7f2152742514298a96a8a66cd4253f5d6da7d
+SHA1:
+  metadata.gz: 4ef0c77cc212c88e05b3b2ba96a93a50b4e7ec6a
+  data.tar.gz: 3d052f7c4ae45331d3284fe06ab4b5c6387a2505
 SHA512:
-  metadata.gz: faf730e43186059835223e61f6ee7280d62de27bb9aeb40eb08e5b15c868633c0a9ce24db072857fd271a47e447b84171f5069334a37ed125a13709e5c626dbf
-  data.tar.gz: 70ffe56c87f88d4a65027115a2e22428a0db607b94651de2c72bc81789ecf21094b6b94f63cdd7789ec201190d358bd59492f87bfd94238b0e2c4f70260cde77
+  metadata.gz: b769db3c40da12eb211331bf3c00f73b7a938aeea5f09a1672cc142c68044b05303e79919b4dc611bce66684b6bf8b4255d3532e615c412357e58b80ca95fc9f
+  data.tar.gz: 775be1007e7030acbb089441297345e78d9afa106659be6d47d4017ad86f3db36c4ca9ab96eec0bb4a181d1bb8aebaef431cd730a0e6ccdee9b3ec8c90c7d546

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 All notable changes to this project will be documented in this file.
 The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 1.7.1
+
+### User-facing
+
+#### Fixed
+
+- \#412 Fixed `Fog::Storage::GoogleXML::GetObjectHttpUrl#get_object_http_url` 
+  request
+
 ## 1.7.0
 
 ### User-facing

data/lib/fog/google/version.rb

@@ -1,5 +1,5 @@
 module Fog
   module Google
-    VERSION = "1.7.0".freeze
+    VERSION = "1.7.1".freeze
   end
 end

data/lib/fog/storage/google_xml/requests/get_object_http_url.rb

@@ -6,12 +6,11 @@ module Fog
           raise ArgumentError.new("bucket_name is required") unless bucket_name
           raise ArgumentError.new("object_name is required") unless object_name
 
-          https_url(options.merge(:headers  => {},
-                                  :host     => @host,
-                                  :method   => "GET",
-                                  :path     => "#{bucket_name}/#{object_name}"),
+          http_url(options.merge(:headers  => {},
+                                 :host     => @host,
+                                 :method   => "GET",
+                                 :path     => "#{bucket_name}/#{object_name}"),
                     expires)
-          http_url(url_options, expires)
         end
       end
 

data/lib/fog/storage/google_xml/requests/get_object_https_url.rb

@@ -2,7 +2,7 @@ module Fog
   module Storage
     class GoogleXML
       module GetObjectHttpsUrl
-        def get_object_https_url(bucket_name, object_name, expires, options)
+        def get_object_https_url(bucket_name, object_name, expires, options = {})
           raise ArgumentError.new("bucket_name is required") unless bucket_name
           raise ArgumentError.new("object_name is required") unless object_name
 

data/test/unit/storage/test_xml_requests.rb

@@ -12,6 +12,22 @@ class UnitTestXMLRequests < MiniTest::Test
     Fog.unmock!
   end
 
+  def test_get_http_url
+    url = @client.get_object_http_url("bucket",
+                                      "just some file.json",
+                                      Time.now + 2 * 60)
+    assert_match(/^http:\/\//, url,
+                 "URL starts with HTTP")
+  end
+
+  def test_get_https_url
+    url = @client.get_object_https_url("bucket",
+                                       "just some file.json",
+                                       Time.now + 2 * 60)
+    assert_match(/^https:\/\//, url,
+                 "URL starts with HTTPS")
+  end
+
   def test_get_url_path_has_query_params
     url = @client.get_object_url("bucket",
                                  "just some file.json",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fog-google
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Nat Welch
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-19 00:00:00.000000000 Z
+date: 2018-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog-core
@@ -778,7 +778,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Module for the 'fog' gem to support Google.