fog-google 1.25.0 → 1.26.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87a715866f44c0d1a77d6a2d9eb1c86b9eb1b2ad1926b48ca8f33bff6729f038
-  data.tar.gz: 9d0af9d669834f9859b2a5c1d0b12a377fdc11cc8bcdad1d14a58068f00f1c35
+  metadata.gz: f5f068b5166ef1e1c12d9bef6ae6da15c489df03929d86047709ef19c3dd70e9
+  data.tar.gz: 4e94f5cfb3be3fec06535efd74368720b42c37537ea8ffcf2c42888b68bcf283
 SHA512:
-  metadata.gz: 556ef7cd9ca3e7c33308c9fd8e668f98284fdf7aecbd17c1ceeef2a317b324c2f4cd8e6cd6201fd95507c9a74960d2318dbbf6c6d173cf246d8491367a578523
-  data.tar.gz: 7c00ced8d78888a448c83ee5582580fe10c970aab34dd7d84e52961b8fb796e8d6cf1a776ca704542cd6618b5fdbb591c12bff42014e4389862522da08311db3
+  metadata.gz: 7fed398133b6232a92ada212c143d65228dbb3a0d6c49b1842256ef79b1fea2a2bf9add46947459d2afb4b3df4f69fb74b49bfe14f0a6459cceab7adb4518ae1
+  data.tar.gz: 53397624bfcdb357853bba55725c9c60336c734fe0ecb81f812cabed0945cb9009b93b2d3b6ff04e3673082ebee82d1fdda647f55631dced3f27673a8f6f1430

data/.github/workflows/integration-compute-core.yml

@@ -36,13 +36,13 @@ jobs:
     runs-on: fog-arc-runner
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2' ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4' ]
       # Integration tests from the same task cannot run in parallel yet due to cleanup
       # TODO(fog-google#626): remove this once cleanup is fixed
       max-parallel: 1
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/integration-compute-instance_groups.yml

@@ -37,12 +37,12 @@ jobs:
     runs-on: fog-arc-runner
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2' ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4' ]
       # Integration tests from the same task cannot run in parallel yet due to cleanup
       max-parallel: 1
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/integration-compute-loadbalancing.yml

@@ -37,12 +37,12 @@ jobs:
     runs-on: fog-arc-runner
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2' ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4' ]
       # Integration tests from the same task cannot run in parallel yet due to cleanup
       max-parallel: 1
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/integration-compute-networking.yml

@@ -36,12 +36,12 @@ jobs:
     runs-on: fog-arc-runner
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2' ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4' ]
       # Integration tests from the same task cannot run in parallel yet due to cleanup
       max-parallel: 1
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/integration-monitoring.yml

@@ -37,12 +37,12 @@ jobs:
     runs-on: fog-arc-runner
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2' ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4' ]
       # Integration tests from the same task cannot run in parallel yet due to cleanup
       max-parallel: 1
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/integration-pubsub.yml

@@ -37,12 +37,12 @@ jobs:
     runs-on: fog-arc-runner
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2' ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4' ]
       # Integration tests from the same task cannot run in parallel yet due to cleanup
       max-parallel: 1
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/integration-sql.yml

@@ -37,12 +37,12 @@ jobs:
     runs-on: fog-arc-runner
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2' ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4' ]
       # Integration tests from the same task cannot run in parallel yet due to cleanup
       max-parallel: 1
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/integration-storage.yml

@@ -38,12 +38,12 @@ jobs:
     runs-on: fog-arc-runner
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2' ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4' ]
       # Integration tests from the same task cannot run in parallel yet due to cleanup
       max-parallel: 1
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/unit.yml

@@ -16,10 +16,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: [ '3.0', '3.1', '3.2', 'head', 'truffleruby-head']
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4', 'head', 'truffleruby-head']
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/CHANGELOG.md

@@ -4,10 +4,29 @@ The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-## Next
+## 1.26.0
 
 ### User-facing
 
+#### Fixed
+
+- #632 remove unused files from package [temikus]
+- #643 update disk attachment method to use new attached_disk_obj method [geemus]
+- #644 improve mock bucket name regex validation [geemus]
+- #646 fix frozen string literal warnings in storage [krororo]
+
+### Development changes
+
+#### Added
+
+- #645 add ruby 3.3 and 3.4 to CI test matrix [krororo]
+
+#### Fixed
+
+- #641 Updated actions/checkout from 4 to 5 [dependabot]
+- #642 Updated actions/stale from 9 to 10 [dependabot]
+- remove stale workflow [geemus]
+
 ## 1.25.0
 
 ### User-facing
@@ -335,7 +354,7 @@ Drop travis usage
 
 #### Fixed
 
-- \#448 Add `:google_application_default` as recognized argument in 
+- \#448 Add `:google_application_default` as recognized argument in
   Fog::Compute::Google client [mavin]
 
 ### Development changes
@@ -351,14 +370,14 @@ Drop travis usage
 #### Added
 
 - \#442 Add support for Application Default credentials [mavin]
-  - This change allows the use of Application Default Credentials so that end 
+  - This change allows the use of Application Default Credentials so that end
     users can authenticate without a service account for development, testing,
-    and one-off interactions by using `:google_application_default`client 
+    and one-off interactions by using `:google_application_default`client
     option. See README for more details.
 
 ### Fixed
 
-- \#444 Remove deprecated `google_client_email` option from client parameters 
+- \#444 Remove deprecated `google_client_email` option from client parameters
   [temikus]
 - \#446 Updating service parameters to avoid "unrecognised parameter" warnings
   when initializing Fog client with application default auth [temikus]
@@ -383,7 +402,7 @@ Drop travis usage
 
 #### Fixed
 
-- \#433 Allow the api to close Tempfiles inline, improving disk utilization. 
+- \#433 Allow the api to close Tempfiles inline, improving disk utilization.
         [itopalov]
 
 ### Development changes
@@ -425,12 +444,12 @@ Drop travis usage
 - \#419 Locked down fog upstream dependencies to alleviate deprecation warnings
   until they can be properly dealt with. [temikus]
 - \#400 Small `%Collection%.get` and `%Collection%.all` behaviour fixes [temikus]
-  - `Fog::Google::SQL::Instances.get(nil)` no longer returns an invalid 
+  - `Fog::Google::SQL::Instances.get(nil)` no longer returns an invalid
     `sql#instancesList` object.
-  - `Fog::Compute::Google::InstanceGroups.get` and `.all` methods now support 
+  - `Fog::Compute::Google::InstanceGroups.get` and `.all` methods now support
     more than just `:filter` option, fixed `.all` output without `zone` option.
   - Fix a typo causing `Operations.get(region:REGION)` to fail.
-  - `Fog::Compute::Google::Images.get(IMAGE, PROJECT)`, now returns `nil` if 
+  - `Fog::Compute::Google::Images.get(IMAGE, PROJECT)`, now returns `nil` if
     image is not found rather than throwing `Google::Apis::ClientError`.
 
 ### Development changes
@@ -438,13 +457,13 @@ Drop travis usage
 #### Added
 
 - \#400 Additional test coverage [temikus]
-  - Expanded tests for `%Collection%.get` behavior - scoped requests 
-    (e.g. `get(zone:ZONE)`) and their corresponding code paths are now also 
+  - Expanded tests for `%Collection%.get` behavior - scoped requests
+    (e.g. `get(zone:ZONE)`) and their corresponding code paths are now also
     properly tested.
   - Increase `Fog::Compute::Google::Images` integration test coverage.
   - Unit tests now work without a `~/.fog` config file set up.
   - Expanded unit test coverage.
-- \#424 Add simple integration tests to check client proxy options being 
+- \#424 Add simple integration tests to check client proxy options being
   applied.
 
 #### Changed
@@ -461,7 +480,7 @@ Drop travis usage
 
 #### Fixed
 
-- \#412 Fixed `Fog::Storage::GoogleXML::GetObjectHttpUrl#get_object_http_url` 
+- \#412 Fixed `Fog::Storage::GoogleXML::GetObjectHttpUrl#get_object_http_url`
   request
 
 ## 1.7.0
@@ -478,8 +497,8 @@ Drop travis usage
 
 #### Changed
 
-- \#394 `save/update/destroy` and other operations now wait until they are in a 
-  DONE state, instead of !PENDING. This should be a no-op for users but should 
+- \#394 `save/update/destroy` and other operations now wait until they are in a
+  DONE state, instead of !PENDING. This should be a no-op for users but should
   safeguard from issues in the future. [temikus]
 - \#383 `Fog::Compute::Google::Address` resources are now created synchronously
   by default. [temikus]
@@ -497,7 +516,7 @@ Drop travis usage
 - \#376 Add doc coverage tracking. [temikus]
 - \#383 Increase integration test coverage further. [temikus]
   - Add collection tests and factories (when mutable) for following resources:
-    - Addresses 
+    - Addresses
     - Disks
     - Projects
     - Routes
@@ -521,7 +540,7 @@ Drop travis usage
 
 #### Changed
 
-- \#338 `Fog::Google::SQL` resources are now created and destroyed synchronously by default. 
+- \#338 `Fog::Google::SQL` resources are now created and destroyed synchronously by default.
 You can override it in a standard manner by passing a parameter to async method, e.g.:
  `Fog::Google::SQL::Instance.create(true)` [temikus]
 - \#367 `Fog::Compute::Google::Server.bootstrap` changes [temikus]
@@ -590,30 +609,30 @@ You can override it in a standard manner by passing a parameter to async method,
 #### Added
 
 - \#336 `Fog::Compute::Google::Server.set_metadata` is now working properly and adopted a simpler format, e.g. `{'foo' => 'bar', 'baz'=>'foo'}`
-- \#334 Added a new helper method: `Fog::Compute::Google::Server.public_ip_address` [temikus] 
-- \#314 Added `Fog::Compute::Google::InstanceGroup.add_instance` method back [temikus] 
+- \#334 Added a new helper method: `Fog::Compute::Google::Server.public_ip_address` [temikus]
+- \#314 Added `Fog::Compute::Google::InstanceGroup.add_instance` method back [temikus]
 - \#326 Added support for using predefined ACLs, refactor valid ACLs [vimutter]
 - \#318 Added fog_public support in Storage JSON API [jayhsu21]
 
 #### Fixed
 
-- \#354 Bump Google API client to 0.23 [temikus] 
-- \#346 Fixed get_health when called with an instance name [bpaquet] 
-- \#317 Fixed source_image selection to get the image from name if the format is not compatible with new Google API Client [temikus] 
-- \#321 Fix string key instead of symbol for subnetworks listing [tumido] 
-- \#351 Fixed trailing spaces and added data presence check to `Fog::Storage::GoogleJSON.put_object` [vimutter] 
+- \#354 Bump Google API client to 0.23 [temikus]
+- \#346 Fixed get_health when called with an instance name [bpaquet]
+- \#317 Fixed source_image selection to get the image from name if the format is not compatible with new Google API Client [temikus]
+- \#321 Fix string key instead of symbol for subnetworks listing [tumido]
+- \#351 Fixed trailing spaces and added data presence check to `Fog::Storage::GoogleJSON.put_object` [vimutter]
 
 ### Development changes
 
 #### Added
 
-- \#353 Added collection/model unit tests to be run by Travis CI [temikus] 
-- \#347 Added target pool tests [temikus] 
+- \#353 Added collection/model unit tests to be run by Travis CI [temikus]
+- \#347 Added target pool tests [temikus]
 
 #### Fixed
 
 - \#322 Fixed all broken integration tests, all tests now pass in CI [temikus]
-- \#344 Updated CI pipeline to run in parallel, broke out test tasks [temikus] 
+- \#344 Updated CI pipeline to run in parallel, broke out test tasks [temikus]
 
 ## 1.0.1
 

data/SECURITY.md

@@ -1,16 +1,5 @@
-# Security Policy
+# Security contact information
 
-Our README.md is the end all be all for authoritative information, but the following is our security policy.
+To report a security vulnerability, please contact [Tidelift security](https://tidelift.com/security).
 
-## Supported Versions
-
-Versions with :white_check_mark: are supported. All other versions need to be upgraded.
-
-| Version | Supported          |
-| ------- | ------------------ |
-| 1.9.x   | :white_check_mark: |
-| 0.1.x   | :white_check_mark: until July 1st, 2019 |
-
-## Reporting a Vulnerability
-
-Please file an issue here to report a vulnerability. For immediate escalations, please email nat@natwelch.com and temikus@google.com with the subject `[Fog-Google Security Issue] Description`.
+Tidelift will coordinate the fix and disclosure.

data/fog-google.gemspec

@@ -12,9 +12,8 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/fog/fog-google"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0")
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.start_with?("test/") }
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
   # As of 0.1.1
@@ -39,7 +38,7 @@ Gem::Specification.new do |spec|
   # Debugger
   # Locked because pry-byebug is broken with 13+
   # see: https://github.com/deivid-rodriguez/pry-byebug/issues/343
-  spec.add_development_dependency "pry", "= 0.14.2"
+  spec.add_development_dependency "pry", "= 0.15.2"
 
   # Testing gems
   spec.add_development_dependency "retriable"

data/lib/fog/google/compute/models/server.rb

@@ -277,7 +277,7 @@ module Fog
           requires :identity, :zone
 
           if disk.is_a? Disk
-            disk_obj = disk.get_attached_disk
+            disk_obj = disk.attached_disk_obj(**attached_disk_options)
           elsif disk.is_a? String
             disk_obj = service.disks.attached_disk_obj(disk, **attached_disk_options)
           end

data/lib/fog/google/storage/storage_json/real.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fog
   module Google
     class StorageJSON
@@ -34,7 +36,7 @@ module Fog
 DATA
 
           google_headers = {}
-          canonical_google_headers = ""
+          canonical_google_headers = +""
           params[:headers].each do |key, value|
             google_headers[key] = value if key[0..6] == "x-goog-"
           end
@@ -45,7 +47,7 @@ DATA
           end
           string_to_sign << canonical_google_headers.to_s
 
-          canonical_resource = "/"
+          canonical_resource = +"/"
           if subdomain = params.delete(:subdomain)
             canonical_resource << "#{CGI.escape(subdomain).downcase}/"
           end

data/lib/fog/google/storage/storage_json/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "addressable"
 
 module Fog
@@ -5,11 +7,11 @@ module Fog
     class StorageJSON
       module Utils
         def http_url(params, expires)
-          "http://" << host_path_query(params, expires)
+          "http://#{host_path_query(params, expires)}"
         end
 
         def https_url(params, expires)
-          "https://" << host_path_query(params, expires)
+          "https://#{host_path_query(params, expires)}"
         end
 
         def url(params, expires)

data/lib/fog/google/storage/storage_xml/real.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fog
   module Google
     class StorageXML
@@ -46,7 +48,7 @@ module Fog
 DATA
 
           google_headers = {}
-          canonical_google_headers = ""
+          canonical_google_headers = +""
           params[:headers].each do |key, value|
             google_headers[key] = value if key[0..6] == "x-goog-"
           end
@@ -57,7 +59,7 @@ DATA
           end
           string_to_sign << canonical_google_headers.to_s
 
-          canonical_resource = "/"
+          canonical_resource = +"/"
           if subdomain = params.delete(:subdomain)
             canonical_resource << "#{CGI.escape(subdomain).downcase}/"
           end

data/lib/fog/google/storage/storage_xml/requests/get_bucket.rb

@@ -49,7 +49,7 @@ module Fog
         def get_bucket(bucket_name, options = {})
           raise ArgumentError.new("bucket_name is required") unless bucket_name
           response = Excon::Response.new
-          name = /(\w+\.?)*/.match(bucket_name)
+          name = /([a-zA-Z0-9][a-zA-Z0-9\-_.]+[a-zA-Z0-9])/.match(bucket_name)
           if bucket_name == name.to_s
             if bucket = data[:buckets][bucket_name]
               contents = bucket[:objects].values.sort_by { |a| a["Key"] }.reject do |object|

data/lib/fog/google/storage/storage_xml/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Fog
   module Google
     class StorageXML
@@ -14,11 +16,11 @@ module Fog
         ).freeze
 
         def http_url(params, expires)
-          "http://" << host_path_query(params, expires)
+          "http://#{host_path_query(params, expires)}"
         end
 
         def https_url(params, expires)
-          "https://" << host_path_query(params, expires)
+          "https://#{host_path_query(params, expires)}"
         end
 
         def url(params, expires)

data/lib/fog/google/version.rb

@@ -1,5 +1,5 @@
 module Fog
   module Google
-    VERSION = "1.25.0".freeze
+    VERSION = "1.26.0".freeze
   end
 end