fog-brightbox 1.11.0 → 1.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2704dd100c0417f4e0c5542215cc2e0b1e84f0b066f8c4be9858dae64f96a53
-  data.tar.gz: 5bf6d58cdbb9360746281d9d2d2196b027db82702000e1e62691d21d30e6ddb3
+  metadata.gz: 9fdadbc0fea3aa4cedbd5f80c7cd921ff302304f18a10b4d00a95bfb62f8c01f
+  data.tar.gz: eb5f3540d35cee35994ffe5468c3b6bc6abd6668ca3aa8748f01aa6554e594bd
 SHA512:
-  metadata.gz: 9b4009f6fc679a921ba6aa51bde935a8d4221d39d1d91e7b1815b31f8aa46ffbf4cf41ca4e49574c5c4829aeb8444f19893da742e67f024dfb0890227ad453b1
-  data.tar.gz: 4cdd670508ec4be444829057d96e373aee41df23c8506d66361f33d7228c22b5afaea1f3c74700ebc27f186a4e88c5219025e6747f2db45a2ffb126639bad66d
+  metadata.gz: 822ae83ee99e51772dc7d201f8ad0afe12276301b0c548284cb29dc6d64ce8a4204efc946011ab9f756a00d2d0dd0f044ee75538e262f723b94c71703ed9a755
+  data.tar.gz: 01c48ca96800eb5d830bde46306ec25adbc2bc60dad60fd7b667e7677e2b2843e28da151830cb901555b44ce3a609d83cc9fea5aa2c7c80270e78b5aa5452dd9

data/.github/workflows/ruby.yml

@@ -15,12 +15,11 @@ on:
 
 jobs:
   test:
-
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
-        ruby-version: ["2.1", "2.2", "2.3", "2.4", "2.5", "2.6", "2.7", "3.0", "head"]
-
+        ruby-version: ["2.4", "2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "3.3", "head"]
     steps:
     - uses: actions/checkout@v2
     - name: Set up Ruby
@@ -32,3 +31,21 @@ jobs:
         bundler-cache: true # runs 'bundle install' and caches installed gems automatically
     - name: Run tests
       run: bundle exec rake
+
+  test-old:
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby-version: ["2.3"]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+      # change this to (see https://github.com/ruby/setup-ruby#versioning):
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rake

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+### 1.12.0 / 2024-12-10
+
+Bug fixes:
+
+* Declare `Excon[:omit_default_port]` to fix specs matching on headers
+  that vary based on the Ruby version and the discovered Excon version's
+  default behaviour
+* Explicitly require `base64` in authentication code
+* Require `base64` gem for Ruby 3.4 as it is no longer in stdlib
+* Remove `rubocop` version dependency as it is a development tool
+
+Changes:
+
+* Soft deprecation of Ruby 2.1 and 2.2 due to upstream constraints
+* Updated CI testing matrix for supported versions
+* Remove specs related to legacy FTP image uploading
+
 ### 1.11.0 / 2023-01-26
 
 Enhancements:

data/README.md

@@ -44,6 +44,12 @@ and its modules:
 As required by the main `fog-core` library, support for Ruby 1.9 was dropped in
 `v1.0.0` of this gem.
 
+Upstream changes on dependencies have resulted in support failing for Ruby <2.3
+from `v1.12.0` due to some libraries failing to declare usage of newer language
+features in their own gemspec files.
+
+As of 2024 `fog-core` is only testing for Ruby 3.0+ support.
+
 ## Contributing
 
 1. Fork it ( https://github.com/fog/fog-brightbox/fork )

data/fog-brightbox.gemspec

@@ -22,6 +22,10 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 2.0"
 
+  if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4")
+    spec.add_dependency "base64"
+  end
+
   spec.add_dependency "fog-core", ">= 1.45", "< 3.0"
   spec.add_dependency "fog-json"
   spec.add_dependency "dry-inflector"
@@ -30,7 +34,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rubocop", "< 0.50"
+  spec.add_development_dependency "rubocop"
   spec.add_development_dependency "shindo"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "yard"

data/lib/fog/brightbox/oauth2.rb

@@ -1,3 +1,5 @@
+require "base64"
+
 module Fog
   module Brightbox
     # This module covers Brightbox's partial implementation of OAuth 2.0

data/lib/fog/brightbox/version.rb

@@ -1,5 +1,5 @@
 module Fog
   module Brightbox
-    VERSION = "1.11.0".freeze
+    VERSION = "1.12.0".freeze
   end
 end

data/spec/fog/brightbox/storage/authentication_request_spec.rb

@@ -3,11 +3,18 @@ require "spec_helper"
 describe Fog::Brightbox::Storage::AuthenticationRequest do
   include StockStorageResponses
 
+  before do
+    # Excon v1.0 changes the behaviour and results in older versions of Ruby
+    # limited to v0.112.0 reporting failures since they can not match the Host
+    # header correctly.
+    Excon.defaults[:omit_default_port] = true
+  end
+
   describe "when initialised with blank config" do
     before do
       stub_request(:get, "https://orbit.brightbox.com/v1")
         .with(headers: {
-                "Host" => "orbit.brightbox.com:443",
+                "Host" => "orbit.brightbox.com",
                 "X-Auth-User" => "",
                 "X-Auth-Key" => ""
               }).to_return(bad_url_response)
@@ -25,7 +32,7 @@ describe Fog::Brightbox::Storage::AuthenticationRequest do
     before do
       stub_request(:get, "https://orbit.brightbox.com/v1")
         .with(headers: {
-                "Host" => "orbit.brightbox.com:443",
+                "Host" => "orbit.brightbox.com",
                 "X-Auth-User" => "cli-12345",
                 "X-Auth-Key" => "12345"
               }).to_return(authorized_response)
@@ -46,7 +53,7 @@ describe Fog::Brightbox::Storage::AuthenticationRequest do
     before do
       stub_request(:get, "https://orbit.brightbox.com/v1")
         .with(headers: {
-                "Host" => "orbit.brightbox.com:443",
+                "Host" => "orbit.brightbox.com",
                 "X-Auth-User" => "user@example.test",
                 "X-Auth-Key" => "abcde"
               }).to_return(authorized_response)
@@ -69,7 +76,7 @@ describe Fog::Brightbox::Storage::AuthenticationRequest do
     before do
       stub_request(:get, "https://orbit.brightbox.com/v1")
         .with(headers: {
-                "Host" => "orbit.brightbox.com:443",
+                "Host" => "orbit.brightbox.com",
                 "X-Auth-User" => "user@example.test",
                 "X-Auth-Key" => "abcde"
               }).to_return(unauthorized_response)

data/spec/fog/compute/brightbox_spec.rb

@@ -14,10 +14,16 @@ describe Fog::Brightbox::Compute do
       }
 
       @credential_guard = Minitest::Mock.new
+      # Stub for older versions of fog-core
       def @credential_guard.reject
         {}
       end
 
+      # Stub for newer versions of fog-core
+      def @credential_guard.select
+        {}
+      end
+
       Fog.stub :credentials, @credential_guard do
         @service = Fog::Brightbox::Compute.new(@arguments)
       end

data/tests/brightbox/models/compute/account_tests.rb

@@ -2,14 +2,4 @@ Shindo.tests("Fog::Compute[:brightbox] | Account model", ["brightbox"]) do
   pending if Fog.mocking?
 
   @account = Fog::Compute[:brightbox].account
-
-  tests("success") do
-    tests("#reset_ftp_password") do
-      pending if Fog.mocking?
-      test("original ftp password is blanked") { @account.library_ftp_password.nil? }
-      @new_password = @account.reset_ftp_password
-      test("new ftp password was not nil") { !@new_password.nil? }
-      test("new ftp password is set") { @account.library_ftp_password == @new_password }
-    end
-  end
 end

data/tests/brightbox/requests/compute/account_tests.rb

@@ -34,20 +34,6 @@ Shindo.tests("Fog::Compute[:brightbox] | account requests", ["brightbox"]) do
       result = Fog::Compute[:brightbox].update_account(@scoped_account_identifier, update_options)
       data_matches_schema(Brightbox::Compute::Formats::Full::ACCOUNT, allow_extra_keys: true) { result }
     end
-
-    tests("#reset_ftp_password_scoped_account") do
-      pending if Fog.mocking?
-      result = Fog::Compute[:brightbox].reset_ftp_password_scoped_account
-      data_matches_schema(Brightbox::Compute::Formats::Full::ACCOUNT, allow_extra_keys: true) { result }
-      test("new ftp password is visible") { !result["library_ftp_password"].nil? }
-    end
-
-    tests("#reset_ftp_password_account(#{@scoped_account_identifier})") do
-      pending if Fog.mocking?
-      result = Fog::Compute[:brightbox].reset_ftp_password_account(@scoped_account_identifier)
-      data_matches_schema(Brightbox::Compute::Formats::Full::ACCOUNT, allow_extra_keys: true) { result }
-      test("new ftp password is visible") { !result["library_ftp_password"].nil? }
-    end
   end
 
   tests("failure") do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fog-brightbox
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.12.0
 platform: ruby
 authors:
 - Paul Thornthwaite
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1970-01-01 00:00:00.000000000 Z
+date: 2024-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog-core
@@ -118,16 +118,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.50'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.50'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: shindo
   requirement: !ruby/object:Gem::Requirement
@@ -495,7 +495,7 @@ homepage: https://github.com/fog/fog-brightbox
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -510,8 +510,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: This library can be used as a module for `fog` or as standalone provider
   to use the Brightbox Cloud in applications