fog-azure-rm 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4b685851346e42d9a032133a02a6c3a12ccf5896
-  data.tar.gz: f018a73de0ea3dcec83d57c9f355b0b76571fded
+  metadata.gz: d368c1c1b51e0a2ce92cc1791b88c7fc41c05ecc
+  data.tar.gz: 9d50a7b320080bc990a6e2e54cef9c5144c9e7c5
 SHA512:
-  metadata.gz: 42f964d72836337a5057cacf99ce98c144e62e99461ab1fe00e92c9ac83d291b7e8c6a465babc116481894d221c8ed65f70396ecb18b69c688fb5e96e7feab89
-  data.tar.gz: afcd011ce4a78237e5515eba3ff43559bfa77c9cf5b539367ad54fb33d2d893b533768f40d6b7ef89668b03a93cd87118dcec079518aad7cfc59ca22410c5f7a
+  metadata.gz: b397f190098b56507d6cfae71f290c298282ef4de15e122ee59d38dcb3b3fae6759646824e91a25c78640237b18bb9f7bd61315f3a962c11c4f384653e1b8f36
+  data.tar.gz: 4503e9320364fa79d212cc5872052a5f72c32f4b96ad7cdfdaaf9260c47a524305c19bc5d2a87281c41cb6d01d7308459dd7fd4713969e22db51d7f37803ee32

data/.travis.yml

@@ -15,6 +15,8 @@ matrix:
     - rvm: 2.2.0
     - rvm: 2.3.0
     - rvm: jruby-head
+  allow_failures:
+    - rvm: jruby-head
 
 notifications:
   email:

data/CHANGELOG.md

@@ -1,4 +1,14 @@
-## 0.0.7 
+## 0.0.9
+
+**Added:**
+- Azure SQL Service - Added support for SQL Server, SQL Databases and Data warehouse.
+
+**Changed:**
+- DNS Service - DNS Service moved from API calls to Azure latest SDK.
+
+
+
+## 0.0.8 
 
 **Added:**
 - Compute Service - Added support to create virtual machine from a custom image.

data/README.md

@@ -47,24 +47,32 @@ After creating the service principal, you should have three pieces of informatio
 
 ### Compute
 
-  Fog-AzureRM for compute includes implementaion of Virtual Machines and Availability Sets. Readme for the usage of [Compute](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/compute.md) module.
+  Fog-AzureRM for compute includes implementation of Virtual Machines and Availability Sets. Readme for the usage of [Compute](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/compute.md) module.
 
 ### Resources
 
-  Fog-AzureRM for resources includes implementaion of Resource Groups. Readme for the usage of [Resources](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/resources.md) module.
+  Fog-AzureRM for resources includes implementation of Resource Groups. Readme for the usage of [Resources](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/resources.md) module.
 
 ### DNS
 
-  Fog-AzureRM for dns includes implementaion of Record sets and Zones. Readme for the usage of [DNS](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/dns.md) module.
+  Fog-AzureRM for dns includes implementation of Record sets and Zones. Readme for the usage of [DNS](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/dns.md) module.
 
 ### Network
 
-  Fog-AzureRM for network includes implementaion of Network Interfaces, Public IPs, Subnets and Virtual Networks. Readme for the usage of [Network](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/network.md) module.
+  Fog-AzureRM for network includes implementation of Network Interfaces, Public IPs, Subnets and Virtual Networks. Readme for the usage of [Network](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/network.md) module.
 
 ### Storage
 
-  Fog-AzureRM for storage includes implementaion of Storage Accounts. Readme for the usage of [Storage](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/storage.md) module.
+  Fog-AzureRM for storage includes implementation of Storage Accounts. Readme for the usage of [Storage](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/storage.md) module.
   
+### Traffic Manager
+  
+  Fog-AzureRM for Traffic Manager includes implementation of Traffic Manager Profile and Traffic Manager End-points. Readme for the usage of [Traffic Manager](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/traffic_manager.md) module.
+
+### SQL 
+  
+  Fog-AzureRM for SQL includes implementation of SQL Server, SQL Databases and Data Warehouse. Readme for the usage of [Azure SQL](https://github.com/fog/fog-azure-rm/blob/master/lib/fog/azurerm/docs/sql.md) module.
+
 ## Supported Services
 
 Use following command for the complete list of services, Fog provides for Azure Resource Manager.

data/fog-azure-rm.gemspec

@@ -22,12 +22,13 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest', '~> 5.8.4'
   spec.add_development_dependency 'simplecov', '~> 0.11.2'
   spec.add_development_dependency 'codeclimate-test-reporter'
-  spec.add_dependency 'fog-core', '~> 1.42.0'
+  spec.add_dependency 'fog-core', '~> 1.43.0'
   spec.add_dependency 'rest-client', '~> 2.0.0'
-  spec.add_dependency 'azure_mgmt_compute', '~> 0.5.0'
-  spec.add_dependency 'azure_mgmt_resources', '~> 0.5.0'
-  spec.add_dependency 'azure_mgmt_storage', '~> 0.5.0'
-  spec.add_dependency 'azure_mgmt_network', '~> 0.5.0'
-  spec.add_dependency 'azure_mgmt_traffic_manager', '~> 0.5.0'
-  spec.add_dependency 'azure-storage', '~> 0.10.2.preview'
+  spec.add_dependency 'azure_mgmt_compute', '~> 0.6.0'
+  spec.add_dependency 'azure_mgmt_resources', '~> 0.6.0'
+  spec.add_dependency 'azure_mgmt_storage', '~> 0.6.0'
+  spec.add_dependency 'azure_mgmt_network', '~> 0.6.0'
+  spec.add_dependency 'azure_mgmt_dns', '~> 0.6.0'
+  spec.add_dependency 'azure_mgmt_traffic_manager', '~> 0.6.0'
+  spec.add_dependency 'azure-storage', '~> 0.11.1.preview'
 end

data/lib/fog/azurerm/application_gateway.rb

@@ -14,6 +14,8 @@ module Fog
       request :get_application_gateway
       request :update_subnet_id_in_gateway_ip_configuration
       request :update_sku_attributes
+      request :start_application_gateway
+      request :stop_application_gateway
 
       model_path 'fog/azurerm/models/application_gateway'
       model :gateway

data/lib/fog/azurerm/dns.rb

@@ -34,10 +34,19 @@ module Fog
       # This class provides the actual implemention for service calls.
       class Real
         def initialize(options)
+          begin
+            require 'azure_mgmt_dns'
+          rescue LoadError => e
+            retry if require('rubygems')
+            raise e.message
+          end
+
+          credentials = Fog::Credentials::AzureRM.get_credentials(options[:tenant_id], options[:client_id], options[:client_secret])
+          @dns_client = ::Azure::ARM::Dns::DnsManagementClient.new(credentials)
+          @dns_client.subscription_id = options[:subscription_id]
           @tenant_id = options[:tenant_id]
           @client_id = options[:client_id]
           @client_secret = options[:client_secret]
-          @subscription_id = options[:subscription_id]
           @resources = Fog::Resources::AzureRM.new(
             tenant_id: options[:tenant_id],
             client_id: options[:client_id],

data/lib/fog/azurerm/docs/sql.md

@@ -0,0 +1,130 @@
+#Azure SQL
+
+This document explains how to get started using Azure SQL Services with Fog.
+
+## Usage
+
+First of all, you need to require the Fog library by executing:
+
+```ruby
+require 'fog/azurerm'
+```
+
+## Create Connection
+
+Next, create a connection to the SQL Service:
+
+```ruby
+    azure_sql_service = Fog::Sql::AzureRM.new(
+        tenant_id:       '<Tenantid>',           # Tenant id of Azure Active Directory Application
+        client_id:       '<Clientid>',           # Client id of Azure Active Directory Application
+        client_secret:   '<ClientSecret>',       # Client Secret of Azure Active Directory Application
+        subscription_id: '<Subscriptionid>'      # Subscription id of an Azure Account
+    )
+```
+
+The {server-name} and {database-name} value must be set using all lowercase ANSI letters , hyphen, and the numbers 1 through 9. Do not use a hyphen as the leading or trailing character.
+
+
+## Create SQL Server
+
+Create a new Server
+
+```ruby
+    azure_sql_service.sql_servers.create(
+        name: '<Unique Server Name>',
+        resource_group: '<Resource Group Name>',
+        location: 'East US',
+        version: '2.0',                                # Specifies the version of the Azure server. The acceptable value are: '2.0' or '12.0'
+        administrator_login: 'testserveradmin',        # Specifies the name of the SQL administrator.
+        administrator_login_password: 'svr@admin123'   # Specifies the password of the SQL administrator.
+    )
+```
+For more information, see link: https://msdn.microsoft.com/en-us/library/azure/mt297738.aspx
+
+## List SQL Servers
+Get a list of servers in given resource group
+```ruby
+    servers  = azure_sql_service.sql_servers(resource_group: '<Resource Group Name>')
+    servers.each do |server|
+      puts "Listing : #{server.name}"
+    end
+```
+
+## Retrieve a single SQL Server
+
+Get a single record of SQL Server
+
+```ruby
+     server = azure_sql_service.sql_servers
+                   .get('<Resource Group Name>', '<Server Name>')
+     puts "Server Name: #{server.name}"
+```
+
+## Destroy a SQL Server
+
+Get SQL Server object from the get method(described above) and destroy that Server.
+
+```ruby
+      server.destroy
+```
+
+## Create SQL Database
+
+Creates a new Sql Database
+
+In parameter {create_mode}: 'Copy', 'NonReadableSecondary', and 'OnlineSecondary' are not supported by SQL Data Warehouse.
+
+If parameter {edition} is set to DataWarehouse, the acceptable values for parameter {requested_service_objective_name} are: ['DW100', 'DW200', 'DW300', 'DW400', 'DW500', 'DW600', 'DW1000', 'DW1200', 'DW1500', 'DW2000', 'DW3000', 'DW6000'] 
+
+```ruby
+    azure_sql_service.sql_databases.create(
+        resource_group: '<Resource Group Name>',
+        location: 'East US',
+        server_name: '<Server Name>',
+        name: '<Database Name>',
+        create_mode: '<Create Mode>',           # Optional. Specifies the type of database to create. The default value is Default. The acceptable values are: [Copy, Default, NonReadableSecondary, OnlineSecondary, PointInTimeRestore, PointInTimeRestore, Restore]
+        edition: '<Edition>',                   # Conditional. Specifies the edition of the database. If createMode is set to Default, then this value must be specified. The acceptable value are: [Basic, Standard, Premium, DataWarehouse]
+        source_database_id: '<URI>',                  # Conditional. Specifies the URI of the source database. If createMode is not set to Default, then this value must be specified.
+        collation: '<Collation>',                     # Conditional. Specifies the name of the collation. If createMode is set to Default, then this value must be specified. 
+        max_size_bytes: '<Size>',                     # Conditional. Specifies the maximum size to which the database may grow. If createMode is set to Default, then this value must be specified.
+        requested_service_objective_name: '<Name>' ,  # Conditional. Specifies the requested service level of the database. If requestedServiceObjectiveId is specified, then this value must not be specified. The acceptable value are: [Basic, S0, S1, S2, S3, P1, P2, P4, P6, P11, ElasticPool]
+        restore_point_in_time: '<String>',            # Conditional. Specifies the point in time for the restore. If createMode is set to PointInTimeRestore, then this value must be specified. 
+        source_database_deletion_date: '<Date>',      # Conditional. Specifies the deletion date of the source database. If createMode is set to Restore, then this value must be specified
+        elastic_pool_name: '<Pool Name>',             # Conditional. Specifies the name of the elastic database pool. If requestedServiceObjectiveId or requestedServiceObjectiveName is set to ElasticPool, then this value must be specified.
+        requested_service_objective_id: '<GUID>'      # Conditional. Specifies the identifier of the requested service level. If requestedServiceObjectiveName is specified, then this value must not be specified.   
+    )
+```
+For more information see link: https://msdn.microsoft.com/en-us/library/azure/mt163685.aspx  
+
+## List SQL Databases
+Get a list of databases in given resource group
+
+```ruby
+    databases  = azure_sql_service.sql_databases(resource_group: '<Resource Group Name>', server_name: '<Server Name>')
+    databases.each do |database|
+      puts "Listing : #{database.name}"
+    end
+```
+
+## Retrieve a single SQL Database
+
+Get a single record of SQL Database
+
+```ruby
+     database = azure_sql_service.sql_databases
+                   .get('<Resource Group Name>', '<Server Name>', '<Database Name>')
+     puts "Database Name: #{database.name}"
+```
+
+## Destroy a SQL Database
+
+Get SQL Database object from the get method(described above) and destroy that Database.
+
+```ruby
+      database.destroy
+```
+
+
+## Support and Feedback
+Your feedback is appreciated! If you have specific issues with the fog ARM, you should file an issue via Github.

data/lib/fog/azurerm/docs/structure.md

@@ -50,4 +50,4 @@ Plugin Root
                              |--- storage
 ```
 
-For more information aboute fog struture [Click Here](http://fog.io/about/structure.html)
+For more information about fog structure [Click Here](http://fog.io/about/structure.html)

data/lib/fog/azurerm/models/application_gateway/gateway.rb

@@ -601,6 +601,14 @@ module Fog
           merge_attributes(Fog::ApplicationGateway::AzureRM::Gateway.parse(gateway))
         end
 
+        def start
+          service.start_application_gateway(resource_group, name)
+        end
+
+        def stop
+          service.stop_application_gateway(resource_group, name)
+        end
+
         def destroy
           service.delete_application_gateway(resource_group, name)
         end

data/lib/fog/azurerm/models/dns/record_set.rb

@@ -7,50 +7,41 @@ module Fog
         attribute :id
         identity :name
         attribute :resource_group
-        attribute :location
         attribute :zone_name
         attribute :records
         attribute :type
         attribute :ttl
-        attribute :fqdn
         attribute :cname_record
-        attribute :a_record
+        attribute :a_records
 
         def self.parse(recordset)
           hash = {}
-          hash['id'] = recordset['id']
-          hash['name'] = recordset['name']
-          hash['resource_group'] = recordset['id'].split('/')[4]
-          hash['location'] = recordset['location']
-          hash['zone_name'] = recordset['id'].split('/')[8]
-          hash['type'] = recordset['type']
-          type = recordset['type'].split('/')[2]
+          hash['id'] = recordset.id
+          hash['name'] = recordset.name
+          hash['resource_group'] = get_resource_group_from_id(recordset.id)
+          hash['zone_name'] = get_record_set_from_id(recordset.id)
+          hash['type'] = recordset.type
+          type = get_type_from_recordset_type(recordset.type)
           hash['records'] = []
           if type == 'A'
-            record_entries = recordset['properties']['ARecords']
+            record_entries = recordset.arecords
             record_entries.each do |record|
-              hash['records'] << record['ipv4Address']
+              hash['records'] << record.ipv4address
             end
           end
           if type == 'CNAME'
-            record_entries = recordset['properties']['CNAMERecord']['cname']
+            record_entries = recordset.cname_record
             hash['records'] << record_entries
           end
-          hash['a_record'] = recordset['properties']['ARecords'] if type == 'A'
-          hash['cname_record'] = recordset['properties']['CNAMERecord'] if type == 'CNAME'
-          hash['ttl'] = recordset['properties']['TTL']
-          hash['fqdn'] = recordset['properties']['fqdn']
+          hash['a_records'] = recordset.arecords if type == 'A'
+          hash['cname_record'] = recordset.cname_record if type == 'CNAME'
+          hash['ttl'] = recordset.ttl
           hash
         end
 
         def save
-          requires :name
-          requires :resource_group
-          requires :zone_name
-          requires :records
-          requires :type
-          requires :ttl
-          record_set = service.create_or_update_record_set(resource_group, name, zone_name, records, type, ttl)
+          requires :name, :resource_group, :zone_name, :records, :type, :ttl
+          record_set = service.create_or_update_record_set(record_set_params, type)
           merge_attributes(Fog::DNS::AzureRM::RecordSet.parse(record_set))
         end
 
@@ -63,21 +54,37 @@ module Fog
         end
 
         def update_ttl(ttl)
-          record_set = service.create_or_update_record_set(resource_group, name, zone_name, records, get_record_type(type), ttl)
+          params = record_set_params
+          params[:ttl] = ttl
+          record_set = service.create_or_update_record_set(params, get_record_type(type))
           merge_attributes(Fog::DNS::AzureRM::RecordSet.parse(record_set))
         end
 
         def add_a_type_record(record)
           records << record
-          record_set = service.create_or_update_record_set(resource_group, name, zone_name, records, get_record_type(type), ttl)
+          record_set = service.create_or_update_record_set(record_set_params, get_record_type(type))
           merge_attributes(Fog::DNS::AzureRM::RecordSet.parse(record_set))
         end
 
         def remove_a_type_record(record)
           records.delete(record)
-          record_set = service.create_or_update_record_set(resource_group, name, zone_name, records, get_record_type(type), ttl)
+          record_set = service.create_or_update_record_set(record_set_params, get_record_type(type))
           merge_attributes(Fog::DNS::AzureRM::RecordSet.parse(record_set))
         end
+
+        private
+
+        def record_set_params
+          {
+            name: name,
+            resource_group: resource_group,
+            zone_name: zone_name,
+            records: records,
+            ttl: ttl,
+            cname_record: cname_record,
+            a_records: a_records
+          }
+        end
       end
     end
   end

data/lib/fog/azurerm/models/dns/zone.rb

@@ -12,32 +12,46 @@ module Fog
         attribute :tags
         attribute :etag
         attribute :number_of_record_sets
-        attribute :max_number_of_recordsets
+        attribute :max_number_of_record_sets
 
         def self.parse(zone)
           hash = {}
-          hash['id'] = zone['id']
-          hash['name'] = zone['name']
-          hash['resource_group'] = zone['id'].split('/')[4]
-          hash['location'] = zone['location']
-          hash['type'] = zone['type']
-          hash['tags'] = zone['tags']
-          hash['etag'] = zone['etag']
-          hash['number_of_record_sets'] = zone['properties']['numberOfRecordSets']
-          hash['max_number_of_recordsets'] = zone['properties']['maxNumberOfRecordSets']
+          hash['id'] = zone.id
+          hash['name'] = zone.name
+          hash['resource_group'] = get_resource_group_from_id(zone.id)
+          hash['location'] = zone.location
+          hash['type'] = zone.type
+          hash['tags'] = zone.tags
+          hash['etag'] = zone.etag
+          hash['number_of_record_sets'] = zone.number_of_record_sets
+          hash['max_number_of_record_sets'] = zone.max_number_of_record_sets
           hash
         end
 
         def save
-          requires :name
-          requires :resource_group
-          zone = service.create_or_update_zone(resource_group, name)
+          requires :name, :resource_group, :location
+          zone = service.create_or_update_zone(zone_params)
           merge_attributes(Fog::DNS::AzureRM::Zone.parse(zone))
         end
 
         def destroy
           service.delete_zone(resource_group, name)
         end
+
+        private
+
+        def zone_params
+          {
+            name: name,
+            resource_group: resource_group,
+            location: location,
+            type: type,
+            tags: tags,
+            number_of_record_sets: number_of_record_sets,
+            max_number_of_record_sets: max_number_of_record_sets,
+            etag: etag
+          }
+        end
       end
     end
   end

data/lib/fog/azurerm/models/network/express_route_circuit_authorization.rb

@@ -8,29 +8,21 @@ module Fog
         attribute :resource_group
         attribute :authorization_name
         attribute :authorization_key
-        attribute :authorization_status
+        attribute :authorization_use_status
         attribute :provisioning_state
         attribute :etag
         attribute :circuit_name
 
         def self.parse(circuit_authorization)
-          circuit_auth_hash = {}
-          circuit_auth_hash['id'] = circuit_authorization.id
+          circuit_auth_hash = get_hash_from_object(circuit_authorization)
           circuit_auth_hash['resource_group'] = get_resource_group_from_id(circuit_authorization.id)
           circuit_auth_hash['circuit_name'] = get_circuit_name_from_id(circuit_authorization.id)
-          circuit_auth_hash['authorization_key'] = circuit_authorization.authorization_key
-          circuit_auth_hash['authorization_status'] = circuit_authorization.authorization_use_status
-          circuit_auth_hash['provisioning_state'] = circuit_authorization.provisioning_state
-          circuit_auth_hash['name'] = circuit_authorization.name
-          circuit_auth_hash['etag'] = circuit_authorization.etag
-
           circuit_auth_hash
         end
 
         def save
           requires :name, :resource_group, :circuit_name
-          circuit_authorization_parameters = express_route_circuit_authorization_params
-          circuit_authorization = service.create_or_update_express_route_circuit_authorization(circuit_authorization_parameters)
+          circuit_authorization = service.create_or_update_express_route_circuit_authorization(express_route_circuit_authorization_params)
           merge_attributes(ExpressRouteCircuitAuthorization.parse(circuit_authorization))
         end
 
@@ -47,7 +39,7 @@ module Fog
             circuit_name: circuit_name,
             authorization_name: authorization_name,
             authorization_key: authorization_key,
-            authorization_status: authorization_status,
+            authorization_use_status: authorization_use_status,
             provisioning_state: provisioning_state,
             etag: etag
           }

data/lib/fog/azurerm/models/network/express_route_circuit_authorizations.rb

@@ -11,12 +11,8 @@ module Fog
         attribute :circuit_name
 
         def all
-          requires :resource_group
-          requires :circuit_name
-          circuit_authorizations = []
-          service.list_express_route_circuit_authorizations(resource_group, circuit_name).each do |circuit_authorization|
-            circuit_authorizations << ExpressRouteCircuitAuthorization.parse(circuit_authorization)
-          end
+          requires :resource_group, :circuit_name
+          circuit_authorizations = service.list_express_route_circuit_authorizations(resource_group, circuit_name).map { |circuit_authorization| ExpressRouteCircuitAuthorization.parse(circuit_authorization) }
           load(circuit_authorizations)
         end
 

data/lib/fog/azurerm/models/network/local_network_gateway.rb

@@ -17,30 +17,22 @@ module Fog
         attribute :provisioning_state
 
         def self.parse(local_network_gateway)
-          local_network_gateway_hash = {}
-          local_network_gateway_hash['id'] = local_network_gateway.id
-          local_network_gateway_hash['name'] = local_network_gateway.name
-          local_network_gateway_hash['location'] = local_network_gateway.location
-          local_network_gateway_hash['type'] = local_network_gateway.type
-          local_network_gateway_hash['resource_group'] = get_resource_group_from_id(local_network_gateway.id)
-          local_network_gateway_hash['tags'] = local_network_gateway.tags
-          local_network_address_space = local_network_gateway.local_network_address_space
-          local_network_gateway_hash['local_network_address_space_prefixes'] = local_network_address_space.address_prefixes unless local_network_address_space.nil?
-          local_network_gateway_hash['gateway_ip_address'] = local_network_gateway.gateway_ip_address
+          local_network_gateway_hash = get_hash_from_object(local_network_gateway)
           bgp_settings = local_network_gateway.bgp_settings
           unless bgp_settings.nil?
             local_network_gateway_hash['asn'] = bgp_settings.asn
             local_network_gateway_hash['bgp_peering_address'] = bgp_settings.bgp_peering_address
             local_network_gateway_hash['peer_weight'] = bgp_settings.peer_weight
           end
-          local_network_gateway_hash['provisioning_state'] = local_network_gateway.provisioning_state
+          local_network_address_space = local_network_gateway.local_network_address_space
+          local_network_gateway_hash['local_network_address_space_prefixes'] = local_network_address_space.address_prefixes unless local_network_address_space.nil?
+          local_network_gateway_hash['resource_group'] = get_resource_group_from_id(local_network_gateway.id)
           local_network_gateway_hash
         end
 
         def save
           requires :name, :location, :resource_group, :local_network_address_space_prefixes, :gateway_ip_address, :asn, :bgp_peering_address, :peer_weight
-          local_network_gateway_params = local_network_gateway_parameters
-          local_network_gateway = service.create_or_update_local_network_gateway(local_network_gateway_params)
+          local_network_gateway = service.create_or_update_local_network_gateway(local_network_gateway_parameters)
           merge_attributes(LocalNetworkGateway.parse(local_network_gateway))
         end
 

data/lib/fog/azurerm/models/network/local_network_gateways.rb

@@ -6,15 +6,12 @@ module Fog
     class AzureRM
       # LocalNetworkGateways collection class for Network Service
       class LocalNetworkGateways < Fog::Collection
-        model Fog::Network::AzureRM::LocalNetworkGateway
+        model LocalNetworkGateway
         attribute :resource_group
 
         def all
           requires :resource_group
-          local_network_gateways = []
-          service.list_local_network_gateways(resource_group).each do |gateway|
-            local_network_gateways << LocalNetworkGateway.parse(gateway)
-          end
+          local_network_gateways = service.list_local_network_gateways(resource_group).map { |gateway| LocalNetworkGateway.parse(gateway) }
           load(local_network_gateways)
         end
 

data/lib/fog/azurerm/models/network/virtual_network_gateway_connection.rb

@@ -24,12 +24,7 @@ module Fog
         attribute :provisioning_state
 
         def self.parse(gateway_connection)
-          connection = {}
-          connection['id'] = gateway_connection.id
-          connection['name'] = gateway_connection.name
-          connection['location'] = gateway_connection.location
-          connection['resource_group'] = get_resource_group_from_id(gateway_connection.id)
-          connection['tags'] = gateway_connection.tags
+          connection = get_hash_from_object(gateway_connection)
 
           unless gateway_connection.virtual_network_gateway1.nil?
             gateway1 = VirtualNetworkGateway.new
@@ -40,25 +35,13 @@ module Fog
             gateway2 = VirtualNetworkGateway.new
             connection['virtual_network_gateway2'] = gateway2.merge_attributes(VirtualNetworkGateway.parse(gateway_connection.virtual_network_gateway2))
           end
-
-          connection['connection_type'] = gateway_connection.connection_type
-          connection['connection_status'] = gateway_connection.connection_status
-          connection['authorization_key'] = gateway_connection.authorization_key
-          connection['routing_weight'] = gateway_connection.routing_weight
-          connection['shared_key'] = gateway_connection.shared_key
-          connection['egress_bytes_transferred'] = gateway_connection.egress_bytes_transferred
-          connection['ingress_bytes_transferred'] = gateway_connection.ingress_bytes_transferred
-          connection['peer'] = gateway_connection.peer
-          connection['enable_bgp'] = gateway_connection.enable_bgp
-          connection['provisioning_state'] = gateway_connection.provisioning_state
-
+          connection['resource_group'] = get_resource_group_from_id(gateway_connection.id)
           connection
         end
 
         def save
           requires :name, :location, :resource_group, :connection_type
-          gateway_connection_params = gateway_connection_parameters
-          gateway_connection = service.create_or_update_virtual_network_gateway_connection(gateway_connection_params)
+          gateway_connection = service.create_or_update_virtual_network_gateway_connection(gateway_connection_parameters)
           merge_attributes(VirtualNetworkGatewayConnection.parse(gateway_connection))
         end
 

data/lib/fog/azurerm/models/network/virtual_network_gateway_connections.rb

@@ -11,10 +11,7 @@ module Fog
 
         def all
           requires :resource_group
-          gateway_connections = []
-          service.list_virtual_network_gateway_connections(resource_group).each do |connection|
-            gateway_connections << VirtualNetworkGatewayConnection.parse(connection)
-          end
+          gateway_connections = service.list_virtual_network_gateway_connections(resource_group).map { |connection| VirtualNetworkGatewayConnection.parse(connection) }
           load(gateway_connections)
         end