fog-aliyun 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8f039d826c1b8f347bd39065fca8d8c8d1a3a513
-  data.tar.gz: 883c955e643d7d333571a41ce98f30ce16706a40
+  metadata.gz: 82062a69285f3c3a240f77d49730e674be34e1a4
+  data.tar.gz: 8054a3818fab3fb5661d45279c88bfd1c3527de3
 SHA512:
-  metadata.gz: a315a64cbbd5ae803e0064ac3b063dcab53b7970cf4e6aa0c0ee70abddf0273cc7e9cfde587f627f6bcf5ddc931a9153b883e2f4b6e5ae86f78d0170181cc362
-  data.tar.gz: e700199fed03abeeec6cd02f7c313ce6fee29c7f72ac6d5aca366ea83621c474f286ce313c4ba3a32ba0b5a75b7170ee798057e3ee0d120ba63fdc3a1d746480
+  metadata.gz: '08af5f88a8e2da7ff72366f7fc84f87b135d7d74a1549422fd23cd4c94cdc7ddb778ce2868c351e93d591d1f9a1e9d4219568a4ccda7bda2437c87dd7a020d86'
+  data.tar.gz: 6db1a3348d5f9a1406fa752be842d17ae507ec915d2baaf3e3bfb37d14aace66d8b76927dc3a43f98819c4e59a7d4efc5f3d9050b9bc1e0d50cfd1db60ffa48e

data/.rubocop.yml

@@ -0,0 +1,5 @@
+AllCops:
+  Exclude:
+    - bin/**/*
+
+# inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,149 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-05-12 13:44:44 +0800 using RuboCop version 0.40.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 4
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'lib/fog/aliyun/requests/compute/create_server.rb'
+    - 'lib/fog/aliyun/requests/compute/delete_server.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
+# SupportedStyles: start_of_line, def
+Lint/DefEndAlignment:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
+# SupportedStyles: keyword, variable, start_of_line
+Lint/EndAlignment:
+  Enabled: false
+
+# Offense count: 4
+Lint/RandOne:
+  Exclude:
+    - 'lib/fog/aliyun/requests/compute/list_images.rb'
+    - 'lib/fog/aliyun/requests/compute/list_route_tables.rb'
+    - 'lib/fog/aliyun/requests/compute/list_servers.rb'
+    - 'lib/fog/aliyun/requests/compute/list_vrouters.rb'
+
+# Offense count: 127
+Lint/UnderscorePrefixedVariableName:
+  Enabled: false
+
+# Offense count: 1
+Lint/UnreachableCode:
+  Exclude:
+    - 'lib/fog/aliyun/models/storage/directory.rb'
+
+# Offense count: 38
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/fog/aliyun.rb'
+    - 'lib/fog/aliyun/requests/compute/list_disks.rb'
+    - 'lib/fog/aliyun/requests/compute/list_security_groups.rb'
+    - 'lib/fog/aliyun/requests/storage/delete_object.rb'
+    - 'lib/fog/aliyun/requests/storage/get_bucket.rb'
+    - 'lib/fog/aliyun/requests/storage/get_container.rb'
+    - 'lib/fog/aliyun/requests/storage/get_containers.rb'
+    - 'lib/fog/aliyun/requests/storage/get_object_http_url.rb'
+    - 'lib/fog/aliyun/requests/storage/get_object_https_url.rb'
+    - 'lib/fog/aliyun/requests/storage/list_buckets.rb'
+    - 'lib/fog/aliyun/requests/storage/list_objects.rb'
+    - 'lib/fog/aliyun/requests/storage/put_bucket.rb'
+    - 'lib/fog/aliyun/requests/storage/put_object.rb'
+    - 'lib/fog/aliyun/storage.rb'
+
+# Offense count: 78
+Metrics/AbcSize:
+  Max: 100
+
+# Offense count: 5
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 154
+
+# Offense count: 18
+Metrics/CyclomaticComplexity:
+  Max: 15
+
+# Offense count: 257
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 247
+
+# Offense count: 110
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 97
+
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 6
+
+# Offense count: 17
+Metrics/PerceivedComplexity:
+  Max: 19
+
+# Offense count: 1
+Style/ClassVars:
+  Exclude:
+    - 'lib/fog/bin/aliyun.rb'
+
+# Offense count: 138
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 7
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: for, each
+Style/For:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
+  Exclude:
+    - 'lib/fog/aliyun/models/compute/server.rb'
+    - 'lib/fog/aliyun/models/compute/vpcs.rb'
+    - 'lib/fog/aliyun/models/compute/vrouter.rb'
+    - 'lib/fog/aliyun/models/compute/vswitch.rb'
+
+# Offense count: 2
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/fog/aliyun/requests/compute/delete_vpc.rb'
+    - 'lib/fog/aliyun/requests/compute/delete_vswitch.rb'
+
+# Offense count: 2
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'lib/fog/aliyun/models/storage/files.rb'
+
+# Offense count: 1
+Style/IfInsideElse:
+  Exclude:
+    - 'lib/fog/aliyun/models/compute/security_group_rule.rb'
+
+# Offense count: 4
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/MethodName:
+  Enabled: false
+
+# Offense count: 741
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/VariableName:
+  Enabled: false

data/.ruby-gemset

@@ -0,0 +1 @@
+fog-aliyun

data/.ruby-version

@@ -0,0 +1 @@
+2.4

data/Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/fog-aliyun.gemspec

@@ -4,25 +4,28 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'fog/aliyun/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "fog-aliyun"
+  spec.name          = 'fog-aliyun'
   spec.version       = Fog::Aliyun::VERSION
-  spec.authors       = ["Qinsi Deng, Jianxun Li, Jane Han"]
-  spec.email         = ["dengqs@dtdream.com"]
+  spec.authors       = ['Qinsi Deng, Jianxun Li, Jane Han']
+  spec.email         = ['dengqs@dtdream.com']
 
-  spec.summary       = %q{Fog provider for Aliyun Web Services.}
-  spec.description   = %q{As a FOG provider, fog-aliyun support aliyun OSS/ECS. It will support more aliyun services later.}
-  spec.homepage      = "https://github.com/fog/fog-aliyun"
-  spec.license       = "MIT"
+  spec.summary       = 'Fog provider for Aliyun Web Services.'
+  spec.description   = 'As a FOG provider, fog-aliyun support aliyun OSS/ECS. It will support more aliyun services later.'
+  spec.homepage      = 'https://github.com/fog/fog-aliyun'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
+
+  spec.add_development_dependency 'bundler', '~> 1.10'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.3'
+  spec.add_development_dependency 'rubocop', '~> 0.40.0'
+  spec.add_development_dependency 'mime-types', '~> 2.6', '>= 2.6.2'
+  spec.add_development_dependency 'pry-nav'
 
-  spec.add_development_dependency "bundler", "~> 1.10"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.3"
-  
   spec.add_dependency 'fog-core',  '~> 1.27'
   spec.add_dependency 'fog-json',  '~> 1.0'
   spec.add_dependency 'ipaddress', '~> 0.8'

data/lib/fog/aliyun.rb

@@ -1,19 +1,19 @@
-require "fog/core"
-require "fog/json"
-require "fog/aliyun/version"
+require 'fog/core'
+require 'fog/json'
+require 'fog/aliyun/version'
 
 module Fog
   module Compute
-    ret = autoload :Aliyun, "fog/aliyun/compute"
+    ret = autoload :Aliyun, 'fog/aliyun/compute'
   end
 
   module Storage
-    ret = autoload :Aliyun, "fog/aliyun/storage"
+    ret = autoload :Aliyun, 'fog/aliyun/storage'
   end
-  
+
   module Aliyun
     extend Fog::Provider
-    service(:compute, "Compute")
-    service(:storage, "Storage")
+    service(:compute, 'Compute')
+    service(:storage, 'Storage')
   end
 end

data/lib/fog/aliyun/compute.rb

@@ -1,8 +1,8 @@
 module Fog
   module Compute
     class Aliyun < Fog::Service
-      recognizes :aliyun_url, 
-                 :aliyun_accesskey_id, 
+      recognizes :aliyun_url,
+                 :aliyun_accesskey_id,
                  :aliyun_accesskey_secret,
                  :aliyun_region_id,
                  :aliyun_zone_id
@@ -39,32 +39,27 @@ module Fog
       #
       request_path 'fog/aliyun/requests/compute'
 
-
       # Server CRUD
       request :list_servers
       request :list_server_types
       request :create_server
       request :delete_server
 
-
       # Server Actions
       request :reboot_server
       request :start_server
       request :stop_server
 
-
-      #SnapShoot CRUD
+      # SnapShoot CRUD
       request :list_snapshots
       request :create_snapshot
       request :delete_snapshot
 
-
       # Image CRUD
       request :list_images
       request :create_image
       request :delete_image
 
-
       # Eip
       request :list_eip_addresses
       request :allocate_eip_address
@@ -72,7 +67,6 @@ module Fog
       request :associate_eip_address
       request :unassociate_eip_address
 
-
       # Security Group
       request :list_security_groups
       request :list_security_group_rules
@@ -89,11 +83,9 @@ module Fog
       request :join_security_group
       request :leave_security_group
 
-
       # Zones
       request :list_zones
 
-      
       # VPC
       request :create_vpc
       request :delete_vpc
@@ -104,21 +96,19 @@ module Fog
       request :modify_vpc
       request :modify_vswitch
 
-      #VRouter
+      # VRouter
       request :list_vrouters
 
-      #RouteTable
+      # RouteTable
       request :list_route_tables
 
-      
-      #clouddisk
+      # clouddisk
       request :list_disks
       request :create_disk
       request :delete_disk
       request :attach_disk
       request :detach_disk
 
-
       class Mock
         attr_reader :auth_token
         attr_reader :auth_token_expiration
@@ -128,51 +118,51 @@ module Fog
         def self.data
           @data ||= Hash.new do |hash, key|
             hash[key] = {
-              :last_modified => {
-                :images  => {},
-                :servers => {},
-                :key_pairs => {},
-                :security_groups => {},
-                :addresses => {}
+              last_modified: {
+                images: {},
+                servers: {},
+                key_pairs: {},
+                security_groups: {},
+                addresses: {}
               },
-              :images  => {
-                "0e09fbd6-43c5-448a-83e9-0d3d05f9747e" => {
-                  "id"=>"0e09fbd6-43c5-448a-83e9-0d3d05f9747e",
-                  "name"=>"cirros-0.3.0-x86_64-blank",
+              images: {
+                '0e09fbd6-43c5-448a-83e9-0d3d05f9747e' => {
+                  'id' => '0e09fbd6-43c5-448a-83e9-0d3d05f9747e',
+                  'name' => 'cirros-0.3.0-x86_64-blank',
                   'progress'  => 100,
-                  'status'    => "ACTIVE",
-                  'updated'   => "",
+                  'status'    => 'ACTIVE',
+                  'updated'   => '',
                   'minRam'    => 0,
                   'minDisk'   => 0,
                   'metadata'  => {},
-                  'links'     => [{"href"=>"http://nova1:8774/v1.1/admin/images/1", "rel"=>"self"}, {"href"=>"http://nova1:8774/admin/images/2", "rel"=>"bookmark"}]
+                  'links'     => [{ 'href' => 'http://nova1:8774/v1.1/admin/images/1', 'rel' => 'self' }, { 'href' => 'http://nova1:8774/admin/images/2', 'rel' => 'bookmark' }]
                 }
               },
-              :servers => {},
-              :key_pairs => {},
-              :security_groups => {
+              servers: {},
+              key_pairs: {},
+              security_groups: {
                 '0' => {
-                  "id"          => 0,
-                  "tenant_id"   => Fog::Mock.random_hex(8),
-                  "name"        => "default",
-                  "description" => "default",
-                  "rules"       => [
-                    { "id"              => 0,
-                      "parent_group_id" => 0,
-                      "from_port"       => 68,
-                      "to_port"         => 68,
-                      "ip_protocol"     => "udp",
-                      "ip_range"        => { "cidr" => "0.0.0.0/0" },
-                      "group"           => {}, },
-                  ],
-                },
+                  'id'          => 0,
+                  'tenant_id'   => Fog::Mock.random_hex(8),
+                  'name'        => 'default',
+                  'description' => 'default',
+                  'rules'       => [
+                    { 'id'              => 0,
+                      'parent_group_id' => 0,
+                      'from_port'       => 68,
+                      'to_port'         => 68,
+                      'ip_protocol'     => 'udp',
+                      'ip_range'        => { 'cidr' => '0.0.0.0/0' },
+                      'group'           => {} }
+                  ]
+                }
               },
-              :server_security_group_map => {},
-              :addresses => {},
-              :quota => {
+              server_security_group_map: {},
+              addresses: {},
+              quota: {
                 'security_group_rules' => 20,
                 'security_groups' => 10,
-                'injected_file_content_bytes' => 10240,
+                'injected_file_content_bytes' => 10_240,
                 'injected_file_path_bytes' => 256,
                 'injected_files' => 5,
                 'metadata_items' => 128,
@@ -182,9 +172,9 @@ module Fog
                 'gigabytes'      => 5000,
                 'volumes'        => 10,
                 'cores'          => 20,
-                'ram'            => 51200
+                'ram'            => 51_200
               },
-              :volumes => {}
+              volumes: {}
             }
           end
         end
@@ -193,17 +183,17 @@ module Fog
           @data = nil
         end
 
-        def initialize(options={})
+        def initialize(options = {})
           @openstack_username = options[:openstack_username]
           @openstack_user_domain = options[:openstack_user_domain] || options[:openstack_domain]
-          @openstack_project_domain  = options[:openstack_project_domain]  || options[:openstack_domain] || 'Default'
+          @openstack_project_domain = options[:openstack_project_domain] || options[:openstack_domain] || 'Default'
           @openstack_auth_uri = URI.parse(options[:openstack_auth_url])
 
           @current_tenant = options[:openstack_tenant]
           @current_tenant_id = options[:openstack_tenant_id]
 
           @auth_token = Fog::Mock.random_base64(64)
-          @auth_token_expiration = (Time.now.utc + 86400).iso8601
+          @auth_token_expiration = (Time.now.utc + 86_400).iso8601
 
           management_url = URI.parse(options[:openstack_auth_url])
           management_url.port = 8774
@@ -224,16 +214,15 @@ module Fog
         end
 
         def credentials
-          { :provider                 => 'openstack',
-            :openstack_auth_url       => @openstack_auth_uri.to_s,
-            :openstack_auth_token     => @auth_token,
-            :openstack_management_url => @openstack_management_url,
-            :openstack_identity_endpoint => @openstack_identity_public_endpoint }
+          { provider: 'openstack',
+            openstack_auth_url: @openstack_auth_uri.to_s,
+            openstack_auth_token: @auth_token,
+            openstack_management_url: @openstack_management_url,
+            openstack_identity_endpoint: @openstack_identity_public_endpoint }
         end
       end
 
       class Real
-
         # Initialize connection to ECS
         #
         # ==== Notes
@@ -258,18 +247,17 @@ module Fog
         attr_reader :aliyun_url
         attr_reader :aliyun_zone_id
 
-        def initialize(options={})
-
-          #initialize the parameters
+        def initialize(options = {})
+          # initialize the parameters
           @aliyun_url              = options[:aliyun_url]
           @aliyun_accesskey_id     = options[:aliyun_accesskey_id]
           @aliyun_accesskey_secret = options[:aliyun_accesskey_secret]
           @aliyun_region_id        = options[:aliyun_region_id]
           @aliyun_zone_id          = options[:aliyun_zone_id]
 
-          #check for the parameters
-          missing_credentials = Array.new
-          missing_credentials << :aliyun_accesskey_id  unless @aliyun_accesskey_id
+          # check for the parameters
+          missing_credentials = []
+          missing_credentials << :aliyun_accesskey_id unless @aliyun_accesskey_id
           missing_credentials << :aliyun_accesskey_secret unless @aliyun_accesskey_secret
           missing_credentials << :aliyun_region_id unless @aliyun_region_id
           missing_credentials << :aliyun_url unless @aliyun_url
@@ -277,7 +265,7 @@ module Fog
           raise ArgumentError, "Missing required arguments: #{missing_credentials.join(', ')}" unless missing_credentials.empty?
 
           @connection_options = options[:connection_options] || {}
-          
+
           uri = URI.parse(@aliyun_url)
           @host   = uri.host
           @path   = uri.path
@@ -286,7 +274,6 @@ module Fog
 
           @persistent = options[:persistent] || false
           @connection = Fog::Core::Connection.new("#{@scheme}://#{@host}:#{@port}", @persistent, @connection_options)
-
         end
 
         def reload
@@ -295,81 +282,80 @@ module Fog
 
         def request(params)
           begin
-            response = @connection.request(params.merge({
-              :headers  => {
-                'Content-Type' => 'application/json',
-                'Accept' => 'application/json',
-                'X-Auth-Token' => @auth_token
-              }.merge!(params[:headers] || {}),
-              :path     => "#{@path}/#{params[:path]}",
-              :query    => params[:query]
-            }))
+            response = @connection.request(params.merge(headers: {
+              'Content-Type' => 'application/json',
+              'Accept' => 'application/json',
+              'X-Auth-Token' => @auth_token
+            }.merge!(params[:headers] || {}),
+                                                        path: "#{@path}/#{params[:path]}",
+                                                        query: params[:query]))
           rescue Excon::Errors::HTTPStatusError => error
             raise case error
-              when Excon::Errors::NotFound
-                Fog::Compute::Aliyun::NotFound.slurp(error)
-              else
-                error
+                  when Excon::Errors::NotFound
+                    Fog::Compute::Aliyun::NotFound.slurp(error)
+                  else
+                    error
               end
           end
 
-          if !response.body.empty? and response.get_header('Content-Type') == 'application/json'
+          if !response.body.empty? && response.get_header('Content-Type') == 'application/json'
             response.body = Fog::JSON.decode(response.body)
           end
 
           response
         end
-        
-        #operation compute-- default URL
+
+        # operation compute-- default URL
         def defaultAliyunUri(action, sigNonce, time)
-          parTimeFormat = time.strftime("%Y-%m-%dT%H:%M:%SZ")
-          urlTimeFormat = URI.encode(parTimeFormat,':')
-          return '?Format=JSON&AccessKeyId='+@aliyun_accesskey_id+'&Action='+action+'&SignatureMethod=HMAC-SHA1&RegionId='+@aliyun_region_id+'&SignatureNonce='+sigNonce+'&SignatureVersion=1.0&Version=2014-05-26&Timestamp='+urlTimeFormat
+          parTimeFormat = time.strftime('%Y-%m-%dT%H:%M:%SZ')
+          urlTimeFormat = URI.encode(parTimeFormat, ':')
+          '?Format=JSON&AccessKeyId=' + @aliyun_accesskey_id + '&Action=' + action + '&SignatureMethod=HMAC-SHA1&RegionId=' + @aliyun_region_id + '&SignatureNonce=' + sigNonce + '&SignatureVersion=1.0&Version=2014-05-26&Timestamp=' + urlTimeFormat
         end
 
-        #generate random num
-        def randonStr ()
-          numStr = rand(100000).to_s
+        # generate random num
+        def randonStr
+          numStr = rand(100_000).to_s
           timeStr = Time.now.to_f.to_s
-          ranStr = timeStr+"-"+numStr
-          return ranStr
+          ranStr = timeStr + '-' + numStr
+          ranStr
         end
 
-        #operation compute--collection of default parameters
+        # operation compute--collection of default parameters
         def defalutParameters(action, sigNonce, time)
-          parTimeFormat = time.strftime("%Y-%m-%dT%H:%M:%SZ")
+          parTimeFormat = time.strftime('%Y-%m-%dT%H:%M:%SZ')
           para = {
-            'Format'=>'JSON',
-            'Version'=>'2014-05-26',
-            'Action'=>action,
-            'AccessKeyId'=>@aliyun_accesskey_id, 
-            'SignatureVersion'=>'1.0',
-            'SignatureMethod'=>'HMAC-SHA1',
-            'SignatureNonce'=>sigNonce,
-            'RegionId'=>@aliyun_region_id,
-            'Timestamp'=>parTimeFormat};
-          return para
+            'Format' => 'JSON',
+            'Version' => '2014-05-26',
+            'Action' => action,
+            'AccessKeyId' => @aliyun_accesskey_id,
+            'SignatureVersion' => '1.0',
+            'SignatureMethod' => 'HMAC-SHA1',
+            'SignatureNonce' => sigNonce,
+            'RegionId' => @aliyun_region_id,
+            'Timestamp' => parTimeFormat
+          }
+          para
         end
 
-        #compute signature
-        def sign (accessKeySecret,parameters)
+        # compute signature
+        def sign(accessKeySecret, parameters)
           sortedParameters = parameters.sort
           canonicalizedQueryString = ''
-          sortedParameters.each do | k, v |
-              canonicalizedQueryString += '&' + URI.encode(k,'/[^!*\'()\;?:@#&%=+$,{}[]<>`" ') + '=' + URI.encode(v,'/[^!*\'()\;?:@#&%=+$,{}[]<>`" ')
+          sortedParameters.each do |k, v|
+            canonicalizedQueryString += '&' + URI.encode(k, '/[^!*\'()\;?:@#&%=+$,{}[]<>`" ') + '=' + URI.encode(v, '/[^!*\'()\;?:@#&%=+$,{}[]<>`" ')
           end
 
           canonicalizedQueryString[0] = ''
-          stringToSign = 'GET&%2F&' + URI.encode(canonicalizedQueryString,'/[^!*\'()\;?:@#&%=+$,{}[]<>`" ')
+          stringToSign = 'GET&%2F&' + URI.encode(canonicalizedQueryString, '/[^!*\'()\;?:@#&%=+$,{}[]<>`" ')
           key = accessKeySecret + '&'
 
-          digVer =  OpenSSL::Digest.new("sha1")
+          digVer =  OpenSSL::Digest.new('sha1')
           digest =  OpenSSL::HMAC.digest(digVer, key, stringToSign)
           signature = Base64.encode64(digest)
           signature[-1] = ''
-          encodedSig = URI.encode(signature,'/[^!*\'()\;?:@#&%=+$,{}[]<>`" ')
+          encodedSig = URI.encode(signature, '/[^!*\'()\;?:@#&%=+$,{}[]<>`" ')
 
-          return encodedSig
+          encodedSig
         end
       end
     end