focused_controller 0.2.0 → 1.0.0

data/README.md

@@ -17,19 +17,25 @@ for discussion.
 
 ``` ruby
 class ApplicationController
-  include FocusedController::Mixin
+  class Action < ApplicationController
+    include FocusedController::Mixin
+  end
 end
 
 module PostsController
-  class Index < ApplicationController
+  class Action < ApplicationController::Action
+    before_filter :authenticate
+  end
+
+  class Index < Action
     expose(:posts) { Post.recent.limit(5) }
   end
 
-  class New < ApplicationController
+  class New < Action
     expose(:post) { Post.new }
   end
 
-  class Singular < ApplicationController
+  class Singular < Action
     expose(:post) { Post.find params[:id] }
     before_filter { redirect_to root_path unless post.accessible_to?(current_user) }
   end
@@ -49,22 +55,19 @@ module PostsController
 end
 ```
 
-Some notes:
-
-* You can include `FocusedController::Mixin` anywhere, so you don't have
-  to use Focused Controller in every single controller if you don't want
-  to
-* `expose` makes the object returned by the block available in your view
-  template. It also memoizes the result so the block will only be
-  executed once.
-* It is not necessary to specify `:only` or `:except` on the before
-  filter, since we declare the filter for exactly the actions we want it
-  to run on. Rails has many methods which accept action names to limit
-  what they get applied to - this is basically irrelevant with Focused
-  Controller due to the increased granularity that having a class for each
-  action gives us.
-* The `#call` method is what gets invoked when the action runs, so put
-  the 'active ingredients' in here.
+You can include `FocusedController::Mixin` anywhere, so you don't have
+to use Focused Controller in every single controller if you don't want
+to. I find it useful to define `ApplicationController::Action` and
+inherit from that where needed.
+
+The `#call` method is what gets invoked when the request is served.
+
+The `#expose` declaration defines a method which runs the block and
+memoizes the result. It also makes `post` a helper method so you can
+call it from the view template.
+
+The `before_filter` in Singular is inherited by precisely the actions
+that need it, so we don't need to specify `:only` or `:except`.
 
 ## Routing ##
 
@@ -224,7 +227,7 @@ describe UsersController do
   include FocusedController::RSpecHelper
 
   describe UsersController::Create do
-    test "should create user" do
+    it "creates a user" do
       subject.params = { user: { name: 'Jon' } }
       expect { subject.call }.to change(User, :count).by(1)
       response.should redirect_to(user_path(subject.user))

data/lib/focused_controller/route_mapper.rb

@@ -13,8 +13,13 @@ module FocusedController
       options = @options.dup
 
       if to = to_option
-        options[:to]     = FocusedController::Route.new(to)
-        options[:action] = FocusedController.action_name # necessary for rails <= 3.1
+        options[:to]         = FocusedController::Route.new(to)
+
+        # This causes rails to spit out a bit of extra useful information in the case
+        # of a routing error. The :action option is also necessary for the routing to
+        # work on Rails <= 3.1.
+        options[:action]     = FocusedController.action_name
+        options[:controller] = to.underscore
       end
 
       options

data/lib/focused_controller/version.rb

@@ -1,3 +1,3 @@
 module FocusedController
-  VERSION = "0.2.0"
+  VERSION = "1.0.0"
 end

data/test/app/app/controllers/posts_controller.rb

@@ -1,19 +1,13 @@
 module PostsController
-  class Action < ApplicationController
-  end
-
-  class Index < Action
+  class Index < ApplicationController
     expose(:posts) { Post.all }
   end
 
-  class Initializer < Action
+  class New < ApplicationController
     expose(:post) { Post.new params[:post] }
   end
 
-  class New < Initializer
-  end
-
-  class Create < Initializer
+  class Create < New
     def call
       if post.save
         redirect_to post, :notice => 'Post was successfully created.'
@@ -23,17 +17,14 @@ module PostsController
     end
   end
 
-  class Finder < Action
+  class Show < ApplicationController
     expose(:post) { Post.find params[:id] }
   end
 
-  class Show < Finder
-  end
-
-  class Edit < Finder
+  class Edit < Show
   end
 
-  class Update < Finder
+  class Update < Edit
     def call
       if post.update_attributes(params[:post])
         redirect_to post, :notice => 'Post was successfully updated.'
@@ -43,7 +34,7 @@ module PostsController
     end
   end
 
-  class Destroy < Finder
+  class Destroy < Edit
     def call
       post.destroy
       redirect_to posts_url

data/test/unit/route_mapper_test.rb

@@ -56,7 +56,8 @@ module FocusedController
       mappings.each do |(method, path), controller|
         route = recognize(path, :method => method)
         route.app.name.must_equal controller
-        route.defaults[:action].must_equal 'call'
+        route.defaults[:action].must_equal FocusedController.action_name
+        route.defaults[:controller].must_equal controller.underscore
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: focused_controller
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-12 00:00:00.000000000 Z
+date: 2012-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack