fluent_fixtures 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c70fba1d0e0cb81714a74684bc8906bfd363a707
-  data.tar.gz: 0cb6b28e3e362e2f86e6b2a2543fa8974a5b1309
+  metadata.gz: fdc1f6ce5b49218750ef162d0f73ae7b9150be8b
+  data.tar.gz: 9c6edc393f5b5966ceeaf4ce91a32dbc1d92b5ed
 SHA512:
-  metadata.gz: aea30395e953f18e878fc54cfb97da5e9fa05b937a220a5cccb641182adc311bf0dbff0579a5f0ea7acb2afb7c9952f9b59937dd5cbd2ac36fa30da20e939575
-  data.tar.gz: e4a83d0c50b788dc98d52284f5ef7fb4d7ecb28d863c54b51eb87df5a40be4775852feb0b9a231b3303d6d1b6f40553badfe7528edcf80f69ffe89fda2bfa491
+  metadata.gz: 10965916800b2b08931ffceff65b124de14e570d262851ba8d7c9e5942142cc8b9270a09dbbe22e90f037e036018486297e7902f7869217f720a37f1a3f0522b
+  data.tar.gz: dce961bbe9d5eaae9e2582bde164e9bc8d8c98dea9905fa270e9ee649237d4ae3e4d6258827f2c3d3109cd4c597a496b4f3d8e11d1547634b5fa484f1889c0da

data/History.md

@@ -1,3 +1,11 @@
+## v0.2.0 [2016-10-28] Michael Granger <ged@FaerieMUD.org>
+
+Bugfixes:
+- Fix the way #create and #instance handle their arguments. Arguments are
+  now iterated over and used to set attributes instead of just being
+	discarded.
+
+
 ## v0.1.0 [2016-10-28] Michael Granger <ged@FaerieMUD.org>
 
 New feature:

data/lib/fluent_fixtures/factory.rb

@@ -62,29 +62,34 @@ class FluentFixtures::Factory
 
 	### Create an instance, apply declared decorators in order, and return the resulting
 	### object.
-	def instance( *args, &block )
+	def instance( args={}, &block )
 		instance = self.fixture_module.
 			fixtured_instance( *self.constructor_args, &self.constructor_block )
 
-		self.decorators.each do |decorator_name, args, block|
-			# :TODO: Reify other fixtures in `args` here?
+		self.decorators.each do |decorator_name, decorator_args, block|
+			# :TODO: Reify other fixtures in `decorator_args` here?
 			if !decorator_name
 				self.apply_inline_decorator( instance, block )
 			elsif self.fixture_module.decorators.key?( decorator_name )
-				self.apply_named_decorator( instance, args, decorator_name )
+				self.apply_named_decorator( instance, decorator_args, decorator_name )
 			else
-				self.apply_method_decorator( instance, args, decorator_name, block )
+				self.apply_method_decorator( instance, decorator_args, decorator_name, block )
 			end
 		end
 
+		args.each_pair do |attrname, value|
+			# :TODO: Reify the `value` if it responds to #create?
+			instance.public_send( "#{attrname}=", value )
+		end
+
 		# If the factory was called with a block, use it as a final decorator before
 		# returning it.
 		if block
 			self.log.debug "Applying inline decorator %p" % [ block ]
 			if block.arity.zero?
-				instance.instance_exec( *args, &block )
+				instance.instance_exec( &block )
 			else
-				block.call( instance, *args )
+				block.call( instance )
 			end
 		end
 
@@ -93,9 +98,9 @@ class FluentFixtures::Factory
 
 
 	### Return a saved #instance of the fixtured object.
-	def create( *args, &block )
+	def create( args={}, &block )
 		obj = self.with_transaction do
-			obj = self.instance( *args, &block )
+			obj = self.instance( args, &block )
 			obj = self.fixture_module.call_before_saving( obj ) if
 				self.fixture_module.respond_to?( :call_before_saving )
 

data/lib/fluent_fixtures.rb

@@ -11,10 +11,10 @@ module FluentFixtures
 
 
 	# Package version
-	VERSION = '0.1.0'
+	VERSION = '0.2.0'
 
 	# Version control revision
-	REVISION = %q$Revision: c6eb79628953 $
+	REVISION = %q$Revision: bde330b02946 $
 
 
 	# Loggability API -- set up a named logger

data/spec/fluent_fixtures/factory_spec.rb

@@ -110,6 +110,36 @@ describe FluentFixtures::Factory do
 	end
 
 
+	it "sets attributes on the object when #instance is passed hash arguments" do
+		object = factory.instance( name: 'Dan', login: 'danp', email: 'danp@example.com' )
+
+		expect( object ).to be_a( fixtured_class )
+		expect( object.name ).to eq( 'Dan' )
+		expect( object.login ).to eq( 'danp' )
+		expect( object.email ).to eq( 'danp@example.com' )
+		expect( object ).to_not be_saved
+	end
+
+
+	it "sets attributes on the object when #instance is passed a Hash" do
+		values = { name: 'Dan', login: 'danp', email: 'danp@example.com' }
+		object = factory.instance( values )
+
+		expect( object ).to be_a( fixtured_class )
+		expect( object.name ).to eq( 'Dan' )
+		expect( object.login ).to eq( 'danp' )
+		expect( object.email ).to eq( 'danp@example.com' )
+		expect( object ).to_not be_saved
+	end
+
+
+	it "raises an argument when #instance is passed something that doesn't #each_pair" do
+		expect {
+			factory.instance( [:missiles, :weasels] )
+		}.to raise_error( NoMethodError, /each_pair/i )
+	end
+
+
 	it "executes a block passed to #instance in the context of the new object if it doesn't declare arguments" do
 		object = factory.instance do
 			self.name = 'Dan'
@@ -140,6 +170,24 @@ describe FluentFixtures::Factory do
 	end
 
 
+	it "sets attributes before saving when #create is passed a Hash" do
+		object = factory.create( name: 'Jenn', login: 'jennnn', email: 'jennnn@allthejennifers.org' )
+
+		expect( object ).to be_a( fixtured_class )
+		expect( object.name ).to eq( 'Jenn' )
+		expect( object.login ).to eq( 'jennnn' )
+		expect( object.email ).to eq( 'jennnn@allthejennifers.org' )
+		expect( object ).to be_saved
+	end
+
+
+	it "raises an argument when #create is passed something that doesn't #each_pair" do
+		expect {
+			factory.create( [:chocolate, :darkroom] )
+		}.to raise_error( NoMethodError, /each_pair/i )
+	end
+
+
 	it "executes a block passed to #create in the context of the new object" do
 		object = factory.create do
 			self.name = 'Jenn'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fluent_fixtures
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Michael Granger