flt 1.4.5 → 1.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7de71640b6e679c521d717895549d5858393bf9a
-  data.tar.gz: 20405872b9008205ffd8f4af67b2197be583539f
+  metadata.gz: 8f6269709d2755e8f6cc52aed9a2d2bbee4cbcf0
+  data.tar.gz: 1e17d3367948b38a3d37bf011b76e0589000a8a0
 SHA512:
-  metadata.gz: d5b4929799d05f048bf51827ad8dd3704467d71e4d93b996e3841c2a85d098770b20f70a7dd75b1dd86d4975d05c1232a9669e826eea70370f03e93dd61ccca6
-  data.tar.gz: a4f6ee9f59a5e6c70c128f902465927bd68a07858871a6dff468fa78a5615d5048e6c2e4302210b60ca749b1d54dabc8175220ec617fb888e7cbba1517b68791
+  metadata.gz: e58ff28351ba6dbf89c2bd2c2b5acb8837e4a45237231a471bbc085bbbfe048557db87a94c49b63a5716a76f833419356c4519b1adb5f3b92cd6368b8948fa9a
+  data.tar.gz: 0cb92e963d19b7937fe841fb7b83506d8ba4bec7a395636ae2d2bae20ee585144744692a9088f9cad5e7e0ac00722e64ffc33c2e246cde62c902a6186b3dea0e

data/History.txt

@@ -1,3 +1,8 @@
+== 1.4.6 2015-04-07
+
+* Bugfix
+  - BigDecimal.context.copy_sign returned a Float
+
 == 1.4.5 2015-03-04
 
 * New feature

data/lib/flt/bigdecimal.rb

@@ -83,20 +83,25 @@ class Flt::BigDecimalContext
     ROUNDING_MODES[BigDecimal.mode(BigDecimal::ROUND_MODE, nil)]
   end
 
-  # Sign: -1 for minus, +1 for plus, nil for nan (note that Float zero is signed)
+  # Sign: -1 for minus, +1 for plus, nil for nan (note that BigDecimal zero is signed)
   def sign(x)
-    x.sign < 0 ? -1 : +1
+    big_dec_sign = x.sign
+    if big_dec_sign < 0
+      -1
+    elsif big_dec_sign > 0
+      +1
+    end
   end
 
   # Return copy of x with the sign of y
   def copy_sign(x, y)
-    self_sign = x.sign
+    self_sign = sign(x)
     other_sign = y.is_a?(Integer) ? (y < 0 ? -1 : +1) : y.sign
     if self_sign && other_sign
       if self_sign == other_sign
-        x.to_f
+        x
       else
-        -x.to_f
+        -x
       end
     else
       nan

data/lib/flt/version.rb

@@ -1,3 +1,3 @@
 module Flt
-  VERSION = "1.4.5"
+  VERSION = "1.4.6"
 end

data/test/test_big_decimal.rb

@@ -0,0 +1,38 @@
+require File.expand_path(File.join(File.dirname(__FILE__),'helper.rb'))
+
+class TestBigDecimal < Test::Unit::TestCase
+
+  def setup
+    initialize_context
+  end
+
+  def test_sign
+    assert_equal -1, BigDecimal.context.sign(BigDecimal('-1.0'))
+    assert_equal -1, BigDecimal.context.sign(BigDecimal('-10.0'))
+    assert_equal -1, BigDecimal.context.sign(BigDecimal('-10E50'))
+    assert_equal -1, BigDecimal.context.sign(BigDecimal('-10E-50'))
+    assert_equal -1, BigDecimal.context.sign(BigDecimal('-723'))
+    assert_equal -1, BigDecimal.context.sign(BigDecimal('-0.0'))
+
+    assert_equal +1, BigDecimal.context.sign(BigDecimal('+1.0'))
+    assert_equal +1, BigDecimal.context.sign(BigDecimal('+10.0'))
+    assert_equal +1, BigDecimal.context.sign(BigDecimal('+10E50'))
+    assert_equal +1, BigDecimal.context.sign(BigDecimal('+10E-50'))
+    assert_equal +1, BigDecimal.context.sign(BigDecimal('+723'))
+    assert_equal +1, BigDecimal.context.sign(BigDecimal('0.0'))
+
+    assert_nil BigDecimal.context.sign(BigDecimal.context.nan)
+  end
+
+  def copy_sign
+    assert_equal -BigDecimal('1.23'), BigDecimal.context.copy_sign(BigDecimal('1.23'), -1)
+    assert_equal -BigDecimal('1.23'), BigDecimal.context.copy_sign(BigDecimal('1.23'), BigDecimal('-10'))
+    assert_equal -BigDecimal('1.23'), BigDecimal.context.copy_sign(BigDecimal('-1.23'), -1)
+    assert_equal -BigDecimal('1.23'), BigDecimal.context.copy_sign(BigDecimal('-1.23'), BigDecimal('-10'))
+    assert_equal BigDecimal('1.23'), BigDecimal.context.copy_sign(BigDecimal('-1.23'), +1)
+    assert_equal BigDecimal('1.23'), BigDecimal.context.copy_sign(BigDecimal('-1.23'), BigDecimal('+10'))
+    assert_equal BigDecimal('1.23'), BigDecimal.context.copy_sign(BigDecimal('1.23'), +1)
+    assert_equal BigDecimal('1.23'), BigDecimal.context.copy_sign(BigDecimal('1.23'), BigDecimal('+10'))
+  end
+
+end

data/test/test_float.rb

@@ -0,0 +1,40 @@
+require File.expand_path(File.join(File.dirname(__FILE__),'helper.rb'))
+
+class TestFloat < Test::Unit::TestCase
+
+  def setup
+    initialize_context
+  end
+
+  def test_sign
+    assert_equal -1, Float.context.sign(-1.0)
+    assert_equal -1, Float.context.sign(-100.0)
+    assert_equal -1, Float.context.sign(-0.0)
+    assert_equal -1, Float.context.sign(-Float::MIN)
+    assert_equal -1, Float.context.sign(-Float::MAX)
+    assert_equal -1, Float.context.sign(-Float::EPSILON)
+    assert_equal -1, Float.context.sign(-Float::INFINITY)
+
+    assert_equal +1, Float.context.sign(+1.0)
+    assert_equal +1, Float.context.sign(+100.0)
+    assert_equal +1, Float.context.sign(+0.0)
+    assert_equal +1, Float.context.sign(Float::MIN)
+    assert_equal +1, Float.context.sign(Float::MAX)
+    assert_equal +1, Float.context.sign(Float::EPSILON)
+    assert_equal +1, Float.context.sign(Float::INFINITY)
+
+    assert_nil Float.context.sign(Float.context.nan)
+  end
+
+  def copy_sign
+    assert_equal -1.23, BigDecimal.context.copy_sign(1.23, -1)
+    assert_equal -1.23, BigDecimal.context.copy_sign(1.23, -10.0)
+    assert_equal -1.23, BigDecimal.context.copy_sign(-1.23, -1)
+    assert_equal -1.23, BigDecimal.context.copy_sign(-1.23, -10.0)
+    assert_equal 1.23, BigDecimal.context.copy_sign(-1.23, +1)
+    assert_equal 1.23, BigDecimal.context.copy_sign(-1.23, 10.0)
+    assert_equal 1.23, BigDecimal.context.copy_sign(1.23, +1)
+    assert_equal 1.23, BigDecimal.context.copy_sign(1.23, 10.0)
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flt
 version: !ruby/object:Gem::Version
-  version: 1.4.5
+  version: 1.4.6
 platform: ruby
 authors:
 - Javier Goizueta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-04 00:00:00.000000000 Z
+date: 2015-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -83,6 +83,7 @@ files:
 - test/reader.rb
 - test/test_base_digits.rb
 - test/test_basic.rb
+- test/test_big_decimal.rb
 - test/test_bin.rb
 - test/test_bin_arithmetic.rb
 - test/test_binfloat_conversion.rb
@@ -93,6 +94,7 @@ files:
 - test/test_epsilon.rb
 - test/test_exact.rb
 - test/test_flags.rb
+- test/test_float.rb
 - test/test_format.rb
 - test/test_formatter.rb
 - test/test_hex_format.rb
@@ -139,6 +141,7 @@ test_files:
 - test/reader.rb
 - test/test_base_digits.rb
 - test/test_basic.rb
+- test/test_big_decimal.rb
 - test/test_bin.rb
 - test/test_bin_arithmetic.rb
 - test/test_binfloat_conversion.rb
@@ -149,6 +152,7 @@ test_files:
 - test/test_epsilon.rb
 - test/test_exact.rb
 - test/test_flags.rb
+- test/test_float.rb
 - test/test_format.rb
 - test/test_formatter.rb
 - test/test_hex_format.rb