flog 1.1.0 → 1.2.0

data/History.txt

@@ -1,10 +1,32 @@
-== 1.1.0 / 2007-08-21
+=== 1.2.0 / 2008-10-22
+
+* 14 minor enhancements:
+
+  * Added -c flag to continue dispite errors.
+  * Added -m to only report code in methods (skips #none).
+  * Added -n flag to give NO method details (summary only)
+  * Added -n to skip method details... pussies should learn grep.
+  * Added -q to quiet method details (total per method only)
+  * Added avg & stddev to total.
+  * Added avg score per method to report.
+  * Added lots of doco from contributors (hugh sasse?).
+  * Fixed class names when const2/3.
+  * Fixed unified ruby changes
+  * Refactored flog with help from flay.
+  * Refactored get_source_index
+  * Refactored into gem_updater.rb and cleaned up.
+  * Works with new incremental rubygems, albiet slower than before.
+
+=== 1.1.0 / 2007-08-21
 
 * 3 major enhancements:
+
   * Added assignments and branches and a lot of other stuff. rad.
   * Added process_iter section for DSL style blocks (rake tasks etc).
   * Made Flog usable as a library.
+
 * 12 minor enhancements:
+
   * Added -a flag to turn off threshold culling for other tools.
   * Added -s for summarizing the score.
   * Added -v feedback to know what file you're flogging.
@@ -17,23 +39,27 @@
   * Added unpack.rb and update_scores.rb at base level (not installed)
   * Added scoring for block_pass.
   * Converted totals to use distance formula on ABC's.
+
 * 3 bug fixes:
+
   * Ran flog on every latest gem available. Found a bunch of problems.
   * Use a stack for both class/module and method accounting.
   * block_args weren't processing the arg
 
-== 1.0.2 / 2007-08-01
+=== 1.0.2 / 2007-08-01
 
 * 1 bug fix:
+
   * stupid rubygems bin wrapper... *sigh*
 
-== 1.0.1 / 2007-08-01
+=== 1.0.1 / 2007-08-01
 
 * 1 bug fix:
+
   * New Rule: NEVER release new software when exhausted: Fixed dependency list. 
 
-== 1.0.0 / 2007-08-01
+=== 1.0.0 / 2007-08-01
 
 * 1 major enhancement:
-  * Birthday!
 
+  * Birthday!

data/Manifest.txt

@@ -3,6 +3,7 @@ Manifest.txt
 README.txt
 Rakefile
 bin/flog
+gem_updater.rb
 lib/flog.rb
 unpack.rb
 update_scores.rb

data/README.txt

@@ -1,7 +1,7 @@
-flog
-    by Ryan Davis, Seattle.rb
-    http://ruby.sadi.st/
-    http://rubyforge.org/projects/seattlerb
+= flog
+
+* http://ruby.sadi.st/
+* http://rubyforge.org/projects/seattlerb
 
 == DESCRIPTION:
 
@@ -25,7 +25,7 @@ report. The higher the score, the more pain the code is in.
 == REQUIREMENTS:
 
 * ruby2ruby
-* parse_tree
+* ParseTree
 
 == INSTALL:
 

data/Rakefile

@@ -2,16 +2,22 @@
 
 require 'rubygems'
 require 'hoe'
+
+Hoe.add_include_dirs("../../ParseTree/dev/lib",
+                     "../../RubyInline/dev/lib",
+                     "../../sexp_processor/dev/lib",
+                     "../../ZenTest/dev/lib",
+                     "lib")
+
 require './lib/flog'
 
-Hoe.new('flog', Flog::VERSION) do |p|
-  p.rubyforge_name = 'seattlerb'
-  p.summary = p.paragraphs_of('README.txt', 2).first
-  p.description = p.paragraphs_of('README.txt', 2, 6).join("\n\n")
-  p.url = p.paragraphs_of('README.txt', 0).first.split(/\n/)[2..-1].map {|u| u.strip }
-  p.changes = p.paragraphs_of('History.txt', 1).join("\n\n")
+Hoe.new('flog', Flog::VERSION) do |flog|
+  flog.rubyforge_name = 'seattlerb'
+
+  flog.developer('Ryan Davis', 'ryand-ruby@zenspider.com')
 
-  p.extra_deps << ["ParseTree", '>= 2.0.0']
+  flog.extra_deps << ['sexp_processor', '~> 3.0']
+  flog.extra_deps << ["ParseTree", '~> 3.0']
 end
 
 # vim: syntax=Ruby

data/bin/flog

@@ -2,15 +2,20 @@
 
 require 'flog'
 
+# In case this is being called on the end of a pipe:
 ARGV.push "-" if ARGV.empty?
 
 if defined? $h then
   puts "#{File.basename $0} options dirs_or_files"
   puts "  -a      display all flog results, not top 60%"
+  puts "  -c      continue despite syntax errors"
   puts "  -h      display help"
   puts "  -I=path extend $LOAD_PATH with path"
+  puts "  -m      skip code outside of methods"
+  puts "  -n      no method details in report"
   puts "  -s      display total score only"
   puts "  -v      verbosely display progress and errors"
+  puts "  -q      quiet, don't show method breakdowns"
   exit 0
 end
 

data/gem_updater.rb

@@ -0,0 +1,161 @@
+require 'rubygems/remote_fetcher'
+
+$u ||= false
+
+module GemUpdater
+  GEMURL = URI.parse 'http://gems.rubyforge.org'
+
+  @@index = nil
+
+  def self.stupid_gems
+    ["ruby-aes-table1-1.0.gem", # stupid dups usually because of "dash" renames
+     "ruby-aes-unroll1-1.0.gem",
+     "hpricot-scrub-0.2.0.gem",
+     "extract_curves-0.0.1.gem",
+     "extract_curves-0.0.1-i586-linux.gem",
+     "extract_curves-0.0.1-mswin32.gem",
+     "rfeedparser-ictv-0.9.931.gem",
+     "spec_unit-0.0.1.gem"]
+  end
+
+  def self.initialize_dir
+    Dir.mkdir "../gems" unless File.directory? "../gems"
+    self.in_gem_dir do
+      File.symlink ".", "cache" unless File.exist? "cache"
+    end
+  end
+
+  def self.get_source_index
+    return @@index if @@index
+
+    dump = if $u or not File.exist? '.source_index' then
+             url = GEMURL + "Marshal.#{Gem.marshal_version}.Z"
+             dump = Gem::RemoteFetcher.fetcher.fetch_path url
+             require 'zlib'
+             dump = Gem.inflate dump
+             open '.source_index', 'wb' do |io| io.write dump end
+             dump
+           else
+             open '.source_index', 'rb' do |io| io.read end
+           end
+
+    @@index = Marshal.load dump
+  end
+
+  def self.get_latest_gems
+    @@cache ||= get_source_index.latest_specs
+  end
+
+  def self.get_gems_by_name
+    @@by_name ||= Hash[*get_latest_gems.map { |gem|
+                         [gem.name, gem, gem.full_name, gem]
+                       }.flatten]
+  end
+
+  def self.dependencies_of name
+    index = self.get_source_index
+    get_gems_by_name[name].dependencies.map { |dep| index.search(dep).last }
+  end
+
+  def self.dependent_upon name
+    get_latest_gems.find_all { |gem|
+      gem.dependencies.any? { |dep| dep.name == name }
+    }
+  end
+
+  def self.update_gem_tarballs
+    GemUpdater.initialize_dir
+
+    latest = GemUpdater.get_latest_gems
+
+    puts "updating mirror"
+
+    self.in_gem_dir do
+      gems = Dir["*.gem"]
+      tgzs = Dir["*.tgz"]
+
+      old = tgzs - latest.map { |spec| "#{spec.full_name}.tgz" }
+      unless old.empty? then
+        puts "deleting #{old.size} tgzs"
+        old.each do |tgz|
+          File.unlink tgz
+        end
+      end
+
+      new = latest.map { |spec|
+        "#{spec.full_name}.tgz"
+      } - tgzs
+
+      puts "fetching #{new.size} tgzs"
+
+      latest.sort.each do |spec|
+        full_name = spec.full_name
+        tgz_name = "#{full_name}.tgz"
+        gem_name = "#{full_name}.gem"
+
+        next if tgzs.include? tgz_name
+
+        unless gems.include? gem_name then
+          begin
+            warn "downloading #{full_name}"
+            Gem::RemoteFetcher.fetcher.download(spec, GEMURL, Dir.pwd)
+          rescue Gem::RemoteFetcher::FetchError
+            warn "  failed"
+            next
+          end
+        end
+
+        warn "converting #{gem_name} to tarball"
+
+        unless File.directory? full_name then
+          system "gem unpack cache/#{gem_name}"
+          system "gem spec -l cache/#{gem_name} > #{full_name}/gemspec.rb"
+        end
+
+        system "tar zmcf #{tgz_name} #{full_name}"
+        system "rm -rf   #{full_name} #{gem_name}"
+      end
+    end
+  end
+
+  def self.each_gem filter = /^[\w-]+-\d+(\.\d+)*\.tgz$/
+    self.in_gem_dir do
+      Dir["*.tgz"].each do |tgz|
+        next unless tgz =~ filter
+
+        yield File.basename(tgz, ".tgz")
+      end
+    end
+  end
+
+  def self.with_gem name
+    self.in_gem_dir do
+      begin
+        system "tar zxmf #{name}.tgz 2> /dev/null"
+        Dir.chdir name do
+          yield name
+        end
+      ensure
+        system "rm -r #{name}"
+      end
+    end
+  end
+
+  def self.load_yaml path, default = {}
+    YAML.load(File.read(path)) rescue default
+  end
+
+  def self.save_yaml path, data
+    File.open("#{path}.new", 'w') do |f|
+      warn "*** saving #{path}"
+      YAML.dump data, f
+    end
+    File.rename "#{path}.new", path
+  end
+
+  def self.in_gem_dir
+    Dir.chdir "../gems" do
+      yield
+    end
+  end
+end

data/lib/flog.rb

@@ -3,12 +3,16 @@ require 'parse_tree'
 require 'sexp_processor'
 require 'unified_ruby'
 
-$a ||= false
-$s ||= false
-$v ||= false
+$a ||= false # report all methods, not just 60%
+$c ||= false # continue despite syntax errors
+$m ||= false # real methods only (no global scope)
+$n ||= false # no method details
+$s ||= false # summary only
+$v ||= false # verbose, print methods as processed
+$q ||= false # quiet, don't show method details
 
 class Flog < SexpProcessor
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 
   include UnifiedRuby
 
@@ -16,50 +20,58 @@ class Flog < SexpProcessor
   SCORES = Hash.new(1)
   BRANCHING = [ :and, :case, :else, :if, :or, :rescue, :until, :when, :while ]
 
+  ##
   # various non-call constructs
+
   OTHER_SCORES = {
-    :alias => 2,
-    :assignment => 1,
-    :block => 1,
-    :branch => 1,
-    :lit_fixnum => 0.25,
-    :sclass => 5,
-    :super => 1,
-    :to_proc_icky! => 10,
+    :alias          => 2,
+    :assignment     => 1,
+    :block          => 1,
+    :branch         => 1,
+    :lit_fixnum     => 0.25,
+    :sclass         => 5,
+    :super          => 1,
+    :to_proc_icky!  => 10,
     :to_proc_normal => 5,
-    :yield => 1,
+    :yield          => 1,
   }
 
+  ##
   # eval forms
+
   SCORES.merge!(:define_method => 5,
-                :eval => 5,
-                :module_eval => 5,
-                :class_eval => 5,
+                :eval          => 5,
+                :module_eval   => 5,
+                :class_eval    => 5,
                 :instance_eval => 5)
 
+  ##
   # various "magic" usually used for "clever code"
-  SCORES.merge!(:alias_method => 2,
-                :extend => 2,
-                :include => 2,
-                :instance_method => 2,
-                :instance_methods => 2,
-                :method_added => 2,
-                :method_defined? => 2,
-                :method_removed => 2,
-                :method_undefined => 2,
-                :private_class_method => 2,
-                :private_instance_methods => 2,
-                :private_method_defined? => 2,
-                :protected_instance_methods => 2,
-                :protected_method_defined? => 2,
-                :public_class_method => 2,
-                :public_instance_methods => 2,
-                :public_method_defined? => 2,
-                :remove_method => 2,
-                :send => 3,
-                :undef_method => 2)
 
+  SCORES.merge!(:alias_method               => 2,
+                :extend                     => 2,
+                :include                    => 2,
+                :instance_method            => 2,
+                :instance_methods           => 2,
+                :method_added               => 2,
+                :method_defined?            => 2,
+                :method_removed             => 2,
+                :method_undefined           => 2,
+                :private_class_method       => 2,
+                :private_instance_methods   => 2,
+                :private_method_defined?    => 2,
+                :protected_instance_methods => 2,
+                :protected_method_defined?  => 2,
+                :public_class_method        => 2,
+                :public_instance_methods    => 2,
+                :public_method_defined?     => 2,
+                :remove_method              => 2,
+                :send                       => 3,
+                :undef_method               => 2)
+
+  ##
   # calls I don't like and usually see being abused
+
   SCORES.merge!(:inject => 2)
 
   @@no_class = :main
@@ -81,16 +93,31 @@ class Flog < SexpProcessor
     @calls["#{self.klass_name}##{self.method_name}"][name] += score * @multiplier
   end
 
+  ##
+  # For the duration of the block the complexity factor is increased
+  # by #bonus This allows the complexity of sub-expressions to be
+  # influenced by the expressions in which they are found.  Yields 42
+  # to the supplied block.
+
   def bad_dog! bonus
     @multiplier += bonus
     yield 42
     @multiplier -= bonus
   end
 
+  ##
+  # process each element of #exp in turn.
+
   def bleed exp
     process exp.shift until exp.empty?
   end
 
+  ##
+  # Process #files with flog, recursively descending directories.
+  #--
+  # There is no way to exclude directories at present (RCS, SCCS, .svn)
+  #++
+
   def flog_files *files
     files.flatten.each do |file|
       if File.directory? file then
@@ -103,10 +130,12 @@ class Flog < SexpProcessor
           process Sexp.from_array(sexp).first
         rescue SyntaxError => e
           if e.inspect =~ /<%|%>/ then
-            warn e.inspect + " at " + e.backtrace.first(5).join(', ')
+            warn "#{e.inspect} at #{e.backtrace.first(5).join(', ')}"
             warn "...stupid lemmings and their bad erb templates... skipping"
           else
-            raise e
+            raise e unless $c
+            warn file
+            warn "#{e.inspect} at #{e.backtrace.first(5).join(', ')}"
           end
         end
       end
@@ -119,40 +148,65 @@ class Flog < SexpProcessor
     @klasses.shift
   end
 
+  ##
+  # returns the first class in the list, or @@no_class if there are
+  # none.
+
   def klass_name
-    @klasses.first || @@no_class
+    name = @klasses.first || @@no_class
+    if Sexp === name then
+      case name.first
+      when :colon2 then
+        name = name.flatten
+        name.delete :const
+        name.delete :colon2
+        name = name.join("::")
+      when :colon3 then
+        name = name.last
+      end
+    end
+    name
   end
 
+  ##
+  # Adds name to the list of methods, for the duration of the block
+
   def method name
     @methods.unshift name
     yield
     @methods.shift
   end
 
+  ##
+  # returns the first method in the list, or @@no_method if there are
+  # none.
+
   def method_name
     @methods.first || @@no_method
   end
 
+  ##
+  # Report results to #io, STDOUT by default.
+
   def report io = $stdout
     current = 0
+    totals = self.totals
     total_score = self.total
     max = total_score * THRESHOLD
-    totals = self.totals
-
-    if $s then
-      io.puts total_score
-      exit 0
-    end
 
-    io.puts "Total score = #{total_score}"
+    io.puts "Total Flog = %.1f (%.1f +/- %.1f flog / method)" % [total_score, self.average, self.stddev]
     io.puts
 
+    exit 0 if $s
+
     @calls.sort_by { |k,v| -totals[k] }.each do |klass_method, calls|
+      next if $m and klass_method =~ /##{@@no_method}/
       total = totals[klass_method]
       io.puts "%s: (%.1f)" % [klass_method, total]
+      next if $q
       calls.sort_by { |k,v| -v }.each do |call, count|
         io.puts "  %6.1f: %s" % [count, call]
-      end
+      end unless $n
 
       current += total
       break if current >= max
@@ -162,22 +216,23 @@ class Flog < SexpProcessor
   end
 
   def reset
-    @totals = @total_score = nil
+    # TODO: rename @totals
+    @totals = @total = nil
     @multiplier = 1.0
     @calls = Hash.new { |h,k| h[k] = Hash.new 0 }
   end
 
-  def total
-    self.totals unless @total_score # calculates total_score as well
+  attr_reader :total, :average, :stddev
 
-    @total_score
-  end
+  ##
+  # Return the total score and populates @totals.
 
   def totals
     unless @totals then
-      @total_score = 0
+      @total = 0
       @totals = Hash.new(0)
       self.calls.each do |meth, tally|
+        next if $m and meth =~ /##{@@no_method}$/
         a, b, c = 0, 0, 0
         tally.each do |cat, score|
           case cat
@@ -188,9 +243,17 @@ class Flog < SexpProcessor
         end
         score = Math.sqrt(a*a + b*b + c*c)
         @totals[meth] = score
-        @total_score += score
+        @total += score
       end
     end
+
+    size = self.calls.size.to_f
+    @average = @total / size
+
+    sum = 0
+    @totals.values.each { |i| sum += (i - @average) ** 2 }
+    @stddev = (1 / size * sum)
+
     @totals
   end
 
@@ -212,6 +275,7 @@ class Flog < SexpProcessor
     end
     s()
   end
+  alias :process_or :process_and
 
   def process_attrasgn(exp)
     add_to_score :assignment, OTHER_SCORES[:assignment]
@@ -234,7 +298,6 @@ class Flog < SexpProcessor
     s()
   end
 
-  # [:block_pass, [:lit, :blah], [:fcall, :foo]]
   def process_block_pass(exp)
     arg = exp.shift
     call = exp.shift
@@ -298,6 +361,8 @@ class Flog < SexpProcessor
     process exp.shift # assigment, if any
     s()
   end
+  alias :process_iasgn :process_dasgn_curr
+  alias :process_lasgn :process_dasgn_curr
 
   def process_defn(exp)
     self.method exp.shift do
@@ -321,13 +386,8 @@ class Flog < SexpProcessor
     end
     s()
   end
-
-  def process_iasgn(exp)
-    add_to_score :assignment, OTHER_SCORES[:assignment]
-    exp.shift # name
-    process exp.shift # rhs
-    s()
-  end
+  alias :process_rescue :process_else
+  alias :process_when   :process_else
 
   def process_if(exp)
     add_to_score :branch, OTHER_SCORES[:branch]
@@ -343,7 +403,8 @@ class Flog < SexpProcessor
     context = (self.context - [:class, :module, :scope])
     if context.uniq.sort_by {|s|s.to_s} == [:block, :iter] then
       recv = exp.first
-      if recv[0] == :call and recv[1] == nil and recv.arglist[1] and [:lit, :str].include? recv.arglist[1][0] then
+      if (recv[0] == :call and recv[1] == nil and recv.arglist[1] and
+          [:lit, :str].include? recv.arglist[1][0]) then
         msg = recv[2]
         submsg = recv.arglist[1][1]
         self.method submsg do
@@ -366,13 +427,6 @@ class Flog < SexpProcessor
     s()
   end
 
-  def process_lasgn(exp)
-    add_to_score :assignment, OTHER_SCORES[:assignment]
-    exp.shift # name
-    process exp.shift # rhs
-    s()
-  end
-
   def process_lit(exp)
     value = exp.shift
     case value
@@ -390,8 +444,7 @@ class Flog < SexpProcessor
 
   def process_masgn(exp)
     add_to_score :assignment, OTHER_SCORES[:assignment]
-    process exp.shift # lhs
-    process exp.shift # rhs
+    bleed exp
     s()
   end
 
@@ -402,23 +455,6 @@ class Flog < SexpProcessor
     s()
   end
 
-  def process_or(exp)
-    add_to_score :branch, OTHER_SCORES[:branch]
-    bad_dog! 0.1 do
-      process exp.shift # lhs
-      process exp.shift # rhs
-    end
-    s()
-  end
-
-  def process_rescue(exp)
-    add_to_score :branch, OTHER_SCORES[:branch]
-    bad_dog! 0.1 do
-      bleed exp
-    end
-    s()
-  end
-
   def process_sclass(exp)
     bad_dog! 0.5 do
       recv = process exp.shift
@@ -435,24 +471,6 @@ class Flog < SexpProcessor
     s()
   end
 
-  def process_until(exp)
-    add_to_score :branch, OTHER_SCORES[:branch]
-    bad_dog! 0.1 do
-      process exp.shift # cond
-      process exp.shift # body
-    end
-    exp.shift # pre/post
-    s()
-  end
-
-  def process_when(exp)
-    add_to_score :branch, OTHER_SCORES[:branch]
-    bad_dog! 0.1 do
-      bleed exp
-    end
-    s()
-  end
-
   def process_while(exp)
     add_to_score :branch, OTHER_SCORES[:branch]
     bad_dog! 0.1 do
@@ -462,6 +480,7 @@ class Flog < SexpProcessor
     exp.shift # pre/post
     s()
   end
+  alias :process_until :process_while
 
   def process_yield(exp)
     add_to_score :yield, OTHER_SCORES[:yield]

data/update_scores.rb

@@ -1,70 +1,63 @@
-#!/usr/local/bin/ruby -ws
+#!/usr/bin/env ruby -ws
 
-$: << 'lib'
-$: << '../../ParseTree/dev/lib'
+# Update the flog scores for a specific set of gems.
+
+$: << 'lib' << '../../ParseTree/dev/lib'
+$:.unshift File.expand_path("~/Work/svn/rubygems/lib")
+
+require 'yaml'
 require 'flog'
-require 'rubygems/source_info_cache'
+require 'gem_updater'
 
 $u ||= false
 $f ||= false
 
-$score_file = '../dev/scores.yml'
-$misc_error = [-1]
-$syntax_error = [-2]
-$no_methods = ["", -3]
-$no_gem = [-4]
+$score_file   = '../dev/scores.yml'
+$misc_error   = {:total => -1, :average => -1, :methods => {}}
+$syntax_error = {:total => -2, :average => -2, :methods => {}}
+$no_gem       = {:total => -4, :average => -4, :methods => {}}
 
-max = (ARGV.shift || 10).to_i
+max    = (ARGV.shift || 10).to_i
 
 scores = YAML.load(File.read($score_file)) rescue {}
 
-["ruby-aes-table1-1.0.gem",
- "ruby-aes-unroll1-1.0.gem",
- "hpricot-scrub-0.2.0.gem",
- "extract_curves-0.0.1.gem",
- "rfeedparser-ictv-0.9.931.gem",
- "spec_unit-0.0.1.gem"].each do|p|
+##
+# Save the scores in $score_file.
+#--
+# Creates a new file, then renames to overwrite the old one.
+# Wouldn't it be better to copy the old one, then create a new
+# one so you can do a diff?
+#++
+
+def save_scores scores
+  File.open("#{$score_file}.new", 'w') do |f|
+    warn "*** saving scores"
+    YAML.dump scores, f
+  end
+  File.rename "#{$score_file}.new", $score_file
+end
+
+GemUpdater::stupid_gems.each do|p|
   scores[p] = $no_gem.dup
 end
 
-Dir.mkdir "../gems" unless File.directory? "../gems"
+GemUpdater::initialize_dir
 
 if $u then
-  puts "updating mirror"
-
-  Dir.chdir "../gems" do
-    cache = Gem::SourceInfoCache.cache_data['http://gems.rubyforge.org']
-
-    gems = Dir["*.gem"]
-    old = gems - cache.source_index.latest_specs.values.map { |spec|
-      "#{spec.full_name}.gem"
-    }
-
-    puts "deleting #{old.size} gems"
-    old.each do |gem|
-      scores.delete gem
-      File.unlink gem
-    end
-
-    new = cache.source_index.latest_specs.map { |name, spec|
-      "#{spec.full_name}.gem"
-    } - gems
-
-    puts "fetching #{new.size} gems"
-    new.each do |gem|
-      next if scores[gem] == $no_gem unless $f # FIX
-      unless system "wget http://gems.rubyforge.org/gems/#{gem}" then
-        scores[gem] = $no_gem
-      end
-    end
-  end
+  GemUpdater.update_gem_tarballs
+  exit 1
 end
 
-my_projects = Regexp.union("InlineFortran", "ParseTree", "RubyInline", "ZenTest", "bfts", "box_layout", "flog", "heckle", "image_science", "miniunit", "png", "ruby2ruby", "vlad", "zentest", "ZenHacks", "rubyforge", "RubyToC", "hoe")
+my_projects = Regexp.union("InlineFortran", "ParseTree", "RubyInline",
+                           "RubyToC", "ZenHacks", "ZenTest", "bfts",
+                           "box_layout", "flog", "heckle", "hoe",
+                           "image_science", "miniunit", "png", "ruby2ruby",
+                           "rubyforge", "vlad", "zentest")
 
 $owners = {}
-cache = Marshal.load(File.read(Gem::SourceInfoCache.new.cache_file))
-cache['http://gems.rubyforge.org'].source_index.latest_specs.map { |name, spec|
+
+GemUpdater.get_latest_gems.each do |spec|
+  name  = spec.name
   owner = spec.authors.compact
   owner = Array(spec.email) if owner.empty?
   owner.map! { |o| o.sub(/\s*[^ \w@.].*$/, '') }
@@ -73,17 +66,22 @@ cache['http://gems.rubyforge.org'].source_index.latest_specs.map { |name, spec|
   # because we screwed these up back before hoe
   owner << "Eric Hodel" if name =~ /bfts|RubyToC|ParseTree|heckle/
 
-  $owners["#{spec.full_name}.gem"] = owner.uniq
-}
+  $owners["#{spec.full_name}.tgz"] = owner.uniq || 'omg I have no idea'
+end
 
 def score_for dir
   files = `find #{dir} -name \\*.rb | grep -v gen.*templ`.split(/\n/)
 
   flogger = Flog.new
   flogger.flog_files files
-  methods = flogger.totals.reject { |k,v| k =~ /\#none$/ }.sort_by { |k,v| v }
-  methods = [$no_methods.dup] if methods.empty?
-  [flogger.total] + methods
+  methods = flogger.totals.reject { |k,v| k =~ /\#none$/ }
+  {
+    :total => flogger.total,
+    :size => methods.size,
+    :average => flogger.average,
+    :stddev => flogger.stddev,
+    :methods => methods
+  }
 rescue SyntaxError => e
   warn e.inspect + " at " + e.backtrace.first(5).join(', ') if $v
   $syntax_error.dup
@@ -92,44 +90,40 @@ rescue => e
   $misc_error.dup
 end
 
-def save_scores scores
-  File.open("#{$score_file}.new", 'w') do |f|
-    warn "*** saving scores"
-    YAML.dump scores, f
-  end
-  File.rename "#{$score_file}.new", $score_file
-end
-
+# extract all the gems and process the data for them.
 begin
   dirty = false
   Dir.chdir "../gems" do
-    Dir["*.gem"].each_with_index do |gem, i|
+    Dir["*.tgz"].each_with_index do |gem, i|
       project = File.basename gem
-      next if scores.has_key? project unless $f and scores[project][0] < 0
+      next if scores.has_key? project unless $f and scores[project][:total] < 0
       dirty = true
       begin
         warn gem
-        dir = gem.sub(/\.gem$/, '')
-        Dir.mkdir dir
+        dir = gem.sub(/\.tgz$/, '')
+
+        system "tar -zmxf #{gem} 2> /dev/null"
+
         Dir.chdir dir do
-          system "(tar -Oxf ../#{gem} data.tar.gz | tar zxf -) 2> /dev/null"
           system "chmod -R a+r ."
           scores[project] = score_for(File.directory?('lib') ? 'lib' : '.')
         end
       ensure
         system "rm -rf #{dir}"
       end
-
-      if i % 500 == 0 then
-        save_scores scores
-      end
     end
   end
 ensure
   save_scores scores if dirty
 end
 
-scores.reject! { |k,v| v.first.nil? or Fixnum === v.last or v.last.last < 0 }
+scores.reject! { |k,v| v[:total].nil? or v[:methods].empty? }
+
+class Hash
+  def sorted_methods
+    self[:methods].sort_by { |k,v| -v }
+  end
+end
 
 class Array
   def sum
@@ -170,13 +164,13 @@ def report title, data
   end
 end
 
-project_numbers = scores.map { |k,v| [k, v[1..-1].map {|_,n| n}.flatten] }
+project_numbers = scores.map { |k,v| [k, v[:methods].map {|_,n| n}.flatten] }
 project_stats   = project_numbers.map { |k,v| [k, v.size, v.average, v.stddev] }
 
 title "Statistics" do
-  flog_numbers = scores.map { |k,v| v.first }
-  all_scores = scores.map { |k,v| v[1..-1].map { |_,n| n } }.flatten
-  method_counts = project_stats.map { |n,c,a,s| c }
+  flog_numbers = scores.map { |k,v| v[:total] }
+  all_scores = scores.map { |k,v| v[:methods].values }.flatten
+  method_counts = scores.map { |k,v| v[:size] }
 
   puts "total # gems      : %8d" % scores.size
   puts "total # methods   : %8d" % all_scores.size
@@ -194,14 +188,27 @@ def report_worst section, data
   end
 end
 
-worst = scores.sort_by { |k,v| -v.first }.first(max)
+worst = scores.sort_by { |k,v| -v[:total] }.first(max)
 report_worst "Worst Projects EVAR", worst do |project, score|
-  [score.first, project, $owners[project].join(', ')]
+  owner = $owners[project].join(', ') rescue nil
+  raise "#{project} seems not to have an owner" if owner.nil?
+  [score[:total], project, owner]
 end
 
-worst = scores.sort_by { |k,v| -v.last.last }.first(max)
-report_worst "Worst Methods EVAR", worst do |project, methods|
-  [methods.last.last, project, methods.last.first]
+worst = {}
+scores.each do |long_name, spec|
+  name = long_name.sub(/-(\d+\.)*\d+\.gem$/, '')
+  spec[:methods].each do |method_name, score|
+    worst[[name, method_name]] = score
+  end
+end
+
+worst = worst.sort_by { |_,v| -v }.first(max)
+
+max_size = worst.map { |(name, meth), score| name.size }.max
+title "Worth Methods EVAR"
+worst.each_with_index do |((name, meth), score), i|
+  puts "%3d: %9.2f: %-#{max_size}s %s" % [i + 1, score, name, meth]
 end
 
 report "Methods per Gem", project_stats.sort_by { |n, c, a, sd| -c }.first(max)
@@ -212,7 +219,7 @@ $projects_per_owner = Hash.new { |h,k| h[k] = {} }
 $owners.each do |project, owners|
   next unless scores.has_key? project # bad project
   owners.each do |owner|
-    score = scores[project].first || 10000
+    score = scores[project][:total] || 1000000
     $projects_per_owner[owner][project] = score
     $score_per_owner[owner] += score
   end
@@ -234,5 +241,5 @@ report_bad_people "Top Flog Scores per Developer" do
 end
 
 report_bad_people "Most Prolific Developers" do |k,v|
-  $projects_per_owner.sort_by { |k,v| -v.size }.first(max)
+  $projects_per_owner.sort_by { |k,v| [-v.size, -$score_per_owner[k]] }.first(max)
 end

metadata

@@ -1,73 +1,94 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.4
-specification_version: 1
 name: flog
 version: !ruby/object:Gem::Version 
-  version: 1.1.0
-date: 2007-08-21 00:00:00 -07:00
-summary: Flog reports the most tortured code in an easy to read pain report. The higher the score, the more pain the code is in.
-require_paths: 
-- lib
-email: ryand-ruby@zenspider.com
-homepage: http://ruby.sadi.st/
-rubyforge_project: seattlerb
-description: "Flog reports the most tortured code in an easy to read pain report. The higher the score, the more pain the code is in.  % ./bin/flog bin/flog Total score = 128.7  Flog#report: (21) 4: puts 2: sort_by ..."
-autorequire: 
-default_executable: 
-bindir: bin
-has_rdoc: true
-required_ruby_version: !ruby/object:Gem::Version::Requirement 
-  requirements: 
-  - - ">"
-    - !ruby/object:Gem::Version 
-      version: 0.0.0
-  version: 
+  version: 1.2.0
 platform: ruby
-signing_key: 
-cert_chain: 
-post_install_message: 
 authors: 
 - Ryan Davis
-files: 
-- History.txt
-- Manifest.txt
-- README.txt
-- Rakefile
-- bin/flog
-- lib/flog.rb
-- unpack.rb
-- update_scores.rb
-test_files: []
-
-rdoc_options: 
-- --main
-- README.txt
-extra_rdoc_files: 
-- History.txt
-- Manifest.txt
-- README.txt
-executables: 
-- flog
-extensions: []
-
-requirements: []
+autorequire: 
+bindir: bin
+cert_chain: []
 
+date: 2008-10-22 00:00:00 -05:00
+default_executable: 
 dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: sexp_processor
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: "3.0"
+    version: 
 - !ruby/object:Gem::Dependency 
   name: ParseTree
+  type: :runtime
   version_requirement: 
-  version_requirements: !ruby/object:Gem::Version::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        version: 2.0.0
+        version: "3.0"
     version: 
 - !ruby/object:Gem::Dependency 
   name: hoe
+  type: :development
   version_requirement: 
-  version_requirements: !ruby/object:Gem::Version::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 1.3.0
+        version: 1.8.0
     version: 
+description: Flog reports the most tortured code in an easy to read pain report. The higher the score, the more pain the code is in.
+email: 
+- ryand-ruby@zenspider.com
+executables: 
+- flog
+extensions: []
+
+extra_rdoc_files: 
+- History.txt
+- Manifest.txt
+- README.txt
+files: 
+- History.txt
+- Manifest.txt
+- README.txt
+- Rakefile
+- bin/flog
+- gem_updater.rb
+- lib/flog.rb
+- unpack.rb
+- update_scores.rb
+has_rdoc: true
+homepage: http://ruby.sadi.st/
+post_install_message: 
+rdoc_options: 
+- --main
+- README.txt
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+requirements: []
+
+rubyforge_project: seattlerb
+rubygems_version: 1.3.0
+signing_key: 
+specification_version: 2
+summary: Flog reports the most tortured code in an easy to read pain report
+test_files: []
+