flipper 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 881ca599099f433a4204f2a058c512b6b9198f529d1db4fd3a3445ba822dcd9b
-  data.tar.gz: 5ad5da793cec928e09357f2d46ddb139c159dfc1d5b9ddea4ae4c0c52193a75b
+  metadata.gz: b53cde688da0c42de8705aa6d3adbcb7c43f2771a75bb49ccb2b500637b10f07
+  data.tar.gz: 65532d9f52b340a85028101e7e31538c5b2165e16fb453e74ca2d65f5041bd07
 SHA512:
-  metadata.gz: 9b049bcd83af70810efd36f1873fb9d72cf22f95cf460d80829b7ad7ed68b7ef11e619b621ea001c230dfdbee43c453e76326de59be2306ee52b23444b50619b
-  data.tar.gz: fb82eca0e34233cf3fe9e001923f3b87ae2acf9f7dfdbbdce553d1b8408d5f23df075d789f5be2f975d6facf077637294f306d774e026005e4a7a13124866a3a
+  metadata.gz: a250b1d0b4928a0f060fc699cbf4ff69550158732bcfb3f5cf567d088a207daa1607b6da342ec3cc2888353032ad42f66096f2281e2751a0948ff1a5bed8e02b
+  data.tar.gz: 8dd06e0a50cf2f80efb2fbbb8ad42ddbc3140befd7d0b28a9a9124b7432365aa4c5e541d5f4d3749d3cb70e4d67ba53c9b2c05ecac50f564b1c426b53314de3e

data/.github/workflows/ci.yml

@@ -93,7 +93,7 @@ jobs:
       - name: Check out repository code
         uses: actions/checkout@v6
       - name: Do some action caching
-        uses: actions/cache@v4
+        uses: actions/cache@v5
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gems-${{ matrix.ruby }}-${{ matrix.rails }}-${{ hashFiles('**/Gemfile.lock') }}

data/.github/workflows/examples.yml

@@ -73,7 +73,7 @@ jobs:
       - name: Check out repository code
         uses: actions/checkout@v6
       - name: Do some action caching
-        uses: actions/cache@v4
+        uses: actions/cache@v5
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gems-${{ matrix.ruby }}-${{ matrix.rails }}-${{ hashFiles('**/Gemfile.lock') }}

data/.superset/config.json

@@ -0,0 +1,4 @@
+{
+  "setup": ["script/conductor-setup"],
+  "teardown": []
+}

data/CLAUDE.md

@@ -26,6 +26,10 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 - `bundle exec rake build` - Build all gems locally into pkg/ directory
 - `script/release` - Manual fallback for local releases (prompts for OTP)
 
+**After releasing**, purge the cached release URLs on flippercloud.io:
+- `/release`
+- `/release.json`
+
 ## Architecture Overview
 
 Flipper is a feature flag library for Ruby with a modular adapter-based architecture:
@@ -85,3 +89,5 @@ For outbound HTTP requests, use `Flipper::Adapters::Http::Client` instead of raw
 ### Testing
 
 Uses both RSpec (currently preferred for new tests) and Minitest. Shared adapter specs ensure consistency across all storage backends. Extensive testing across multiple Rails versions (5.0-8.0).
+
+`Flipper.configuration` is reset to nil before each spec (in `spec/spec_helper.rb`), but `Flipper::UI.configuration` is **not** globally reset. When modifying UI config in tests, set the value in `before` and reset it in `after` to match the existing pattern throughout the spec suite.

data/lib/flipper/adapters/http.rb

@@ -65,7 +65,7 @@ module Flipper
         path += "&_cb=#{Time.now.to_i}" if cache_bust
         etag = @get_all_mutex.synchronize { @last_get_all_etag }
 
-        if etag
+        if etag && !cache_bust
           options[:headers] = { if_none_match: etag }
         end
 

data/lib/flipper/adapters/strict.rb

@@ -10,11 +10,40 @@ module Flipper
         end
       end
 
+      class << self
+        # Returns whether sync mode is enabled for the current thread.
+        # When sync mode is enabled, strict checks are not enforced,
+        # allowing sync operations to add features and bring local state
+        # in line with remote state.
+        def sync_mode
+          Thread.current[:flipper_strict_sync_mode]
+        end
+
+        def sync_mode=(value)
+          Thread.current[:flipper_strict_sync_mode] = value
+        end
+
+        # Executes a block with sync mode enabled. Strict checks will
+        # not be enforced within the block.
+        def with_sync_mode
+          old_value = sync_mode
+          self.sync_mode = true
+          yield
+        ensure
+          self.sync_mode = old_value
+        end
+      end
+
       def initialize(adapter, handler = nil, &block)
         super(adapter)
         @handler = block || handler
       end
 
+      def add(feature)
+        assert_feature_exists(feature) unless self.class.sync_mode
+        super
+      end
+
       def get(feature)
         assert_feature_exists(feature)
         super
@@ -28,6 +57,7 @@ module Flipper
       private
 
       def assert_feature_exists(feature)
+        return if self.class.sync_mode
         return if @adapter.features.include?(feature.key)
 
         case handler

data/lib/flipper/adapters/sync/synchronizer.rb

@@ -1,6 +1,7 @@
 require "flipper/feature"
 require "flipper/gate_values"
 require "flipper/adapters/actor_limit"
+require "flipper/adapters/strict"
 require "flipper/adapters/sync/feature_synchronizer"
 
 module Flipper
@@ -29,7 +30,9 @@ module Flipper
         # Public: Forces a sync.
         def call
           @instrumenter.instrument("synchronizer_call.flipper") do
-            Flipper::Adapters::ActorLimit.with_sync_mode { sync }
+            Flipper::Adapters::Strict.with_sync_mode do
+              Flipper::Adapters::ActorLimit.with_sync_mode { sync }
+            end
           end
         end
 

data/lib/flipper/poller.rb

@@ -18,7 +18,10 @@ module Flipper
     end
 
     def self.reset
-      instances.each {|_, instance| instance.stop }.clear
+      instances.each do |_, instance|
+        instance.stop
+        instance.thread&.join(1)
+      end.clear
     end
 
     MINIMUM_POLL_INTERVAL = 10
@@ -116,6 +119,7 @@ module Flipper
       begin
         return if thread_alive?
         @thread = Thread.new { run }
+        @thread&.report_on_exception = false
         @instrumenter.instrument("poller.#{InstrumentationNamespace}", {
           operation: :thread_start,
         })

data/lib/flipper/version.rb

@@ -1,5 +1,5 @@
 module Flipper
-  VERSION = '1.4.0'.freeze
+  VERSION = '1.4.1'.freeze
 
   REQUIRED_RUBY_VERSION = '2.6'.freeze
   NEXT_REQUIRED_RUBY_VERSION = '3.0'.freeze

data/spec/flipper/adapters/http_spec.rb

@@ -278,6 +278,95 @@ RSpec.describe Flipper::Adapters::Http do
       }.to raise_error(Flipper::Adapters::Http::Error)
     end
 
+    it "skips If-None-Match header when cache_bust is true" do
+      features_response = {
+        "features" => [
+          {
+            "key" => "search",
+            "gates" => [
+              {"key" => "boolean", "value" => true}
+            ]
+          }
+        ]
+      }
+
+      # First request - populate the ETag cache
+      stub_request(:get, "http://app.com/flipper/features?exclude_gate_names=true")
+        .to_return(
+          status: 200,
+          body: JSON.generate(features_response),
+          headers: { 'ETag' => '"abc123"' }
+        )
+
+      adapter = described_class.new(url: 'http://app.com/flipper')
+      adapter.get_all
+
+      # Second request with cache_bust - should NOT send If-None-Match
+      cache_bust_stub = stub_request(:get, %r{/flipper/features\?_cb=\d+&exclude_gate_names=true})
+        .to_return(
+          status: 200,
+          body: JSON.generate(features_response),
+          headers: { 'ETag' => '"def456"' }
+        )
+
+      adapter.get_all(cache_bust: true)
+
+      expect(cache_bust_stub).to have_been_requested.once
+      expect(
+        a_request(:get, %r{/flipper/features\?_cb=\d+&exclude_gate_names=true})
+        .with { |req| req.headers['If-None-Match'].nil? }
+      ).to have_been_made.once
+    end
+
+    it "returns fresh data on cache_bust even when ETag is cached" do
+      stale_response = {
+        "features" => [
+          {
+            "key" => "search",
+            "gates" => [
+              {"key" => "boolean", "value" => nil}
+            ]
+          }
+        ]
+      }
+
+      fresh_response = {
+        "features" => [
+          {
+            "key" => "search",
+            "gates" => [
+              {"key" => "boolean", "value" => true}
+            ]
+          }
+        ]
+      }
+
+      # First request - populate ETag cache with feature disabled
+      stub_request(:get, "http://app.com/flipper/features?exclude_gate_names=true")
+        .to_return(
+          status: 200,
+          body: JSON.generate(stale_response),
+          headers: { 'ETag' => '"abc123"' }
+        )
+
+      adapter = described_class.new(url: 'http://app.com/flipper')
+      stale_result = adapter.get_all
+
+      expect(stale_result["search"][:boolean]).to be_nil
+
+      # Cache bust request returns fresh data (feature now enabled)
+      stub_request(:get, %r{/flipper/features\?_cb=\d+&exclude_gate_names=true})
+        .to_return(
+          status: 200,
+          body: JSON.generate(fresh_response),
+          headers: { 'ETag' => '"def456"' }
+        )
+
+      fresh_result = adapter.get_all(cache_bust: true)
+
+      expect(fresh_result["search"][:boolean]).to eq("true")
+    end
+
     it "does not send If-None-Match for other endpoints" do
       stub_request(:get, "http://app.com/flipper/features/search")
         .to_return(status: 404)

data/spec/flipper/adapters/strict_spec.rb

@@ -21,6 +21,12 @@ RSpec.describe Flipper::Adapters::Strict do
           expect { subject.get_multi([feature]) }.to raise_error(Flipper::Adapters::Strict::NotFound)
         end
       end
+
+      context "#add" do
+        it "raises an error for unknown feature" do
+          expect { subject.add(feature) }.to raise_error(Flipper::Adapters::Strict::NotFound)
+        end
+      end
     end
   end
 
@@ -28,16 +34,22 @@ RSpec.describe Flipper::Adapters::Strict do
     subject { described_class.new(Flipper::Adapters::Memory.new, :warn) }
 
     context "#get" do
-      it "raises an error for unknown feature" do
+      it "warns for unknown feature" do
         expect(capture_output { subject.get(feature) }).to match(/Could not find feature "unknown"/)
       end
     end
 
     context "#get_multi" do
-      it "raises an error for unknown feature" do
+      it "warns for unknown feature" do
         expect(capture_output { subject.get_multi([feature]) }).to match(/Could not find feature "unknown"/)
       end
     end
+
+    context "#add" do
+      it "warns for unknown feature" do
+        expect(capture_output { subject.add(feature) }).to match(/Could not find feature "unknown"/)
+      end
+    end
   end
 
   context "handler = Block" do
@@ -48,17 +60,63 @@ RSpec.describe Flipper::Adapters::Strict do
 
 
     context "#get" do
-      it "raises an error for unknown feature" do
+      it "calls block for unknown feature" do
         subject.get(feature)
         expect(unknown_features).to eq(["unknown"])
       end
     end
 
     context "#get_multi" do
-      it "raises an error for unknown feature" do
+      it "calls block for unknown feature" do
         subject.get_multi([flipper[:foo], flipper[:bar]])
         expect(unknown_features).to eq(["foo", "bar"])
       end
     end
+
+    context "#add" do
+      it "calls block for unknown feature" do
+        subject.add(feature)
+        expect(unknown_features).to eq(["unknown"])
+      end
+    end
+  end
+
+  describe ".with_sync_mode" do
+    subject { described_class.new(Flipper::Adapters::Memory.new, :raise) }
+
+    it "bypasses strict checks for add" do
+      described_class.with_sync_mode do
+        expect { subject.add(feature) }.not_to raise_error
+      end
+    end
+
+    it "bypasses strict checks for get" do
+      described_class.with_sync_mode do
+        expect { subject.get(feature) }.not_to raise_error
+      end
+    end
+
+    it "bypasses strict checks for get_multi" do
+      described_class.with_sync_mode do
+        expect { subject.get_multi([feature]) }.not_to raise_error
+      end
+    end
+
+    it "restores previous sync mode after block" do
+      described_class.with_sync_mode do
+        # inside sync mode
+      end
+      expect { subject.add(feature) }.to raise_error(Flipper::Adapters::Strict::NotFound)
+    end
+
+    it "restores previous sync mode even on error" do
+      begin
+        described_class.with_sync_mode do
+          raise "boom"
+        end
+      rescue RuntimeError
+      end
+      expect { subject.add(feature) }.to raise_error(Flipper::Adapters::Strict::NotFound)
+    end
   end
 end

data/spec/spec_helper.rb

@@ -39,6 +39,13 @@ RSpec.configure do |config|
     Flipper.configuration = nil
   end
 
+  config.after(:example) do
+    # Stop any pollers started during the test BEFORE WebMock clears stubs
+    # in its own after hook (RSpec runs after hooks in reverse registration
+    # order, so ours runs first since webmock/rspec was required before this).
+    Flipper::Poller.reset if defined?(Flipper::Poller)
+  end
+
   config.disable_monkey_patching!
 
   config.filter_run focus: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-02-26 00:00:00.000000000 Z
+date: 2026-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -38,6 +38,7 @@ files:
 - ".github/workflows/examples.yml"
 - ".github/workflows/release.yml"
 - ".rspec"
+- ".superset/config.json"
 - CLAUDE.md
 - CODE_OF_CONDUCT.md
 - Changelog.md
@@ -322,7 +323,7 @@ metadata:
   homepage_uri: https://www.flippercloud.io
   source_code_uri: https://github.com/flippercloud/flipper
   bug_tracker_uri: https://github.com/flippercloud/flipper/issues
-  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.4.0
+  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.4.1
   funding_uri: https://github.com/sponsors/flippercloud
 post_install_message:
 rdoc_options: []