flipper 0.7.0.beta2 → 0.7.0.beta3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fcc306a0110366af90921368bda9c8aeffa353ca
-  data.tar.gz: a1b1808be6c648f99f14e9e033dd945a4152744a
+  metadata.gz: b952f92d9398ba28267085a3084fbc659e571f6f
+  data.tar.gz: 4e535ba61ef3e38e24f419489c305c17cbdf58e1
 SHA512:
-  metadata.gz: 16397be35aa9c521e74c15046bd2efacb8537d9460f0e4dc9ef3ca212e46d320791d0a22fd1dbacd058776feab6ea7cd91e6af7855b7c9e297bcca75342ea641
-  data.tar.gz: e70319c0460a878e2f861a637715cc749f76992d08f3ee6d17a149b05ea847a49fb665d2a77a604981dac8366e09fc3740c08a59ba35cdba027952b4fb220a7e
+  metadata.gz: 5457f2328718155eef1ff0014346179f5bec08cd594a9c6f31ccd3e02977a91089477bffee66d53438bf849c04d66b9ca73dc56e06653f8a4dbb6168e69e56c8
+  data.tar.gz: 9c7da626025b191605e70beb3b6cdefd190d124c429354b54451472e7d3ea3fb48b90218356da8843fd30955529981769b320404e2c07e7ffef92da2cf787e40

data/README.md

@@ -250,6 +250,35 @@ A good place to start when creating your own adapter is to copy one of the adapt
 
 I would also recommend setting `fail_fast = true` in your RSpec configuration as that will just give you one failure at a time to work through. It is also handy to have the shared adapter spec file open.
 
+## Instrumentation
+
+Flipper comes with automatic instrumentation. By default these work with ActiveSupport::Notifications, but only require the pieces of ActiveSupport that are needed and only do so if you actually attempt to require the instrumentation files listed below.
+
+To use the log subscriber:
+
+```ruby
+# Gemfile
+gem "activesupport"
+
+# config/initializers/flipper.rb (or wherever you want it)
+require "flipper/instrumentation/log_subscriber"
+```
+
+To use the statsd instrumentation:
+
+```ruby
+# Gemfile
+gem "activesupport"
+gem "statsd-ruby"
+
+# config/initializers/flipper.rb (or wherever you want it)
+require "flipper/instrumentation/statsd"
+Flipper::Instrumentation::StatsdSubscriber.client = Statsd.new # or whatever your statsd instance is
+```
+
+You can also do whatever you want with the instrumented events. Check out [this example](https://github.com/jnunemaker/flipper/blob/master/examples/instrumentation.rb) for more.
+
+
 ## Optimization
 
 One optimization that flipper provides is a memoizing middleware. The memoizing middleware ensures that you only make one adapter call per feature per request.

data/flipper.gemspec

@@ -4,7 +4,6 @@ require File.expand_path('../lib/flipper/version', __FILE__)
 Gem::Specification.new do |gem|
   gem.authors       = ["John Nunemaker"]
   gem.email         = ["nunemaker@gmail.com"]
-  gem.description   = %q{Feature flipper for any adapter}
   gem.summary       = %q{Feature flipper for any adapter}
   gem.homepage      = "http://jnunemaker.github.com/flipper"
 
@@ -14,4 +13,5 @@ Gem::Specification.new do |gem|
   gem.name          = "flipper"
   gem.require_paths = ["lib"]
   gem.version       = Flipper::VERSION
+  gem.license       = "MIT"
 end

data/lib/flipper/adapters/decorator.rb

@@ -3,7 +3,7 @@ require 'flipper/decorator'
 module Flipper
   module Adapters
     class Decorator < ::Flipper::Decorator
-      include Flipper::Adapter
+      include Adapter
     end
   end
 end

data/lib/flipper/adapters/instrumented.rb

@@ -20,7 +20,7 @@ module Flipper
       def initialize(adapter, options = {})
         super(adapter)
         @name = :instrumented
-        @instrumenter = options.fetch(:instrumenter, Flipper::Instrumenters::Noop)
+        @instrumenter = options.fetch(:instrumenter, Instrumenters::Noop)
       end
 
       # Public

data/lib/flipper/adapters/memory.rb

@@ -3,7 +3,7 @@ require 'set'
 module Flipper
   module Adapters
     class Memory
-      include Flipper::Adapter
+      include Adapter
 
       FeaturesKey = :flipper_features
 

data/lib/flipper/adapters/pstore.rb

@@ -0,0 +1,166 @@
+require "pstore"
+require "set"
+
+module Flipper
+  module Adapters
+    class PStore
+      include Adapter
+
+      FeaturesKey = :flipper_features
+
+      # Public: The name of the adapter.
+      attr_reader :name
+
+      # Public: The path to where the file is stored.
+      attr_reader :path
+
+      # Public
+      def initialize(path = "flipper.pstore")
+        @path = path
+        @store = ::PStore.new(path)
+        @name = :pstore
+      end
+
+      # Public: The set of known features.
+      def features
+        set_members FeaturesKey
+      end
+
+      # Public: Adds a feature to the set of known features.
+      def add(feature)
+        set_add FeaturesKey, feature.key
+        true
+      end
+
+      # Public: Removes a feature from the set of known features and clears
+      # all the values for the feature.
+      def remove(feature)
+        set_delete FeaturesKey, feature.key
+        clear(feature)
+        true
+      end
+
+      # Public: Clears all the gate values for a feature.
+      def clear(feature)
+        feature.gates.each do |gate|
+          delete key(feature, gate)
+        end
+        true
+      end
+
+      # Public
+      def get(feature)
+        result = {}
+
+        feature.gates.each do |gate|
+          result[gate.key] = case gate.data_type
+          when :boolean, :integer
+            read key(feature, gate)
+          when :set
+            set_members key(feature, gate)
+          else
+            raise "#{gate} is not supported by this adapter yet"
+          end
+        end
+
+        result
+      end
+
+      # Public
+      def enable(feature, gate, thing)
+        case gate.data_type
+        when :boolean, :integer
+          write key(feature, gate), thing.value.to_s
+        when :set
+          set_add key(feature, gate), thing.value.to_s
+        else
+          raise "#{gate} is not supported by this adapter yet"
+        end
+
+        true
+      end
+
+      # Public
+      def disable(feature, gate, thing)
+        case gate.data_type
+        when :boolean
+          clear(feature)
+        when :integer
+          write key(feature, gate), thing.value.to_s
+        when :set
+          set_delete key(feature, gate), thing.value.to_s
+        else
+          raise "#{gate} is not supported by this adapter yet"
+        end
+
+        true
+      end
+
+      # Public
+      def inspect
+        attributes = [
+          "name=#{@name.inspect}",
+          "path=#{@path.inspect}",
+          "store=#{@store}",
+        ]
+        "#<#{self.class.name}:#{object_id} #{attributes.join(', ')}>"
+      end
+
+      private
+
+      # Private
+      def key(feature, gate)
+        "#{feature.key}/#{gate.key}"
+      end
+
+      # Private
+      def read(key)
+        @store.transaction do
+          @store[key.to_s]
+        end
+      end
+
+      # Private
+      def write(key, value)
+        @store.transaction do
+          @store[key.to_s] = value.to_s
+        end
+      end
+
+      # Private
+      def delete(key)
+        @store.transaction do
+          @store.delete(key.to_s)
+        end
+      end
+
+      # Private
+      def set_add(key, value)
+        set_members(key) do |members|
+          members.add(value.to_s)
+        end
+      end
+
+      # Private
+      def set_delete(key, value)
+        set_members(key) do |members|
+          members.delete(value.to_s)
+        end
+      end
+
+      # Private
+      def set_members(key)
+        key = key.to_s
+        @store.transaction do
+          @store[key] ||= Set.new
+
+          if block_given?
+            yield @store[key]
+          else
+            @store[key]
+          end
+        end
+      end
+    end
+  end
+end

data/lib/flipper/dsl.rb

@@ -16,12 +16,12 @@ module Flipper
     # options - The Hash of options.
     #           :instrumenter - What should be used to instrument all the things.
     def initialize(adapter, options = {})
-      @instrumenter = options.fetch(:instrumenter, Flipper::Instrumenters::Noop)
+      @instrumenter = options.fetch(:instrumenter, Instrumenters::Noop)
 
-      instrumented = Flipper::Adapters::Instrumented.new(adapter, {
+      instrumented = Adapters::Instrumented.new(adapter, {
         :instrumenter => @instrumenter,
       })
-      memoized = Flipper::Adapters::Memoizable.new(instrumented)
+      memoized = Adapters::Memoizable.new(instrumented)
       @adapter = memoized
 
       @memoized_features = {}

data/lib/flipper/feature.rb

@@ -35,14 +35,14 @@ module Flipper
     def initialize(name, adapter, options = {})
       @name = name
       @key = name.to_s
-      @instrumenter = options.fetch(:instrumenter, Flipper::Instrumenters::Noop)
+      @instrumenter = options.fetch(:instrumenter, Instrumenters::Noop)
       @adapter = adapter
     end
 
     # Public: Enable this feature for something.
     #
     # Returns the result of Adapter#enable.
-    def enable(thing = Types::Boolean.new(true))
+    def enable(thing = true)
       instrument(:enable, thing) { |payload|
         adapter.add self
 
@@ -56,7 +56,7 @@ module Flipper
     # Public: Disable this feature for something.
     #
     # Returns the result of Adapter#disable.
-    def disable(thing = Types::Boolean.new(false))
+    def disable(thing = false)
       instrument(:disable, thing) { |payload|
         adapter.add self
 
@@ -110,7 +110,7 @@ module Flipper
     #
     # Returns result of enable.
     def enable_group(group)
-      enable Flipper::Types::Group.wrap(group)
+      enable Types::Group.wrap(group)
     end
 
     # Public: Enables a feature a percentage of time.
@@ -150,7 +150,7 @@ module Flipper
     #
     # Returns result of disable.
     def disable_group(group)
-      disable Flipper::Types::Group.wrap(group)
+      disable Types::Group.wrap(group)
     end
 
     # Public: Disables a feature a percentage of time.
@@ -176,10 +176,12 @@ module Flipper
     # Public: Returns state for feature (:on, :off, or :conditional).
     def state
       values = gate_values
+      boolean = gate(:boolean)
+      non_boolean_gates = gates - [boolean]
 
-      if boolean_gate.enabled?(values.boolean)
+      if values.boolean || values.percentage_of_actors == 100 || values.percentage_of_time == 100
         :on
-      elsif conditional_gates(values).any?
+      elsif non_boolean_gates.detect { |gate| gate.enabled?(values[gate.key]) }
         :conditional
       else
         :off
@@ -202,23 +204,6 @@ module Flipper
       state == :conditional
     end
 
-    # Public: Human readable description of the enabled-ness of the feature.
-    def description
-      values = gate_values
-      conditional_gates = conditional_gates(values)
-
-      if boolean_gate.enabled?(values.boolean) || !conditional_gates.any?
-        boolean_gate.description(values.boolean).capitalize
-      else
-        fragments = conditional_gates.map { |gate|
-          value = values[gate.key]
-          gate.description(value)
-        }
-
-        "Enabled for #{fragments.join(', ')}"
-      end
-    end
-
     # Public: Returns the raw gate values stored by the adapter.
     def gate_values
       GateValues.new(adapter.get(self))
@@ -274,6 +259,35 @@ module Flipper
       gate_values.percentage_of_time
     end
 
+    # Public: Get the gates that have been enabled for the feature.
+    #
+    # Returns an Array of Flipper::Gate instances.
+    def enabled_gates
+      values = gate_values
+      gates.select { |gate| gate.enabled?(values[gate.key]) }
+    end
+
+    # Public: Get the names of the enabled gates.
+    #
+    # Returns an Array of gate names.
+    def enabled_gate_names
+      enabled_gates.map(&:name)
+    end
+
+    # Public: Get the gates that have not been enabled for the feature.
+    #
+    # Returns an Array of Flipper::Gate instances.
+    def disabled_gates
+      gates - enabled_gates
+    end
+
+    # Public: Get the names of the disabled gates.
+    #
+    # Returns an Array of gate names.
+    def disabled_gate_names
+      disabled_gates.map(&:name)
+    end
+
     # Public: Returns the string representation of the feature.
     def to_s
       name.to_s
@@ -289,7 +303,7 @@ module Flipper
       attributes = [
         "name=#{name.inspect}",
         "state=#{state.inspect}",
-        "description=#{description.inspect}",
+        "enabled_gate_names=#{enabled_gate_names.inspect}",
         "adapter=#{adapter.name.inspect}",
       ]
       "#<#{self.class.name}:#{object_id} #{attributes.join(', ')}>"
@@ -328,24 +342,6 @@ module Flipper
 
     private
 
-    # Private: Get the boolean gate.
-    def boolean_gate
-      @boolean_gate ||= gate(:boolean)
-    end
-
-    # Private: Get all gates except the boolean gate.
-    def non_boolean_gates
-      @non_boolean_gates ||= gates - [boolean_gate]
-    end
-
-    # Private: Get all non boolean gates that are enabled in some way.
-    def conditional_gates(gate_values)
-      non_boolean_gates.select { |gate|
-        value = gate_values[gate.key]
-        gate.enabled?(value)
-      }
-    end
-
     # Private: Instrument a feature operation.
     def instrument(operation, thing)
       payload = {

data/lib/flipper/gate.rb

@@ -26,10 +26,6 @@ module Flipper
       raise 'Not implemented'
     end
 
-    def description(value)
-      raise 'Not implemented'
-    end
-
     # Internal: Check if a gate is open for a thing. Implemented in subclass.
     #
     # Returns true if gate open for thing, false if not.

data/lib/flipper/gates/actor.rb

@@ -15,15 +15,6 @@ module Flipper
         :set
       end
 
-      def description(value)
-        if enabled?(value)
-          actor_ids = value.to_a.sort.map { |id| id.inspect }
-          "actors (#{actor_ids.join(', ')})"
-        else
-          'disabled'
-        end
-      end
-
       def enabled?(value)
         !Typecast.to_set(value).empty?
       end

data/lib/flipper/gates/boolean.rb

@@ -15,14 +15,6 @@ module Flipper
         :boolean
       end
 
-      def description(value)
-        if enabled?(value)
-          'Enabled'
-        else
-          'Disabled'
-        end
-      end
-
       def enabled?(value)
         Typecast.to_boolean(value)
       end
@@ -35,8 +27,17 @@ module Flipper
         value
       end
 
+      def wrap(thing)
+        Types::Boolean.wrap(thing)
+      end
+
       def protects?(thing)
-        thing.is_a?(Flipper::Types::Boolean)
+        case thing
+        when Types::Boolean, TrueClass, FalseClass
+          true
+        else
+          false
+        end
       end
     end
   end

data/lib/flipper/gates/group.rb

@@ -15,15 +15,6 @@ module Flipper
         :set
       end
 
-      def description(value)
-        if enabled?(value)
-          group_names = value.to_a.sort.map { |name| name.to_sym.inspect }
-          "groups (#{group_names.join(', ')})"
-        else
-          'disabled'
-        end
-      end
-
       def enabled?(value)
         !Typecast.to_set(value).empty?
       end
@@ -47,7 +38,7 @@ module Flipper
       end
 
       def protects?(thing)
-        thing.is_a?(Flipper::Types::Group)
+        thing.is_a?(Types::Group)
       end
     end
   end

data/lib/flipper/gates/percentage_of_actors.rb

@@ -17,14 +17,6 @@ module Flipper
         :integer
       end
 
-      def description(value)
-        if enabled?(value)
-          "#{value}% of actors"
-        else
-          'disabled'
-        end
-      end
-
       def enabled?(value)
         Typecast.to_integer(value) > 0
       end
@@ -46,7 +38,7 @@ module Flipper
       end
 
       def protects?(thing)
-        thing.is_a?(Flipper::Types::PercentageOfActors)
+        thing.is_a?(Types::PercentageOfActors)
       end
     end
   end

data/lib/flipper/gates/percentage_of_time.rb

@@ -15,14 +15,6 @@ module Flipper
         :integer
       end
 
-      def description(value)
-        if enabled?(value)
-          "#{value}% of the time"
-        else
-          'disabled'
-        end
-      end
-
       def enabled?(value)
         Typecast.to_integer(value) > 0
       end

data/lib/flipper/type.rb

@@ -1,6 +1,11 @@
 module Flipper
   # Internal: Root class for all flipper types. You should never need to use this.
   class Type
+    def self.wrap(value_or_instance)
+      return value_or_instance if value_or_instance.is_a?(self)
+      new(value_or_instance)
+    end
+
     def value
       raise 'Not implemented'
     end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.7.0.beta2"
+  VERSION = "0.7.0.beta3"
 end

data/lib/flipper.rb

@@ -68,7 +68,7 @@ module Flipper
   # Raises Flipper::GroupNotRegistered if group is not registered.
   def self.group(name)
     groups_registry.get(name)
-  rescue Flipper::Registry::KeyNotFound => e
+  rescue Registry::KeyNotFound => e
     raise GroupNotRegistered, "Group #{e.key.inspect} has not been registered"
   end
 

data/spec/flipper/adapters/pstore_spec.rb

@@ -0,0 +1,13 @@
+require 'helper'
+require 'flipper/adapters/pstore'
+require 'flipper/spec/shared_adapter_specs'
+
+describe Flipper::Adapters::PStore do
+  subject { described_class.new(FlipperRoot.join("tmp", "flipper.pstore")) }
+
+  it_should_behave_like 'a flipper adapter'
+
+  it "defaults path to flipper.pstore" do
+    described_class.new.path.should eq("flipper.pstore")
+  end
+end

data/spec/flipper/feature_spec.rb

@@ -97,8 +97,13 @@ describe Flipper::Feature do
       string.should include('Flipper::Feature')
       string.should include('name=:search')
       string.should include('state=:off')
-      string.should include('description="Disabled"')
+      string.should include('enabled_gate_names=[]')
       string.should include("adapter=#{subject.adapter.name.inspect}")
+
+      subject.enable
+      string = subject.inspect
+      string.should include('state=:on')
+      string.should include('enabled_gate_names=[:boolean]')
     end
   end
 
@@ -178,21 +183,21 @@ describe Flipper::Feature do
       end
     end
 
-    context "fully off" do
+    context "percentage of time set to 100" do
       before do
-        subject.disable
+        subject.enable_percentage_of_time 100
       end
 
-      it "returns :off" do
-        subject.state.should be(:off)
+      it "returns :on" do
+        subject.state.should be(:on)
       end
 
-      it "returns false for on?" do
-        subject.on?.should be(false)
+      it "returns true for on?" do
+        subject.on?.should be(true)
       end
 
-      it "returns true for off?" do
-        subject.off?.should be(true)
+      it "returns false for off?" do
+        subject.off?.should be(false)
       end
 
       it "returns false for conditional?" do
@@ -200,59 +205,69 @@ describe Flipper::Feature do
       end
     end
 
-    context "partially on" do
+    context "percentage of actors set to 100" do
       before do
-        subject.enable Flipper::Types::PercentageOfTime.new(5)
+        subject.enable_percentage_of_actors 100
       end
 
-      it "returns :conditional" do
-        subject.state.should be(:conditional)
+      it "returns :on" do
+        subject.state.should be(:on)
       end
 
-      it "returns false for on?" do
-        subject.on?.should be(false)
+      it "returns true for on?" do
+        subject.on?.should be(true)
       end
 
       it "returns false for off?" do
         subject.off?.should be(false)
       end
 
-      it "returns true for conditional?" do
-        subject.conditional?.should be(true)
+      it "returns false for conditional?" do
+        subject.conditional?.should be(false)
       end
     end
-  end
 
-  describe "#description" do
-    context "fully on" do
+    context "fully off" do
       before do
-        subject.enable
+        subject.disable
       end
 
-      it "returns enabled" do
-        subject.description.should eq('Enabled')
+      it "returns :off" do
+        subject.state.should be(:off)
       end
-    end
 
-    context "fully off" do
-      before do
-        subject.disable
+      it "returns false for on?" do
+        subject.on?.should be(false)
+      end
+
+      it "returns true for off?" do
+        subject.off?.should be(true)
       end
 
-      it "returns disabled" do
-        subject.description.should eq('Disabled')
+      it "returns false for conditional?" do
+        subject.conditional?.should be(false)
       end
     end
 
     context "partially on" do
       before do
-        actor = Struct.new(:flipper_id).new(5)
         subject.enable Flipper::Types::PercentageOfTime.new(5)
-        subject.enable actor
       end
 
-      it "returns text" do
-        subject.description.should eq('Enabled for actors ("5"), 5% of the time')
+      it "returns :conditional" do
+        subject.state.should be(:conditional)
+      end
+
+      it "returns false for on?" do
+        subject.on?.should be(false)
+      end
+
+      it "returns false for off?" do
+        subject.off?.should be(false)
+      end
+
+      it "returns true for conditional?" do
+        subject.conditional?.should be(true)
       end
     end
   end
@@ -623,4 +638,37 @@ describe Flipper::Feature do
       end
     end
   end
+
+  describe "#enabled/disabled_gates" do
+    before do
+      subject.enable_percentage_of_time 5
+      subject.enable_percentage_of_actors 5
+    end
+
+    it "can return enabled gates" do
+      subject.enabled_gates.map(&:name).to_set.should eq(Set[
+        :percentage_of_actors,
+        :percentage_of_time,
+      ])
+
+      subject.enabled_gate_names.to_set.should eq(Set[
+        :percentage_of_actors,
+        :percentage_of_time,
+      ])
+    end
+
+    it "can return disabled gates" do
+      subject.disabled_gates.map(&:name).to_set.should eq(Set[
+        :actor,
+        :boolean,
+        :group,
+      ])
+
+      subject.disabled_gate_names.to_set.should eq(Set[
+        :actor,
+        :boolean,
+        :group,
+      ])
+    end
+  end
 end

data/spec/flipper/gates/actor_spec.rb

@@ -6,19 +6,4 @@ describe Flipper::Gates::Actor do
   subject {
     described_class.new
   }
-
-  describe "#description" do
-    context "with actors in set" do
-      it "returns text" do
-        values = Set['bacon', 'ham']
-        subject.description(values).should eq('actors ("bacon", "ham")')
-      end
-    end
-
-    context "with no actors in set" do
-      it "returns disabled" do
-        subject.description(Set.new).should eq('disabled')
-      end
-    end
-  end
 end

data/spec/flipper/gates/boolean_spec.rb

@@ -7,20 +7,6 @@ describe Flipper::Gates::Boolean do
     described_class.new
   }
 
-  describe "#description" do
-    context "for enabled" do
-      it "returns Enabled" do
-        subject.description(true).should eq('Enabled')
-      end
-    end
-
-    context "for disabled" do
-      it "returns Disabled" do
-        subject.description(false).should eq('Disabled')
-      end
-    end
-  end
-
   describe "#enabled?" do
     context "for true value" do
       it "returns true" do
@@ -48,4 +34,34 @@ describe Flipper::Gates::Boolean do
       end
     end
   end
+
+  describe "#protects?" do
+    it "returns true for boolean type" do
+      subject.protects?(Flipper::Types::Boolean.new(true)).should be(true)
+    end
+
+    it "returns true for true" do
+      subject.protects?(true).should be(true)
+    end
+
+    it "returns true for false" do
+      subject.protects?(false).should be(true)
+    end
+  end
+
+  describe "#wrap" do
+    it "returns boolean type for boolean type" do
+      subject.wrap(Flipper::Types::Boolean.new(true)).should be_instance_of(Flipper::Types::Boolean)
+    end
+
+    it "returns boolean type for true" do
+      subject.wrap(true).should be_instance_of(Flipper::Types::Boolean)
+      subject.wrap(true).value.should be(true)
+    end
+
+    it "returns boolean type for true" do
+      subject.wrap(false).should be_instance_of(Flipper::Types::Boolean)
+      subject.wrap(false).value.should be(false)
+    end
+  end
 end

data/spec/flipper/gates/group_spec.rb

@@ -7,21 +7,6 @@ describe Flipper::Gates::Group do
     described_class.new
   }
 
-  describe "#description" do
-    context "with groups in set" do
-      it "returns text" do
-        values = Set['bacon', 'ham']
-        subject.description(values).should eq('groups (:bacon, :ham)')
-      end
-    end
-
-    context "with no groups in set" do
-      it "returns disabled" do
-        subject.description(Set.new).should eq('disabled')
-      end
-    end
-  end
-
   describe "#open?" do
     context "with a group in adapter, but not registered" do
       before do

data/spec/flipper/gates/percentage_of_actors_spec.rb

@@ -7,20 +7,6 @@ describe Flipper::Gates::PercentageOfActors do
     described_class.new
   }
 
-  describe "#description" do
-    context "when enabled" do
-      it "returns text" do
-        subject.description(22).should eq('22% of actors')
-      end
-    end
-
-    context "when disabled" do
-      it "returns disabled" do
-        subject.description(0).should eq('disabled')
-      end
-    end
-  end
-
   describe "#open?" do
     context "when compared against two features" do
       let(:percentage) { 0.05 }

data/spec/flipper/gates/percentage_of_time_spec.rb

@@ -6,18 +6,4 @@ describe Flipper::Gates::PercentageOfTime do
   subject {
     described_class.new
   }
-
-  describe "#description" do
-    context "when enabled" do
-      it "returns text" do
-        subject.description(22).should eq('22% of the time')
-      end
-    end
-
-    context "when disabled" do
-      it "returns disabled" do
-        subject.description(0).should eq('disabled')
-      end
-    end
-  end
 end

data/spec/helper.rb

@@ -3,9 +3,9 @@ $:.unshift(File.expand_path('../../lib', __FILE__))
 require 'pathname'
 require 'logger'
 
-root_path = Pathname(__FILE__).dirname.join('..').expand_path
-lib_path  = root_path.join('lib')
-log_path  = root_path.join('log')
+FlipperRoot = Pathname(__FILE__).dirname.join('..').expand_path
+lib_path  = FlipperRoot.join('lib')
+log_path  = FlipperRoot.join('log')
 log_path.mkpath
 
 require 'rubygems'
@@ -15,14 +15,9 @@ Bundler.setup(:default)
 
 require 'flipper'
 
-Dir[root_path.join("spec/support/**/*.rb")].each { |f| require f }
+Dir[FlipperRoot.join("spec/support/**/*.rb")].each { |f| require f }
 
 RSpec.configure do |config|
-  config.filter_run :focus => true
-  config.alias_example_to :fit, :focused => true
-  config.alias_example_to :xit, :pending => true
-  config.run_all_when_everything_filtered = true
-
   config.before(:each) do
     Flipper.unregister_groups
   end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.7.0.beta2
+  version: 0.7.0.beta3
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-16 00:00:00.000000000 Z
+date: 2015-04-24 00:00:00.000000000 Z
 dependencies: []
-description: Feature flipper for any adapter
+description: 
 email:
 - nunemaker@gmail.com
 executables: []
@@ -42,6 +42,7 @@ files:
 - lib/flipper/adapters/memoizable.rb
 - lib/flipper/adapters/memory.rb
 - lib/flipper/adapters/operation_logger.rb
+- lib/flipper/adapters/pstore.rb
 - lib/flipper/decorator.rb
 - lib/flipper/dsl.rb
 - lib/flipper/errors.rb
@@ -81,6 +82,7 @@ files:
 - spec/flipper/adapters/memoizable_spec.rb
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/adapters/operation_logger_spec.rb
+- spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb
@@ -109,7 +111,8 @@ files:
 - spec/integration_spec.rb
 - spec/support/fake_udp_socket.rb
 homepage: http://jnunemaker.github.com/flipper
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -136,6 +139,7 @@ test_files:
 - spec/flipper/adapters/memoizable_spec.rb
 - spec/flipper/adapters/memory_spec.rb
 - spec/flipper/adapters/operation_logger_spec.rb
+- spec/flipper/adapters/pstore_spec.rb
 - spec/flipper/dsl_spec.rb
 - spec/flipper/feature_spec.rb
 - spec/flipper/gate_spec.rb