flipper 0.13.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea1b15f3ff6a07841a2a56d57df8850cb2b0d99a
-  data.tar.gz: 47a9731ed32255a3e4757953acc6cd9ef150f6fb
+  metadata.gz: 843f963e51439159d1fd4c6d27abefcbc091dd38
+  data.tar.gz: 96b4532f699e3d1dc61a399be98d2494b47b3f36
 SHA512:
-  metadata.gz: 2e30588ec41798decb4c5046989591d970ad449f4bcff410be91da49c5ae4868b6f02c3edf6409356105de13baca25d6d147bb8c24f43086bace1f374b3e4f8e
-  data.tar.gz: e905fbdd814ff3fdff84a9bc3c35d71f3850817981a27539e77dcedf23581846f08a80187577f244a0d4e87802b5c797439f436ec0b7376fba96a043cf2631a6
+  metadata.gz: 23146daa1a8eff45c01d065f00d0b101b7929ebda1635bfd2e902427ca8c13f98cd97920176d1855d3d9798e3db508c401bde42e40dd18c2960d0eb5034c9aee
+  data.tar.gz: c5943fff3072a0d9ddab4cb823270cc0c76b3f912a95f27d18053b03a73353a0bd0855437e3ab5a9f073df5d32b34d46531d65eec23619b2565ea02f9b75c6b5

data/Changelog.md

@@ -1,3 +1,7 @@
+## 0.14.0
+
+* Changed sync_interval to be seconds instead of milliseconds.
+
 ## 0.13.0
 
 ### Additions/Changes

data/lib/flipper/adapters/sync.rb

@@ -20,8 +20,8 @@ module Flipper
       # local - The local flipper adapter that should serve reads.
       # remote - The remote flipper adpater that should serve writes and update
       #          the local on an interval.
-      # interval - The number of milliseconds between syncs from remote to
-      #            local. Default value is set in IntervalSynchronizer.
+      # interval - The Float or Integer number of seconds between syncs from
+      # remote to local. Default value is set in IntervalSynchronizer.
       def initialize(local, remote, options = {})
         @name = :sync
         @local = local

data/lib/flipper/adapters/sync/interval_synchronizer.rb

@@ -2,18 +2,18 @@ module Flipper
   module Adapters
     class Sync
       # Internal: Wraps a Synchronizer instance and only invokes it every
-      # N milliseconds.
+      # N seconds.
       class IntervalSynchronizer
-        # Private: Number of milliseconds between syncs (default: 10 seconds).
-        DEFAULT_INTERVAL_MS = 10_000
+        # Private: Number of seconds between syncs (default: 10).
+        DEFAULT_INTERVAL = 10
 
         # Private
         def self.now_ms
           Process.clock_gettime(Process::CLOCK_MONOTONIC, :millisecond)
         end
 
-        # Public: The number of milliseconds between invocations of the
-        # wrapped synchronizer.
+        # Public: The Float or Integer number of seconds between invocations of
+        # the wrapped synchronizer.
         attr_reader :interval
 
         # Public: Initializes a new interval synchronizer.
@@ -23,7 +23,7 @@ module Flipper
         #            the wrapped synchronizer.
         def initialize(synchronizer, interval: nil)
           @synchronizer = synchronizer
-          @interval = interval || DEFAULT_INTERVAL_MS
+          @interval = interval || DEFAULT_INTERVAL
           # TODO: add jitter to this so all processes booting at the same time
           # don't phone home at the same time.
           @last_sync_at = 0
@@ -41,7 +41,7 @@ module Flipper
         private
 
         def time_to_sync?
-          (now_ms - @last_sync_at) >= @interval
+          ((now_ms - @last_sync_at) / 1_000.0) >= @interval
         end
 
         def now_ms

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.13.0'.freeze
+  VERSION = '0.14.0'.freeze
 end

data/spec/flipper/adapters/sync/interval_synchronizer_spec.rb

@@ -14,20 +14,20 @@ RSpec.describe Flipper::Adapters::Sync::IntervalSynchronizer do
     expect(events.size).to be(1)
   end
 
-  it "only invokes wrapped synchronizer every interval milliseconds" do
+  it "only invokes wrapped synchronizer every interval seconds" do
     now = described_class.now_ms
     subject.call
     events.clear
 
     # move time to one millisecond less than last sync + interval
     1.upto(interval) do |i|
-      allow(described_class).to receive(:now_ms).and_return(now + i - 1)
+      allow(described_class).to receive(:now_ms).and_return(now + (i * 1_000) - 1)
       subject.call
     end
     expect(events.size).to be(0)
 
-    # move time to last sync + interval
-    allow(described_class).to receive(:now_ms).and_return(now + interval)
+    # move time to last sync + interval in milliseconds
+    allow(described_class).to receive(:now_ms).and_return(now + (interval * 1_000))
     subject.call
     expect(events.size).to be(1)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.14.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-04 00:00:00.000000000 Z
+date: 2018-03-27 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper is the act of enabling/disabling features in your application,
   ideally without re-deploying or changing anything in your code base. Flipper makes