flipper 0.11.0.beta7 → 0.11.0.beta8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 258c0cfa4877a2bea9e7927f5d39ed1339c3f698
-  data.tar.gz: 4402f1aa545f09f2bf0dd97937d6e7564ec6d008
+  metadata.gz: 690b416d2f41272c1756a810581d20f5382dd73a
+  data.tar.gz: 7db56f6d59863e7b896442b89a8caff91b1ed502
 SHA512:
-  metadata.gz: 7596ed84b459acc7b052a11e7a86e5be07d4bc52b083e31dcd14749b56e026f7a6ee0a6b3aac50fdc61950afcc764bdf64834bcecd4668baadc62e06a60d248b
-  data.tar.gz: 18a608871470cd7ae57db9b4dccf661e9ea8fe68e55efced9fea8cec26b9374a9c528b324516da9f263cad8cd4da28d697501f321d8f9a2b0280a351e1ed057c
+  metadata.gz: 68d9eeede5def4ad36cb7ffae54fc3c99203548b0942b6e95dc0f968865e9990d234fae1634df5bf3268d7ca181d279766b1022cdd8b983e6b80137202b5dbc0
+  data.tar.gz: cd61f0435c5265ef1bf126161940f6d87ccbeed1c63b60070903e552983addf4a5599f9c09eaa70de468f2921e1cdb42c54c1d031201a4b53f1f311528d60353

data/.rubocop_todo.yml

@@ -151,6 +151,7 @@ Style/FileName:
   Exclude:
     - 'lib/flipper-active_record.rb'
     - 'lib/flipper-api.rb'
+    - 'lib/flipper-cache_store.rb'
     - 'lib/flipper-cloud.rb'
     - 'lib/flipper-dalli.rb'
     - 'lib/flipper-mongo.rb'

data/Changelog.md

@@ -2,7 +2,7 @@
 
 ### Backwards Compatibility Breaks
 
-* * Set flipper from env for API and UI (https://github.com/jnunemaker/flipper/pull/223 and https://github.com/jnunemaker/flipper/pull/229). It is documented, but now the memoizing middleware requires that the SetupEnv middleware is used first.
+* Set flipper from env for API and UI (https://github.com/jnunemaker/flipper/pull/223 and https://github.com/jnunemaker/flipper/pull/229). It is documented, but now the memoizing middleware requires that the SetupEnv middleware is used first.
 * Drop support for Ruby 2.0 as it is end of lined (https://github.com/jnunemaker/flipper/commit/c2c81ed89938155ce91acb5173ac38580f630e3d).
 * Allow unregistered groups (https://github.com/jnunemaker/flipper/pull/244). Only break in compatibility is that previously unregistered groups could not be enabled and now they can be.
 

data/Gemfile

@@ -8,7 +8,6 @@ end
 
 gem 'pry'
 gem 'rake', '~> 10.4.2'
-gem 'metriks', '~> 0.9.9'
 gem 'shotgun', '~> 0.9'
 gem 'statsd-ruby', '~> 1.2.1'
 gem 'rspec', '~> 3.0'

data/README.md

@@ -77,7 +77,7 @@ Of course there are more [examples for you to peruse](examples/). You could also
 
 * [Gates](docs/Gates.md) - Boolean, Groups, Actors, % of Actors, and % of Time
 * [Adapters](docs/Adapters.md) - Mongo, Redis, Cassandra, Active Record...
-* [Instrumentation](docs/Instrumentation.md) - ActiveSupport::Notifications, Statsd and Metriks
+* [Instrumentation](docs/Instrumentation.md) - ActiveSupport::Notifications and Statsd
 * [Optimization](docs/Optimization.md) - Memoization middleware and Cache adapters
 * [Web Interface](docs/ui/README.md) - Point and click...
 * [API](docs/api/README.md) - HTTP API interface

data/docs/Gates.md

@@ -15,23 +15,27 @@ flipper[:stats].enabled? # check
 
 ## 2. Group
 
-Turn on feature based on value of block. Super flexible way to turn on a feature for multiple things (users, people, accounts, etc.)
+Turn on feature based on the return value of block. Super flexible way to turn on a feature for multiple things (users, people, accounts, etc.) as long as the thing returns true when passed to the block. 
 
 ```ruby
+# this registers a group
 Flipper.register(:admins) do |actor|
   actor.respond_to?(:admin?) && actor.admin?
 end
 
 flipper = Flipper.new(adapter)
 
-flipper[:stats].enable flipper.group(:admins) # turn on the stats feature for admins
+flipper[:stats].enable flipper.group(:admins) # This registers a stats feature and turns it on for admins (which is anything that returns true from the registered block).
 flipper[:stats].disable flipper.group(:admins) # turn off the stats feature for admins
 
 person = Person.find(params[:id])
 flipper[:stats].enabled? person # check if enabled, returns true if person.admin? is true
 
-# you can also use shortcut methods
+# you can also use shortcut methods. This also registers a stats feature and turns it on for admins.
 flipper.enable_group :stats, :admins
+person = Person.find(params[:id])
+flipper[:stats].enabled? person # same as above. check if enabled, returns true if person.admin? is true
+
 flipper.disable_group :stats, :admins
 flipper[:stats].enable_group :admins
 flipper[:stats].disable_group :admins
@@ -50,7 +54,7 @@ end
 flipper[:stats].enable flipper.group(:admins)
 ```
 
-- The above enables the stats feature to any object that returns true from the :admins proc.
+- The above enables the stats feature to any object that returns true from the `:admins` proc.
 
 ```
 person = Person.find(params[:id])
@@ -61,6 +65,16 @@ When the `person` object is passed to the `enabled?` method, it is then passed i
 
 There is no requirement that the thing yielded to the block be a user model or whatever. It can be anything you want, therefore it is a good idea to check that the thing passed into the group block actually responds to what you are trying to do in the `register` proc.
 
+In your application code, you can do something like this now:
+
+```
+if flipper[:stats].enabled?(some_admin)
+  # do thing...
+else
+  raise "Your are not authorized to view this page"
+end 
+```
+
 ## 3. Individual Actor
 
 Turn feature on for individual thing. Think enable feature for someone to test or for a buddy. The only requirement for an individual actor is that it must respond to `flipper_id`.
@@ -137,13 +151,14 @@ flipper = Flipper.new(adapter)
 # get percentage of time instance set to 5
 percentage = flipper.time(5)
 
-# turn on logging for 5 percent of the time
-# could be on during one request and off the next
+# Register a feature called logging and turn it on for 5 percent of the time.
+# This could be on during one request and off the next
 # could even be on first time in request and off second time
 flipper[:logging].enable percentage
+flipper[:logging].enabled? # this will return true 5% of the time.
 
 # you can also use shortcut methods
-flipper.enable_percentage_of_time :search, 5
+flipper.enable_percentage_of_time :search, 5 # registers a feature called "enable_percentage_of_time" and enables it 5% of the time
 flipper.disable_percentage_of_time :search # sets to 0
 flipper[:search].enable_percentage_of_time 5
 flipper[:search].disable_percentage_of_time # sets to 0

data/docs/Optimization.md

@@ -2,43 +2,34 @@
 
 ## Memoizing Middleware
 
-One optimization that flipper provides is a memoizing middleware. The memoizing middleware ensures that you only make one adapter call per feature per request.
+One optimization that flipper provides is a memoizing middleware. The memoizing middleware ensures that you only make one adapter call per feature per request. This means if you check the same feature over and over, it will only make one Mongo, Redis, or whatever call per feature for the length of the request.
 
-This means if you check the same feature over and over, it will only make one Mongo, Redis, or whatever call per feature for the length of the request.
-
-You can use the middleware from a Rails initializer like so:
+You can use the middleware like so for Rails:
 
 ```ruby
-# create flipper dsl instance, see above Usage for more details
-flipper = Flipper.new(...)
+# setup default instance (perhaps in config/initializer/flipper.rb)
+Flipper.configure do |config|
+  config.default do
+    Flipper.new(...)
+  end
+end
 
-require 'flipper/middleware/setup_env'
+# This assumes you setup a default flipper instance using configure.
 require 'flipper/middleware/memoizer'
-config.middleware.use Flipper::Middleware::SetupEnv, flipper
 config.middleware.use Flipper::Middleware::Memoizer
 ```
 
-If you set your flipper instance up in an initializer, you can pass a block to the middleware and it will lazily load the instance the first time the middleware is invoked.
+**Note**: Be sure that the middleware is high enough up in your stack that all feature checks are wrapped.
 
-```ruby
-# config/initializers/flipper.rb
-module MyRailsApp
-  def self.flipper
-    @flipper ||= Flipper.new(...)
-  end
-end
+**Also Note**: If you haven't setup a default instance, you can pass the instance to `SetupEnv` as `Memoizer` uses whatever is setup in the `env`:
 
-# config/application.rb
+```ruby
 require 'flipper/middleware/setup_env'
 require 'flipper/middleware/memoizer'
-config.middleware.use Flipper::Middleware::SetupEnv, lambda {
-  MyRailsApp.flipper
-}
+config.middleware.use Flipper::Middleware::SetupEnv, -> { Flipper.new(...) }
 config.middleware.use Flipper::Middleware::Memoizer
 ```
 
-**Note**: Be sure that the middleware is high enough up in your stack that all feature checks are wrapped.
-
 ### Options
 
 The Memoizer middleware also supports a few options. Use either `preload` or `preload_all`, not both.
@@ -102,7 +93,7 @@ Rails applications can cache Flipper calls in any [ActiveSupport::Cache::Store](
 
 Add this line to your application's Gemfile:
 
-    gem 'flipper-cache-store'
+    gem 'flipper-cache_store'
 
 And then execute:
 
@@ -110,7 +101,7 @@ And then execute:
 
 Or install it yourself with:
 
-    $ gem install flipper-cache-store
+    $ gem install flipper-cache_store
 
 Example using the CacheStore adapter with ActiveSupport's [MemoryStore](http://api.rubyonrails.org/classes/ActiveSupport/Cache/MemoryStore.html), Flipper's [Memory adapter](https://github.com/jnunemaker/flipper/blob/master/lib/flipper/adapters/memory.rb), and a TTL of 5 minutes.
 

data/docs/http/README.md

@@ -9,12 +9,12 @@ Initialize the HTTP adapter with a configuration Hash.
 require 'flipper/adapters/http'
 
 configuration = {
-  uri: URI('http://app.com/mount-point'), # required
+  url: 'http://app.com/mount-point', # required
   headers: { 'X-Custom-Header' => 'foo' },
   basic_auth_username: 'user123',
   basic_auth_password: 'password123'
-  read_timeout: 75,
-  open_timeout: 70
+  read_timeout: 5,
+  open_timeout: 2,
 }
 
 adapter = Flipper::Adapters::Http.new(configuration)
@@ -22,7 +22,7 @@ flipper = Flipper.new(adapter)
 ```
 
 **Required keys**:
-* uri: [URI](https://docs.ruby-lang.org/en/2.3.0/URI.html) object referencing url where [Flipper Api](https://github.com/jnunemaker/flipper/blob/master/docs/api/README.md) is mounted.
+* url: String url where [Flipper Api](https://github.com/jnunemaker/flipper/blob/master/docs/api/README.md) is mounted.
 
 **Optional keys**:
 *These will affect every request the adapter makes.  For example, send basic auth credentials with every request.*

data/lib/flipper.rb

@@ -31,6 +31,8 @@ module Flipper
 
   # Public: Sets Flipper::Configuration instance.
   def configuration=(configuration)
+    # need to reset flipper instance if configuration changes
+    Thread.current[:flipper_instance] = nil
     @configuration = configuration
   end
 
@@ -55,7 +57,7 @@ module Flipper
                  :enable_percentage_of_time, :disable_percentage_of_time,
                  :time, :percentage_of_time,
                  :features, :feature, :[], :preload, :preload_all,
-                 :add, :remove, :import
+                 :adapter, :add, :remove, :import
 
   # Public: Use this to register a group by name.
   #

data/lib/flipper/adapters/http.rb

@@ -13,7 +13,7 @@ module Flipper
       attr_reader :name
 
       def initialize(options = {})
-        @client = Client.new(uri: options.fetch(:uri),
+        @client = Client.new(url: options.fetch(:url),
                              headers: options[:headers],
                              basic_auth_username: options[:basic_auth_username],
                              basic_auth_password: options[:basic_auth_password],

data/lib/flipper/adapters/http/client.rb

@@ -15,7 +15,7 @@ module Flipper
         HTTPS_SCHEME = "https".freeze
 
         def initialize(options = {})
-          @uri = URI(options.fetch(:uri))
+          @uri = URI(options.fetch(:url))
           @headers = DEFAULT_HEADERS.merge(options[:headers] || {})
           @basic_auth_username = options[:basic_auth_username]
           @basic_auth_password = options[:basic_auth_password]

data/lib/flipper/middleware/memoizer.rb

@@ -3,9 +3,10 @@ require 'rack/body_proxy'
 module Flipper
   module Middleware
     class Memoizer
-      # Public: Initializes an instance of the Memoizer middleware. The flipper
-      # instance must be setup in the env of the request. You can do this by
-      # using the Flipper::Middleware::SetupEnv middleware.
+      # Public: Initializes an instance of the Memoizer middleware. Flipper must
+      # be configured with a default instance or the flipper instance must be
+      # setup in the env of the request. You can do this by using the
+      # Flipper::Middleware::SetupEnv middleware.
       #
       # app - The app this middleware is included in.
       # opts - The Hash of options.
@@ -49,7 +50,8 @@ module Flipper
       end
 
       def memoized_call(env)
-        flipper = env.fetch(@env_key)
+        reset_on_body_close = false
+        flipper = env.fetch(@env_key) { Flipper }
         original = flipper.adapter.memoizing?
         flipper.adapter.memoize = true
 
@@ -63,10 +65,10 @@ module Flipper
         response[2] = Rack::BodyProxy.new(response[2]) do
           flipper.adapter.memoize = original
         end
+        reset_on_body_close = true
         response
-      rescue
-        flipper.adapter.memoize = original
-        raise
+      ensure
+        flipper.adapter.memoize = original if flipper && !reset_on_body_close
       end
     end
   end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.11.0.beta7'.freeze
+  VERSION = '0.11.0.beta8'.freeze
 end

data/spec/flipper/adapters/http_spec.rb

@@ -9,7 +9,7 @@ FLIPPER_SPEC_API_PORT = ENV.fetch('FLIPPER_SPEC_API_PORT', 9001).to_i
 RSpec.describe Flipper::Adapters::Http do
   context 'adapter' do
     subject do
-      described_class.new(uri: URI("http://localhost:#{FLIPPER_SPEC_API_PORT}"))
+      described_class.new(url: "http://localhost:#{FLIPPER_SPEC_API_PORT}")
     end
 
     before :all do
@@ -66,7 +66,7 @@ RSpec.describe Flipper::Adapters::Http do
       .with(headers: headers)
       .to_return(status: 404, body: "", headers: {})
 
-    adapter = described_class.new(uri: URI('http://app.com/flipper'))
+    adapter = described_class.new(url: 'http://app.com/flipper')
     adapter.get(flipper[:feature_panel])
   end
 
@@ -75,7 +75,7 @@ RSpec.describe Flipper::Adapters::Http do
       stub_request(:get, "http://app.com/flipper/features/feature_panel")
         .to_return(status: 503, body: "", headers: {})
 
-      adapter = described_class.new(uri: URI('http://app.com/flipper'))
+      adapter = described_class.new(url: 'http://app.com/flipper')
       expect do
         adapter.get(flipper[:feature_panel])
       end.to raise_error(Flipper::Adapters::Http::Error)
@@ -87,7 +87,7 @@ RSpec.describe Flipper::Adapters::Http do
       stub_request(:get, "http://app.com/flipper/features?keys=feature_panel")
         .to_return(status: 503, body: "", headers: {})
 
-      adapter = described_class.new(uri: URI('http://app.com/flipper'))
+      adapter = described_class.new(url: 'http://app.com/flipper')
       expect do
         adapter.get_multi([flipper[:feature_panel]])
       end.to raise_error(Flipper::Adapters::Http::Error)
@@ -99,7 +99,7 @@ RSpec.describe Flipper::Adapters::Http do
       stub_request(:get, "http://app.com/flipper/features")
         .to_return(status: 503, body: "", headers: {})
 
-      adapter = described_class.new(uri: URI('http://app.com/flipper'))
+      adapter = described_class.new(url: 'http://app.com/flipper')
       expect do
         adapter.get_all
       end.to raise_error(Flipper::Adapters::Http::Error)
@@ -111,7 +111,7 @@ RSpec.describe Flipper::Adapters::Http do
       stub_request(:get, "http://app.com/flipper/features")
         .to_return(status: 503, body: "", headers: {})
 
-      adapter = described_class.new(uri: URI('http://app.com/flipper'))
+      adapter = described_class.new(url: 'http://app.com/flipper')
       expect do
         adapter.features
       end.to raise_error(Flipper::Adapters::Http::Error)
@@ -122,7 +122,7 @@ RSpec.describe Flipper::Adapters::Http do
     let(:debug_output) { object_double($stderr) }
     let(:options) do
       {
-        uri: URI('http://app.com/mount-point'),
+        url: 'http://app.com/mount-point',
         headers: { 'X-Custom-Header' => 'foo' },
         basic_auth_username: 'username',
         basic_auth_password: 'password',

data/spec/flipper/middleware/memoizer_spec.rb

@@ -254,6 +254,58 @@ RSpec.describe Flipper::Middleware::Memoizer do
     include_examples 'flipper middleware'
   end
 
+  context 'with Flipper setup in env' do
+    it 'caches getting a feature for duration of request' do
+      Flipper.configure do |config|
+        config.default do
+          memory = Flipper::Adapters::Memory.new
+          logged_adapter = Flipper::Adapters::OperationLogger.new(memory)
+          Flipper.new(logged_adapter)
+        end
+      end
+      Flipper.enable(:stats)
+      Flipper.adapter.reset # clear the log of operations
+
+      app = lambda do |_env|
+        Flipper.enabled?(:stats)
+        Flipper.enabled?(:stats)
+        Flipper.enabled?(:stats)
+        [200, {}, []]
+      end
+
+      middleware = described_class.new(app)
+      middleware.call('flipper' => Flipper)
+
+      expect(Flipper.adapter.count(:get)).to be(1)
+    end
+  end
+
+  context 'defaults to Flipper' do
+    it 'caches getting a feature for duration of request' do
+      Flipper.configure do |config|
+        config.default do
+          memory_adapter = Flipper::Adapters::Memory.new
+          logged_adapter = Flipper::Adapters::OperationLogger.new(memory_adapter)
+          Flipper.new(logged_adapter)
+        end
+      end
+      Flipper.enable(:stats)
+      Flipper.adapter.reset # clear the log of operations
+
+      app = lambda do |_env|
+        Flipper.enabled?(:stats)
+        Flipper.enabled?(:stats)
+        Flipper.enabled?(:stats)
+        [200, {}, []]
+      end
+
+      middleware = described_class.new(app)
+      middleware.call({})
+
+      expect(Flipper.adapter.count(:get)).to be(1)
+    end
+  end
+
   context 'with preload_all and unless option' do
     let(:app) do
       # ensure scoped for builder block, annoying...

data/spec/flipper_spec.rb

@@ -39,6 +39,19 @@ RSpec.describe Flipper do
       expect(described_class.instance).to be(instance)
       expect(described_class.instance).to be(described_class.instance) # memoized
     end
+
+    it 'is reset when configuration is changed' do
+      described_class.configure do |config|
+        config.default { described_class.new(Flipper::Adapters::Memory.new) }
+      end
+      original_instance = described_class.instance
+
+      new_config = Flipper::Configuration.new
+      new_config.default { described_class.new(Flipper::Adapters::Memory.new) }
+      described_class.configuration = new_config
+
+      expect(described_class.instance).not_to be(original_instance)
+    end
   end
 
   describe "delegation to instance" do
@@ -176,6 +189,10 @@ RSpec.describe Flipper do
       described_class.import(other)
       expect(described_class.enabled?(:search)).to be(true)
     end
+
+    it 'delegates adapter to instance' do
+      expect(described_class.adapter).to eq(described_class.instance.adapter)
+    end
   end
 
   describe '.register' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.11.0.beta7
+  version: 0.11.0.beta8
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-26 00:00:00.000000000 Z
+date: 2017-10-28 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper is the act of enabling/disabling features in your application,
   ideally without re-deploying or changing anything in your code base. Flipper makes
@@ -52,7 +52,6 @@ files:
 - examples/percentage_of_actors_enabled_check.rb
 - examples/percentage_of_actors_group.rb
 - examples/percentage_of_time.rb
-- flipper-cache-store.gemspec
 - flipper.gemspec
 - lib/flipper.rb
 - lib/flipper/actor.rb
@@ -79,8 +78,6 @@ files:
 - lib/flipper/gates/percentage_of_actors.rb
 - lib/flipper/gates/percentage_of_time.rb
 - lib/flipper/instrumentation/log_subscriber.rb
-- lib/flipper/instrumentation/metriks.rb
-- lib/flipper/instrumentation/metriks_subscriber.rb
 - lib/flipper/instrumentation/statsd.rb
 - lib/flipper/instrumentation/statsd_subscriber.rb
 - lib/flipper/instrumentation/subscriber.rb
@@ -122,7 +119,6 @@ files:
 - spec/flipper/gates/percentage_of_actors_spec.rb
 - spec/flipper/gates/percentage_of_time_spec.rb
 - spec/flipper/instrumentation/log_subscriber_spec.rb
-- spec/flipper/instrumentation/metriks_subscriber_spec.rb
 - spec/flipper/instrumentation/statsd_subscriber_spec.rb
 - spec/flipper/instrumenters/memory_spec.rb
 - spec/flipper/instrumenters/noop_spec.rb
@@ -192,7 +188,6 @@ test_files:
 - spec/flipper/gates/percentage_of_actors_spec.rb
 - spec/flipper/gates/percentage_of_time_spec.rb
 - spec/flipper/instrumentation/log_subscriber_spec.rb
-- spec/flipper/instrumentation/metriks_subscriber_spec.rb
 - spec/flipper/instrumentation/statsd_subscriber_spec.rb
 - spec/flipper/instrumenters/memory_spec.rb
 - spec/flipper/instrumenters/noop_spec.rb

data/flipper-cache-store.gemspec

@@ -1,24 +0,0 @@
-# -*- encoding: utf-8 -*-
-require File.expand_path('../lib/flipper/version', __FILE__)
-
-flipper_cache_store_files = lambda do |file|
-  file =~ /cache_store/
-end
-
-Gem::Specification.new do |gem|
-  gem.authors       = ['John Nunemaker']
-  gem.email         = ['nunemaker@gmail.com']
-  gem.summary       = 'ActiveSupport::Cache::Store adapter for Flipper'
-  gem.description   = 'ActiveSupport::Cache::Store adapter for Flipper'
-  gem.license       = 'MIT'
-  gem.homepage      = 'https://github.com/jnunemaker/flipper'
-
-  gem.files         = `git ls-files`.split("\n").select(&flipper_cache_store_files) + ['lib/flipper/version.rb']
-  gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n").select(&flipper_cache_store_files)
-  gem.name          = 'flipper-cache-store'
-  gem.require_paths = ['lib']
-  gem.version       = Flipper::VERSION
-
-  gem.add_dependency 'flipper', "~> #{Flipper::VERSION}"
-  gem.add_dependency 'activesupport', '>= 3.2', '< 6'
-end

data/lib/flipper/instrumentation/metriks.rb

@@ -1,6 +0,0 @@
-require 'securerandom'
-require 'active_support/notifications'
-require 'flipper/instrumentation/metriks_subscriber'
-
-ActiveSupport::Notifications.subscribe /\.flipper$/,
-                                       Flipper::Instrumentation::MetriksSubscriber

data/lib/flipper/instrumentation/metriks_subscriber.rb

@@ -1,20 +0,0 @@
-# Note: You should never need to require this file directly if you are using
-# ActiveSupport::Notifications. Instead, you should require the metriks file
-# that lives in the same directory as this file. The benefit is that it
-# subscribes to the correct events and does everything for your.
-require 'flipper/instrumentation/subscriber'
-require 'metriks'
-
-module Flipper
-  module Instrumentation
-    class MetriksSubscriber < Subscriber
-      def update_timer(metric)
-        Metriks.timer(metric).update(@duration)
-      end
-
-      def update_counter(metric)
-        Metriks.meter(metric).mark
-      end
-    end
-  end
-end

data/spec/flipper/instrumentation/metriks_subscriber_spec.rb

@@ -1,52 +0,0 @@
-require 'helper'
-require 'flipper/adapters/memory'
-require 'flipper/instrumentation/metriks'
-
-RSpec.describe Flipper::Instrumentation::MetriksSubscriber do
-  let(:adapter) do
-    memory = Flipper::Adapters::Memory.new
-    Flipper::Adapters::Instrumented.new(memory, instrumenter: ActiveSupport::Notifications)
-  end
-  let(:flipper) do
-    Flipper.new(adapter, instrumenter: ActiveSupport::Notifications)
-  end
-
-  let(:user) { user = Flipper::Actor.new('1') }
-
-  before do
-    Metriks::Registry.default.clear
-  end
-
-  context 'for enabled feature' do
-    it 'updates feature metrics when calls happen' do
-      flipper[:stats].enable(user)
-      expect(Metriks.timer('flipper.feature_operation.enable').count).to be(1)
-
-      flipper[:stats].enabled?(user)
-      expect(Metriks.timer('flipper.feature_operation.enabled').count).to be(1)
-      expect(Metriks.meter('flipper.feature.stats.enabled').count).to be(1)
-    end
-  end
-
-  context 'for disabled feature' do
-    it 'updates feature metrics when calls happen' do
-      flipper[:stats].disable(user)
-      expect(Metriks.timer('flipper.feature_operation.disable').count).to be(1)
-
-      flipper[:stats].enabled?(user)
-      expect(Metriks.timer('flipper.feature_operation.enabled').count).to be(1)
-      expect(Metriks.meter('flipper.feature.stats.disabled').count).to be(1)
-    end
-  end
-
-  it 'updates adapter metrics when calls happen' do
-    flipper[:stats].enable(user)
-    expect(Metriks.timer('flipper.adapter.memory.enable').count).to be(1)
-
-    flipper[:stats].enabled?(user)
-    expect(Metriks.timer('flipper.adapter.memory.get').count).to be(1)
-
-    flipper[:stats].disable(user)
-    expect(Metriks.timer('flipper.adapter.memory.disable').count).to be(1)
-  end
-end