flipper 0.11.0.beta4 → 0.11.0.beta5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: baf85e722be59174189c5871316c40cb1109c507
-  data.tar.gz: a05626a7197b77e0ef609a21233d24aeac5d639d
+  metadata.gz: 0d6d3fb5a81f8e36791a48a6475dfdbfc56ba65e
+  data.tar.gz: 82e678db59d539f2230fdc585511e6116495f682
 SHA512:
-  metadata.gz: 0b0f2bbae8bc3a80afa52ee58563cbc5e284a9c0093268e535dd6b7f6cd67b9868690eae86d2b9a93efc01e5f0d4b6f23b2667ecd688f4fc35fcd4d121ab96a2
-  data.tar.gz: 785f3114118eaa592f7c012319fcdacd34d0bb21ca342ca2ba197a622ab32f6de1808df4a3faf9a846b0b47b1b0e881532f6372e5ac1576d77e6742267dc2406
+  metadata.gz: d986d350d0f87bfb6e36db9ffd347fb69e79bbae6656df0266b2b58186b8d794032fc3e08f9f3572de33dc32c09e33d1b3429ca5c787531c1259cd6f90f0b8b5
+  data.tar.gz: 9defcfe3b411db0252793d35a96cffb1979a8d42b12f533a3ed15f37e7e0fa2afe25262eb3353ea4a58be0d82d6d927e242a6b1325fe184fda3ad7865fdc35af

data/docs/Gates.md

@@ -92,13 +92,13 @@ The one exception to this rule is if you have globally unique `flipper_ids`, suc
 ```ruby
 class User
   def flipper_id
-    "User:#{id}"
+    "User;#{id}"
   end
 end
 
 class Group
   def flipper_id
-    "Group:#{id}"
+    "Group;#{id}"
   end
 end
 ```

data/docs/api/README.md

@@ -502,7 +502,7 @@ Successful disabling of the group will return a 200 HTTP status and the feature
 **Request**
 
 ```
-curl -X POST -d "flipper_id=User:1" http://example.com/flipper/api/features/reports/actors
+curl -X POST -d "flipper_id=User;1" http://example.com/flipper/api/features/reports/actors
 ```
 
 **Response**
@@ -557,7 +557,7 @@ Successful enabling of the actor will return a 200 HTTP status and the feature o
 **Request**
 
 ```
-curl -X DELETE -d "flipper_id=User:1" http://example.com/flipper/api/features/reports/actors
+curl -X DELETE -d "flipper_id=User;1" http://example.com/flipper/api/features/reports/actors
 ```
 
 **Response**

data/docs/http/README.md

@@ -32,3 +32,4 @@ flipper = Flipper.new(adapter)
 * basic_auth_password: Basic Auth password.
 * read_timeout: [number in seconds](https://docs.ruby-lang.org/en/2.3.0/Net/HTTP.html#attribute-i-read_timeout).
 * open_timeout: [number in seconds](https://docs.ruby-lang.org/en/2.3.0/Net/HTTP.html#attribute-i-open_timeout).
+* debug_output: Set an output stream for debugging (e.g. `debug_output: $stderr`). The output stream is passed on to [Net::HTTP#set_debug_output](https://ruby-doc.org/stdlib-2.4.1/libdoc/net/http/rdoc/Net/HTTP.html#method-i-set_debug_output).

data/examples/group_dynamic_lookup.rb

@@ -9,7 +9,7 @@ stats = flipper[:stats]
 
 # Register group
 Flipper.register(:enabled_team_member) do |actor, context|
-  combos = context.actors_value.map { |flipper_id| flipper_id.split(":", 2) }
+  combos = context.actors_value.map { |flipper_id| flipper_id.split(";", 2) }
   team_names = combos.select { |class_name, id| class_name == "Team" }.map { |class_name, id| id }
   teams = team_names.map { |name| Team.find(name) }
   teams.any? { |team| team.member?(actor) }
@@ -24,7 +24,7 @@ class User
   end
 
   def flipper_id
-    "User:#{@id}"
+    "User;#{@id}"
   end
 end
 

data/examples/percentage_of_actors_group.rb

@@ -21,7 +21,7 @@ class User
 
   # Must respond to flipper_id
   def flipper_id
-    "User:#{@id}"
+    "User;#{@id}"
   end
 end
 

data/lib/flipper/adapters/http.rb

@@ -18,7 +18,8 @@ module Flipper
                              basic_auth_username: options[:basic_auth_username],
                              basic_auth_password: options[:basic_auth_password],
                              read_timeout: options[:read_timeout],
-                             open_timeout: options[:open_timeout])
+                             open_timeout: options[:open_timeout],
+                             debug_output: options[:debug_output])
         @name = :http
       end
 

data/lib/flipper/adapters/http/client.rb

@@ -21,6 +21,7 @@ module Flipper
           @basic_auth_password = options[:basic_auth_password]
           @read_timeout = options[:read_timeout]
           @open_timeout = options[:open_timeout]
+          @debug_output = options[:debug_output]
         end
 
         def get(path)
@@ -56,6 +57,7 @@ module Flipper
           http = Net::HTTP.new(uri.host, uri.port)
           http.read_timeout = @read_timeout if @read_timeout
           http.open_timeout = @open_timeout if @open_timeout
+          http.set_debug_output(@debug_output) if @debug_output
 
           if uri.scheme == HTTPS_SCHEME
             http.use_ssl = true

data/lib/flipper/middleware/memoizer.rb

@@ -29,6 +29,7 @@ module Flipper
 
         @app = app
         @opts = opts
+        @env_key = opts.fetch(:env_key, 'flipper')
       end
 
       def call(env)
@@ -48,7 +49,7 @@ module Flipper
       end
 
       def memoized_call(env)
-        flipper = env.fetch('flipper')
+        flipper = env.fetch(@env_key)
         original = flipper.adapter.memoizing?
         flipper.adapter.memoize = true
 

data/lib/flipper/middleware/setup_env.rb

@@ -19,8 +19,9 @@ module Flipper
       #   # using with a block that yields a flipper instance
       #   use Flipper::Middleware::SetEnv, lambda { Flipper.new(...) }
       #
-      def initialize(app, flipper_or_block)
+      def initialize(app, flipper_or_block, options = {})
         @app = app
+        @env_key = options.fetch(:env_key, 'flipper')
 
         if flipper_or_block.respond_to?(:call)
           @flipper_block = flipper_or_block
@@ -30,7 +31,7 @@ module Flipper
       end
 
       def call(env)
-        env['flipper'.freeze] ||= flipper
+        env[@env_key] ||= flipper
         @app.call(env)
       end
 

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.11.0.beta4'.freeze
+  VERSION = '0.11.0.beta5'.freeze
 end

data/spec/flipper/adapters/http_spec.rb

@@ -119,6 +119,7 @@ RSpec.describe Flipper::Adapters::Http do
   end
 
   describe 'configuration' do
+    let(:debug_output) { object_double($stderr) }
     let(:options) do
       {
         uri: URI('http://app.com/mount-point'),
@@ -127,6 +128,7 @@ RSpec.describe Flipper::Adapters::Http do
         basic_auth_password: 'password',
         read_timeout: 100,
         open_timeout: 40,
+        debug_output: debug_output,
       }
     end
     subject { described_class.new(options) }
@@ -151,6 +153,14 @@ RSpec.describe Flipper::Adapters::Http do
         .with(basic_auth: %w(username password))
       ).to have_been_made.once
     end
+
+    it 'allows client to set debug output' do
+      user_agent = Net::HTTP.new("app.com")
+      allow(Net::HTTP).to receive(:new).and_return(user_agent)
+
+      expect(user_agent).to receive(:set_debug_output).with(debug_output)
+      subject.get(feature)
+    end
   end
 
   def fixture_file(name)

data/spec/support/spec_helpers.rb

@@ -8,14 +8,14 @@ module SpecHelpers
     base.let(:app) { build_app(flipper) }
   end
 
-  def build_app(flipper)
-    Flipper::UI.app(flipper) do |builder|
+  def build_app(flipper, options = {})
+    Flipper::UI.app(flipper, options) do |builder|
       builder.use Rack::Session::Cookie, secret: 'test'
     end
   end
 
-  def build_api(flipper)
-    Flipper::Api.app(flipper)
+  def build_api(flipper, options = {})
+    Flipper::Api.app(flipper, options)
   end
 
   def build_flipper(adapter = build_memory_adapter)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper
 version: !ruby/object:Gem::Version
-  version: 0.11.0.beta4
+  version: 0.11.0.beta5
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-10 00:00:00.000000000 Z
+date: 2017-05-16 00:00:00.000000000 Z
 dependencies: []
 description: Feature flipper is the act of enabling/disabling features in your application,
   ideally without re-deploying or changing anything in your code base. Flipper makes