flipper-ui 1.3.6 → 1.3.7.test

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 42fd7dcb2640b87a4c3a8a841bb1956ee6c2bd8a4a8d1619b2e7ce6d6b61b306
-  data.tar.gz: 0b2bffb8e6ad0f7f2a6e220956188fcfbd9efc4ddb435be0554672542e1d2e0c
+  metadata.gz: e92c4665d60234e6b2942d61dbe7a860e747b573e91a4f4f107975e5c98f27ff
+  data.tar.gz: 0d289545c59f59c68b893b090e4192e993b0f1c469d850d3195deaa70cce4864
 SHA512:
-  metadata.gz: 11c0782c666370f0e11e174b8c8159773495360d894ec72a6110db00b04cf03d5f5f80c72521a4ae41874f69af60bb208e6bd1cdcc1f9eafb3b9237ac24a4100
-  data.tar.gz: 0a1b1a91471cb2c9a2561112314dbd2255c72c82eadb6cb499af1b412650f7a44eda39d360fe0d461624b88e933b4daba74cfe523c802aaa1447b91f389ee5ae
+  metadata.gz: 6dec25435c957b97c45075942889c435ee97240cf1fac3b6d157674c8a32e3cccf5b4cb620d3b49e6f520e57591c0f30d4efbbaf2b89a4613d8f2ac828289c89
+  data.tar.gz: 72c321f75fef4300ea37bc6cd1946f8fd20d597b5f0b24a514dd308c92416629e94714cf5b6f23fdc51e362c3e4515cc87f83d84f6e9991dab91b458720ce628

data/examples/ui/basic.ru

@@ -25,6 +25,7 @@ Flipper::UI.configure do |config|
   config.feature_removal_enabled = true
   config.cloud_recommendation = true
   config.confirm_fully_enable = false
+  config.confirm_disable = false
   config.read_only = false
   # config.show_feature_description_in_list = true
   config.descriptions_source = lambda do |_keys|

data/lib/flipper/ui/action.rb

@@ -7,6 +7,14 @@ require 'sanitize'
 
 module Flipper
   module UI
+    # Sanitize config for descriptions in list view. Removes anchor tags to
+    # avoid nested links (the feature row is wrapped in an <a> tag).
+    # See: https://github.com/flippercloud/flipper/issues/939
+    SANITIZE_LIST = Sanitize::Config.merge(
+      Sanitize::Config::BASIC,
+      elements: Sanitize::Config::BASIC[:elements] - ['a']
+    )
+
     class Action
       module FeatureNameFromRoute
         def feature_name

data/lib/flipper/ui/actions/cloud_migrate.rb

@@ -0,0 +1,26 @@
+require 'flipper/ui/action'
+require 'flipper/ui/util'
+
+module Flipper
+  module UI
+    module Actions
+      class CloudMigrate < UI::Action
+        route %r{\A/settings\/cloud/?\Z}
+
+        def post
+          result = Flipper::Cloud.migrate(flipper)
+
+          if result.url
+            status 302
+            header 'location', result.url
+            halt [@code, @headers, ['']]
+          else
+            message = "Migration failed (HTTP #{result.code})"
+            message << ": #{result.message}" if result.message
+            redirect_to "/settings?error=#{Flipper::UI::Util.escape(message)}"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/flipper/ui/middleware.rb

@@ -27,6 +27,7 @@ module Flipper
         @action_collection.add UI::Actions::Features
         @action_collection.add UI::Actions::Export
         @action_collection.add UI::Actions::Import
+        @action_collection.add UI::Actions::CloudMigrate
         @action_collection.add UI::Actions::Settings
 
         # Static Assets/Files

data/lib/flipper/ui/public/js/application.js

@@ -12,8 +12,8 @@ document.addEventListener("DOMContentLoaded", function () {
 
   document.querySelectorAll("*[data-confirmation-text]").forEach(function (element) {
     element.addEventListener("click", function (e) {
-      var expected = e.target.getAttribute("data-confirmation-text");
-      var actual = prompt(e.target.getAttribute("data-confirmation-prompt"));
+      var expected = element.getAttribute("data-confirmation-text");
+      var actual = prompt(element.getAttribute("data-confirmation-prompt"));
 
       if (expected !== actual) {
         e.preventDefault();

data/lib/flipper/ui/views/feature.erb

@@ -255,14 +255,13 @@
             <div class="row">
               <% unless @feature.boolean_value %>
                 <div class="col d-grid">
-                  <button type="submit" name="action" value="Enable" class="btn btn-outline-success">
-                    <span class="d-block" data-bs-toggle="tooltip"
-                      <% if Flipper::UI.configuration.confirm_fully_enable %>
-                        data-confirmation-prompt="Are you sure you want to fully enable this feature for everyone? Please enter the name of the feature to confirm it: <%= feature_name %>"
-                        data-confirmation-text="<%= feature_name %>"
-                      <% end %>
-                        title="Enable for everyone"
-                      >
+                  <button type="submit" name="action" value="Enable" class="btn btn-outline-success"
+                    <% if Flipper::UI.configuration.confirm_fully_enable %>
+                      data-confirmation-prompt="Are you sure you want to fully enable this feature for everyone? Please enter the name of the feature to confirm it: <%= feature_name %>"
+                      data-confirmation-text="<%= feature_name %>"
+                    <% end %>
+                  >
+                    <span class="d-block" data-bs-toggle="tooltip" title="Enable for everyone">
                       Fully Enable
                     </span>
                   </button>
@@ -271,14 +270,13 @@
 
               <% unless @feature.off? %>
                 <div class="col d-grid">
-                  <button type="submit" name="action" value="Disable" class="btn btn-outline-danger">
-                    <span class="d-block" data-bs-toggle="tooltip"
-                      <% if Flipper::UI.configuration.confirm_disable %>
-                        data-confirmation-prompt="Are you sure you want to disable this feature for everyone? Please enter the name of the feature to confirm it: <%= feature_name %>"
-                        data-confirmation-text="<%= feature_name %>"
-                      <% end %>
-                        title="Disable for everyone by clearing all percentages, groups and actors."
-                      >
+                  <button type="submit" name="action" value="Disable" class="btn btn-outline-danger"
+                    <% if Flipper::UI.configuration.confirm_disable %>
+                      data-confirmation-prompt="Are you sure you want to disable this feature for everyone? Please enter the name of the feature to confirm it: <%= feature_name %>"
+                      data-confirmation-text="<%= feature_name %>"
+                    <% end %>
+                  >
+                    <span class="d-block" data-bs-toggle="tooltip" title="Disable for everyone by clearing all percentages, groups and actors.">
                       Disable
                     </span>
                   </button>

data/lib/flipper/ui/views/features.erb

@@ -45,7 +45,7 @@
             <div class="text-truncate" style="font-weight: 500"><%= feature.key %></div>
             <% if Flipper::UI.configuration.show_feature_description_in_list? && Flipper::UI::Util.present?(feature.description) %>
               <div class="text-muted fw-light" style="line-height: 1.4; white-space: initial; padding: 8px 0">
-                <%== Sanitize.fragment(feature.description, Sanitize::Config::BASIC) %>
+                <%== Sanitize.fragment(feature.description, Flipper::UI::SANITIZE_LIST) %>
               </div>
             <% end %>
             <div class="text-muted text-truncate">

data/lib/flipper/ui/views/settings.erb

@@ -1,3 +1,30 @@
+<% if params.key?("error") %>
+  <div class="alert alert-danger"><%= params["error"] %></div>
+<% end %>
+
+<div class="card mb-4">
+  <div class="card-header">
+    <h4 class="m-0">Migrate to Flipper Cloud</h4>
+  </div>
+  <div class="card-body">
+    <p>Flipper Cloud gives you audit history, rollback, finer-grained permissions, and multi-environment sync. We even have a free tier!</p>
+
+    <ul class="mb-3">
+      <li>Audit log of every feature change</li>
+      <li>Instant rollback to any previous state</li>
+      <li>Team permissions and approval workflows</li>
+      <li>Sync flags across environments</li>
+    </ul>
+
+    <p>You have <strong><%= flipper.features.count %></strong> <%= flipper.features.count == 1 ? 'feature' : 'features' %> ready to migrate.</p>
+
+    <form action="<%= script_name %>/settings/cloud" method="post">
+      <%== csrf_input_tag %>
+      <input type="submit" value="Migrate to Flipper Cloud" class="btn btn-primary">
+    </form>
+  </div>
+</div>
+
 <div class="card mb-4 ">
   <div class="card-header">
     <h4 class="m-0">Export</h4>

data/lib/flipper/version.rb

@@ -1,5 +1,5 @@
 module Flipper
-  VERSION = '1.3.6'.freeze
+  VERSION = '1.3.7.test'.freeze
 
   REQUIRED_RUBY_VERSION = '2.6'.freeze
   NEXT_REQUIRED_RUBY_VERSION = '3.0'.freeze

data/spec/flipper/ui/actions/cloud_migrate_spec.rb

@@ -0,0 +1,54 @@
+require 'flipper/cloud/migrate'
+
+RSpec.describe Flipper::UI::Actions::CloudMigrate do
+  let(:token) do
+    if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
+      Rack::Protection::AuthenticityToken.random_token
+    else
+      'a'
+    end
+  end
+
+  let(:session) do
+    { :csrf => token, 'csrf' => token, '_csrf_token' => token }
+  end
+
+  describe "POST /settings/cloud" do
+    context "when migration succeeds" do
+      before do
+        flipper.enable :search
+        allow(Flipper::Cloud).to receive(:migrate).and_return(
+          Flipper::Cloud::MigrateResult.new(code: 200, url: "https://www.flippercloud.io/cloud/setup/abc123")
+        )
+
+        post '/settings/cloud',
+          {'authenticity_token' => token},
+          'rack.session' => session
+      end
+
+      it 'redirects to the cloud URL' do
+        expect(last_response.status).to be(302)
+        expect(last_response.headers['location']).to eq('https://www.flippercloud.io/cloud/setup/abc123')
+      end
+    end
+
+    context "when migration fails" do
+      before do
+        flipper.enable :search
+        allow(Flipper::Cloud).to receive(:migrate).and_return(
+          Flipper::Cloud::MigrateResult.new(code: 500, url: nil)
+        )
+
+        post '/settings/cloud',
+          {'authenticity_token' => token},
+          'rack.session' => session
+      end
+
+      it 'redirects back to settings with error' do
+        expect(last_response.status).to be(302)
+        expect(last_response.headers['location']).to include('/settings')
+        expect(last_response.headers['location']).to include('error=')
+      end
+    end
+  end
+end

data/spec/flipper/ui/actions/feature_spec.rb

@@ -211,4 +211,18 @@ RSpec.describe Flipper::UI::Actions::Feature do
       expect(last_response.body).to include('../../../../blah')
     end
   end
+
+  describe 'GET /features/:feature with question mark in feature name' do
+    before do
+      get '/features/can_do_stuff%3F'
+    end
+
+    it 'responds with success' do
+      expect(last_response.status).to be(200)
+    end
+
+    it 'renders template with question mark in feature name' do
+      expect(last_response.body).to include('can_do_stuff?')
+    end
+  end
 end

data/spec/flipper/ui/actions/features_spec.rb

@@ -32,10 +32,12 @@ RSpec.describe Flipper::UI::Actions::Features do
       flipper.add("../../../../blah")
       flipper.add("this that")
       flipper.add("foo/bar")
+      flipper.add("can_do_stuff?")
       get '/features'
       expect(last_response.body).to include("..%2F..%2F..%2F..%2Fblah")
       expect(last_response.body).to include("this+that")
       expect(last_response.body).to include("foo%2Fbar")
+      expect(last_response.body).to include("can_do_stuff%3F")
     end
 
     context "when there are no features to list" do
@@ -88,6 +90,25 @@ RSpec.describe Flipper::UI::Actions::Features do
         expect(last_response.body).not_to include('<a class="btn btn-primary btn-sm" href="/features/new">Add Feature</a>')
       end
     end
+
+    context 'when descriptions have links' do
+      before do
+        Flipper::UI.configuration.show_feature_description_in_list = true
+        Flipper::UI.configuration.descriptions_source = lambda { |_keys|
+          { 'test_feature' => 'Check <a href="https://example.com">this link</a> for more info' }
+        }
+
+        flipper[:test_feature].enable
+      end
+
+      it 'strips anchor tags from descriptions to avoid nested links' do
+        get '/features'
+
+        expect(last_response.status).to eq(200)
+        expect(last_response.body).to include('Check this link for more info')
+        expect(last_response.body).not_to include('<a href="https://example.com">this link</a>')
+      end
+    end
   end
 
   describe 'POST /features' do
@@ -151,6 +172,19 @@ RSpec.describe Flipper::UI::Actions::Features do
         end
       end
 
+      context 'feature name contains question mark' do
+        let(:feature_name) { 'can_do_stuff?' }
+
+        it 'adds feature with question mark' do
+          expect(flipper.features.map(&:key)).to include('can_do_stuff?')
+        end
+
+        it 'redirects to feature with encoded question mark' do
+          expect(last_response.status).to be(302)
+          expect(last_response.headers['location']).to eq('/features/can_do_stuff%3F')
+        end
+      end
+
       context 'for an invalid feature name' do
         context 'empty feature name' do
           let(:feature_name) { '' }

data/spec/flipper/ui/actions/settings_spec.rb

@@ -23,5 +23,13 @@ RSpec.describe Flipper::UI::Actions::Settings do
     it 'renders template' do
       expect(last_response.body).to include('Download')
     end
+
+    it 'includes migrate to Flipper Cloud card' do
+      expect(last_response.body).to include('Migrate to Flipper Cloud')
+    end
+
+    it 'shows feature count' do
+      expect(last_response.body).to include('features ready to migrate')
+    end
   end
 end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-ui
 version: !ruby/object:Gem::Version
-  version: 1.3.6
+  version: 1.3.7.test
 platform: ruby
 authors:
 - John Nunemaker
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2026-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -75,14 +76,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: 1.3.7.test
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: 1.3.7.test
 - !ruby/object:Gem::Dependency
   name: erubi
   requirement: !ruby/object:Gem::Requirement
@@ -117,6 +118,7 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '8'
+description:
 email: support@flippercloud.io
 executables: []
 extensions: []
@@ -134,6 +136,7 @@ files:
 - lib/flipper/ui/actions/actors_gate.rb
 - lib/flipper/ui/actions/add_feature.rb
 - lib/flipper/ui/actions/boolean_gate.rb
+- lib/flipper/ui/actions/cloud_migrate.rb
 - lib/flipper/ui/actions/export.rb
 - lib/flipper/ui/actions/feature.rb
 - lib/flipper/ui/actions/features.rb
@@ -175,6 +178,7 @@ files:
 - spec/flipper/ui/actions/actors_gate_spec.rb
 - spec/flipper/ui/actions/add_feature_spec.rb
 - spec/flipper/ui/actions/boolean_gate_spec.rb
+- spec/flipper/ui/actions/cloud_migrate_spec.rb
 - spec/flipper/ui/actions/export_spec.rb
 - spec/flipper/ui/actions/feature_spec.rb
 - spec/flipper/ui/actions/features_spec.rb
@@ -198,8 +202,9 @@ metadata:
   homepage_uri: https://www.flippercloud.io
   source_code_uri: https://github.com/flippercloud/flipper
   bug_tracker_uri: https://github.com/flippercloud/flipper/issues
-  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.3.6
+  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.3.7.test
   funding_uri: https://github.com/sponsors/flippercloud
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -214,26 +219,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.5.22
+signing_key:
 specification_version: 4
 summary: Feature flag UI for the Flipper gem
-test_files:
-- spec/flipper/ui/action_spec.rb
-- spec/flipper/ui/actions/actors_gate_spec.rb
-- spec/flipper/ui/actions/add_feature_spec.rb
-- spec/flipper/ui/actions/boolean_gate_spec.rb
-- spec/flipper/ui/actions/export_spec.rb
-- spec/flipper/ui/actions/feature_spec.rb
-- spec/flipper/ui/actions/features_spec.rb
-- spec/flipper/ui/actions/file_spec.rb
-- spec/flipper/ui/actions/groups_gate_spec.rb
-- spec/flipper/ui/actions/home_spec.rb
-- spec/flipper/ui/actions/import_spec.rb
-- spec/flipper/ui/actions/percentage_of_actors_gate_spec.rb
-- spec/flipper/ui/actions/percentage_of_time_gate_spec.rb
-- spec/flipper/ui/actions/settings_spec.rb
-- spec/flipper/ui/configuration_spec.rb
-- spec/flipper/ui/decorators/feature_spec.rb
-- spec/flipper/ui/decorators/gate_spec.rb
-- spec/flipper/ui/util_spec.rb
-- spec/flipper/ui_spec.rb
+test_files: []