flipper-ui 0.9.0.beta1 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc0173948538ea1c5a5efb109694ee186ffdba06
-  data.tar.gz: a75a8008ced7c513e22c6ecbd378c39f430b4ba0
+  metadata.gz: ac02aa3928a20cfd18227e4ea03a710445963411
+  data.tar.gz: 4e326d8a1ae7d55df414e89b38f3635e40c58bfb
 SHA512:
-  metadata.gz: c66f6b0dbd1bebe6ec49643b48c0fb7b3e52b7595563f4d153bbc24162559e0607d315b5fd4a77ca899cb78542776849f58e94744170985b4a7ada7c003ad22d
-  data.tar.gz: 437f7ba277a33fabd1526ed09fbdd3e79457113af2b228cf90273bff0c6f02fb8bacc9f668577e1f644cb81ff545abf106894e1dc0ccce0f168d20b64e3ae9bb
+  metadata.gz: a7fcb2fb3018253ca9e9cc0f9a3bcffd2b35647761a8da4552cf17cee2b8ad745366daf1f9eb5e449220bcd3b6fbf34b014acf53d6c4a7c9c56079dc40838a54
+  data.tar.gz: b58496ab5a0648e98883143d0db86a9ae079e5e79c717179ee378608f15e4591650e2e832609d4bf3b5e1ba1b167609f7a24df3184149d244e933cee088e610b

data/lib/flipper/ui/action.rb

@@ -8,6 +8,13 @@ module Flipper
     class Action
       extend Forwardable
 
+      VALID_REQUEST_METHOD_NAMES = Set.new([
+        "get".freeze,
+        "post".freeze,
+        "put".freeze,
+        "delete".freeze,
+      ]).freeze
+
       # Public: Call this in subclasses so the action knows its route.
       #
       # regex - The Regexp that this action should run for.
@@ -67,7 +74,7 @@ module Flipper
       #
       # Returns whatever the request method returns in the action.
       def run
-        if respond_to?(request_method_name)
+        if valid_request_method? && respond_to?(request_method_name)
           catch(:halt) { send(request_method_name) }
         else
           raise UI::RequestMethodNotSupported, "#{self.class} does not support request method #{request_method_name.inspect}"
@@ -213,6 +220,10 @@ module Flipper
       def csrf_input_tag
         %Q(<input type="hidden" name="authenticity_token" value="#{@request.session[:csrf]}">)
       end
+
+      def valid_request_method?
+        VALID_REQUEST_METHOD_NAMES.include?(request_method_name)
+      end
     end
   end
 end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.9.0.beta1".freeze
+  VERSION = "0.9.0".freeze
 end

data/spec/flipper/ui/action_spec.rb

@@ -0,0 +1,59 @@
+require 'helper'
+
+RSpec.describe Flipper::UI::Action do
+  let(:action_subclass) {
+    Class.new(described_class) do
+      def noooope
+        raise "should never run this"
+      end
+
+      def get
+        [200, {}, "get"]
+      end
+
+      def post
+        [200, {}, "post"]
+      end
+
+      def put
+        [200, {}, "put"]
+      end
+
+      def delete
+        [200, {}, "delete"]
+      end
+    end
+  }
+
+  it "won't run method that isn't whitelisted" do
+    fake_request = Struct.new(:request_method, :env, :session).new("NOOOOPE", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect {
+      action.run
+    }.to raise_error(Flipper::UI::RequestMethodNotSupported)
+  end
+
+  it "will run get" do
+    fake_request = Struct.new(:request_method, :env, :session).new("GET", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect(action.run).to eq([200, {}, "get"])
+  end
+
+  it "will run post" do
+    fake_request = Struct.new(:request_method, :env, :session).new("POST", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect(action.run).to eq([200, {}, "post"])
+  end
+
+  it "will run put" do
+    fake_request = Struct.new(:request_method, :env, :session).new("PUT", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect(action.run).to eq([200, {}, "put"])
+  end
+
+  it "will run delete" do
+    fake_request = Struct.new(:request_method, :env, :session).new("DELETE", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect(action.run).to eq([200, {}, "delete"])
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-ui
 version: !ruby/object:Gem::Version
-  version: 0.9.0.beta1
+  version: 0.9.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -50,14 +50,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0.beta1
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0.beta1
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
@@ -249,6 +249,7 @@ files:
 - lib/flipper/ui/views/features.erb
 - lib/flipper/ui/views/layout.erb
 - lib/flipper/version.rb
+- spec/flipper/ui/action_spec.rb
 - spec/flipper/ui/actions/actors_gate_spec.rb
 - spec/flipper/ui/actions/add_feature_spec.rb
 - spec/flipper/ui/actions/boolean_gate_spec.rb
@@ -279,9 +280,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5.1
@@ -289,6 +290,7 @@ signing_key:
 specification_version: 4
 summary: UI for the Flipper gem
 test_files:
+- spec/flipper/ui/action_spec.rb
 - spec/flipper/ui/actions/actors_gate_spec.rb
 - spec/flipper/ui/actions/add_feature_spec.rb
 - spec/flipper/ui/actions/boolean_gate_spec.rb