flipper-ui 0.7.0.beta4 → 0.7.0.beta5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e8385a002087b4445e5d5d167e96741c2c3841f
-  data.tar.gz: e03bd3bc018c15f0af45fad684796cd895823376
+  metadata.gz: ab0bcc2a79240d47bc81c5d1b07ac30ea036ccab
+  data.tar.gz: e719e3fecef747f692140cff6bd7eb898d58bb83
 SHA512:
-  metadata.gz: 7495ee2bb82e94423d8a05527cb2abc8f5c516c2dad1009a658c39064996111d9561b9409fe81e76419c50fffeb44327e3ff77856c3edddfad6e05b82cf03970
-  data.tar.gz: 3d23541561bed553b8cd878336c4317b7a27cb82c1c7e24665b7f94ca9d8c682b4ee58ce87aaa21cc073576e9ce6d402e495b8bd0729e5fbef0fc6611320eecc
+  metadata.gz: f648274c486d501453b90b82db87faa005483cd75b510a33fc7c41c2f4a7b4b2f19d6143576f12dc4b138389d4ddf016c2f4c8b6103d48706648447f3e9607ec
+  data.tar.gz: 343d6b3558d012d8599760a358d75cd87461785326039a9cd9e864e8fb4ef39a12e45dc8eefc233b1c06e6ea1b5227bc0b1dc7718f8911269beb9b844a5ded34

data/docs/ui/README.md

@@ -40,7 +40,7 @@ you can mount `Flipper::UI` to a route of your choice:
 # config/routes.rb
 
 YourRailsApp::Application.routes.draw do
-  mount Flipper::UI.app($flipper, secret: "_your_session_secret") => '/flipper'
+  mount Flipper::UI.app($flipper) => '/flipper'
 end
 ```
 
@@ -53,7 +53,7 @@ You almost certainly want to limit access when using Flipper::UI in production.
 
 flipper_constraint = lambda { |request| request.remote_ip == '127.0.0.1' }
 constraints flipper_constraint do
-  mount Flipper::UI.app($flipper, secret: "_your_session_secret") => '/flipper'
+  mount Flipper::UI.app($flipper) => '/flipper'
 end
 ```
 
@@ -72,7 +72,7 @@ end
 # config/routes.rb
 
 constraints CanAccessFlipperUI do
-  mount Flipper::UI.app($flipper, secret: "_your_session_secret") => '/flipper'
+  mount Flipper::UI.app($flipper) => '/flipper'
 end
 ```
 
@@ -90,7 +90,15 @@ require 'flipper/adapters/memory'
 adapter = Flipper::Adapters::Memory.new
 flipper = Flipper.new(adapter)
 
-run Flipper::UI.app(flipper, secret: "_your_session_secret")
+run Flipper::UI.app(flipper) { |builder|
+  builder.use Rack::Session::Cookie, secret: "something long and random"
+}
+```
+
+The key is that you need to have sessions setup. Rails does this for you, so this step isn't necessary, but for standalone rack, you'll need it. Without sessions setup, you will receive a Runtime error like:
+
+```
+RuntimeError: you need to set up a session middleware *before* Rack::Protection::RemoteToken.
 ```
 
 See [examples/ui/basic.ru](https://github.com/jnunemaker/flipper/blob/master/examples/ui/basic.ru) for a more full example

data/examples/ui/basic.ru

@@ -43,4 +43,6 @@ flipper = Flipper.new(adapter, instrumenter: ActiveSupport::Notifications)
 # flipper[:logging].enable_percentage_of_time 5
 # flipper[:new_cache].enable_percentage_of_actors 15
 
-run Flipper::UI.app(flipper, secret: "example_secret_dont_use_this")
+run Flipper::UI.app(flipper) { |builder|
+  builder.use Rack::Session::Cookie, secret: "_super_secret"
+}

data/lib/flipper/ui.rb

@@ -2,9 +2,13 @@ require 'pathname'
 require 'rack'
 require 'rack/methodoverride'
 require 'rack/protection'
+
 require 'flipper'
 require 'flipper/middleware/memoizer'
 
+require 'flipper/ui/actor'
+require 'flipper/ui/middleware'
+
 module Flipper
   module UI
     def self.root
@@ -15,8 +19,6 @@ module Flipper
       app = lambda { |env| [200, {'Content-Type' => 'text/html'}, ['']] }
       builder = Rack::Builder.new
       yield builder if block_given?
-      secret = options[:secret] || raise(ArgumentError, "Flipper::UI.app missing required option: secret")
-      builder.use Rack::Session::Cookie, secret: secret
       builder.use Rack::Protection
       builder.use Rack::Protection::AuthenticityToken
       builder.use Rack::MethodOverride
@@ -27,6 +29,3 @@ module Flipper
     end
   end
 end
-
-require 'flipper/ui/middleware'
-require 'flipper/ui/actor'

data/lib/flipper/ui/actions/gate.rb

@@ -1,5 +1,4 @@
 require 'flipper/ui/action'
-require 'flipper/ui/actor'
 require 'flipper/ui/decorators/feature'
 
 module Flipper

data/lib/flipper/ui/middleware.rb

@@ -2,7 +2,7 @@ require 'rack'
 require 'flipper/ui/action_collection'
 
 # Require all actions automatically.
-Flipper::UI.root.join('actions').each_child(false) do |name|
+Pathname(__FILE__).dirname.join('actions').each_child(false) do |name|
   require "flipper/ui/actions/#{name}"
 end
 

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.7.0.beta4"
+  VERSION = "0.7.0.beta5"
 end

data/spec/flipper/ui/actions/actors_gate_spec.rb

@@ -1,5 +1,4 @@
 require 'helper'
-require 'flipper/ui/actor'
 
 describe Flipper::UI::Actions::ActorsGate do
   describe "GET /features/:feature/actors" do

data/spec/flipper/ui/actions/percentage_of_actors_gate_spec.rb

@@ -1,5 +1,4 @@
 require 'helper'
-require 'flipper/ui/actor'
 
 describe Flipper::UI::Actions::PercentageOfActorsGate do
   describe "POST /features/:feature/percentage_of_actors" do

data/spec/flipper/ui_spec.rb

@@ -1,14 +1,6 @@
 require 'helper'
-require 'rack/test'
-require 'flipper'
-require 'flipper/adapters/memory'
 
 describe Flipper::UI do
-  include Rack::Test::Methods
-
-  let(:flipper) { build_flipper }
-  let(:app)     { build_app(flipper) }
-
   describe "Initializing middleware with flipper instance" do
     let(:app) { build_app(flipper) }
 
@@ -21,7 +13,9 @@ describe Flipper::UI do
   end
 
   describe "Initializing middleware lazily with a block" do
-    let(:app) { Flipper::UI.app(lambda { flipper }, secret: "test") }
+    let(:app) {
+      build_app(lambda { flipper })
+    }
 
     it "works" do
       flipper.enable :some_great_feature
@@ -31,12 +25,6 @@ describe Flipper::UI do
     end
   end
 
-  describe "Creating app without secret" do
-    it "raises argument error" do
-      expect { Flipper::UI.app(flipper) }.to raise_error(ArgumentError, "Flipper::UI.app missing required option: secret")
-    end
-  end
-
   describe "Request method unsupported by action" do
     it "raises error" do
       expect {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-ui
 version: !ruby/object:Gem::Version
-  version: 0.7.0.beta4
+  version: 0.7.0.beta5
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-28 00:00:00.000000000 Z
+date: 2015-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -50,14 +50,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.0.beta4
+        version: 0.7.0.beta5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.0.beta4
+        version: 0.7.0.beta5
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement