flipper-ui 0.16.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 25aa2745af2e31218cbd4b27af8193e58737cf9d
-  data.tar.gz: cdda6a59fe7edcbdc5b06be258d2d685a2796636
+  metadata.gz: 1ee6d79027b24abab8374678ef7d18816eac6231
+  data.tar.gz: a2122c8642e23b1974e03787735cb2c04bf1f507
 SHA512:
-  metadata.gz: c834961bc28b80d3890bcb150ef26a9dffc2f7450acb5d0f2dc6e49d5be0f13bbf435c49916a1c08adf6c1944e1100500cf49f00d147b6a28d5f05bd97ed4399
-  data.tar.gz: 505af952e52ec8ccba2b37368c1fb84fcde104308d09a666f5479769677d6453edeea3088f70f74f49c4241a19f52eaa985f02f4c6400124b6b6a38cb5abc2ea
+  metadata.gz: 72670387cff1e1953d1e83ec70dd575c07790d18e2cc2f01d04bb90d2bd3832e65a595c9c679935a6965fdc61c6cffd351fe315f54b947ab2b8b7f2e46e807af
+  data.tar.gz: 2130c3fb5c76a3a19be90d92b06049e10a06ddc99f6aa4fb5dd8ed6ed607bcae72bb63c5e08dc83ede1e821b832c636b9ece16d544ea2dd436234520905fd928

data/lib/flipper/ui/action.rb

@@ -10,7 +10,7 @@ module Flipper
         def feature_name
           @feature_name ||= begin
             match = request.path_info.match(self.class.route_regex)
-            match ? match[:feature_name] : nil
+            match ? Rack::Utils.unescape(match[:feature_name]) : nil
           end
         end
         private :feature_name

data/lib/flipper/ui/views/feature.erb

@@ -35,7 +35,7 @@
     </div>
   </div>
   <div class="row">
-    <div class="col-md mb-4 mb-md-0">
+    <div class="col-md mb-4 mb-lg-0">
       <div class="card">
         <h4 class="card-header"><%= Flipper::UI.configuration.percentage_of_actors.title %></h4>
         <div class="card-body">
@@ -128,7 +128,7 @@
                 <form action="<%= script_name %>/features/<%= @feature.key %>/groups" method="post" class="form-inline">
                   <%== csrf_input_tag %>
                   <input type="hidden" name="operation" value="enable">
-                  <select name="value" class="form-control form-control-sm mr-sm-2 mb-2 mb-md-0">
+                  <select name="value" class="form-control form-control-sm mr-sm-2 mb-2 mb-sm-0">
                     <option value="">Select a group...</option>
                     <% @feature.disabled_groups.each do |group| %>
                       <option value="<%= group.name %>"><%= group.name %></option>
@@ -186,7 +186,7 @@
               <form action="<%= script_name %>/features/<%= @feature.key %>/actors" method="post" class="form-inline">
                 <%== csrf_input_tag %>
                 <input type="hidden" name="operation" value="enable">
-                <input type="text" name="value" placeholder="ie: User:6" class="form-control form-control-sm mr-sm-2 mb-2 mb-md-0">
+                <input type="text" name="value" placeholder="ie: User:6" class="form-control form-control-sm mr-sm-2 mb-2 mb-sm-0">
                 <input type="submit" value="Add Actor" class="btn btn-light btn-sm">
               </form>
             </div>

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.16.0'.freeze
+  VERSION = '0.16.1'.freeze
 end

data/spec/flipper/ui/action_spec.rb

@@ -1,59 +1,78 @@
 require 'helper'
 
 RSpec.describe Flipper::UI::Action do
-  let(:action_subclass) do
-    Class.new(described_class) do
-      def noooope
-        raise 'should never run this'
-      end
+  describe 'request methods' do
+    let(:action_subclass) do
+      Class.new(described_class) do
+        def noooope
+          raise 'should never run this'
+        end
 
-      def get
-        [200, {}, 'get']
-      end
+        def get
+          [200, {}, 'get']
+        end
 
-      def post
-        [200, {}, 'post']
-      end
+        def post
+          [200, {}, 'post']
+        end
 
-      def put
-        [200, {}, 'put']
-      end
+        def put
+          [200, {}, 'put']
+        end
 
-      def delete
-        [200, {}, 'delete']
+        def delete
+          [200, {}, 'delete']
+        end
       end
     end
-  end
 
-  it "won't run method that isn't whitelisted" do
-    fake_request = Struct.new(:request_method, :env, :session).new('NOOOOPE', {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect do
-      action.run
-    end.to raise_error(Flipper::UI::RequestMethodNotSupported)
-  end
+    it "won't run method that isn't whitelisted" do
+      fake_request = Struct.new(:request_method, :env, :session).new('NOOOOPE', {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect do
+        action.run
+      end.to raise_error(Flipper::UI::RequestMethodNotSupported)
+    end
 
-  it 'will run get' do
-    fake_request = Struct.new(:request_method, :env, :session).new('GET', {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect(action.run).to eq([200, {}, 'get'])
-  end
+    it 'will run get' do
+      fake_request = Struct.new(:request_method, :env, :session).new('GET', {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect(action.run).to eq([200, {}, 'get'])
+    end
 
-  it 'will run post' do
-    fake_request = Struct.new(:request_method, :env, :session).new('POST', {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect(action.run).to eq([200, {}, 'post'])
-  end
+    it 'will run post' do
+      fake_request = Struct.new(:request_method, :env, :session).new('POST', {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect(action.run).to eq([200, {}, 'post'])
+    end
 
-  it 'will run put' do
-    fake_request = Struct.new(:request_method, :env, :session).new('PUT', {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect(action.run).to eq([200, {}, 'put'])
+    it 'will run put' do
+      fake_request = Struct.new(:request_method, :env, :session).new('PUT', {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect(action.run).to eq([200, {}, 'put'])
+    end
   end
 
-  it 'will run delete' do
-    fake_request = Struct.new(:request_method, :env, :session).new('DELETE', {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect(action.run).to eq([200, {}, 'delete'])
+  describe 'FeatureNameFromRoute' do
+    let(:action_subclass) do
+      Class.new(described_class) do |parent|
+        include parent::FeatureNameFromRoute
+
+        route %r{\A/features/(?<feature_name>.*)\Z}
+
+        def get
+          [200, { feature_name: feature_name }, 'get']
+        end
+      end
+    end
+
+    it 'decodes feature_name' do
+      requested_feature_name = Rack::Utils.escape("team:side_pane")
+      fake_request = Struct
+                     .new(:request_method, :env, :session, :path_info)
+                     .new('GET', {}, {}, "/features/#{requested_feature_name}")
+      action = action_subclass.new(flipper, fake_request)
+      expect(action.run).to eq([200, { feature_name: "team:side_pane" }, 'get'])
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-ui
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-01 00:00:00.000000000 Z
+date: 2019-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -56,14 +56,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.16.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.16.1
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement