flipper-mongo 0.2.2 → 0.3.0

data/.travis.yml

@@ -0,0 +1,10 @@
+language: ruby
+rvm:
+  - 1.8.7
+  - ree
+  - 1.9.3
+notifications:
+  email: false
+bundler_args: --without guard
+before_script: sudo service mongodb status
+services: mongodb

data/Gemfile

@@ -2,19 +2,15 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'rake'
+gem 'rspec'
+gem 'timecop'
+gem 'bson_ext'
+gem 'mongo'
+gem 'rack-test'
 
 group(:guard) do
   gem 'guard'
   gem 'guard-rspec'
   gem 'guard-bundler'
-  gem 'growl'
+  gem 'rb-fsevent'
 end
-
-group(:test) do
-  gem 'rspec'
-  gem 'timecop'
-  gem 'bson_ext'
-  gem 'mongo'
-  gem 'rack-test'
-end
-

data/flipper-mongo.gemspec

@@ -14,5 +14,5 @@ Gem::Specification.new do |gem|
   gem.name          = "flipper-mongo"
   gem.require_paths = ["lib"]
   gem.version       = Flipper::Adapters::Mongo::VERSION
-  gem.add_dependency 'flipper', '~> 0.2'
+  gem.add_dependency 'flipper', '~> 0.4'
 end

data/lib/flipper/adapters/mongo.rb

@@ -17,11 +17,11 @@ module Flipper
       end
 
       def write(key, value)
-        update key, {'$set' => {'v' => value}}
+        update key, {'$set' => {'v' => value.to_s}}
       end
 
       def delete(key)
-        @collection.remove criteria(key)
+        remove key
       end
 
       def set_members(key)
@@ -29,17 +29,19 @@ module Flipper
       end
 
       def set_add(key, value)
-        update key, {'$addToSet' => {'v' => value}}
+        update key, {'$addToSet' => {'v' => value.to_s}}
       end
 
       def set_delete(key, value)
-        update key, {'$pull' => {'v' => value}}
+        update key, {'$pull' => {'v' => value.to_s}}
       end
 
       private
 
       def find_one(key)
-        if (doc = @collection.find_one(criteria(key)))
+        doc = @collection.find_one(criteria(key))
+
+        unless doc.nil?
           doc['v']
         end
       end
@@ -48,8 +50,12 @@ module Flipper
         @collection.update criteria(key), updates, @update_options
       end
 
+      def remove(key)
+        @collection.remove criteria(key)
+      end
+
       def criteria(key)
-        {:_id => key}
+        {:_id => key.to_s}
       end
     end
   end

data/lib/flipper/adapters/mongo/document.rb

@@ -17,37 +17,40 @@ module Flipper
         end
 
         def read(key)
-          source[key]
+          source[key.to_s]
         end
 
         def write(key, value)
-          @collection.update @criteria, {'$set' => {key => value}}, @mongo_options
-          @source[key] = value
+          value = value.to_s
+          @collection.update @criteria, {'$set' => {key.to_s => value}}, @mongo_options
+          @source[key.to_s] = value
         end
 
         def delete(key)
-          @collection.update @criteria, {'$unset' => {key => 1}}, @mongo_options
-          @source.delete key
+          @collection.update @criteria, {'$unset' => {key.to_s => 1}}, @mongo_options
+          @source.delete key.to_s
         end
 
         def set_members(key)
-          members = source.fetch(key) { @source[key] = Set.new }
+          members = source.fetch(key.to_s) { @source[key.to_s] = Set.new }
 
           if members.is_a?(Array)
-            @source[key] = members.to_set
+            @source[key.to_s] = members.to_set
           else
             members
           end
         end
 
         def set_add(key, value)
-          @collection.update @criteria, {'$addToSet' => {key => value}}, @mongo_options
-          set_members(key).add(value)
+          value = value.to_s
+          @collection.update @criteria, {'$addToSet' => {key.to_s => value}}, @mongo_options
+          set_members(key.to_s).add(value)
         end
 
         def set_delete(key, value)
-          @collection.update @criteria, {'$pull' => {key => value}}, @mongo_options
-          set_members(key).delete(value)
+          value = value.to_s
+          @collection.update @criteria, {'$pull' => {key.to_s => value}}, @mongo_options
+          set_members(key.to_s).delete(value)
         end
 
         def clear

data/lib/flipper/adapters/mongo/version.rb

@@ -1,7 +1,7 @@
 module Flipper
   module Adapters
     class Mongo
-      VERSION = "0.2.2"
+      VERSION = "0.3.0"
     end
   end
 end

data/spec/flipper/adapters/mongo/document_spec.rb

@@ -27,7 +27,7 @@ describe Flipper::Adapters::MongoSingleDocument::Document do
 
   describe "loading document" do
     before do
-      collection.update(criteria, {'$set' => {'foo' => 'bar', 'people' => [1, 2, 3]}}, options)
+      collection.update(criteria, {'$set' => {'foo' => 'bar', 'people' => ['1', '2', '3']}}, options)
     end
 
     it "only happens once" do
@@ -151,18 +151,18 @@ describe Flipper::Adapters::MongoSingleDocument::Document do
   describe "#set_members" do
     context "existing key" do
       before do
-        collection.update(criteria, {'$set' => {'people' => [1, 2, 3], 'foo' => 'bar'}}, options)
+        collection.update(criteria, {'$set' => {'people' => ['1', '2', '3'], 'foo' => 'bar'}}, options)
         @result = subject.set_members('people')
       end
 
       it "returns set" do
-        @result.should eq(Set[1, 2, 3])
+        @result.should eq(Set['1', '2', '3'])
       end
 
       it "loads source hash" do
         source.should eq({
           '_id'    => id,
-          'people' => Set[1, 2, 3],
+          'people' => Set['1', '2', '3'],
           'foo'    => 'bar',
         })
       end
@@ -170,7 +170,7 @@ describe Flipper::Adapters::MongoSingleDocument::Document do
 
     context "missing key" do
       before do
-        collection.update(criteria, {'$set' => {'people' => [1, 2, 3]}}, options)
+        collection.update(criteria, {'$set' => {'people' => ['1', '2', '3']}}, options)
         @result = subject.set_members('users')
       end
 
@@ -189,31 +189,31 @@ describe Flipper::Adapters::MongoSingleDocument::Document do
   describe "#set_add" do
     context "existing key" do
       before do
-        collection.update(criteria, {'$set' => {'people' => [1, 2, 3]}}, options)
+        collection.update(criteria, {'$set' => {'people' => ['1', '2', '3']}}, options)
         subject.set_add('people', 4)
       end
 
       it "adds value to set" do
-        document.fetch('people').should eq([1, 2, 3, 4])
-        source.fetch('people').should eq(Set[1, 2, 3, 4])
+        document.fetch('people').should eq(['1', '2', '3', '4'])
+        source.fetch('people').should eq(Set['1', '2', '3', '4'])
       end
     end
 
     context "missing key" do
       before do
-        collection.update(criteria, {'$set' => {'people' => [1, 2, 3]}}, options)
-        subject.set_add('users', 1)
+        collection.update(criteria, {'$set' => {'people' => ['1', '2', '3']}}, options)
+        subject.set_add('users', '1')
       end
 
       it "adds value to set" do
-        document.fetch('users').should eq([1])
-        source.fetch('users').should eq(Set[1])
+        document.fetch('users').should eq(['1'])
+        source.fetch('users').should eq(Set['1'])
       end
     end
 
     context "missing document" do
       before do
-        subject.set_add('people', 1)
+        subject.set_add('people', '1')
       end
 
       it "creates document" do
@@ -221,8 +221,8 @@ describe Flipper::Adapters::MongoSingleDocument::Document do
       end
 
       it "adds value to set" do
-        document.fetch('people').should eq([1])
-        source.fetch('people').should eq(Set[1])
+        document.fetch('people').should eq(['1'])
+        source.fetch('people').should eq(Set['1'])
       end
     end
   end
@@ -230,23 +230,23 @@ describe Flipper::Adapters::MongoSingleDocument::Document do
   describe "#set_delete" do
     context "existing key" do
       before do
-        collection.update(criteria, {'$set' => {'people' => [1, 2, 3]}}, options)
-        subject.set_delete 'people', 3
+        collection.update(criteria, {'$set' => {'people' => ['1', '2', '3']}}, options)
+        subject.set_delete 'people', '3'
       end
 
       it "removes value to key" do
-        document.fetch('people').should eq([1, 2])
-        source.fetch('people').should eq(Set[1, 2])
+        document.fetch('people').should eq(['1', '2'])
+        source.fetch('people').should eq(Set['1', '2'])
       end
     end
 
     context "missing key" do
       before do
-        collection.update(criteria, {'$set' => {'people' => [1, 2, 3]}}, options)
+        collection.update(criteria, {'$set' => {'people' => ['1', '2', '3']}}, options)
       end
 
       it "does not error" do
-        expect { subject.set_delete 'foo', 1 }.to_not raise_error
+        expect { subject.set_delete 'foo', '1' }.to_not raise_error
       end
     end
 

data/spec/flipper/adapters/mongo_single_document_spec.rb

@@ -15,7 +15,7 @@ describe Flipper::Adapters::MongoSingleDocument do
 
   def read_key(key)
     if (doc = collection.find_one(criteria))
-      value = doc[key]
+      value = doc[key.to_s]
 
       if value.is_a?(::Array)
         value = value.to_set
@@ -26,12 +26,14 @@ describe Flipper::Adapters::MongoSingleDocument do
   end
 
   def write_key(key, value)
-    if value.is_a?(::Set)
-      value = value.to_a
+    value = if value.is_a?(::Set)
+      value.to_a.map(&:to_s)
+    else
+      value.to_s
     end
 
     options = {:upsert => true}
-    updates = {'$set' => {key => value}}
+    updates = {'$set' => {key.to_s => value}}
     collection.update criteria, updates, options
   end
 

data/spec/flipper/adapters/mongo_spec.rb

@@ -13,7 +13,7 @@ describe Flipper::Adapters::Mongo do
   end
 
   def read_key(key)
-    if (doc = collection.find_one(:_id => key))
+    if (doc = collection.find_one(:_id => key.to_s))
       value = doc['v']
 
       if value.is_a?(::Array)
@@ -25,11 +25,13 @@ describe Flipper::Adapters::Mongo do
   end
 
   def write_key(key, value)
-    if value.is_a?(::Set)
-      value = value.to_a
+    value = if value.is_a?(::Set)
+      value.to_a.map(&:to_s)
+    else
+      value.to_s
     end
 
-    criteria = {:_id => key}
+    criteria = {:_id => key.to_s}
     updates  = {'$set' => {'v' => value}}
     options  = {:upsert => true}
     collection.update criteria, updates, options

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flipper-mongo
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,19 +9,24 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-08 00:00:00.000000000 Z
+date: 2013-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
-  requirement: &70110164650060 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0.4'
   type: :runtime
   prerelease: false
-  version_requirements: *70110164650060
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.4'
 description: Mongo adapter for Flipper
 email:
 - nunemaker@gmail.com
@@ -30,6 +35,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - Guardfile
 - LICENSE
@@ -62,7 +68,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3406714501289693291
+      hash: 1196015138740871413
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -71,10 +77,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3406714501289693291
+      hash: 1196015138740871413
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Mongo adapter for Flipper