flipper-dalli 0.10.1 → 0.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e1088db7bed10c43a5ff39bca97aa66a182a633
-  data.tar.gz: bd918fb54b3033385ee20859d7773e11ae4a3686
+  metadata.gz: ef5a0f642bcfcb0213304e46a573ed943a54fec6
+  data.tar.gz: a80ffc852ed4bb0ed5b239ba34292b03aa1b74b0
 SHA512:
-  metadata.gz: 4b4f20082b8cd307ab9712088ba4e46668ee0f99c87f9b50049edc13a605f052b2ee6c060b393e3618355e1030ce297be0f51c563bf3ac54f4b84245aef44ecb
-  data.tar.gz: cb540355805e7fc81e2bf8b8d4daf08139c1c5427234ed9fbc493a878360349e041d79f51a45bd877b1b85492c6b83b750b930f5dc8285296f3b729db4d56051
+  metadata.gz: 108cc70cbffdd6790ee1a599e1e34b0533ff47e24146eb8e12bd1f6d87174276be2aceca00b8ddd2fd4c374923a3901353f466419a2190cb1f140b799fa9f6bd
+  data.tar.gz: 1cf97e8949eeca88b5608aeddffa4e315992e86b8ae48270ce26ea963c562b04b7449415e640b495fb70021a9d455214c67a80e3e89f77513ce5dc5f4f89a87d

data/lib/flipper/adapters/dalli.rb

@@ -7,7 +7,14 @@ module Flipper
     class Dalli
       include ::Flipper::Adapter
 
-      FeaturesKey = :flipper_features
+      Version = "v1".freeze
+      Namespace = "flipper/#{Version}".freeze
+      FeaturesKey = "#{Namespace}/features".freeze
+
+      # Private
+      def self.key_for(key)
+        "#{Namespace}/feature/#{key}"
+      end
 
       # Internal
       attr_reader :cache
@@ -41,36 +48,59 @@ module Flipper
       def remove(feature)
         result = @adapter.remove(feature)
         @cache.delete(FeaturesKey)
+        @cache.delete(key_for(feature.key))
         result
       end
 
       # Public
       def clear(feature)
         result = @adapter.clear(feature)
-        @cache.delete(feature)
+        @cache.delete(key_for(feature.key))
         result
       end
 
       # Public
       def get(feature)
-        @cache.fetch(feature, @ttl) do
+        @cache.fetch(key_for(feature.key), @ttl) do
           @adapter.get(feature)
         end
       end
 
+      def get_multi(features)
+        keys = features.map { |feature| key_for(feature.key) }
+        result = @cache.get_multi(keys)
+        uncached_features = features.reject { |feature| result[key_for(feature.key)] }
+
+        if uncached_features.any?
+          response = @adapter.get_multi(uncached_features)
+          response.each do |key, value|
+            @cache.set(key_for(key), value, @ttl)
+            result[key] = value
+          end
+        end
+
+        result
+      end
+
       # Public
       def enable(feature, gate, thing)
         result = @adapter.enable(feature, gate, thing)
-        @cache.delete(feature)
+        @cache.delete(key_for(feature.key))
         result
       end
 
       # Public
       def disable(feature, gate, thing)
         result = @adapter.disable(feature, gate, thing)
-        @cache.delete(feature)
+        @cache.delete(key_for(feature.key))
         result
       end
+
+      private
+
+      def key_for(key)
+        self.class.key_for(key)
+      end
     end
   end
 end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.10.1".freeze
+  VERSION = "0.10.2".freeze
 end

data/spec/flipper/adapters/dalli_spec.rb

@@ -17,6 +17,34 @@ RSpec.describe Flipper::Adapters::Dalli do
 
   it_should_behave_like 'a flipper adapter'
 
+  describe "#remove" do
+    it "expires feature" do
+      feature = flipper[:stats]
+      adapter.get(feature)
+      adapter.remove(feature)
+      expect(cache.get(described_class.key_for(feature))).to be(nil)
+    end
+  end
+
+  describe "#get_multi" do
+    it "warms uncached features" do
+      stats = flipper[:stats]
+      search = flipper[:search]
+      other = flipper[:other]
+      stats.enable
+      search.enable
+
+      adapter.get(stats)
+      expect(cache.get(described_class.key_for(search))).to be(nil)
+      expect(cache.get(described_class.key_for(other))).to be(nil)
+
+      adapter.get_multi([stats, search, other])
+
+      expect(cache.get(described_class.key_for(search))[:boolean]).to eq("true")
+      expect(cache.get(described_class.key_for(other))[:boolean]).to be(nil)
+    end
+  end
+
   describe "#name" do
     it "is dalli" do
       expect(subject.name).to be(:dalli)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-dalli
 version: !ruby/object:Gem::Version
-  version: 0.10.1
+  version: 0.10.2
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-19 00:00:00.000000000 Z
+date: 2016-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.10.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.10.2
 - !ruby/object:Gem::Dependency
   name: dalli
   requirement: !ruby/object:Gem::Requirement