flipper-api 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f8ced0ad1e2b583f6d120df8923f9b5f46a8cffe
-  data.tar.gz: fd6601ab6d8a0ee61b893026b8516ea2af45140d
+  metadata.gz: 602b1d466a68b777063b76d351ab845843057406
+  data.tar.gz: a0a32a90d8accbce74b0dec3b2157cf9bb669dc2
 SHA512:
-  metadata.gz: b8ce87b4252ffc05ab922da1f901221b6baca42e2ab5fd1aed4c51e26e4876a2550d45b52fe422525b5cf8da9a6ad09ecc741587ae9e4f4920ebccac1ce92b9f
-  data.tar.gz: 0b295988e586c2d5c5fa9f7650cf8fc29c1c469d9df35a114009a483c08568cc45d57469252874f08fb356131b142c35e34d90c6d7354355aa0e464877aabf69
+  metadata.gz: 81401173dd23fe114cde4087e1469ddb5289cf2032f99062225247ad88933c858401c88d60810d16d9ccd51a2ea18bc030b7b3ba42183e3cb1c49c1da33fbce4
+  data.tar.gz: 8dcdac503eefc843e1c1e61e0e465f70a01d4b4ec556a0212d8c6f373d84663df9b3e0cfc9a10a55d7d2e2cc85c447c87315c1d3c6c319a1d7715a97eebd414a

data/lib/flipper/api/middleware.rb

@@ -7,7 +7,7 @@ Pathname(__FILE__).dirname.join('v1/actions').each_child(false) do |name|
 end
 
 module Flipper
-  module Api 
+  module Api
     class Middleware
       # Public: Initializes an instance of the API middleware.
       #
@@ -37,6 +37,7 @@ module Flipper
         @action_collection = ActionCollection.new
         @action_collection.add Api::V1::Actions::BooleanGate
         @action_collection.add Api::V1::Actions::Feature
+        @action_collection.add Api::V1::Actions::Features
       end
 
       def flipper

data/lib/flipper/api/v1/actions/features.rb

@@ -0,0 +1,39 @@
+require 'flipper/api/action'
+require 'flipper/api/v1/decorators/feature'
+require 'json'
+
+module Flipper
+  module Api
+    module V1
+      module Actions
+        class Features < Api::Action
+
+          route %r{api/v1/features\Z}
+
+          def get
+            features = flipper.features.map { |feature|
+              Decorators::Feature.new(feature).as_json
+            }
+
+            json_response({
+              features: features
+            })
+          end
+
+          def post
+            feature_name = params.fetch('name') do
+              json_response({
+                errors: [{
+                  message: 'Missing post parameter: name',
+                }]
+              }, 422)
+            end
+
+            flipper.adapter.add(flipper[feature_name])
+            json_response({}, 200)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.9.1".freeze
+  VERSION = "0.9.2".freeze
 end

data/spec/flipper/api/v1/actions/features_spec.rb

@@ -0,0 +1,106 @@
+require 'helper'
+
+RSpec.describe Flipper::Api::V1::Actions::Features do
+  let(:app) { build_api(flipper) }
+  let(:feature) { build_feature }
+  let(:admin) { double 'Fake Fliper Thing', flipper_id: 10 }
+
+  describe 'get' do
+    context 'with flipper features' do
+      before do
+        flipper[:my_feature].enable
+        flipper[:my_feature].enable(admin)
+        get 'api/v1/features'
+      end
+
+      it 'responds with correct attributes' do
+        expected_response = {
+          "features" => [
+            {
+              "key" =>"my_feature",
+              "state" => "on",
+              "gates" => [
+                {
+                  "key"=> "boolean",
+                  "name"=> "boolean",
+                  "value" => true},
+                  {
+                  "key" =>"groups",
+                  "name" => "group",
+                  "value" =>[],
+                },
+                {
+                  "key" => "actors",
+                  "name"=>"actor",
+                  "value"=>["10"],
+                },
+                {
+                  "key" => "percentage_of_actors",
+                  "name" => "percentage_of_actors",
+                  "value" => 0,
+                },
+                {
+                  "key"=> "percentage_of_time",
+                  "name"=> "percentage_of_time",
+                  "value"=> 0,
+                },
+            ],
+            },
+          ]
+        }
+        expect(last_response.status).to eq(200)
+        expect(json_response).to eq(expected_response)
+      end
+    end
+
+    context 'with no flipper features' do
+      before do
+        get 'api/v1/features'
+      end
+
+      it 'returns empty array for features key' do
+        expected_response = {
+          "features" => []
+        }
+        expect(last_response.status).to eq(200)
+        expect(json_response).to eq(expected_response)
+      end
+    end
+  end
+
+  describe 'post' do
+    context 'succesful request' do
+      before do
+        post 'api/v1/features', { name: 'my_feature' }
+      end
+
+      it 'responds 200 on success' do
+        expect(last_response.status).to eq(200)
+        expect(json_response).to eq({})
+      end
+
+      it 'adds feature' do
+        expect(flipper.features.map(&:key)).to include('my_feature')
+      end
+
+      it 'does not enable feature' do
+        expect(flipper['my_feature'].enabled?).to be_falsy
+      end
+    end
+
+    context 'bad request' do
+      before do
+        post 'api/v1/features'
+      end
+
+      it 'returns correct status code' do
+        expect(last_response.status).to eq(422)
+      end
+
+      it 'returns formatted error' do
+        errors = json_response['errors']
+        expect(errors.first['message']).to eq('Missing post parameter: name')
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-api
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-07 00:00:00.000000000 Z
+date: 2016-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.1
+        version: 0.9.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.1
+        version: 0.9.2
 description: Rack middleware that provides an API for the flipper gem.
 email:
 - nunemaker@gmail.com
@@ -60,12 +60,14 @@ files:
 - lib/flipper/api/middleware.rb
 - lib/flipper/api/v1/actions/boolean_gate.rb
 - lib/flipper/api/v1/actions/feature.rb
+- lib/flipper/api/v1/actions/features.rb
 - lib/flipper/api/v1/decorators/feature.rb
 - lib/flipper/api/v1/decorators/gate.rb
 - lib/flipper/version.rb
 - spec/flipper/api/action_spec.rb
 - spec/flipper/api/v1/actions/boolean_gate_spec.rb
 - spec/flipper/api/v1/actions/feature_spec.rb
+- spec/flipper/api/v1/actions/features_spec.rb
 homepage: https://github.com/jnunemaker/flipper
 licenses:
 - MIT
@@ -94,3 +96,4 @@ test_files:
 - spec/flipper/api/action_spec.rb
 - spec/flipper/api/v1/actions/boolean_gate_spec.rb
 - spec/flipper/api/v1/actions/feature_spec.rb
+- spec/flipper/api/v1/actions/features_spec.rb