flipper-api 0.9.0.beta1 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3dc0d6945ca1251ecb23381d67619c4b47037182
-  data.tar.gz: ef1f23b1ca4de85e97c761c9769fb7f8e44b74d3
+  metadata.gz: 190b68fb4dca2dbed9035080387164ddf37f803a
+  data.tar.gz: 987efcf4cfa1434b3d02110e80985a23cc6f2aff
 SHA512:
-  metadata.gz: 5d1927804aa8737cd37fec2ca50ef4a4121887ca854a0ee80ea3b8e0d810f423564cc54240e18a66a2a873ed95f2e6b86c9c92062129ef7774f25ef4a26445bc
-  data.tar.gz: 7b5965dbf784cdabc3850e54220e0258010f435e4fb6926121ad951950cc0ffceab0223ed7da72e9d1917e5a2efa681fd0218a2ee47329c972a1dc386af88f93
+  metadata.gz: a0b8d6d33fa9590e32f1cb44f70c485957b23fb11bf614c3882d3c509f5a39d9b81a8ea331b85811b9003f32130e5c6c05f04a3210a514e0d9312248c7dffe26
+  data.tar.gz: 61433fe1086f7a69779a36effc45ec36dad24b1fbca77789991917675f35da4af91dfc056ef37fe9afc39a25b84aff165572b5c1d02365fa3e835cfb043f5f67

data/lib/flipper/api/action.rb

@@ -1,8 +1,19 @@
+require 'forwardable'
+require 'flipper/api/error'
+require 'json'
+
 module Flipper
   module Api
     class Action
       extend Forwardable
 
+      VALID_REQUEST_METHOD_NAMES = Set.new([
+        "get".freeze,
+        "post".freeze,
+        "put".freeze,
+        "delete".freeze,
+      ]).freeze
+
       # Public: Call this in subclasses so the action knows its route.
       #
       # regex - The Regexp that this action should run for.
@@ -47,7 +58,7 @@ module Flipper
       #
       # Returns whatever the request method returns in the action.
       def run
-        if respond_to?(request_method_name)
+        if valid_request_method? && respond_to?(request_method_name)
           catch(:halt) { send(request_method_name) }
         else
           raise Api::RequestMethodNotSupported, "#{self.class} does not support request method #{request_method_name.inspect}"
@@ -111,6 +122,10 @@ module Flipper
       def path_parts
         @request.path.split("/")
       end
+
+      def valid_request_method?
+        VALID_REQUEST_METHOD_NAMES.include?(request_method_name)
+      end
     end
   end
 end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.9.0.beta1".freeze
+  VERSION = "0.9.0".freeze
 end

data/spec/flipper/api/action_spec.rb

@@ -0,0 +1,59 @@
+require 'helper'
+
+RSpec.describe Flipper::Api::Action do
+  let(:action_subclass) {
+    Class.new(described_class) do
+      def noooope
+        raise "should never run this"
+      end
+
+      def get
+        [200, {}, "get"]
+      end
+
+      def post
+        [200, {}, "post"]
+      end
+
+      def put
+        [200, {}, "put"]
+      end
+
+      def delete
+        [200, {}, "delete"]
+      end
+    end
+  }
+
+  it "won't run method that isn't whitelisted" do
+    fake_request = Struct.new(:request_method, :env, :session).new("NOOOOPE", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect {
+      action.run
+    }.to raise_error(Flipper::Api::RequestMethodNotSupported)
+  end
+
+  it "will run get" do
+    fake_request = Struct.new(:request_method, :env, :session).new("GET", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect(action.run).to eq([200, {}, "get"])
+  end
+
+  it "will run post" do
+    fake_request = Struct.new(:request_method, :env, :session).new("POST", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect(action.run).to eq([200, {}, "post"])
+  end
+
+  it "will run put" do
+    fake_request = Struct.new(:request_method, :env, :session).new("PUT", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect(action.run).to eq([200, {}, "put"])
+  end
+
+  it "will run delete" do
+    fake_request = Struct.new(:request_method, :env, :session).new("DELETE", {}, {})
+    action = action_subclass.new(flipper, fake_request)
+    expect(action.run).to eq([200, {}, "delete"])
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-api
 version: !ruby/object:Gem::Version
-  version: 0.9.0.beta1
+  version: 0.9.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0.beta1
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0.beta1
+        version: 0.9.0
 description: Rack middleware that provides an API for the flipper gem.
 email:
 - nunemaker@gmail.com
@@ -63,6 +63,7 @@ files:
 - lib/flipper/api/v1/decorators/feature.rb
 - lib/flipper/api/v1/decorators/gate.rb
 - lib/flipper/version.rb
+- spec/flipper/api/action_spec.rb
 - spec/flipper/api/v1/actions/boolean_gate_spec.rb
 - spec/flipper/api/v1/actions/feature_spec.rb
 homepage: https://github.com/jnunemaker/flipper
@@ -80,9 +81,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5.1
@@ -90,5 +91,6 @@ signing_key:
 specification_version: 4
 summary: API for the Flipper gem
 test_files:
+- spec/flipper/api/action_spec.rb
 - spec/flipper/api/v1/actions/boolean_gate_spec.rb
 - spec/flipper/api/v1/actions/feature_spec.rb